118387 2013-07-04 02:33:17 -0700 Change static_cast<SVGImageElement*> with toSVGImageElement 2013-07-04 18:36:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim cdumez commit-queue d-r esprehn+autocc fmalita glenn ossy pdr schenney oldest_to_newest 906110 0 gyuyoung.kim 2013-07-04 02:33:17 -0700 As a step to change static_cast with toXXX, static_cast<SVGImageElement*> can be changed with toSVGImageElement(). Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153557 906112 1 206069 gyuyoung.kim 2013-07-04 02:37:29 -0700 Created attachment 206069 Patch 906160 2 206069 commit-queue 2013-07-04 06:58:59 -0700 Comment on attachment 206069 Patch Clearing flags on attachment: 206069 Committed r152399: <http://trac.webkit.org/changeset/152399> 906161 3 commit-queue 2013-07-04 06:59:02 -0700 All reviewed patches have been landed. Closing bug. 906186 4 ossy 2013-07-04 08:27:07 -0700 (In reply to comment #2) > (From update of attachment 206069 [details]) > Clearing flags on attachment: 206069 > > Committed r152399: <http://trac.webkit.org/changeset/152399> It broke the debug builds: In file included from /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/rendering/svg/RenderSVGImage.cpp:41:0: /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h: In function 'WebCore::SVGImageElement* WebCore::toSVGImageElement(WebCore::Node*)': [1;31m/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h:81:34: error: 'SVGNames' has not been declared[0m 906190 5 cdumez 2013-07-04 08:34:42 -0700 (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 206069 [details] [details]) > > Clearing flags on attachment: 206069 > > > > Committed r152399: <http://trac.webkit.org/changeset/152399> > > It broke the debug builds: > In file included from /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/rendering/svg/RenderSVGImage.cpp:41:0: > /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h: In function 'WebCore::SVGImageElement* WebCore::toSVGImageElement(WebCore::Node*)': > [1;31m/home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/svg/SVGImageElement.h:81:34: error: 'SVGNames' has not been declared[0m Build fix landed in <http://trac.webkit.org/changeset/152400>. 906282 6 gyuyoung.kim 2013-07-04 18:36:45 -0700 (In reply to comment #5) > Build fix landed in <http://trac.webkit.org/changeset/152400>. I missed to add it. Thank you for the fixing. 206069 2013-07-04 02:37:29 -0700 2013-07-04 06:58:58 -0700 Patch bug-118387-20130704183522.patch text/plain 4055 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGFiNzFkMDQ5ODM1ODBk MzMwMjdkMGQwZGNlMTk0ZWNjMDcwNmZjNy4uMGJjZTRiMGZmYWU1MDM4ZjFmNWIyZDEyYzUzMmIw MTk4YTdkZDFjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA3LTA0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgQ2hhbmdlIHN0 YXRpY19jYXN0PFNWR0ltYWdlRWxlbWVudCo+IHdpdGggdG9TVkdJbWFnZUVsZW1lbnQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODM4NworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGEgc3RlcCB0byBj aGFuZ2Ugc3RhdGljX2Nhc3Qgd2l0aCB0b1hYWCwgc3RhdGljX2Nhc3Q8U1ZHSW1hZ2VFbGVtZW50 Kj4gY2FuCisgICAgICAgIGJlIGNoYW5nZWQgd2l0aCB0b1NWR0ltYWdlRWxlbWVudCgpLgorCisg ICAgICAgIEJsaW5rIG1lcmdlIGZyb20gaHR0cHM6Ly9zcmMuY2hyb21pdW0ub3JnL3ZpZXd2Yy9i bGluaz92aWV3PXJldiZyZXZpc2lvbj0xNTM1NTcKKworICAgICAgICAqIHJlbmRlcmluZy9zdmcv UmVuZGVyU1ZHSW1hZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHSW1hZ2U6OnVw ZGF0ZUltYWdlVmlld3BvcnQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHSW1hZ2U6Omxh eW91dCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdJbWFnZTo6cGFpbnRGb3JlZ3JvdW5k KToKKyAgICAgICAgKiBzdmcvU1ZHSW1hZ2VFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjp0 b1NWR0ltYWdlRWxlbWVudCk6CisgICAgICAgICogc3ZnL1NWR0ltYWdlTG9hZGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNWR0ltYWdlTG9hZGVyOjpkaXNwYXRjaExvYWRFdmVudCk6CisKIDIw MTMtMDctMDQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUG9ydCBGaWxlU3lzdGVtV2luLmNwcCB0byBXaW5DRQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdJbWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0ltYWdlLmNwcAppbmRleCA2NDU3M2EzZTIzNTE3OGUzODQx MzQ5NDcyODUzNjcwZTE0ZjYwYjAwLi43NmQ3YzVjMmU2OTQzYjI0NTQ0MjljOTEwMDFmMmMyYjIw ZjIwOWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNW R0ltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0lt YWdlLmNwcApAQCAtNjQsNyArNjQsNyBAQCBSZW5kZXJTVkdJbWFnZTo6flJlbmRlclNWR0ltYWdl KCkKIAogYm9vbCBSZW5kZXJTVkdJbWFnZTo6dXBkYXRlSW1hZ2VWaWV3cG9ydCgpCiB7Ci0gICAg U1ZHSW1hZ2VFbGVtZW50KiBpbWFnZSA9IHN0YXRpY19jYXN0PFNWR0ltYWdlRWxlbWVudCo+KG5v ZGUoKSk7CisgICAgU1ZHSW1hZ2VFbGVtZW50KiBpbWFnZSA9IHRvU1ZHSW1hZ2VFbGVtZW50KG5v ZGUoKSk7CiAgICAgRmxvYXRSZWN0IG9sZEJvdW5kYXJpZXMgPSBtX29iamVjdEJvdW5kaW5nQm94 OwogCiAgICAgU1ZHTGVuZ3RoQ29udGV4dCBsZW5ndGhDb250ZXh0KGltYWdlKTsKQEAgLTg4LDcg Kzg4LDcgQEAgdm9pZCBSZW5kZXJTVkdJbWFnZTo6bGF5b3V0KCkKIAogICAgIGJvb2wgdHJhbnNm b3JtT3JCb3VuZGFyaWVzVXBkYXRlID0gbV9uZWVkc1RyYW5zZm9ybVVwZGF0ZSB8fCBtX25lZWRz Qm91bmRhcmllc1VwZGF0ZTsKICAgICBpZiAobV9uZWVkc1RyYW5zZm9ybVVwZGF0ZSkgewotICAg ICAgICBtX2xvY2FsVHJhbnNmb3JtID0gc3RhdGljX2Nhc3Q8U1ZHSW1hZ2VFbGVtZW50Kj4obm9k ZSgpKS0+YW5pbWF0ZWRMb2NhbFRyYW5zZm9ybSgpOworICAgICAgICBtX2xvY2FsVHJhbnNmb3Jt ID0gdG9TVkdJbWFnZUVsZW1lbnQobm9kZSgpKS0+YW5pbWF0ZWRMb2NhbFRyYW5zZm9ybSgpOwog ICAgICAgICBtX25lZWRzVHJhbnNmb3JtVXBkYXRlID0gZmFsc2U7CiAgICAgfQogCkBAIC0xNTEs NyArMTUxLDcgQEAgdm9pZCBSZW5kZXJTVkdJbWFnZTo6cGFpbnRGb3JlZ3JvdW5kKFBhaW50SW5m byYgcGFpbnRJbmZvKQogICAgIEZsb2F0UmVjdCBkZXN0UmVjdCA9IG1fb2JqZWN0Qm91bmRpbmdC b3g7CiAgICAgRmxvYXRSZWN0IHNyY1JlY3QoMCwgMCwgaW1hZ2UtPndpZHRoKCksIGltYWdlLT5o ZWlnaHQoKSk7CiAKLSAgICBTVkdJbWFnZUVsZW1lbnQqIGltYWdlRWxlbWVudCA9IHN0YXRpY19j YXN0PFNWR0ltYWdlRWxlbWVudCo+KG5vZGUoKSk7CisgICAgU1ZHSW1hZ2VFbGVtZW50KiBpbWFn ZUVsZW1lbnQgPSB0b1NWR0ltYWdlRWxlbWVudChub2RlKCkpOwogICAgIGltYWdlRWxlbWVudC0+ cHJlc2VydmVBc3BlY3RSYXRpbygpLnRyYW5zZm9ybVJlY3QoZGVzdFJlY3QsIHNyY1JlY3QpOwog CiAgICAgcGFpbnRJbmZvLmNvbnRleHQtPmRyYXdJbWFnZShpbWFnZS5nZXQoKSwgQ29sb3JTcGFj ZURldmljZVJHQiwgZGVzdFJlY3QsIHNyY1JlY3QpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvc3ZnL1NWR0ltYWdlRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0ltYWdlRWxl bWVudC5oCmluZGV4IGQ4MTIzNTIxODk5YWM2M2MzZjU2NzJhOWFlODI4MzgyNDU5NjdiYzUuLjgy NDAxNWM5Zjk2NjYyOTkxMjIwOTQwYzE5NTQ3MWY4OTQ3OWZjNGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3N2Zy9TVkdJbWFnZUVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHSW1hZ2VFbGVtZW50LmgKQEAgLTc2LDYgKzc2LDEyIEBAIHByaXZhdGU6CiAgICAgU1ZHSW1h Z2VMb2FkZXIgbV9pbWFnZUxvYWRlcjsKIH07CiAKK2lubGluZSBTVkdJbWFnZUVsZW1lbnQqIHRv U1ZHSW1hZ2VFbGVtZW50KE5vZGUqIG5vZGUpCit7CisgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlf SU1QTElDQVRJT04oIW5vZGUgfHwgbm9kZS0+aGFzVGFnTmFtZShTVkdOYW1lczo6aW1hZ2VUYWcp KTsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8U1ZHSW1hZ2VFbGVtZW50Kj4obm9kZSk7Cit9CisK IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlmIC8vIEVOQUJMRShTVkcpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHSW1hZ2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvc3ZnL1NWR0ltYWdlTG9hZGVyLmNwcAppbmRleCBlNjdmNjQ5MGFkZjEwOTM0NWVmZDkwNWJh OWQ2YzZlNGYxNGZmMjdkLi45NzI3MTlkZDBhMWQwMTU2NTc5ZTA3MzU5YzdiNjE3YzJkZGQ0MjA1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHSW1hZ2VMb2FkZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdJbWFnZUxvYWRlci5jcHAKQEAgLTQyLDcgKzQyLDcgQEAg dm9pZCBTVkdJbWFnZUxvYWRlcjo6ZGlzcGF0Y2hMb2FkRXZlbnQoKQogICAgIGlmIChpbWFnZSgp LT5lcnJvck9jY3VycmVkKCkpCiAgICAgICAgIGVsZW1lbnQoKS0+ZGlzcGF0Y2hFdmVudChFdmVu dDo6Y3JlYXRlKGV2ZW50TmFtZXMoKS5lcnJvckV2ZW50LCBmYWxzZSwgZmFsc2UpKTsKICAgICBl bHNlIHsKLSAgICAgICAgU1ZHSW1hZ2VFbGVtZW50KiBpbWFnZUVsZW1lbnQgPSBzdGF0aWNfY2Fz dDxTVkdJbWFnZUVsZW1lbnQqPihlbGVtZW50KCkpOworICAgICAgICBTVkdJbWFnZUVsZW1lbnQq IGltYWdlRWxlbWVudCA9IHRvU1ZHSW1hZ2VFbGVtZW50KGVsZW1lbnQoKSk7CiAgICAgICAgIGlm IChpbWFnZUVsZW1lbnQtPmV4dGVybmFsUmVzb3VyY2VzUmVxdWlyZWRCYXNlVmFsdWUoKSkKICAg ICAgICAgICAgIGltYWdlRWxlbWVudC0+c2VuZFNWR0xvYWRFdmVudElmUG9zc2libGUodHJ1ZSk7 CiAgICAgfQo=