<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118386</bug_id>
          
          <creation_ts>2013-07-04 01:52:49 -0700</creation_ts>
          <short_desc>[GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3</short_desc>
          <delta_ts>2013-07-04 06:19:01 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>116317</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Brian Holt">brian.holt</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>kling</cc>
    
    <cc>menard</cc>
    
    <cc>mrobinson</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>906095</commentid>
    <comment_count>0</comment_count>
    <who name="Brian Holt">brian.holt</who>
    <bug_when>2013-07-04 01:52:49 -0700</bug_when>
    <thetext>Leaks found using the &quot;--leak&quot; option in the Gtk port:

Command: /home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/Programs/DumpRenderTree -
Leak_DefinitelyLost
337 (289 direct, 48 indirect) bytes in 23 blocks are definitely lost in loss record 603 of 913
    malloc (/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    g_malloc (/WebKitBuild/Dependencies/Source/glib-2.36.0/glib/gmem.c:159)
    g_slice_alloc (/WebKitBuild/Dependencies/Source/glib-2.36.0/glib/gslice.c:1003)
    pango_font_description_copy (/build/buildd/pango1.0-1.30.1/./pango/fonts.c:675)
    boxed_proxy_lcopy_value (/WebKitBuild/Dependencies/Source/glib-2.36.0/gobject/gboxed.c:266)
    gtk_style_context_get_valist (/WebKitBuild/Dependencies/Source/gtk+-3.6.0/gtk/gtkstylecontext.c:1437)
    gtk_style_context_get (/WebKitBuild/Dependencies/Source/gtk+-3.6.0/gtk/gtkstylecontext.c:1472)
    WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle(WebCore::StyleResolver*, WebCore::RenderStyle*, WebCore::Element*) const (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::RenderTheme::adjustStyle(WebCore::StyleResolver*, WebCore::RenderStyle*, WebCore::Element*, bool, WebCore::BorderData const&amp;, WebCore::FillLayer const&amp;, WebCore::Color const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::StyleResolver::adjustRenderStyle(WebCore::RenderStyle*, WebCore::RenderStyle*, WebCore::Element*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::StyleResolver::styleForElement(WebCore::Element*, WebCore::RenderStyle*, WebCore::StyleSharingBehavior, WebCore::RuleMatchingBehavior, WebCore::RenderRegion*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::Element::styleForRenderer() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::NodeRenderingContext::createRendererForElementIfNeeded() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::Element::createRendererIfNeeded(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::Element::attach(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::ContainerNode::attach(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::Element::attach(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::ContainerNode::attach(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::ShadowRoot::attach(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::ElementShadow::attach(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::Element::attach(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::HTMLFormControlElement::attach(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::HTMLInputElement::attach(WebCore::Node::AttachContext const&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::HTMLConstructionSite::executeQueuedTasks() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::HTMLDocumentParser::constructTreeFromHTMLToken(WebCore::HTMLToken&amp;) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::HTMLDocumentParser::notifyFinished(WebCore::CachedResource*) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::CachedResource::checkNotify() (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
    WebCore::SubresourceLoader::didFinishLoading(double) (/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0.19.1)
Suppression (error hash=#0745ED00D4761028#):
  For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
   &lt;insert_a_suppression_name_here&gt;
   Memcheck:Leak
   fun:malloc
   fun:g_malloc
   fun:g_slice_alloc
   fun:pango_font_description_copy
   fun:boxed_proxy_lcopy_value
   fun:gtk_style_context_get_valist
   fun:gtk_style_context_get
   fun:_ZNK7WebCore14RenderThemeGtk26adjustInnerSpinButtonStyleEPNS_13StyleResolverEPNS_11RenderStyleEPNS_7ElementE
   fun:_ZN7WebCore11RenderTheme11adjustStyleEPNS_13StyleResolverEPNS_11RenderStyleEPNS_7ElementEbRKNS_10BorderDataERKNS_9FillLayerERKNS_5ColorE
   fun:_ZN7WebCore13StyleResolver17adjustRenderStyleEPNS_11RenderStyleES2_PNS_7ElementE
   fun:_ZN7WebCore13StyleResolver15styleForElementEPNS_7ElementEPNS_11RenderStyleENS_20StyleSharingBehaviorENS_20RuleMatchingBehaviorEPNS_12RenderRegionE
   fun:_ZN7WebCore7Element16styleForRendererEv
   fun:_ZN7WebCore20NodeRenderingContext32createRendererForElementIfNeededEv
   fun:_ZN7WebCore7Element22createRendererIfNeededERKNS_4Node13AttachContextE
   fun:_ZN7WebCore7Element6attachERKNS_4Node13AttachContextE
   fun:_ZN7WebCore13ContainerNode6attachERKNS_4Node13AttachContextE
   fun:_ZN7WebCore7Element6attachERKNS_4Node13AttachContextE
   fun:_ZN7WebCore13ContainerNode6attachERKNS_4Node13AttachContextE
   fun:_ZN7WebCore10ShadowRoot6attachERKNS_4Node13AttachContextE
   fun:_ZN7WebCore13ElementShadow6attachERKNS_4Node13AttachContextE
   fun:_ZN7WebCore7Element6attachERKNS_4Node13AttachContextE
   fun:_ZN7WebCore22HTMLFormControlElement6attachERKNS_4Node13AttachContextE
}</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>906137</commentid>
    <comment_count>1</comment_count>
      <attachid>206076</attachid>
    <who name="Brian Holt">brian.holt</who>
    <bug_when>2013-07-04 04:52:43 -0700</bug_when>
    <thetext>Created attachment 206076
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>906147</commentid>
    <comment_count>2</comment_count>
      <attachid>206076</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-07-04 05:15:36 -0700</bug_when>
    <thetext>Comment on attachment 206076
Patch

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>906156</commentid>
    <comment_count>3</comment_count>
      <attachid>206076</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-07-04 06:18:58 -0700</bug_when>
    <thetext>Comment on attachment 206076
Patch

Clearing flags on attachment: 206076

Committed r152398: &lt;http://trac.webkit.org/changeset/152398&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>906157</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-07-04 06:19:01 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>206076</attachid>
            <date>2013-07-04 04:52:43 -0700</date>
            <delta_ts>2013-07-04 06:18:58 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-118386-20130704125046.patch</filename>
            <type>text/plain</type>
            <size>1689</size>
            <attacher name="Brian Holt">brian.holt</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGFiNzFkMDQ5ODM1ODBk
MzMwMjdkMGQwZGNlMTk0ZWNjMDcwNmZjNy4uYjk3YTJiYTIyZDU4MzAxNzcwOTM3ZTBhZjdmMmRk
ODMyMmIxZGFiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTA0ICBCcmlh
biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXSBMZWFrOiBG
cmVlIFBhbmdvRm9udERlc2NyaXB0aW9uKiBpbiBSZW5kZXJUaGVtZUd0azMKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODM4NgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyZWUgUGFuZ29Gb250RGVzY3Jp
cHRpb24qIGFsbG9jYXRlZCBieSBndGtfc3R5bGVfY29udGV4dF9nZXQgKHRyYW5zZmVyIGZ1bGwp
LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrMy5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpzcGluQnV0dG9uQXJyb3dTaXplKToKKwogMjAxMy0wNy0wNCAgUGF0cmljayBH
YW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBQb3J0IEZpbGVTeXN0ZW1X
aW4uY3BwIHRvIFdpbkNFCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv
UmVuZGVyVGhlbWVHdGszLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJU
aGVtZUd0azMuY3BwCmluZGV4IDZkOTUxNTg5MzllMDdmNjAwNTQwOWNmMmZkMzkyODE5YzFmYjkz
NGIuLmE2OGVmZTdkNjI4M2Y1ZjMyODBiMGE2N2ZjOTIyNTIyODhmZGYxOTMgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwCkBAIC03NjMsMTAg
Kzc2MywxMSBAQCBib29sIFJlbmRlclRoZW1lR3RrOjpwYWludFByb2dyZXNzQmFyKFJlbmRlck9i
amVjdCogcmVuZGVyT2JqZWN0LCBjb25zdCBQYWludEluZgogCiBzdGF0aWMgZ2ludCBzcGluQnV0
dG9uQXJyb3dTaXplKEd0a1N0eWxlQ29udGV4dCogY29udGV4dCkKIHsKLSAgICBjb25zdCBQYW5n
b0ZvbnREZXNjcmlwdGlvbiogZm9udERlc2NyaXB0aW9uOworICAgIFBhbmdvRm9udERlc2NyaXB0
aW9uKiBmb250RGVzY3JpcHRpb247CiAgICAgZ3RrX3N0eWxlX2NvbnRleHRfZ2V0KGNvbnRleHQs
IHN0YXRpY19jYXN0PEd0a1N0YXRlRmxhZ3M+KDApLCAiZm9udCIsICZmb250RGVzY3JpcHRpb24s
IE5VTEwpOwogICAgIGdpbnQgZm9udFNpemUgPSBwYW5nb19mb250X2Rlc2NyaXB0aW9uX2dldF9z
aXplKGZvbnREZXNjcmlwdGlvbik7CiAgICAgZ2ludCBhcnJvd1NpemUgPSBtYXgoUEFOR09fUElY
RUxTKGZvbnRTaXplKSwgbWluU3BpbkJ1dHRvbkFycm93U2l6ZSk7CisgICAgcGFuZ29fZm9udF9k
ZXNjcmlwdGlvbl9mcmVlKGZvbnREZXNjcmlwdGlvbik7CiAKICAgICByZXR1cm4gYXJyb3dTaXpl
IC0gYXJyb3dTaXplICUgMjsgLy8gRm9yY2UgZXZlbi4KIH0K
</data>

          </attachment>
      

    </bug>

</bugzilla>