118381 2013-07-04 01:24:47 -0700 [GTK] gtk_icon_info_free is deprecated since GTK+ 3.8 2020-04-07 02:47:43 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210100 0 itoral csaavedra bugs-noreply cgarcia csaavedra oldest_to_newest 906083 0 itoral 2013-07-04 01:24:47 -0700 gtk_icon_info_free has been deprecated in favor of g_object_unref. I'll attach patch shortly. 906087 1 206062 itoral 2013-07-04 01:32:47 -0700 Created attachment 206062 Proposed 906090 2 206062 cgarcia 2013-07-04 01:42:21 -0700 Comment on attachment 206062 Proposed We can't do this, we depend on GTK+ 3.6, where GtkIconInfo is not a GObject but a boxed type. We need to add an #ifdef until we bump the required version to 3.8, or we can simply ignore deprecated symbols in gtk versions grater than 3.6. I even proposed a patch to remove the annoying warnings for those cases indeed, see bug #118237. 1638488 3 395665 csaavedra 2020-04-07 02:19:23 -0700 Created attachment 395665 Patch 1638493 4 ews-feeder 2020-04-07 02:47:42 -0700 Committed r259631: <https://trac.webkit.org/changeset/259631> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395665. 206062 2013-07-04 01:32:47 -0700 2020-04-07 02:18:59 -0700 Proposed webkit-bug-118381.patch text/plain 1609 itoral SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjM5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTA0ICBJYWdvIFRv cmFsIFF1aXJvZ2EgIDxpdG9yYWxAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXBsYWNlIGRlcHJl Y2F0ZWQgZ3RrX2ljb25faW5mb19mcmVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMTgzODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9HT3duUHRyR3RrLmNwcDoKKyAgICAgICAg KFdURjo6R3RrSWNvbkluZm8pOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0 azMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0U3RvY2tTeW1ib2xpY0ljb25Gb3JXaWRnZXRU eXBlKToKKwogMjAxMy0wNy0wNCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBQb3J0IEZpbGVTeXN0ZW1XaW4uY3BwIHRvIFdpbkNFCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcAkocmV2aXNp b24gMTUyMzUzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3Rr My5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkxNCw3ICs5MTQsNyBAQAogICAgIEdka1BpeGJ1Ziog aWNvbiA9IDA7CiAgICAgaWYgKGluZm8pIHsKICAgICAgICAgaWNvbiA9IGd0a19pY29uX2luZm9f bG9hZF9zeW1ib2xpY19mb3JfY29udGV4dChpbmZvLCBjb250ZXh0LCAwLCAwKTsKLSAgICAgICAg Z3RrX2ljb25faW5mb19mcmVlKGluZm8pOworICAgICAgICBnX29iamVjdF91bnJlZihpbmZvKTsK ICAgICB9CiAKICAgICBndGtfc3R5bGVfY29udGV4dF9yZXN0b3JlKGNvbnRleHQpOwpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0dPd25QdHJHdGsuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HT3duUHRyR3RrLmNwcAkocmV2aXNpb24gMTUy MzUzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0dPd25QdHJHdGsuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zMiw3ICszMiw3IEBACiB0ZW1wbGF0ZSA8PiB2b2lkIGZyZWVPd25lZEdQ dHI8R3RrSWNvbkluZm8+KEd0a0ljb25JbmZvKiBpbmZvKQogewogICAgIGlmIChpbmZvKQotICAg ICAgICBndGtfaWNvbl9pbmZvX2ZyZWUoaW5mbyk7CisgICAgICAgIGdfb2JqZWN0X3VucmVmKGlu Zm8pOwogfQogCiB9Cg== 395665 2020-04-07 02:19:23 -0700 2020-04-07 02:47:42 -0700 Patch bug-118381-20200407121922.patch text/plain 2365 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjU5NTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjY2MjFlZjIwMzkxZjUw OWNkZjZlZTVkNmJjYmQ5ZTdiM2E3OTBjYi4uZmNiNDNhZTQ5YzEwMmIyNGY5MzY0NTNiMDhhNjI1 YjhiYjMzMzAxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA0LTA3ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gZ3Rr X2ljb25faW5mb19mcmVlIGlzIGRlcHJlY2F0ZWQgc2luY2UgR1RLKyAzLjgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODM4MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEd0a0ljb25JbmZvIGlzIGEgR09i amVjdCBzaW5jZSAzLjgsIHVwZGF0ZSBhY2NvcmRpbmdseS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2d0ay9JbWFnZUd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpsb2FkTWlzc2lu Z0ltYWdlSWNvbkZyb21UaGVtZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL0dVbmlxdWVQdHJH dGsuaDoKKwogMjAyMC0wNC0wNiAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBw bGUuY29tPgogCiAgICAgICAgIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5kcmF3SW1hZ2Ugc2hv dWxkIGlnbm9yZSB0aGUgRVhJRiBvcmllbnRhdGlvbiBpZiB0aGUgaW1hZ2Utb3JpZW50YXRpb24g aXMgbm9uZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3Rr L0ltYWdlR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFn ZUd0ay5jcHAKaW5kZXggODMwMTg1ODEwZTFlODQ0ZTU0ODNmNWMyZTZkZjRmYjYxNmQ4MjU0Ny4u MzBkYmU4MDgzNDkxM2IxOWVhNDYyNDEwYTY2ZWYwMWU5MGEyYjE4MCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlR3RrLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VHdGsuY3BwCkBAIC02NCw3ICs2 NCw3IEBAIHN0YXRpYyBSZWY8SW1hZ2U+IGxvYWRNaXNzaW5nSW1hZ2VJY29uRnJvbVRoZW1lKGNv bnN0IGNoYXIqIG5hbWUpCiB7CiAgICAgaW50IGljb25TaXplID0gZ19zdHJfaGFzX3N1ZmZpeChu YW1lLCAiQDJ4IikgPyAzMiA6IDE2OwogICAgIGF1dG8gaWNvbiA9IEJpdG1hcEltYWdlOjpjcmVh dGUoKTsKLSAgICBHVW5pcXVlUHRyPEd0a0ljb25JbmZvPiBpY29uSW5mbyhndGtfaWNvbl90aGVt ZV9sb29rdXBfaWNvbihndGtfaWNvbl90aGVtZV9nZXRfZGVmYXVsdCgpLCAiaW1hZ2UtbWlzc2lu ZyIsIGljb25TaXplLCBHVEtfSUNPTl9MT09LVVBfTk9fU1ZHKSk7CisgICAgR1JlZlB0cjxHdGtJ Y29uSW5mbz4gaWNvbkluZm8gPSBhZG9wdEdSZWYoZ3RrX2ljb25fdGhlbWVfbG9va3VwX2ljb24o Z3RrX2ljb25fdGhlbWVfZ2V0X2RlZmF1bHQoKSwgImltYWdlLW1pc3NpbmciLCBpY29uU2l6ZSwg R1RLX0lDT05fTE9PS1VQX05PX1NWRykpOwogICAgIGlmIChpY29uSW5mbykgewogICAgICAgICBh dXRvIGJ1ZmZlciA9IGxvYWRSZXNvdXJjZVNoYXJlZEJ1ZmZlcihndGtfaWNvbl9pbmZvX2dldF9m aWxlbmFtZShpY29uSW5mby5nZXQoKSkpOwogICAgICAgICBpY29uLT5zZXREYXRhKFdURk1vdmUo YnVmZmVyKSwgdHJ1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv R1VuaXF1ZVB0ckd0ay5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0dVbmlxdWVQdHJH dGsuaAppbmRleCBjMTY3N2M2MDkzOTI5NTE3OWE4YzFmNWVmNGExNDE1MGQyMTRiN2FiLi5kYjk3 NjBiYWU1YjU1YWJjN2NiZDViODdhZmY3MTgxMmFlZDgzNTg1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvR1VuaXF1ZVB0ckd0ay5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9HVW5pcXVlUHRyR3RrLmgKQEAgLTI2LDcgKzI2LDYgQEAKIG5hbWVzcGFj ZSBXVEYgewogCiBXVEZfREVGSU5FX0dQVFJfREVMRVRFUihHZGtFdmVudCwgZ2RrX2V2ZW50X2Zy ZWUpCi1XVEZfREVGSU5FX0dQVFJfREVMRVRFUihHdGtJY29uSW5mbywgZ3RrX2ljb25faW5mb19m cmVlKQogV1RGX0RFRklORV9HUFRSX0RFTEVURVIoR3RrVHJlZVBhdGgsIGd0a190cmVlX3BhdGhf ZnJlZSkKIAogfSAvLyBuYW1lc3BhY2UgV1RGCg==