118377 2013-07-03 22:27:26 -0700 [Coordinated Graphics] Don't use && operator in ASSERT 2013-07-03 23:45:47 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jaepark webkit-unassigned cmarcelo commit-queue luiz noam oldest_to_newest 906046 0 jaepark 2013-07-03 22:27:26 -0700 We don't use && operator in ASSERT because it's impossible to know which condition caused the assertion. 906048 1 206051 jaepark 2013-07-03 22:29:33 -0700 Created attachment 206051 Patch 906055 2 206051 commit-queue 2013-07-03 23:45:44 -0700 Comment on attachment 206051 Patch Clearing flags on attachment: 206051 Committed r152390: <http://trac.webkit.org/changeset/152390> 906056 3 commit-queue 2013-07-03 23:45:47 -0700 All reviewed patches have been landed. Closing bug. 206051 2013-07-03 22:29:33 -0700 2013-07-03 23:45:44 -0700 Patch bug-118377-20130703222845.patch text/plain 2772 jaepark U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQyMDA5Y2U0YTVlNjI5 ODNhMWJmZjkzYTA2ZDYwZDY0MmVjY2M0ZS4uYzVlYjZiM2MxNDY1NGM5Mzc0NWQzYzhkYzZkNDYz NWZjNWZjMTllNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA3LTAzICBKYWUg SHl1biBQYXJrICA8amFlLnBhcmtAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW0Nvb3JkaW5h dGVkIEdyYXBoaWNzXSBEb24ndCB1c2UgJiYgb3BlcmF0b3IgaW4gQVNTRVJUCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzNzcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBkb24ndCB1c2UgJiYgb3Bl YXJ0b3IgaW4gQVNTRVJUIGJlY2F1c2UgaXQncyBpbXBvc3NpYmxlIHRvIGtub3cgd2hpY2gKKyAg ICAgICAgY29uZGl0aW9uIGNhdXNlZCB0aGUgYXNzZXJ0aW9uLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkQmFja2luZ1N0b3JlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVkQmFja2luZ1N0b3JlVGlsZTo6c3dhcEJ1 ZmZlcnMpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9D b29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0 ZWRHcmFwaGljc0xheWVyOjp+Q29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKToKKwogMjAxMy0wNy0w MyAgS2FuZ2lsIEhhbiAgPGthbmdpbC5oYW5Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgQWRvcHQg aXMvdG9IVE1MTWFwRWxlbWVudCBmb3IgY29kZSBjbGVhbnVwCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRC YWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkQmFja2luZ1N0b3JlLmNwcAppbmRleCBjZDVhMTJkOTY3 YjY1MGI5OTA4ZGUxMDJjNGMyOTEzM2E1MmUwYjk0Li4yNzM3ZWMxMjUyNzUyZGZlYTY4ZGI4NTk4 OGFlYWFhNzY1MzAxZWZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRCYWNraW5nU3RvcmUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29y ZGluYXRlZEJhY2tpbmdTdG9yZS5jcHAKQEAgLTQ3LDcgKzQ3LDggQEAgdm9pZCBDb29yZGluYXRl ZEJhY2tpbmdTdG9yZVRpbGU6OnN3YXBCdWZmZXJzKFRleHR1cmVNYXBwZXIqIHRleHR1cmVNYXBw ZXIpCiAgICAgICAgIHNob3VsZFJlc2V0ID0gdHJ1ZTsKICAgICB9CiAKLSAgICBBU1NFUlQodGV4 dHVyZU1hcHBlci0+bWF4VGV4dHVyZVNpemUoKS53aWR0aCgpID49IG1fdGlsZVJlY3Quc2l6ZSgp LndpZHRoKCkgJiYgdGV4dHVyZU1hcHBlci0+bWF4VGV4dHVyZVNpemUoKS5oZWlnaHQoKSA+PSBt X3RpbGVSZWN0LnNpemUoKS5oZWlnaHQoKSk7CisgICAgQVNTRVJUKHRleHR1cmVNYXBwZXItPm1h eFRleHR1cmVTaXplKCkud2lkdGgoKSA+PSBtX3RpbGVSZWN0LnNpemUoKS53aWR0aCgpKTsKKyAg ICBBU1NFUlQodGV4dHVyZU1hcHBlci0+bWF4VGV4dHVyZVNpemUoKS5oZWlnaHQoKSA+PSBtX3Rp bGVSZWN0LnNpemUoKS5oZWlnaHQoKSk7CiAgICAgaWYgKHNob3VsZFJlc2V0KQogICAgICAgICB0 ZXh0dXJlLT5yZXNldChtX3RpbGVSZWN0LnNpemUoKSwgbV9zdXJmYWNlLT5zdXBwb3J0c0FscGhh KCkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXht YXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBo aWNzTGF5ZXIuY3BwCmluZGV4IGQxYzFjNWRjOTkwNDJjOGVmZmM1MmU2NDk3YzRhOWY0NGM3YjM3 ZTIuLjdlNzBiYmIwZDRhY2U0NDg5NzE2YjQ4YTg2YjQzZTkzNjkyM2UyNzMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29y ZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCkBA IC0xMzUsNyArMTM1LDggQEAgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjp+Q29vcmRpbmF0ZWRH cmFwaGljc0xheWVyKCkKICAgICAgICAgcHVyZ2VCYWNraW5nU3RvcmVzKCk7CiAgICAgICAgIG1f Y29vcmRpbmF0b3ItPmRldGFjaExheWVyKHRoaXMpOwogICAgIH0KLSAgICBBU1NFUlQoIW1fY29v cmRpbmF0ZWRJbWFnZUJhY2tpbmcgJiYgIW1fbWFpbkJhY2tpbmdTdG9yZSk7CisgICAgQVNTRVJU KCFtX2Nvb3JkaW5hdGVkSW1hZ2VCYWNraW5nKTsKKyAgICBBU1NFUlQoIW1fbWFpbkJhY2tpbmdT dG9yZSk7CiAgICAgd2lsbEJlRGVzdHJveWVkKCk7CiB9CiAK