118370 2013-07-03 13:32:40 -0700 [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available. 2013-07-04 23:54:19 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ostap73 ostap73 cdumez commit-queue gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 905966 0 ostap73 2013-07-03 13:32:40 -0700 Should have fallback like WK2 test runner has. 905968 1 206021 ostap73 2013-07-03 13:41:30 -0700 Created attachment 206021 Patch 905974 2 206024 ostap73 2013-07-03 14:10:32 -0700 Created attachment 206024 Patch 906036 3 206024 cdumez 2013-07-03 21:34:13 -0700 Comment on attachment 206024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206024&action=review > Tools/DumpRenderTree/efl/DumpRenderTree.cpp:438 > const char* engine = 0; The engine here can be moved inside the #ifdef. 906037 4 206024 cdumez 2013-07-03 21:34:50 -0700 Comment on attachment 206024 Patch Please fix the nit before landing. 906038 5 206024 cdumez 2013-07-03 21:44:21 -0700 Comment on attachment 206024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206024&action=review >> Tools/DumpRenderTree/efl/DumpRenderTree.cpp:438 >> const char* engine = 0; > > The engine here can be moved inside the #ifdef. We actually don't even need this variable. We can simply pass ""opengl_x11" to ecore_evas_new(). 906299 6 206123 ostap73 2013-07-04 22:58:52 -0700 Created attachment 206123 Patch for landing 906304 7 206123 commit-queue 2013-07-04 23:54:16 -0700 Comment on attachment 206123 Patch for landing Clearing flags on attachment: 206123 Committed r152408: <http://trac.webkit.org/changeset/152408> 906305 8 commit-queue 2013-07-04 23:54:19 -0700 All reviewed patches have been landed. Closing bug. 206021 2013-07-03 13:41:30 -0700 2013-07-03 14:10:24 -0700 Patch bug-118370-20130703163928.patch text/plain 1567 ostap73 U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTFlYWEwZjdiMGNmOTZhZDA3MDM1MzE3YTFiNTA5YjVm OWE0OTYzNS4uYjRlYjVkMGZlZTYzYmNkNGM2YmFiM2QwNDA4NDdkMmIzNGExYzY4OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA3LTAzICBWaWF0Y2hlc2xhdiBPc3RhcGVua28gIDxzbC5vc3RhcGVua29Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgRHVtcFJlbmRlclRyZWUgZG9lc24ndCBydW4gaWYgIm9wZW5n bF94MTEiIGVuZ2luZSBpcyBub3QgYXZhaWxhYmxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGZhbGxiYWNrIHRvIHNvZnR3YXJlIFgxMSBlbmdp bmUgaWYgb3BlbmdsX3gxMSBlbmdpbmUgY3JlYXRpb24gZmFpbHMuCisKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoaW5pdEVjb3JlRXZh cyk6CisKIDIwMTMtMDctMDMgIEJyaWFuIEhvbHQgIDxicmlhbi5ob2x0QHNhbXN1bmcuY29tPgog CiAgICAgICAgIFtBVEtdIExlYWs6IG1vcmUgbGVha3MgaW4gQWNjZXNzaWJpbGl0eVVJRWxlbWVu dApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlLmNw cCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggMjk4 YTI2YWRkMDQ3OTQwOTA3MmNlMjM4NWE3YzVhZmFjOWJkODkwYi4uMzkwMmQ3YmNiMmZmOTFlMGY3 Yzk2MmE1NDA3NmZiYjcyMmZkYTU0YiAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv ZWZsL0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVt cFJlbmRlclRyZWUuY3BwCkBAIC00MzYsMTAgKzQzNiwxMyBAQCB2b2lkIGR1bXAoKQogc3RhdGlj IEVjb3JlX0V2YXMqIGluaXRFY29yZUV2YXMoKQogewogICAgIGNvbnN0IGNoYXIqIGVuZ2luZSA9 IDA7CisgICAgRWNvcmVfRXZhcyogZWNvcmVFdmFzID0gMDsKICNpZiBkZWZpbmVkKFdURl9VU0Vf QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpICYmIGRlZmluZWQoSEFWRV9FQ09SRV9YKQogICAgIGVu Z2luZSA9ICJvcGVuZ2xfeDExIjsKKyAgICBlY29yZUV2YXMgPSBlY29yZV9ldmFzX25ldyhlbmdp bmUsIDAsIDAsIDgwMCwgNjAwLCAwKTsKKyAgICBpZiAoIWVjb3JlRXZhcykKICNlbmRpZgotICAg IEVjb3JlX0V2YXMqIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwgMCwgODAw LCA2MDAsIDApOworICAgIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KDAsIDAsIDAsIDgwMCwg NjAwLCAwKTsKICAgICBpZiAoIWVjb3JlRXZhcykgewogICAgICAgICBzaHV0ZG93bkVmbCgpOwog ICAgICAgICBleGl0KEVYSVRfRkFJTFVSRSk7Cg== 206024 2013-07-03 14:10:32 -0700 2013-07-04 22:58:47 -0700 Patch bug-118370-20130703170825.patch text/plain 1572 ostap73 U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTFlYWEwZjdiMGNmOTZhZDA3MDM1MzE3YTFiNTA5YjVm OWE0OTYzNS4uYzA1MGRjMjE1NjY1NTZjMzFkODVjYjFmZmUzMzdlZTgxM2M1YjRhNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA3LTAzICBWaWF0Y2hlc2xhdiBPc3RhcGVua28gIDxzbC5vc3RhcGVua29Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gRHVtcFJlbmRlclRyZWUgZG9lc24ndCBydW4gaWYg Im9wZW5nbF94MTEiIGVuZ2luZSBpcyBub3QgYXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzNzAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgZmFsbGJhY2sgdG8gc29mdHdhcmUgWDEx IGVuZ2luZSBpZiBvcGVuZ2xfeDExIGVuZ2luZSBjcmVhdGlvbiBmYWlscy4KKworICAgICAgICAq IER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChpbml0RWNv cmVFdmFzKToKKwogMjAxMy0wNy0wMyAgQnJpYW4gSG9sdCAgPGJyaWFuLmhvbHRAc2Ftc3VuZy5j b20+CiAKICAgICAgICAgW0FUS10gTGVhazogbW9yZSBsZWFrcyBpbiBBY2Nlc3NpYmlsaXR5VUlF bGVtZW50CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRl eCAyOThhMjZhZGQwNDc5NDA5MDcyY2UyMzg1YTdjNWFmYWM5YmQ4OTBiLi4zOTAyZDdiY2IyZmY5 MWUwZjdjOTYyYTU0MDc2ZmJiNzIyZmRhNTRiIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Vm bC9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTQzNiwxMCArNDM2LDEzIEBAIHZvaWQgZHVtcCgpCiBz dGF0aWMgRWNvcmVfRXZhcyogaW5pdEVjb3JlRXZhcygpCiB7CiAgICAgY29uc3QgY2hhciogZW5n aW5lID0gMDsKKyAgICBFY29yZV9FdmFzKiBlY29yZUV2YXMgPSAwOwogI2lmIGRlZmluZWQoV1RG X1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORykgJiYgZGVmaW5lZChIQVZFX0VDT1JFX1gpCiAg ICAgZW5naW5lID0gIm9wZW5nbF94MTEiOworICAgIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3 KGVuZ2luZSwgMCwgMCwgODAwLCA2MDAsIDApOworICAgIGlmICghZWNvcmVFdmFzKQogI2VuZGlm Ci0gICAgRWNvcmVfRXZhcyogZWNvcmVFdmFzID0gZWNvcmVfZXZhc19uZXcoZW5naW5lLCAwLCAw LCA4MDAsIDYwMCwgMCk7CisgICAgZWNvcmVFdmFzID0gZWNvcmVfZXZhc19uZXcoMCwgMCwgMCwg ODAwLCA2MDAsIDApOwogICAgIGlmICghZWNvcmVFdmFzKSB7CiAgICAgICAgIHNodXRkb3duRWZs KCk7CiAgICAgICAgIGV4aXQoRVhJVF9GQUlMVVJFKTsK 206123 2013-07-04 22:58:52 -0700 2013-07-04 23:54:16 -0700 Patch for landing bug-118370-20130705015641.patch text/plain 1561 ostap73 U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGU0ZmQ1NGU5MmM3NmM0ZGMxZTZlNzYyMzhlMjQ3NzBi YzU1M2Y5Zi4uNmQxYTZlN2QyYzBiM2FkOTI0MTRkNWY2N2EwYjYzYWFlZDhhYzc5YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTA3LTAzICBWaWF0Y2hlc2xhdiBPc3RhcGVua28gIDxzbC5vc3RhcGVua29Ac2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gRHVtcFJlbmRlclRyZWUgZG9lc24ndCBydW4gaWYg Im9wZW5nbF94MTEiIGVuZ2luZSBpcyBub3QgYXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzNzAKKworICAgICAgICBSZXZpZXdlZCBi eSBDaHJpc3RvcGhlIER1bWV6LgorCisgICAgICAgIEFkZCBmYWxsYmFjayB0byBzb2Z0d2FyZSBY MTEgZW5naW5lIGlmIG9wZW5nbF94MTEgZW5naW5lIGNyZWF0aW9uIGZhaWxzLgorCisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAgKGluaXRF Y29yZUV2YXMpOgorCiAyMDEzLTA3LTAzICBEYXZpZCBGYXJsZXIgIDxkZmFybGVyQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgTWFrZWZpbGUgdG8gV2ViS2l0TGF1bmNoZXIKZGlmZiAtLWdpdCBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWUuY3BwCmluZGV4IDI5OGEyNmFkZDA0Nzk0MDkw NzJjZTIzODVhN2M1YWZhYzliZDg5MGIuLmFjODVmMDRhYmZhNzcyM2FiNWJiNGUyYTVjZjZiZWNk ZjE1MjU3NjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVy VHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlLmNw cApAQCAtNDM1LDExICs0MzUsMTIgQEAgdm9pZCBkdW1wKCkKIAogc3RhdGljIEVjb3JlX0V2YXMq IGluaXRFY29yZUV2YXMoKQogewotICAgIGNvbnN0IGNoYXIqIGVuZ2luZSA9IDA7CisgICAgRWNv cmVfRXZhcyogZWNvcmVFdmFzID0gMDsKICNpZiBkZWZpbmVkKFdURl9VU0VfQUNDRUxFUkFURURf Q09NUE9TSVRJTkcpICYmIGRlZmluZWQoSEFWRV9FQ09SRV9YKQotICAgIGVuZ2luZSA9ICJvcGVu Z2xfeDExIjsKKyAgICBlY29yZUV2YXMgPSBlY29yZV9ldmFzX25ldygib3BlbmdsX3gxMSIsIDAs IDAsIDgwMCwgNjAwLCAwKTsKKyAgICBpZiAoIWVjb3JlRXZhcykKICNlbmRpZgotICAgIEVjb3Jl X0V2YXMqIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KGVuZ2luZSwgMCwgMCwgODAwLCA2MDAs IDApOworICAgIGVjb3JlRXZhcyA9IGVjb3JlX2V2YXNfbmV3KDAsIDAsIDAsIDgwMCwgNjAwLCAw KTsKICAgICBpZiAoIWVjb3JlRXZhcykgewogICAgICAgICBzaHV0ZG93bkVmbCgpOwogICAgICAg ICBleGl0KEVYSVRfRkFJTFVSRSk7Cg==