118363 2013-07-03 10:37:11 -0700 [GTK] plugin widgets are not shown or hidden correctly 2015-12-22 06:03:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 rschroll berto berto cgarcia darin eric mcatanzaro mrobinson oldest_to_newest 905918 0 206010 rschroll 2013-07-03 10:37:11 -0700 Created attachment 206010 Test case I've noticed that a plugin I insert into a WebKit-GTK WebView doesn't update correctly when widgets are shown or hidden. Although the visibility of the widgets is sometimes adjusted instantly, the space for the widgets isn't allocated or deallocated automatically. Resizing or scrolling the WebView is enough to trigger this reallocation. Attached is a test case program, which illustrates the problem with two examples. It creates a Gtk.Window that contains a WebView that contains an <embed> that contains a GTK GUI. There are two buttons. The top one creates a label directly below it, but it doesn't become visible until the window is resized. The lower button alternately shows and hides the label below itself. The visibility of the label gets updated immediately, but the space for it isn't added or removed until the window is resized. If I put this GUI directly in a top-level Gtk.Window, it works correctly. I've tried to force the UI to update with the force_redraw function. Right now, it's completely commented out. If you uncomment any of the first three bits of code, the UI will update correctly. The last two do not work, despite seeming that they might. I hope this is a clue as to what's going wrong. For the record, I'm using webkitgtk 1.10.2, the WebKit1 API, and Gtk 3.4.2, on Ubuntu 12.04. On the mailing list, it was suggested that this might be related to bug #106093. 906068 1 berto 2013-07-04 00:32:42 -0700 Thanks for the report and the test case. I'll try to take a look asap. 937426 2 213670 berto 2013-10-08 00:23:46 -0700 Created attachment 213670 Patch Sorry for having taken so long to look into this. The problem is that the web view is not propagating the GTK size_allocate call to its children, so even if any of them needs it (in this case: a new label appears and needs to compute its size) it will not get its allocation. It works if you resize the window because changing the size of the frame will force a new allocation (via GtkPluginWidget::frameRectsChanged). 937440 3 213670 cgarcia 2013-10-08 00:59:39 -0700 Comment on attachment 213670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=213670&action=review > Source/WebKit/gtk/webkit/webkitwebview.cpp:852 > + GtkAllocation* delayedAlloc = static_cast<GtkAllocation*>(g_object_get_data(G_OBJECT(child), "delayed-allocation")); delayedAlloc -> delayedAllocation > Source/WebKit/gtk/webkit/webkitwebview.cpp:859 > + GtkAllocation alloc; alloc -> allocation > Source/WebKit/gtk/webkit/webkitwebview.cpp:861 > + gtk_widget_get_allocation(child, &alloc); > + gtk_widget_size_allocate(child, &alloc); This looks weird to me. Shouldn't the view know the size and position to give to its children? Who set the current child allocation then? 937450 4 berto 2013-10-08 01:19:28 -0700 (In reply to comment #3) > > Source/WebKit/gtk/webkit/webkitwebview.cpp:861 > > + gtk_widget_get_allocation(child, &alloc); > > + gtk_widget_size_allocate(child, &alloc); > > This looks weird to me. Shouldn't the view know the size and > position to give to its children? Who set the current child > allocation then? As far as I can see it's only set by GtkPluginWidget::frameRectsChanged() (via Widget::setFrameRect()). 937454 5 cgarcia 2013-10-08 01:27:52 -0700 (In reply to comment #4) > (In reply to comment #3) > > > > Source/WebKit/gtk/webkit/webkitwebview.cpp:861 > > > + gtk_widget_get_allocation(child, &alloc); > > > + gtk_widget_size_allocate(child, &alloc); > > > > This looks weird to me. Shouldn't the view know the size and > > position to give to its children? Who set the current child > > allocation then? > > As far as I can see it's only set by GtkPluginWidget::frameRectsChanged() > (via Widget::setFrameRect()). Aha, so maybe GtkPluginWidget should set the delayed-allocation instead of calling set_size_request + size_allocate, so that is the container the one in charge of allocating its children. 937463 6 berto 2013-10-08 01:55:50 -0700 (In reply to comment #5) > Aha, so maybe GtkPluginWidget should set the delayed-allocation > instead of calling set_size_request + size_allocate, so that is the > container the one in charge of allocating its children. The problem here is that the allocation of the plugin widget itself (a GtkBox in this case) doesn't change (because the frame size doesn't change). It's the contents of the GtkBox that need a new allocation. 1150874 7 213670 mcatanzaro 2015-12-22 06:03:35 -0800 Comment on attachment 213670 Patch Hi Robert! We don't allow inserting widgets into webviews in WK2, so I guess this bug is obsolete. Certainly the patch is obsolete as it's written for WK1. 206010 2013-07-03 10:37:11 -0700 2013-07-03 10:37:11 -0700 Test case plugin3.c text/x-csrc 3516 rschroll Ly8gQ2xlYW5lZCB1cCBmcm9tIHZhbGEtZ2VuZXJhdGVkIEMuICBBcG9sb2dpZXMgaWYgaXQncyBu b3QgaWRpb21hdGljLgoKI2luY2x1ZGUgPGdsaWIuaD4KI2luY2x1ZGUgPGdsaWItb2JqZWN0Lmg+ CiNpbmNsdWRlIDxndGsvZ3RrLmg+CiNpbmNsdWRlIDxzdGRsaWIuaD4KI2luY2x1ZGUgPHN0cmlu Zy5oPgojaW5jbHVkZSA8d2Via2l0L3dlYmtpdC5oPgoKR3RrQm94KiB3aWRnZXQgPSBOVUxMOwpH dGtMYWJlbCogbGFiZWwgPSBOVUxMOwpnYm9vbGVhbiBoaWRkZW4gPSBGQUxTRTsKCnN0YXRpYyB2 b2lkIG9uX2Rlc3Ryb3kgKEd0a1dpZGdldCogc2VuZGVyLCBncG9pbnRlciBzZWxmKSB7CglndGtf bWFpbl9xdWl0ICgpOwp9CgpzdGF0aWMgdm9pZCBmb3JjZV9yZWRyYXcgKCkgewoJLy8gSWYgdGhp cyBmdW5jdGlvbiBkb2Vzbid0IGRvIGFueXRoaW5nLCB3ZSBkb24ndCBnZXQgYWxsIG9mIHRoZSBV SQoJLy8gdXBkYXRlcyB0aGF0IHdlIGV4cGVjdC4gIFRoZSBmb2xsb3dpbmcgZml2ZSBmdW5jdGlv bnMgY2FsbHMgc2VlbWVkCgkvLyBsaWFibGUgdG8gY2F1c2UgdXBkYXRlcy4gIFRocmVlIG9mIHRo ZW0gd29yaywgdHdvIGRvbid0LgoJCgkvLyBDYWxsaW5nIHJlc2l6ZV9jaGlsZHJlbiB3aWxsIGZv cmNlIHRoZSB1cGRhdGVzLgoJLy9ndGtfY29udGFpbmVyX3Jlc2l6ZV9jaGlsZHJlbiAoKEd0a0Nv bnRhaW5lciopIHdpZGdldCk7CgkKCS8vIENhbGxpbmcgY2hlY2tfcmVzaXplIHdpbGwgZm9yY2Ug dGhlIHVwZGF0ZXMuCgkvL2d0a19jb250YWluZXJfY2hlY2tfcmVzaXplICgoR3RrQ29udGFpbmVy Kikgd2lkZ2V0KTsKCQoJLy8gQ2FsbGluZyBzaXplX2FsbG9jYXRlIHdpbGwgZm9yY2UgdGhlIHVw ZGF0ZXMuCgkvL0d0a0FsbG9jYXRpb24qIGFsbG9jID0gZ19uZXcoR3RrQWxsb2NhdGlvbiwgMSk7 CgkvL2d0a193aWRnZXRfZ2V0X2FsbG9jYXRpb24oKEd0a1dpZGdldCopIHdpZGdldCwgYWxsb2Mp OwoJLy9ndGtfd2lkZ2V0X3NpemVfYWxsb2NhdGUoKEd0a1dpZGdldCopIHdpZGdldCwgYWxsb2Mp OwoJCgkvLyBDYWxsaW5nIHF1ZXVlX2RyYXcgd2lsbCBOT1QgZm9yY2UgdGhlIHVwZGF0ZXMuCgkv L2d0a193aWRnZXRfcXVldWVfZHJhdygoR3RrV2lkZ2V0Kikgd2lkZ2V0KTsKCQoJLy8gQ2FsbGlu ZyBxdWV1ZV9yZXNpemUgd2lsbCBOT1QgZm9yY2UgdGhlIHVwZGF0ZXMuCgkvL2d0a193aWRnZXRf cXVldWVfcmVzaXplKChHdGtXaWRnZXQqKSB3aWRnZXQpOwp9CgpzdGF0aWMgdm9pZCBvbl9hZGQg KEd0a0J1dHRvbiogc2VuZGVyLCBncG9pbnRlciBzZWxmKSB7CglHdGtMYWJlbCogbmV3X2xhYmVs ID0gKEd0a0xhYmVsKikgZ3RrX2xhYmVsX25ldyAoIlBlZWstYS1ib28hIik7CglndGtfYm94X3Bh Y2tfc3RhcnQgKHdpZGdldCwgKEd0a1dpZGdldCopIG5ld19sYWJlbCwgRkFMU0UsIEZBTFNFLCAo Z3VpbnQpIDApOwoJZ3RrX3dpZGdldF9zaG93ICgoR3RrV2lkZ2V0KikgbmV3X2xhYmVsKTsKCWZv cmNlX3JlZHJhdygpOwp9CgpzdGF0aWMgdm9pZCBvbl9oaWRlIChHdGtCdXR0b24qIHNlbmRlciwg Z3BvaW50ZXIgc2VsZikgewoJaWYgKGhpZGRlbikgewoJCWd0a193aWRnZXRfc2hvdyAoKEd0a1dp ZGdldCopIGxhYmVsKTsKCX0gZWxzZSB7CgkJZ3RrX3dpZGdldF9oaWRlICgoR3RrV2lkZ2V0Kikg bGFiZWwpOwoJfQoJaGlkZGVuID0gIWhpZGRlbjsKCWZvcmNlX3JlZHJhdygpOwp9CgpzdGF0aWMg R3RrV2lkZ2V0KiBvbl9jcmVhdGVfcGx1Z2luIChXZWJLaXRXZWJWaWV3KiB2aWV3LCBjb25zdCBn Y2hhciogbWltZV90eXBlLCBjb25zdCBnY2hhciogdXJpLCBHSGFzaFRhYmxlKiBwYXJhbSwgZ3Bv aW50ZXIgc2VsZikgewoJR3RrQnV0dG9uKiBhZGQ7CglHdGtCdXR0b24qIGhpZGU7CgkKCXdpZGdl dCA9IChHdGtCb3gqKSBndGtfYm94X25ldyAoR1RLX09SSUVOVEFUSU9OX1ZFUlRJQ0FMLCAwKTsK CWFkZCA9IChHdGtCdXR0b24qKSBndGtfYnV0dG9uX25ld19mcm9tX3N0b2NrICgiZ3RrLWFkZCIp OwoJZ3RrX2JveF9wYWNrX3N0YXJ0ICh3aWRnZXQsIChHdGtXaWRnZXQqKSBhZGQsIEZBTFNFLCBG QUxTRSwgKGd1aW50KSAwKTsKCWdfc2lnbmFsX2Nvbm5lY3QgKGFkZCwgImNsaWNrZWQiLCAoR0Nh bGxiYWNrKSBvbl9hZGQsIE5VTEwpOwoJCglsYWJlbCA9IChHdGtMYWJlbCopIGd0a19sYWJlbF9u ZXcgKCJOb3cgeW91IHNlZSBtZS4uLiIpOwoJZ3RrX2JveF9wYWNrX2VuZCAod2lkZ2V0LCAoR3Rr V2lkZ2V0KikgbGFiZWwsIEZBTFNFLCBGQUxTRSwgKGd1aW50KSAwKTsKCWhpZGUgPSAoR3RrQnV0 dG9uKikgZ3RrX2J1dHRvbl9uZXdfd2l0aF9sYWJlbCAoIlRvZ2dsZSBoaWRkZW4iKTsKCWd0a19i b3hfcGFja19lbmQgKHdpZGdldCwgKEd0a1dpZGdldCopIGhpZGUsIEZBTFNFLCBGQUxTRSwgKGd1 aW50KSAwKTsKCWdfc2lnbmFsX2Nvbm5lY3QgKGhpZGUsICJjbGlja2VkIiwgKEdDYWxsYmFjaykg b25faGlkZSwgTlVMTCk7CglndGtfd2lkZ2V0X3Nob3dfYWxsICgoR3RrV2lkZ2V0Kikgd2lkZ2V0 KTsKCXJldHVybiAoR3RrV2lkZ2V0Kikgd2lkZ2V0Owp9CgppbnQgbWFpbiAoaW50IGFyZ2MsIGNo YXIqKiBhcmd2KSB7CglnY2hhciogSFRNTDsKCUd0a1dpbmRvdyogd2luZG93OwoJR3RrU2Nyb2xs ZWRXaW5kb3cqIHN3OwoJV2ViS2l0V2ViVmlldyogdmlldzsKCQoJZ190eXBlX2luaXQgKCk7Cgln dGtfaW5pdCAoJmFyZ2MsICZhcmd2KTsKCQoJSFRNTCA9IGdfc3RyZHVwICgiPGh0bWw+PGJvZHk+ PGVtYmVkIHdpZHRoPScxMDAlJyBoZWlnaHQ9JzkwJScgdHlwZT0ndHlwZScgIiBcCgkgICAgICAg ICAgICAgICAgICJzcmM9J3NvdXJjZScgc3R5bGU9J2JhY2tncm91bmQ6ICNlZWUnIC8+PC9ib2R5 PjwvaHRtbD4iKTsKCXdpbmRvdyA9IChHdGtXaW5kb3cqKSBndGtfd2luZG93X25ldyAoR1RLX1dJ TkRPV19UT1BMRVZFTCk7CglnX3NpZ25hbF9jb25uZWN0ICgoR3RrV2lkZ2V0Kikgd2luZG93LCAi ZGVzdHJveSIsIChHQ2FsbGJhY2spIG9uX2Rlc3Ryb3ksIE5VTEwpOwoJZ3RrX3dpbmRvd19zZXRf ZGVmYXVsdF9zaXplICh3aW5kb3csIDMwMCwgNDAwKTsKCXN3ID0gKEd0a1Njcm9sbGVkV2luZG93 KikgZ3RrX3Njcm9sbGVkX3dpbmRvd19uZXcgKE5VTEwsIE5VTEwpOwoJdmlldyA9IChXZWJLaXRX ZWJWaWV3Kikgd2Via2l0X3dlYl92aWV3X25ldyAoKTsKCWd0a19jb250YWluZXJfYWRkICgoR3Rr Q29udGFpbmVyKikgc3csIChHdGtXaWRnZXQqKSB2aWV3KTsKCWd0a19jb250YWluZXJfYWRkICgo R3RrQ29udGFpbmVyKikgd2luZG93LCAoR3RrV2lkZ2V0Kikgc3cpOwoJZ3RrX3dpZGdldF9zaG93 X2FsbCAoKEd0a1dpZGdldCopIHdpbmRvdyk7CglnX3NpZ25hbF9jb25uZWN0ICh2aWV3LCAiY3Jl YXRlLXBsdWdpbi13aWRnZXQiLCAoR0NhbGxiYWNrKSBvbl9jcmVhdGVfcGx1Z2luLCBOVUxMKTsK CXdlYmtpdF93ZWJfdmlld19sb2FkX3N0cmluZyAodmlldywgSFRNTCwgInRleHQvaHRtbCIsICJV VEYtOCIsICIiKTsKCWd0a19tYWluICgpOwoJcmV0dXJuIDA7Cn0K 213670 2013-10-08 00:23:46 -0700 2015-12-22 06:03:35 -0800 Patch 118363.diff text/plain 2618 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCA3ZWM3ZGUxLi45ZTkyMDE3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTMtMTAtMDcgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlh LmNvbT4KKworICAgICAgICBHVEsgcGx1Z2luIHdpZGdldHMgYXJlIG5vdCBzaG93biBvciBoaWRk ZW4gY29ycmVjdGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTgzNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBNYWtlIHN1cmUgdGhhdCBzaXplX2FsbG9jYXRlIGlzIHByb3BhZ2F0ZWQgdG8gYWxsIGNo aWxkcmVuIHdpZGdldHMKKyAgICAgICAgc28gdGhleSBjYW4gdXBkYXRlIHRoZWlyIGFsbG9jYXRp b25zIHdoZW4gdGhleSBuZWVkIGl0LgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcu Y3BwOgorICAgICAgICAodXBkYXRlQ2hpbGRBbGxvY2F0aW9uKToKKyAgICAgICAgKHJlc2l6ZVdl YlZpZXdGcm9tQWxsb2NhdGlvbik6CisKIDIwMTMtMTAtMDUgIFphbiBEb2JlcnNlayAgPHpkb2Jl cnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGJ1aWxkIGZpeCBhZnRl ciByMTU2OTQ2LiBUaGUgZnJhbWVQb2xpY3lGdW5jdGlvbiBpcyBhbiBhdHRyaWJ1dGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1NvdXJj ZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCA1ODBhOWYyLi4xYjg3 OGE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC04 NDQsMTggKzg0NCwyMiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfZ2V0X3ByZWZlcnJl ZF9oZWlnaHQoR3RrV2lkZ2V0KiB3aWRnZXQsIGdpbnQqIG1pbmltdQogfQogI2VuZGlmCiAKLXN0 YXRpYyB2b2lkIHVwZGF0ZUNoaWxkQWxsb2NhdGlvbkZyb21QZW5kaW5nQWxsb2NhdGlvbihHdGtX aWRnZXQqIGNoaWxkLCB2b2lkKikKK3N0YXRpYyB2b2lkIHVwZGF0ZUNoaWxkQWxsb2NhdGlvbihH dGtXaWRnZXQqIGNoaWxkLCB2b2lkKikKIHsKICAgICBpZiAoIWd0a193aWRnZXRfZ2V0X3Zpc2li bGUoY2hpbGQpKQogICAgICAgICByZXR1cm47CiAKLSAgICBHdGtBbGxvY2F0aW9uKiBhbGxvY2F0 aW9uID0gc3RhdGljX2Nhc3Q8R3RrQWxsb2NhdGlvbio+KGdfb2JqZWN0X2dldF9kYXRhKEdfT0JK RUNUKGNoaWxkKSwgImRlbGF5ZWQtYWxsb2NhdGlvbiIpKTsKLSAgICBpZiAoIWFsbG9jYXRpb24p Ci0gICAgICAgIHJldHVybjsKKyAgICBHdGtBbGxvY2F0aW9uKiBkZWxheWVkQWxsb2MgPSBzdGF0 aWNfY2FzdDxHdGtBbGxvY2F0aW9uKj4oZ19vYmplY3RfZ2V0X2RhdGEoR19PQkpFQ1QoY2hpbGQp LCAiZGVsYXllZC1hbGxvY2F0aW9uIikpOwogCi0gICAgZ19vYmplY3Rfc2V0X2RhdGEoR19PQkpF Q1QoY2hpbGQpLCAiZGVsYXllZC1hbGxvY2F0aW9uIiwgMCk7Ci0gICAgZ3RrX3dpZGdldF9zaXpl X2FsbG9jYXRlKGNoaWxkLCBhbGxvY2F0aW9uKTsKLSAgICAqYWxsb2NhdGlvbiA9IEludFJlY3Qo KTsKKyAgICBpZiAoZGVsYXllZEFsbG9jKSB7CisgICAgICAgIGdfb2JqZWN0X3NldF9kYXRhKEdf T0JKRUNUKGNoaWxkKSwgImRlbGF5ZWQtYWxsb2NhdGlvbiIsIDApOworICAgICAgICBndGtfd2lk Z2V0X3NpemVfYWxsb2NhdGUoY2hpbGQsIGRlbGF5ZWRBbGxvYyk7CisgICAgICAgICpkZWxheWVk QWxsb2MgPSBJbnRSZWN0KCk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgR3RrQWxsb2NhdGlvbiBh bGxvYzsKKyAgICAgICAgZ3RrX3dpZGdldF9nZXRfYWxsb2NhdGlvbihjaGlsZCwgJmFsbG9jKTsK KyAgICAgICAgZ3RrX3dpZGdldF9zaXplX2FsbG9jYXRlKGNoaWxkLCAmYWxsb2MpOworICAgIH0K IH0KIAogc3RhdGljIHZvaWQgcmVzaXplV2ViVmlld0Zyb21BbGxvY2F0aW9uKFdlYktpdFdlYlZp ZXcqIHdlYlZpZXcsIEd0a0FsbG9jYXRpb24qIGFsbG9jYXRpb24sIGJvb2wgc2l6ZUNoYW5nZWQp CkBAIC04NjgsNyArODcyLDcgQEAgc3RhdGljIHZvaWQgcmVzaXplV2ViVmlld0Zyb21BbGxvY2F0 aW9uKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIEd0a0FsbG9jYXRpb24qIGEKICAgICAgICAgZnJh bWVWaWV3LT5yZXNpemUoYWxsb2NhdGlvbi0+d2lkdGgsIGFsbG9jYXRpb24tPmhlaWdodCk7CiAg ICAgfQogCi0gICAgZ3RrX2NvbnRhaW5lcl9mb3JhbGwoR1RLX0NPTlRBSU5FUih3ZWJWaWV3KSwg dXBkYXRlQ2hpbGRBbGxvY2F0aW9uRnJvbVBlbmRpbmdBbGxvY2F0aW9uLCAwKTsKKyAgICBndGtf Y29udGFpbmVyX2ZvcmFsbChHVEtfQ09OVEFJTkVSKHdlYlZpZXcpLCB1cGRhdGVDaGlsZEFsbG9j YXRpb24sIDApOwogCiAgICAgaWYgKCFzaXplQ2hhbmdlZCkKICAgICAgICAgcmV0dXJuOwo=