118362 2013-07-03 10:15:26 -0700 [ATK] Leak: more leaks in AccessibilityUIElement 2013-07-03 11:51:10 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116317 0 brian.holt webkit-unassigned commit-queue eflews.bot gtk-ews gyuyoung.kim xan.lopez oldest_to_newest 905905 0 brian.holt 2013-07-03 10:15:26 -0700 In Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Leaks found using the "--leak" option in the Gtk port: { <insert_a_suppression_name_here> Memcheck:Leak fun:malloc fun:__vasprintf_chk fun:g_vasprintf fun:g_strdup_vprintf fun:g_strdup_printf fun:_ZN22AccessibilityUIElement8languageEv fun:_ZL19getLanguageCallbackPK15OpaqueJSContextP13OpaqueJSValueP14OpaqueJSStringPPKS2_ fun:_ZN3JSC16JSCallbackObjectINS_20JSDestructibleObjectEE14getStaticValueEPNS_9ExecStateENS_12PropertyNameE fun:_ZN3JSC16JSCallbackObjectINS_20JSDestructibleObjectEE18getOwnPropertySlotEPNS_6JSCellEPNS_9ExecStateENS_12PropertyNameERNS_12PropertySlotE fun:llint_slow_path_get_by_id obj:/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1 fun:_ZN3JSC11Interpreter7executeEPNS_17ProgramExecutableEPNS_9ExecStateEPNS_8JSObjectE fun:_ZN3JSC8evaluateEPNS_9ExecStateERKNS_10SourceCodeENS_7JSValueEPS5_ fun:_ZN7WebCore16ScriptController15evaluateInWorldERKNS_16ScriptSourceCodeEPNS_15DOMWrapperWorldE fun:_ZN7WebCore16ScriptController8evaluateERKNS_16ScriptSourceCodeE fun:_ZN7WebCore13ScriptElement13executeScriptERKNS_16ScriptSourceCodeE fun:_ZN7WebCore13ScriptElement13prepareScriptERKN3WTF12TextPositionENS0_17LegacyTypeSupportE fun:_ZN7WebCore16HTMLScriptRunner9runScriptEPNS_7ElementERKN3WTF12TextPositionE fun:_ZN7WebCore16HTMLScriptRunner7executeEN3WTF10PassRefPtrINS_7ElementEEERKNS1_12TextPositionE fun:_ZN7WebCore18HTMLDocumentParser30runScriptsForPausedTreeBuilderEv fun:_ZN7WebCore18HTMLDocumentParser16canTakeNextTokenENS0_15SynchronousModeERNS_11PumpSessionE fun:_ZN7WebCore18HTMLDocumentParser13pumpTokenizerENS0_15SynchronousModeE } { <insert_a_suppression_name_here> Memcheck:Leak fun:malloc fun:g_malloc fun:g_strdup fun:_ZL27webkitAccessibleTextGetTextP8_AtkTextii fun:_ZL23webkitAccessibleGetNameP10_AtkObject fun:_ZN22AccessibilityUIElement5titleEv fun:_ZL16getTitleCallbackPK15OpaqueJSContextP13OpaqueJSValueP14OpaqueJSStringPPKS2_ fun:_ZN3JSC16JSCallbackObjectINS_20JSDestructibleObjectEE14getStaticValueEPNS_9ExecStateENS_12PropertyNameE fun:_ZN3JSC16JSCallbackObjectINS_20JSDestructibleObjectEE18getOwnPropertySlotEPNS_6JSCellEPNS_9ExecStateENS_12PropertyNameERNS_12PropertySlotE fun:llint_slow_path_get_by_id obj:/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1 fun:_ZN3JSC11Interpreter7executeEPNS_14EvalExecutableEPNS_9ExecStateENS_7JSValueEPNS_7JSScopeE fun:_ZN3JSC4evalEPNS_9ExecStateE fun:llint_slow_path_call_eval obj:/home/likewise-open/SERILOCAL/brian.holt/Code/gnome3/WebKit/WebKitBuild/Release/.libs/libjavascriptcoregtk-3.0.so.0.14.1 fun:_ZN3JSC11Interpreter7executeEPNS_17ProgramExecutableEPNS_9ExecStateEPNS_8JSObjectE fun:_ZN3JSC8evaluateEPNS_9ExecStateERKNS_10SourceCodeENS_7JSValueEPS5_ fun:_ZN7WebCore16ScriptController15evaluateInWorldERKNS_16ScriptSourceCodeEPNS_15DOMWrapperWorldE fun:_ZN7WebCore16ScriptController8evaluateERKNS_16ScriptSourceCodeE fun:_ZN7WebCore13ScriptElement13executeScriptERKNS_16ScriptSourceCodeE fun:_ZN7WebCore13ScriptElement13prepareScriptERKN3WTF12TextPositionENS0_17LegacyTypeSupportE fun:_ZN7WebCore16HTMLScriptRunner9runScriptEPNS_7ElementERKN3WTF12TextPositionE } 905923 1 206012 brian.holt 2013-07-03 10:51:08 -0700 Created attachment 206012 Patch 905925 2 206012 eflews.bot 2013-07-03 10:54:35 -0700 Comment on attachment 206012 Patch Attachment 206012 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1015764 905926 3 brian.holt 2013-07-03 10:55:11 -0700 The title one is a bit trickier because fun:g_strdup fun:_ZL27webkitAccessibleTextGetTextP8_AtkTextii fun:_ZL23webkitAccessibleGetNameP10_AtkObject fun:_ZN22AccessibilityUIElement5titleEv webkitAccessibleGetName(AtkObject*) sometimes returns a char* that is created by g_strdup but it also sometimes returns a value stored in a cache. Freeing that would be a disaster. My feeling at this stage is that the effort required to refactor is not worth the few bytes leaking. 905928 4 206012 eflews.bot 2013-07-03 10:56:47 -0700 Comment on attachment 206012 Patch Attachment 206012 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1012992 905929 5 206012 gtk-ews 2013-07-03 10:57:32 -0700 Comment on attachment 206012 Patch Attachment 206012 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1022262 905930 6 206012 cdumez 2013-07-03 10:59:14 -0700 Comment on attachment 206012 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206012&action=review > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:439 > + GOwnPtr<char> axValue(g_strdup_printf("AXLanguage: %s", locale)) missing ; > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:625 > + GOwnPtr<char> axValue(g_strdup_printf("AXLanguage: %s", locale)) ditto. 905931 7 206013 brian.holt 2013-07-03 11:03:45 -0700 Created attachment 206013 Patch 905932 8 206013 cdumez 2013-07-03 11:06:15 -0700 Comment on attachment 206013 Patch Ok, r=me. Do you want me to commit? You did not set the cq flag. 905937 9 brian.holt 2013-07-03 11:08:01 -0700 (In reply to comment #8) > (From update of attachment 206013 [details]) > Ok, r=me. Do you want me to commit? You did not set the cq flag. Yes please, I forgot to do that with webkit-patch. 905946 10 206013 commit-queue 2013-07-03 11:51:08 -0700 Comment on attachment 206013 Patch Clearing flags on attachment: 206013 Committed r152371: <http://trac.webkit.org/changeset/152371> 905947 11 commit-queue 2013-07-03 11:51:10 -0700 All reviewed patches have been landed. Closing bug. 206012 2013-07-03 10:51:08 -0700 2013-07-03 11:03:36 -0700 Patch bug-118362-20130703184912.patch text/plain 2425 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjAxZmY4YzUzNDc0MjEyOWUxNWI0MGM4OTZhOGU3Mzg0 OWY2YjJmNy4uZGZlYjAyYzM2OTliZjJhMWIyNzZmMTY0MDQ0ZTE5MzgyYWRiMDBlYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTA3LTAzICBCcmlhbiBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbQVRLXSBMZWFrOiBtb3JlIGxlYWtzIGluIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODM2Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyZWUgdGhl IG1lbW9yeSBjcmVhdGVkIGJ5IGdfc3RyZHVwX3ByaW50Zi4KKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcDoKKyAgICAgICAgKEFjY2Vz c2liaWxpdHlVSUVsZW1lbnQ6Omxhbmd1YWdlKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcDoKKyAgICAg ICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6bGFuZ3VhZ2UpOgorCiAyMDEzLTA3LTAz ICBNb3J0ZW4gU3RlbnNob3JuZSAgPG1zdGVuc2hvQG9wZXJhLmNvbT4KIAogICAgICAgICBbR1RL XSBMZXQgRjUgcmVmcmVzaCB0aGUgcGFnZSBpbiBNaW5pQnJvd3NlcgpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCmluZGV4 IDAwM2NhZGJhOGRjZjFjMmNmYzI0MGJiZjk2Y2NmYjM4ODJlYmIyMGMuLjBiNjMyYzc0MGVhYmZm ZjhhNWM3OTRkYzk3YzVhZDViNzU4MWJiODkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcAorKysgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAgLTQzNiw3ICs0MzYs OCBAQCBKU1N0cmluZ1JlZiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpsYW5ndWFnZSgpCiAgICAg aWYgKCFsb2NhbGUpCiAgICAgICAgIHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJz KDAsIDApOwogCi0gICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGdfc3Ry ZHVwX3ByaW50ZigiQVhMYW5ndWFnZTogJXMiLCBsb2NhbGUpKTsKKyAgICBHT3duUHRyPGNoYXI+ IGF4VmFsdWUoZ19zdHJkdXBfcHJpbnRmKCJBWExhbmd1YWdlOiAlcyIsIGxvY2FsZSkpCisgICAg cmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGF4VmFsdWUuZ2V0KCkpOwogfQog CiBkb3VibGUgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6eCgpCmRpZmYgLS1naXQgYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 QXRrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCmluZGV4IDE4ZDA4MWE2NmJmM2RjZmYyYzU1MmNkZGM2 MmEyOTUxMGEwMmFjOTIuLjMzNjQ2OGI2ODY0YTBiZmY0YzJjMmZjMGEwYWVjMWE3Nzc3ZmY1MDkg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0Fj Y2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCkBAIC02MjIs NyArNjIyLDggQEAgSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IEFjY2Vzc2liaWxpdHlVSUVsZW1l bnQ6Omxhbmd1YWdlKCkKICAgICBpZiAoIWxvY2FsZSkKICAgICAgICAgcmV0dXJuIEpTU3RyaW5n Q3JlYXRlV2l0aENoYXJhY3RlcnMoMCwgMCk7CiAKLSAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVX aXRoVVRGOENTdHJpbmcoZ19zdHJkdXBfcHJpbnRmKCJBWExhbmd1YWdlOiAlcyIsIGxvY2FsZSkp OworICAgIEdPd25QdHI8Y2hhcj4gYXhWYWx1ZShnX3N0cmR1cF9wcmludGYoIkFYTGFuZ3VhZ2U6 ICVzIiwgbG9jYWxlKSkKKyAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmco YXhWYWx1ZS5nZXQoKSk7CiB9CiAKIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBBY2Nlc3NpYmls aXR5VUlFbGVtZW50OjpoZWxwVGV4dCgpIGNvbnN0Cg== 206013 2013-07-03 11:03:45 -0700 2013-07-03 11:51:08 -0700 Patch bug-118362-20130703190148.patch text/plain 2427 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjAxZmY4YzUzNDc0MjEyOWUxNWI0MGM4OTZhOGU3Mzg0 OWY2YjJmNy4uZGZlYjAyYzM2OTliZjJhMWIyNzZmMTY0MDQ0ZTE5MzgyYWRiMDBlYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTA3LTAzICBCcmlhbiBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbQVRLXSBMZWFrOiBtb3JlIGxlYWtzIGluIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODM2Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZyZWUgdGhl IG1lbW9yeSBjcmVhdGVkIGJ5IGdfc3RyZHVwX3ByaW50Zi4KKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcDoKKyAgICAgICAgKEFjY2Vz c2liaWxpdHlVSUVsZW1lbnQ6Omxhbmd1YWdlKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcDoKKyAgICAg ICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6bGFuZ3VhZ2UpOgorCiAyMDEzLTA3LTAz ICBNb3J0ZW4gU3RlbnNob3JuZSAgPG1zdGVuc2hvQG9wZXJhLmNvbT4KIAogICAgICAgICBbR1RL XSBMZXQgRjUgcmVmcmVzaCB0aGUgcGFnZSBpbiBNaW5pQnJvd3NlcgpkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwCmluZGV4 IDAwM2NhZGJhOGRjZjFjMmNmYzI0MGJiZjk2Y2NmYjM4ODJlYmIyMGMuLjBhZDlhNDQ5NGFmYWY2 MDdlYTg3ZTUxZWYxMjljY2ZlODhiMjdmNTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcAorKysgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAgLTQzNiw3ICs0MzYs OCBAQCBKU1N0cmluZ1JlZiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpsYW5ndWFnZSgpCiAgICAg aWYgKCFsb2NhbGUpCiAgICAgICAgIHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJz KDAsIDApOwogCi0gICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGdfc3Ry ZHVwX3ByaW50ZigiQVhMYW5ndWFnZTogJXMiLCBsb2NhbGUpKTsKKyAgICBHT3duUHRyPGNoYXI+ IGF4VmFsdWUoZ19zdHJkdXBfcHJpbnRmKCJBWExhbmd1YWdlOiAlcyIsIGxvY2FsZSkpOworICAg IHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhheFZhbHVlLmdldCgpKTsKIH0K IAogZG91YmxlIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OngoKQpkaWZmIC0tZ2l0IGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVu dEF0ay5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0ay9BY2Nl c3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcAppbmRleCAxOGQwODFhNjZiZjNkY2ZmMmM1NTJjZGRj NjJhMjk1MTBhMDJhYzkyLi41MTU5M2NjZjQxZTJhNGE3NjQ3MDk1ODVlYzFhZjA2NmRmOTgxNWUx IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2F0ay9B Y2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL2F0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50QXRrLmNwcApAQCAtNjIy LDcgKzYyMiw4IEBAIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50OjpsYW5ndWFnZSgpCiAgICAgaWYgKCFsb2NhbGUpCiAgICAgICAgIHJldHVybiBKU1N0cmlu Z0NyZWF0ZVdpdGhDaGFyYWN0ZXJzKDAsIDApOwogCi0gICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRl V2l0aFVURjhDU3RyaW5nKGdfc3RyZHVwX3ByaW50ZigiQVhMYW5ndWFnZTogJXMiLCBsb2NhbGUp KTsKKyAgICBHT3duUHRyPGNoYXI+IGF4VmFsdWUoZ19zdHJkdXBfcHJpbnRmKCJBWExhbmd1YWdl OiAlcyIsIGxvY2FsZSkpOworICAgIHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmlu ZyhheFZhbHVlLmdldCgpKTsKIH0KIAogSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IEFjY2Vzc2li aWxpdHlVSUVsZW1lbnQ6OmhlbHBUZXh0KCkgY29uc3QK