118356 2013-07-03 06:09:49 -0700 [Curl] Download does not replace existing file. 2013-07-15 11:27:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED Curl P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue galpeter oldest_to_newest 905840 0 peavo 2013-07-03 06:09:49 -0700 If the download target file already exists, it is not replaced after the download has finished. At this point, the user would have already approved to replace the file, so it should be replaced. 905844 1 205997 peavo 2013-07-03 06:19:32 -0700 Created attachment 205997 Patch 908330 2 galpeter 2013-07-15 01:30:16 -0700 Well I'm not a reviewer but this looks good to me. I've just got one (two) question(s) if the MoveFileEx fails then the old file will be still there? and if so won't that cause problems? 908455 3 peavo 2013-07-15 10:26:56 -0700 (In reply to comment #2) > Well I'm not a reviewer but this looks good to me. > > I've just got one (two) question(s) if the MoveFileEx fails then the old file will be still there? and if so won't that cause problems? Thanks for commenting :) I think this scenario should be ok, as the old file is a temporary file in a Windows temp folder. The next download will generate a new, unique, temporary file name, to download to, and not have any references to the previous temporary file. 908461 4 205997 bfulgham 2013-07-15 10:59:57 -0700 Comment on attachment 205997 Patch r=me 908466 5 205997 commit-queue 2013-07-15 11:22:21 -0700 Comment on attachment 205997 Patch Clearing flags on attachment: 205997 Committed r152649: <http://trac.webkit.org/changeset/152649> 908467 6 commit-queue 2013-07-15 11:22:23 -0700 All reviewed patches have been landed. Closing bug. 908468 7 peavo 2013-07-15 11:27:30 -0700 (In reply to comment #4) > (From update of attachment 205997 [details]) > r=me Thanks for reviewing! 205997 2013-07-03 06:19:32 -0700 2013-07-15 11:22:21 -0700 Patch bug-118356-20130703151701.patch text/plain 1714 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjM1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTAzICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBEb3dubG9h ZCBkb2VzIG5vdCByZXBsYWNlIGV4aXN0aW5nIGZpbGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzNTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgZG93bmxvYWQgdGFyZ2V0IGZpbGUgYWxy ZWFkeSBleGlzdHMsIGl0IGlzIG5vdCByZXBsYWNlZCBhZnRlciB0aGUgZG93bmxvYWQgaGFzIGZp bmlzaGVkLgorICAgICAgICBBdCB0aGlzIHBvaW50LCB0aGUgdXNlciB3b3VsZCBoYXZlIGFscmVh ZHkgYXBwcm92ZWQgdG8gcmVwbGFjZSB0aGUgZmlsZSwgc28gaXQgc2hvdWxkIGJlIHJlcGxhY2Vk LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxEb3dubG9hZC5jcHA6Cisg ICAgICAgIChDdXJsRG93bmxvYWQ6Om1vdmVGaWxlVG9EZXN0aW5hdGlvbik6IE1vdmUgZmlsZSBh bmQgcmVwbGFjZSBpdCBpZiBpdCBhbHJlYWR5IGV4aXN0cy4KKyAgICAgICAgSWYgdGhlIG5ldyBm aWxlIGlzIG9uIGEgZGlmZmVyZW50IHZvbHVtZSwgZG8gYSBjb3B5L2RlbGV0ZSBvcGVyYXRpb24u CisKIDIwMTMtMDctMDMgIFByemVteXNsYXcgU3p5bWFuc2tpICA8cC5zenltYW5za2kzQHNhbXN1 bmcuY29tPgogCiAgICAgICAgIFRleHR1cmVVbml0IGNvZGUgb3B0aW1pemF0aW9uCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25sb2FkLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybERvd25s b2FkLmNwcAkocmV2aXNpb24gMTUyMzQwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jdXJsL0N1cmxEb3dubG9hZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5OSw3ICsyOTks NyBAQCB2b2lkIEN1cmxEb3dubG9hZDo6bW92ZUZpbGVUb0Rlc3RpbmF0aW9uCiAgICAgaWYgKG1f ZGVzdGluYXRpb24uaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICA6Ok1vdmVGaWxl KG1fdGVtcFBhdGguY2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKS5kYXRhKCksIG1fZGVz dGluYXRpb24uY2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKS5kYXRhKCkpOworICAgIDo6 TW92ZUZpbGVFeChtX3RlbXBQYXRoLmNoYXJhY3RlcnNXaXRoTnVsbFRlcm1pbmF0aW9uKCkuZGF0 YSgpLCBtX2Rlc3RpbmF0aW9uLmNoYXJhY3RlcnNXaXRoTnVsbFRlcm1pbmF0aW9uKCkuZGF0YSgp LCBNT1ZFRklMRV9DT1BZX0FMTE9XRUQgfCBNT1ZFRklMRV9SRVBMQUNFX0VYSVNUSU5HKTsKIH0K IAogdm9pZCBDdXJsRG93bmxvYWQ6OmRpZFJlY2VpdmVIZWFkZXIoY29uc3QgU3RyaW5nJiBoZWFk ZXIpCg==