118352 2013-07-03 04:19:10 -0700 [WK2][GTK] Invalid ASSERTs in WebResources loading code 2013-07-03 07:53:02 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar cgarcia commit-queue gustavo mrobinson svillar oldest_to_newest 905811 0 svillar 2013-07-03 04:19:10 -0700 The WebKitWebView keeps track of the resources being loaded in a map that is cleared each time a new load starts. As it's using the injected bundle API to track resource loads it might happen (specially when running webkit under valgrind) that we get notifications for resources that correspond to previous page loads. We need to remove those ASSERTs as they're no longer correct. 905817 1 205992 svillar 2013-07-03 04:37:58 -0700 Created attachment 205992 Patch 905818 2 commit-queue 2013-07-03 04:39:14 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 905823 3 205992 cgarcia 2013-07-03 05:00:49 -0700 Comment on attachment 205992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205992&action=review You are absolutely right, but I'm not sure about the second assert. Thanks! > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:-1632 > - ASSERT(priv->loadingResourcesMap.contains(resourceIdentifier)); I'm not sure about this one, this method is always called after webkitWebViewGetLoadingWebResource() only when we have a valid pointer. 905869 4 svillar 2013-07-03 07:53:02 -0700 Committed r152354: <http://trac.webkit.org/changeset/152354> 205992 2013-07-03 04:37:58 -0700 2013-07-03 05:00:48 -0700 Patch bug-118352-20130703133551.patch text/plain 2208 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTM5YTI5NjJjOGMzMjNl Y2JiM2M4ZmUxYWQzYTJhMzUxMzdkYTAzYS4uMzkxY2VkYzQxNGExMTk4ODVjNTllYWEzZWRkYjhk YTRkNGNkOTRjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA3LTAzICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdW0dU S10gSW52YWxpZCBBU1NFUlRzIGluIFdlYlJlc291cmNlcyBsb2FkaW5nIGNvZGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODM1MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBXZWJLaXRXZWJWaWV3 IGtlZXBzIHRyYWNrIG9mIHRoZSByZXNvdXJjZXMgYmVpbmcgbG9hZGVkIGluIGEKKyAgICAgICAg bWFwLiBBIGNvdXBsZSBvZiBBU1NFUlRzIHZlcmlmeSB0aGF0IGV2ZXJ5IGxvYWRlZCByZXNvdXJj ZSBpcworICAgICAgICBzdG9yZWQgaW4gdGhhdCBtYXAuCisKKyAgICAgICAgVGhlIG1hcCB0aGF0 IGlzIGNsZWFyZWQgZWFjaCB0aW1lIGEgbmV3IGxvYWQgc3RhcnRzIHNvIHRoZXJlIGlzIGEKKyAg ICAgICAgc21hbGwgY2hhbmNlIHRoYXQgd2UgZ2V0IG5vdGlmaWNhdGlvbnMgZm9yIHJlc291cmNl cyB0aGF0CisgICAgICAgIGNvcnJlc3BvbmQgdG8gcHJldmlvdXMgcGFnZSBsb2FkcworICAgICAg ICAoYW5kIHRodXMgYXJlIG5vdCBzdG9yZWQgaW4gdGhlIG1hcCkuIFdlIHNob3VsZCByZW1vdmUg dGhvc2UKKyAgICAgICAgQVNTRVJUcyBhcyB0aGV5IGFyZSBub3QgdmFsaWQgYW55bW9yZS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwOgorICAgICAgICAo d2Via2l0V2ViVmlld0dldExvYWRpbmdXZWJSZXNvdXJjZSk6CisgICAgICAgICh3ZWJraXRXZWJW aWV3UmVtb3ZlTG9hZGluZ1dlYlJlc291cmNlKToKKwogMjAxMy0wNy0wMSAgQWxleGV5IFByb3Nr dXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhbiB1cCBwcml2YXRlIGJyb3dz aW5nIHNlc3Npb24gdHJhY2tpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggYzVlMDYzZjlmMWM5NGQ5NDVmMTFiZmY4YTlk NGNlOTMzMWIzZDc4Ny4uNzVhN2MyNWNlNjA2YTRhYzRlNDlhZGViOTRlZDc1NjI1YmFiNmFlNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmll dy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmll dy5jcHAKQEAgLTE2MjIsMTQgKzE2MjIsMTIgQEAgdm9pZCB3ZWJraXRXZWJWaWV3UmVzb3VyY2VM b2FkU3RhcnRlZChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJGcmFtZVByb3h5KiBmcmEKIFdl YktpdFdlYlJlc291cmNlKiB3ZWJraXRXZWJWaWV3R2V0TG9hZGluZ1dlYlJlc291cmNlKFdlYktp dFdlYlZpZXcqIHdlYlZpZXcsIHVpbnQ2NF90IHJlc291cmNlSWRlbnRpZmllcikKIHsKICAgICBH UmVmUHRyPFdlYktpdFdlYlJlc291cmNlPiByZXNvdXJjZSA9IHdlYlZpZXctPnByaXYtPmxvYWRp bmdSZXNvdXJjZXNNYXAuZ2V0KHJlc291cmNlSWRlbnRpZmllcik7Ci0gICAgQVNTRVJUKHJlc291 cmNlLmdldCgpKTsKICAgICByZXR1cm4gcmVzb3VyY2UuZ2V0KCk7CiB9CiAKIHZvaWQgd2Via2l0 V2ViVmlld1JlbW92ZUxvYWRpbmdXZWJSZXNvdXJjZShXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCB1 aW50NjRfdCByZXNvdXJjZUlkZW50aWZpZXIpCiB7CiAgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUq IHByaXYgPSB3ZWJWaWV3LT5wcml2OwotICAgIEFTU0VSVChwcml2LT5sb2FkaW5nUmVzb3VyY2Vz TWFwLmNvbnRhaW5zKHJlc291cmNlSWRlbnRpZmllcikpOwogICAgIHByaXYtPmxvYWRpbmdSZXNv dXJjZXNNYXAucmVtb3ZlKHJlc291cmNlSWRlbnRpZmllcik7CiB9CiAK