118346 2013-07-03 02:38:38 -0700 [EFL] Support some more editing keyboard events 2013-07-03 23:21:22 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim cdumez commit-queue gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 905766 0 ktf.kim 2013-07-03 02:38:38 -0700 Thanks to bug 89268, editing keyboard events is supported for EFL WK2, but some more common keyboard events are needed - select all, undo, redo, copy, paste and cut. The copy, paste and cut are not work well now due to the lack of implementation on a clipboard, but it'll be implemented soon. 905769 1 205986 ktf.kim 2013-07-03 02:42:33 -0700 Created attachment 205986 Patch 905771 2 205986 cdumez 2013-07-03 02:49:37 -0700 Comment on attachment 205986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205986&action=review > Source/WebCore/ChangeLog:10 > + No new tests, no behavior change. How can there be no behavior change? 905777 3 205986 gyuyoung.kim 2013-07-03 02:58:33 -0700 Comment on attachment 205986 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205986&action=review > Source/WebCore/ChangeLog:3 > + [EFL][WK2] Support some more editing keyboard events This isn't only for WK2. Remove [WK2] prefix. > Source/WebCore/ChangeLog:10 > + No new tests, no behavior change. I wonder if there are unskip tests in editing layout test. 905783 4 ktf.kim 2013-07-03 03:06:49 -0700 (In reply to comment #2) > (From update of attachment 205986 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205986&action=review > > > Source/WebCore/ChangeLog:10 > > + No new tests, no behavior change. > > How can there be no behavior change? What I meant was no new tests needed because no behavior for LayoutTests changed. I'll remove that description because it can make confusion. > I wonder if there are unskip tests in editing layout test. OK. I'm checking now if there are newly passed tests. 905784 5 cdumez 2013-07-03 03:09:26 -0700 (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 205986 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=205986&action=review > > > > > Source/WebCore/ChangeLog:10 > > > + No new tests, no behavior change. > > > > How can there be no behavior change? > > What I meant was no new tests needed because no behavior for LayoutTests changed. > I'll remove that description because it can make confusion. I don't understand why it wouldn't affect layout tests. What is the impact then? Why do we need this change? 905790 6 ktf.kim 2013-07-03 03:18:00 -0700 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > (From update of attachment 205986 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=205986&action=review > > > > > > > Source/WebCore/ChangeLog:10 > > > > + No new tests, no behavior change. > > > > > > How can there be no behavior change? > > > > What I meant was no new tests needed because no behavior for LayoutTests changed. > > I'll remove that description because it can make confusion. > > I don't understand why it wouldn't affect layout tests. What is the impact then? Why do we need this change? With this change, you can use more shortcut keys on editable contents. You can select all the texts with "Ctrl+A", undo the change with "Ctrl+Z", redo the change with "Ctrl+Y". They're common functions for the editable contents but you couldn't use the functionality only in the EFL port because there were no shortcut. 905796 7 cdumez 2013-07-03 03:23:49 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #2) > > > > (From update of attachment 205986 [details] [details] [details] [details]) > > > > View in context: https://bugs.webkit.org/attachment.cgi?id=205986&action=review > > > > > > > > > Source/WebCore/ChangeLog:10 > > > > > + No new tests, no behavior change. > > > > > > > > How can there be no behavior change? > > > > > > What I meant was no new tests needed because no behavior for LayoutTests changed. > > > I'll remove that description because it can make confusion. > > > > I don't understand why it wouldn't affect layout tests. What is the impact then? Why do we need this change? > > With this change, you can use more shortcut keys on editable contents. > You can select all the texts with "Ctrl+A", undo the change with "Ctrl+Z", redo the change with "Ctrl+Y". > They're common functions for the editable contents but you couldn't use the functionality only in the EFL port because there were no shortcut. so it looks like it would affect layout tests. Please unskip / rebase those tests in the same patch. 906020 8 206042 ktf.kim 2013-07-03 19:02:58 -0700 Created attachment 206042 Patch 906021 9 ktf.kim 2013-07-03 19:09:10 -0700 There was 3 new passes when I executed whole tests, and 65 new passes when I executed only the 'editing' tests, but it was same without this patch. So, I think rebase is needed, but it's independent of this change. [1] 3 new passes when executing whole tests editing/selection/doubleclick-beside-cr-span.html editing/selection/doubleclick-whitespace.html editing/style/5065910.html [2] 65 new passes when executing only 1592 tests in 'editing' editing/execCommand/paste-1.html editing/inserting/before-after-input-element.html editing/pasteboard/3976872.html editing/pasteboard/4076267-2.html editing/pasteboard/4076267-3.html editing/pasteboard/4076267.html editing/pasteboard/4242293.html editing/pasteboard/4641033.html editing/pasteboard/4944770-1.html editing/pasteboard/4944770-2.html editing/pasteboard/4947130.html editing/pasteboard/4989774.html editing/pasteboard/5006779.html editing/pasteboard/5028447.html editing/pasteboard/5071074.html editing/pasteboard/5075944.html editing/pasteboard/5478250.html editing/pasteboard/5601583-1.html editing/pasteboard/cut-text-001.html editing/pasteboard/drag-drop-dead-frame.html editing/pasteboard/drag-drop-modifies-page.html editing/pasteboard/drag-image-to-contenteditable-in-iframe.html editing/pasteboard/drag-selected-image-to-contenteditable.html editing/pasteboard/drop-text-without-selection.html editing/pasteboard/emacs-ctrl-a-k-y.html editing/pasteboard/emacs-ctrl-k-y-001.html editing/pasteboard/input-field-1.html editing/pasteboard/paste-2.html editing/pasteboard/paste-4038267-fix.html editing/pasteboard/paste-line-endings-001.html editing/pasteboard/paste-line-endings-002.html editing/pasteboard/paste-line-endings-003.html editing/pasteboard/paste-line-endings-004.html editing/pasteboard/paste-line-endings-005.html editing/pasteboard/paste-line-endings-006.html editing/pasteboard/paste-line-endings-007.html editing/pasteboard/paste-line-endings-008.html editing/pasteboard/paste-line-endings-009.html editing/pasteboard/paste-line-endings-010.html editing/pasteboard/paste-match-style-001.html editing/pasteboard/paste-match-style-002.html editing/pasteboard/paste-text-004.html editing/pasteboard/paste-text-008.html editing/pasteboard/paste-text-009.html editing/pasteboard/paste-text-013.html editing/pasteboard/paste-text-014.html editing/pasteboard/paste-text-016.html editing/pasteboard/paste-text-019.html editing/pasteboard/paste-text-at-tabspan-003.html editing/pasteboard/paste-xml.xhtml editing/pasteboard/pasting-tabs.html editing/pasteboard/smart-drag-drop.html editing/pasteboard/smart-paste-007.html editing/pasteboard/smart-paste-008.html editing/pasteboard/styled-element-markup.html editing/pasteboard/subframe-dragndrop-1.html editing/pasteboard/undoable-fragment-removes.html editing/selection/contains-boundaries.html editing/selection/doubleclick-beside-cr-span.html editing/selection/doubleclick-whitespace.html editing/selection/mixed-editability-10.html editing/selection/paragraph-granularity.html editing/selection/replaced-boundaries-3.html editing/style/5065910.html editing/style/font-family-with-space.html 906026 10 206042 gyuyoung.kim 2013-07-03 19:33:15 -0700 Comment on attachment 206042 Patch Looks ok based on layout test result. 906027 11 gyuyoung.kim 2013-07-03 19:34:15 -0700 (In reply to comment #9) > There was 3 new passes when I executed whole tests, > and 65 new passes when I executed only the 'editing' tests, > but it was same without this patch. > So, I think rebase is needed, but it's independent of this change. Can you do gardening them ? 906033 12 ktf.kim 2013-07-03 20:43:29 -0700 (In reply to comment #11) > (In reply to comment #9) > > There was 3 new passes when I executed whole tests, > > and 65 new passes when I executed only the 'editing' tests, > > but it was same without this patch. > > So, I think rebase is needed, but it's independent of this change. > > Can you do gardening them ? OK. I'll do it on another bug. 906052 13 206042 commit-queue 2013-07-03 23:21:19 -0700 Comment on attachment 206042 Patch Clearing flags on attachment: 206042 Committed r152389: <http://trac.webkit.org/changeset/152389> 906053 14 commit-queue 2013-07-03 23:21:22 -0700 All reviewed patches have been landed. Closing bug. 205986 2013-07-03 02:42:33 -0700 2013-07-03 19:02:50 -0700 Patch bug-118346-20130703184026.patch text/plain 2165 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE2NzEyYTJkNGZiNmE4 M2FiNDNmYjg2MmMyNzNkYmRhYmU2Njk2ZS4uMjI1MzdhZTM1YTg2ZjQ5NDY0MWQ4N2UyMTA1YzYz MmFmMTMxNDA1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA3LTAzICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gU3Vw cG9ydCBzb21lIG1vcmUgZWRpdGluZyBrZXlib2FyZCBldmVudHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODM0NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBlZGl0YWJsZSBjb250ZW50cywgc3Vw cG9ydCB0aGUgc2hvcnRjdXRzIGZvciBjb3B5LCBwYWdlLCBjdXQsIHNlbGVjdCBhbGwsIHVuZG8g YW5kIHJlZG8uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwOgorCiAyMDEz LTA3LTAzICBSYWR1IFN0YXZpbGEgIDxzdGF2aWxhQGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NT IFJlZ2lvbnNdIEltcHJvdmUgaW1wbGVtZW50YXRpb24gb2YgZWxlbWVudHMgaW4gcmVnaW9uIGJl aW5nIGZsb3dlZCB0byBhbm90aGVyIGZsb3cgdGhyZWFkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZWZsL0VmbEtleWJvYXJkVXRpbGl0aWVzLmNwcAppbmRleCBlYWRkMTIzYmNh MjY5OGE1ZTM0YmU0MGMxZDVhYTRlZGQyMmUxNDU0Li4yODZkZTBlZGU4NDMxYjlhYmIxOTEyODQ0 ODc1NGE2ODU2YThlMTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv RWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Vm bC9FZmxLZXlib2FyZFV0aWxpdGllcy5jcHAKQEAgLTMwMSw2ICszMDEsMTUgQEAgc3RhdGljIGNv bnN0IEtleURvd25FbnRyeSBrZXlEb3duRW50cmllc1tdID0gewogICAgIHsgVktfUkVUVVJOLCBD dHJsS2V5LCAgICAgICAgICAgICJJbnNlcnROZXdsaW5lIiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB9LAogICAgIHsgVktfUkVUVVJOLCBBbHRLZXksICAgICAgICAgICAgICJJbnNlcnRO ZXdsaW5lIiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9LAogICAgIHsgVktfUkVUVVJO LCBBbHRLZXkgfCBTaGlmdEtleSwgICJJbnNlcnROZXdsaW5lIiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB9LAorCisgICAgeyAnQycsICAgICAgIEN0cmxLZXksICAgICAgICAgICAgIkNv cHkiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0sCisgICAgeyAnVics ICAgICAgIEN0cmxLZXksICAgICAgICAgICAgIlBhc3RlIiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIH0sCisgICAgeyAnWCcsICAgICAgIEN0cmxLZXksICAgICAgICAgICAg IkN1dCIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0sCisKKyAgICB7 ICdBJywgICAgICAgQ3RybEtleSwgICAgICAgICAgICAiU2VsZWN0QWxsIiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfSwKKyAgICB7ICdaJywgICAgICAgQ3RybEtleSwgICAgICAg ICAgICAiVW5kbyIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfSwKKyAg ICB7ICdaJywgICAgICAgQ3RybEtleSB8IFNoaWZ0S2V5LCAiUmVkbyIgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgfSwKKyAgICB7ICdZJywgICAgICAgQ3RybEtleSwgICAg ICAgICAgICAiUmVkbyIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfSwK IH07CiAKIHN0YXRpYyBjb25zdCBLZXlQcmVzc0VudHJ5IGtleVByZXNzRW50cmllc1tdID0gewo= 206042 2013-07-03 19:02:58 -0700 2013-07-03 23:21:18 -0700 Patch bug-118346-20130704110051.patch text/plain 2115 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE2NzEyYTJkNGZiNmE4 M2FiNDNmYjg2MmMyNzNkYmRhYmU2Njk2ZS4uMDQxZTkzM2FlODBlODlkYzU3ODE5OGM3Y2Q5YzY1 MDM1ODlkYzQ2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA3LTAzICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIFN1cHBvcnQg c29tZSBtb3JlIGVkaXRpbmcga2V5Ym9hcmQgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzNDYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3IgZWRpdGFibGUgY29udGVudHMsIHN1cHBvcnQg dGhlIHNob3J0Y3V0cyBmb3IgY29weSwgcGFnZSwgY3V0LCBzZWxlY3QgYWxsLCB1bmRvIGFuZCBy ZWRvLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL0VmbEtleWJvYXJkVXRpbGl0aWVzLmNwcDoK KwogMjAxMy0wNy0wMyAgUmFkdSBTdGF2aWxhICA8c3RhdmlsYUBhZG9iZS5jb20+CiAKICAgICAg ICAgW0NTUyBSZWdpb25zXSBJbXByb3ZlIGltcGxlbWVudGF0aW9uIG9mIGVsZW1lbnRzIGluIHJl Z2lvbiBiZWluZyBmbG93ZWQgdG8gYW5vdGhlciBmbG93IHRocmVhZApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0VmbEtleWJvYXJkVXRpbGl0aWVzLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9FZmxLZXlib2FyZFV0aWxpdGllcy5jcHAKaW5kZXggZWFk ZDEyM2JjYTI2OThhNWUzNGJlNDBjMWQ1YWE0ZWRkMjJlMTQ1NC4uMjg2ZGUwZWRlODQzMWI5YWJi MTkxMjg0NDg3NTRhNjg1NmE4ZTEyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZWZsL0VmbEtleWJvYXJkVXRpbGl0aWVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9lZmwvRWZsS2V5Ym9hcmRVdGlsaXRpZXMuY3BwCkBAIC0zMDEsNiArMzAxLDE1IEBAIHN0 YXRpYyBjb25zdCBLZXlEb3duRW50cnkga2V5RG93bkVudHJpZXNbXSA9IHsKICAgICB7IFZLX1JF VFVSTiwgQ3RybEtleSwgICAgICAgICAgICAiSW5zZXJ0TmV3bGluZSIgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfSwKICAgICB7IFZLX1JFVFVSTiwgQWx0S2V5LCAgICAgICAgICAgICAi SW5zZXJ0TmV3bGluZSIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfSwKICAgICB7IFZL X1JFVFVSTiwgQWx0S2V5IHwgU2hpZnRLZXksICAiSW5zZXJ0TmV3bGluZSIgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfSwKKworICAgIHsgJ0MnLCAgICAgICBDdHJsS2V5LCAgICAgICAg ICAgICJDb3B5IiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9LAorICAg IHsgJ1YnLCAgICAgICBDdHJsS2V5LCAgICAgICAgICAgICJQYXN0ZSIgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB9LAorICAgIHsgJ1gnLCAgICAgICBDdHJsS2V5LCAgICAg ICAgICAgICJDdXQiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9LAor CisgICAgeyAnQScsICAgICAgIEN0cmxLZXksICAgICAgICAgICAgIlNlbGVjdEFsbCIgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0sCisgICAgeyAnWicsICAgICAgIEN0cmxLZXks ICAgICAgICAgICAgIlVuZG8iICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IH0sCisgICAgeyAnWicsICAgICAgIEN0cmxLZXkgfCBTaGlmdEtleSwgIlJlZG8iICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0sCisgICAgeyAnWScsICAgICAgIEN0cmxL ZXksICAgICAgICAgICAgIlJlZG8iICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIH0sCiB9OwogCiBzdGF0aWMgY29uc3QgS2V5UHJlc3NFbnRyeSBrZXlQcmVzc0VudHJpZXNb XSA9IHsK