<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118345</bug_id>
          
          <creation_ts>2013-07-03 02:26:48 -0700</creation_ts>
          <short_desc>[GTK] webkit_set_cache_model is not turning the cache off</short_desc>
          <delta_ts>2013-07-08 22:40:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Tomas Popela">tpopela</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>gustavo</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>905760</commentid>
    <comment_count>0</comment_count>
    <who name="Tomas Popela">tpopela</who>
    <bug_when>2013-07-03 02:26:48 -0700</bug_when>
    <thetext>When using webkit_set_cache_model (WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER), WebKit should disable the cache completely. Now it is not disabled properly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>905762</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-07-03 02:29:13 -0700</bug_when>
    <thetext>Yes, this is because setting the cache capacities to 0 doesn&apos;t disable the cache, capacities are only used when pruning the cache, but when adding new resources only whether the cache is enabled is checked.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>905765</commentid>
    <comment_count>2</comment_count>
      <attachid>205984</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-07-03 02:37:59 -0700</bug_when>
    <thetext>Created attachment 205984
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>905822</commentid>
    <comment_count>3</comment_count>
      <attachid>205984</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2013-07-03 05:00:35 -0700</bug_when>
    <thetext>Comment on attachment 205984
Patch

Great!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>906999</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2013-07-08 22:40:21 -0700</bug_when>
    <thetext>Committed r152483: &lt;http://trac.webkit.org/changeset/152483&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>205984</attachid>
            <date>2013-07-03 02:37:59 -0700</date>
            <delta_ts>2013-07-08 06:23:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk1-disable-memory-cache.diff</filename>
            <type>text/plain</type>
            <size>1771</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv
Z3RrL0NoYW5nZUxvZwppbmRleCA3MmUyYzQyLi40ZTdlMzM3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMjAgQEAKKzIwMTMtMDctMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp
YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIHdlYmtpdF9zZXRfY2FjaGVfbW9kZWwgaXMg
bm90IHR1cm5pbmcgdGhlIGNhY2hlIG9mZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgT3VyIGRvY3VtZW50YXRpb24gc2F5cyB0aGF0IFdFQktJVF9DQUNI
RV9NT0RFTF9ET0NVTUVOVF9WSUVXRVIKKyAgICAgICAgZGlzYWJsZXMgdGhlIGNhY2hlIGNvbXBs
ZXRlbHksIGJ1dCB3ZSBhcmUgb25seSBzZXR0aW5nIHRoZSBjYWNoZQorICAgICAgICBjYXBhY2l0
aWVzIHRvIDAuIENhY2hlIGNhcGFjaXRpZXMgYXJlIG5vdCBjaGVja2VkIHdoZW4gcmVzb3VyY2Vz
CisgICAgICAgIGFyZSBhZGRlZCB0byB0aGUgY2FjaGUsIGJ1dCB3aGVuIGl0J3MgcHJ1bmVkLiBU
byBkaXNhYmxlIHRoZSBjYWNoZQorICAgICAgICB3ZSBuZWVkIHRvIGNhbGwgTWVtb3J5Q2FjaGU6
OnNldERpc2FibGVkIGV4cGxpY2l0bHkuCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0Z2xvYmFs
cy5jcHA6CisgICAgICAgICh3ZWJraXRfc2V0X2NhY2hlX21vZGVsKTogRGlzYWJsZSB0aGUgY2Fj
aGUgd2hlbiBtaW4gZGVhZCwgbWF4CisgICAgICAgIGRlYWQgYW5kIHRvdGFsIGNhcGFjaXRpZXMg
YXJlIGFsbCBzZXQgdG8gMC4KKwogMjAxMy0wNy0wMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8
Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVtb3ZlIHVu
c3VwcG9ydGVkIEFDIGJhY2tlbmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr
aXQvd2Via2l0Z2xvYmFscy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0Z2xv
YmFscy5jcHAKaW5kZXggMTdiMWQwZi4uYzljNjdkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp
dC9ndGsvd2Via2l0L3dlYmtpdGdsb2JhbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dl
YmtpdC93ZWJraXRnbG9iYWxzLmNwcApAQCAtMTU2LDYgKzE1Niw4IEBAIHZvaWQgd2Via2l0X3Nl
dF9jYWNoZV9tb2RlbChXZWJLaXRDYWNoZU1vZGVsIG1vZGVsKQogICAgICAgICBnX3JldHVybl9p
Zl9yZWFjaGVkKCk7CiAgICAgfQogCisgICAgYm9vbCBkaXNhYmxlQ2FjaGUgPSAhY2FjaGVNaW5E
ZWFkQ2FwYWNpdHkgJiYgIWNhY2hlTWF4RGVhZENhcGFjaXR5ICYmICFjYWNoZVRvdGFsQ2FwYWNp
dHk7CisgICAgbWVtb3J5Q2FjaGUoKS0+c2V0RGlzYWJsZWQoZGlzYWJsZUNhY2hlKTsKICAgICBt
ZW1vcnlDYWNoZSgpLT5zZXRDYXBhY2l0aWVzKGNhY2hlTWluRGVhZENhcGFjaXR5LCBjYWNoZU1h
eERlYWRDYXBhY2l0eSwgY2FjaGVUb3RhbENhcGFjaXR5KTsKICAgICBtZW1vcnlDYWNoZSgpLT5z
ZXREZWFkRGVjb2RlZERhdGFEZWxldGlvbkludGVydmFsKGRlYWREZWNvZGVkRGF0YURlbGV0aW9u
SW50ZXJ2YWwpOwogICAgIHBhZ2VDYWNoZSgpLT5zZXRDYXBhY2l0eShwYWdlQ2FjaGVDYXBhY2l0
eSk7Cg==
</data>
<flag name="review"
          id="227635"
          type_id="1"
          status="+"
          setter="gustavo"
    />
          </attachment>
      

    </bug>

</bugzilla>