118325 2013-07-02 14:39:43 -0700 EGL and GLES files need to be included in Windows build 2013-07-02 17:19:24 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Minor --- 0 achristensen webkit-unassigned bfulgham commit-queue oldest_to_newest 905578 0 achristensen 2013-07-02 14:39:43 -0700 Windows builds of WebGL need EGL symbols from GLContextEGL.cpp. Also, GraphicsContext3DOpenGL.cpp should be removed in favor of GraphicsContext3DOpenGLES.cpp to use with ANGLE's GLES implementation. 905580 1 205944 achristensen 2013-07-02 14:42:26 -0700 Created attachment 205944 Patch 905632 2 205944 bfulgham 2013-07-02 16:56:32 -0700 Comment on attachment 205944 Patch I was going to ask if we needed to exclude the GLContextEGL.cpp file for now, but I see that it is protected by an USE(EGL) guard in the cpp file. r=me. 905642 3 205944 commit-queue 2013-07-02 17:19:22 -0700 Comment on attachment 205944 Patch Clearing flags on attachment: 205944 Committed r152329: <http://trac.webkit.org/changeset/152329> 905643 4 commit-queue 2013-07-02 17:19:24 -0700 All reviewed patches have been landed. Closing bug. 205944 2013-07-02 14:42:26 -0700 2013-07-02 17:19:22 -0700 Patch bug-118325-20130702144023.patch text/plain 5654 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjMyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA3LTAyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQGFwcGxlLmNvbT4KKworICAgICAgICBQcmVwYXJpbmcg V2luZG93cyBXZWJHTCBidWlsZCBzeXN0ZW0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmUudmN4cHJvai9XZWJDb3JlLnZjeHByb2o6IEFk ZGVkIEVHTCBmaWxlcywgcmVtb3ZlZCB1bnVzZWQgR3JhcGhpY3NDb250ZXh0M0RPcGVuR0wuY3Bw LgorICAgICAgICAqIFdlYkNvcmUudmN4cHJvai9XZWJDb3JlLnZjeHByb2ouZmlsdGVyczogQWRk ZWQgRUdMIGZpbHRlciBhbmQgZmlsZXMsIHJlbW92ZWQgdW51c2VkIEdyYXBoaWNzQ29udGV4dDNE T3BlbkdMLmNwcC4KKwogMjAxMy0wNy0wMiAgUmFkdSBTdGF2aWxhICA8c3RhdmlsYUBhZG9iZS5j b20+CiAKICAgICAgICAgW0NTUyBSZWdpb25zXSBJbXByb3ZlIGltcGxlbWVudGF0aW9uIG9mIGVs ZW1lbnRzIGluIHJlZ2lvbiBiZWluZyBmbG93ZWQgdG8gYW5vdGhlciBmbG93IHRocmVhZApJbmRl eDogU291cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3hwcm9qL1dlYkNvcmUudmN4cHJvago9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnZjeHByb2ovV2ViQ29yZS52Y3hwcm9qCShy ZXZpc2lvbiAxNTIyNzIpCisrKyBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnZjeHByb2ovV2ViQ29y ZS52Y3hwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC00MzczLDYgKzQzNzMsNyBAQAogICAgICAgPEV4 Y2x1ZGVkRnJvbUJ1aWxkIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSkn PT0nUmVsZWFzZV9XaW5DYWlyb3xXaW4zMiciPnRydWU8L0V4Y2x1ZGVkRnJvbUJ1aWxkPgogICAg ICAgPEV4Y2x1ZGVkRnJvbUJ1aWxkIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0 Zm9ybSknPT0nRGVidWdfV2luQ2Fpcm98V2luMzInIj50cnVlPC9FeGNsdWRlZEZyb21CdWlsZD4K ICAgICA8L0NsQ29tcGlsZT4KKyAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXHBsYXRmb3JtXGdy YXBoaWNzXGVnbFxHTENvbnRleHRFR0wuY3BwIiAvPgogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0i Li5ccGxhdGZvcm1cZ3JhcGhpY3NcZ3B1XERyYXdpbmdCdWZmZXIuY3BwIiAvPgogICAgIDxDbENv bXBpbGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3JhcGhpY3NcZ3B1XExvb3BCbGlubkNsYXNzaWZp ZXIuY3BwIiAvPgogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3JhcGhpY3Nc Z3B1XExvb3BCbGlubkxvY2FsVHJpYW5ndWxhdG9yLmNwcCIgLz4KQEAgLTQzOTIsMTYgKzQzOTMs OCBAQAogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3JhcGhpY3Ncb3Blbmds XEV4dGVuc2lvbnMzRE9wZW5HTEVTLmNwcCIgLz4KICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4u XHBsYXRmb3JtXGdyYXBoaWNzXG9wZW5nbFxHTFBsYXRmb3JtQ29udGV4dC5jcHAiIC8+CiAgICAg PENsQ29tcGlsZSBJbmNsdWRlPSIuLlxwbGF0Zm9ybVxncmFwaGljc1xvcGVuZ2xcR0xQbGF0Zm9y bVN1cmZhY2UuY3BwIiAvPgotICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3Jh cGhpY3Ncb3BlbmdsXEdyYXBoaWNzQ29udGV4dDNET3BlbkdMLmNwcCI+Ci0gICAgICA8RXhjbHVk ZWRGcm9tQnVpbGQgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdS ZWxlYXNlfFdpbjMyJyI+dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+Ci0gICAgICA8RXhjbHVkZWRG cm9tQnVpbGQgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdEZWJ1 Z3xXaW4zMiciPnRydWU8L0V4Y2x1ZGVkRnJvbUJ1aWxkPgotICAgICAgPEV4Y2x1ZGVkRnJvbUJ1 aWxkIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nUHJvZHVjdGlv bnxXaW4zMiciPnRydWU8L0V4Y2x1ZGVkRnJvbUJ1aWxkPgotICAgIDwvQ2xDb21waWxlPgogICAg IDxDbENvbXBpbGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3JhcGhpY3Ncb3BlbmdsXEdyYXBoaWNz Q29udGV4dDNET3BlbkdMQ29tbW9uLmNwcCIgLz4KLSAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4u XHBsYXRmb3JtXGdyYXBoaWNzXG9wZW5nbFxHcmFwaGljc0NvbnRleHQzRE9wZW5HTEVTLmNwcCI+ Ci0gICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwk KFBsYXRmb3JtKSc9PSdEZWJ1Z19XaW5DYWlyb3xXaW4zMiciPnRydWU8L0V4Y2x1ZGVkRnJvbUJ1 aWxkPgotICAgICAgPEV4Y2x1ZGVkRnJvbUJ1aWxkIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlv bil8JChQbGF0Zm9ybSknPT0nUmVsZWFzZV9XaW5DYWlyb3xXaW4zMiciPnRydWU8L0V4Y2x1ZGVk RnJvbUJ1aWxkPgotICAgIDwvQ2xDb21waWxlPgorICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5c cGxhdGZvcm1cZ3JhcGhpY3Ncb3BlbmdsXEdyYXBoaWNzQ29udGV4dDNET3BlbkdMRVMuY3BwIiAv PgogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cSGlzdG9ncmFtU3VwcG9ydC5j cHAiIC8+CiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxwbGF0Zm9ybVxLaWxsUmluZ05vbmUu Y3BwIiAvPgogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cS1VSTC5jcHAiIC8+ CkBAIC0xMTg4Niw2ICsxMTg3OSw3IEBACiAgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQgQ29uZGl0 aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNlX1dpbkNhaXJvfFdp bjMyJyI+dHJ1ZTwvRXhjbHVkZWRGcm9tQnVpbGQ+CiAgICAgICA8RXhjbHVkZWRGcm9tQnVpbGQg Q29uZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdEZWJ1Z19XaW5DYWly b3xXaW4zMiciPnRydWU8L0V4Y2x1ZGVkRnJvbUJ1aWxkPgogICAgIDwvQ2xJbmNsdWRlPgorICAg IDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3JhcGhpY3NcZWdsXEdMQ29udGV4dEVH TC5oIiAvPgogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3JhcGhpY3NcZ3B1 XERyYXdpbmdCdWZmZXIuaCIgLz4KICAgICA8Q2xJbmNsdWRlIEluY2x1ZGU9Ii4uXHBsYXRmb3Jt XGdyYXBoaWNzXGdwdVxMb29wQmxpbm5DbGFzc2lmaWVyLmgiIC8+CiAgICAgPENsSW5jbHVkZSBJ bmNsdWRlPSIuLlxwbGF0Zm9ybVxncmFwaGljc1xncHVcTG9vcEJsaW5uQ29uc3RhbnRzLmgiIC8+ CkBAIC0xMzkzMSw0ICsxMzkyNSw0IEBACiAgIDxJbXBvcnQgUHJvamVjdD0iJChWQ1RhcmdldHNQ YXRoKVxNaWNyb3NvZnQuQ3BwLnRhcmdldHMiIC8+CiAgIDxJbXBvcnRHcm91cCBMYWJlbD0iRXh0 ZW5zaW9uVGFyZ2V0cyI+CiAgIDwvSW1wb3J0R3JvdXA+Ci08L1Byb2plY3Q+Cis8L1Byb2plY3Q+ ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpJbmRleDogU291cmNlL1dlYkNvcmUvV2ViQ29y ZS52Y3hwcm9qL1dlYkNvcmUudmN4cHJvai5maWx0ZXJzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL1dlYkNvcmUudmN4cHJvai9XZWJDb3JlLnZjeHByb2ouZmlsdGVycwkocmV2aXNpb24g MTUyMjcyKQorKysgU291cmNlL1dlYkNvcmUvV2ViQ29yZS52Y3hwcm9qL1dlYkNvcmUudmN4cHJv ai5maWx0ZXJzCSh3b3JraW5nIGNvcHkpCkBAIC0yODksNiArMjg5LDkgQEAKICAgICA8RmlsdGVy IEluY2x1ZGU9InBsYXRmb3JtXGdyYXBoaWNzXGdwdSI+CiAgICAgICA8VW5pcXVlSWRlbnRpZmll cj57YzIzMzJmZjktNDM2ZS00YzA3LWI2OTItZmI0YjlkYjQwZmZkfTwvVW5pcXVlSWRlbnRpZmll cj4KICAgICA8L0ZpbHRlcj4KKyAgICA8RmlsdGVyIEluY2x1ZGU9InBsYXRmb3JtXGdyYXBoaWNz XGVnbCI+CisgICAgICA8VW5pcXVlSWRlbnRpZmllcj57ZTI3YjM0OGQtMGI4Ny00ZTVmLWI1Yjkt Yjk5ZTI4M2VhMjJifTwvVW5pcXVlSWRlbnRpZmllcj4KKyAgICA8L0ZpbHRlcj4KICAgPC9JdGVt R3JvdXA+CiAgIDxJdGVtR3JvdXA+CiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxEZXJpdmVk U291cmNlcy5jcHAiPgpAQCAtNzAzNiw5ICs3MDM5LDYgQEAKICAgICA8Q2xDb21waWxlIEluY2x1 ZGU9Ii4uXHBhZ2VcQ2FwdGlvblVzZXJQcmVmZXJlbmNlc01lZGlhQUYuY3BwIj4KICAgICAgIDxG aWx0ZXI+cGFnZTwvRmlsdGVyPgogICAgIDwvQ2xDb21waWxlPgotICAgIDxDbENvbXBpbGUgSW5j bHVkZT0iLi5ccGxhdGZvcm1cZ3JhcGhpY3Ncb3BlbmdsXEdyYXBoaWNzQ29udGV4dDNET3BlbkdM LmNwcCI+Ci0gICAgICA8RmlsdGVyPnBsYXRmb3JtXGdyYXBoaWNzXG9wZW5nbDwvRmlsdGVyPgot ICAgIDwvQ2xDb21waWxlPgogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3Jh cGhpY3NcY2dcR3JhcGhpY3NDb250ZXh0M0RDRy5jcHAiPgogICAgICAgPEZpbHRlcj5wbGF0Zm9y bVxncmFwaGljc1xjZzwvRmlsdGVyPgogICAgIDwvQ2xDb21waWxlPgpAQCAtNzA2MCw2ICs3MDYw LDkgQEAKICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXHBsYXRmb3JtXGdyYXBoaWNzXG9wZW5n bFxHcmFwaGljc0NvbnRleHQzRE9wZW5HTEVTLmNwcCI+CiAgICAgICA8RmlsdGVyPnBsYXRmb3Jt XGdyYXBoaWNzXG9wZW5nbDwvRmlsdGVyPgogICAgIDwvQ2xDb21waWxlPgorICAgIDxDbENvbXBp bGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3JhcGhpY3NcZWdsXEdMQ29udGV4dEVHTC5jcHAiPgor ICAgICAgPEZpbHRlcj5wbGF0Zm9ybVxncmFwaGljc1xlZ2w8L0ZpbHRlcj4KKyAgICA8L0NsQ29t cGlsZT4KICAgPC9JdGVtR3JvdXA+CiAgIDxJdGVtR3JvdXA+CiAgICAgPENsSW5jbHVkZSBJbmNs dWRlPSIuLlxNb2R1bGVzXGZpbGVzeXN0ZW1cQXN5bmNGaWxlV3JpdGVyLmgiPgpAQCAtMTQ3Njgs NiArMTQ3NzEsOSBAQAogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5ccGxhdGZvcm1cZ3JhcGhp Y3NcY2Fpcm9cR0xDb250ZXh0LmgiPgogICAgICAgPEZpbHRlcj5wbGF0Zm9ybVxncmFwaGljc1xj YWlybzwvRmlsdGVyPgogICAgIDwvQ2xJbmNsdWRlPgorICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0i Li5ccGxhdGZvcm1cZ3JhcGhpY3NcZWdsXEdMQ29udGV4dEVHTC5oIj4KKyAgICAgIDxGaWx0ZXI+ cGxhdGZvcm1cZ3JhcGhpY3NcZWdsPC9GaWx0ZXI+CisgICAgPC9DbEluY2x1ZGU+CiAgIDwvSXRl bUdyb3VwPgogICA8SXRlbUdyb3VwPgogICAgIDxOb25lIEluY2x1ZGU9Ii4uXGNzc1xDU1NHcmFt bWFyLnkuaW4iPgo=