118322 2013-07-02 13:36:05 -0700 TrailingObjects shouldn't shrink vector capacity in a loop 2013-07-25 17:35:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren commit-queue esprehn+autocc glenn rniwa oldest_to_newest 905566 0 ggaren 2013-07-02 13:36:05 -0700 TrailingObjects shouldn't shrink vector capacity in a loop 905575 1 205943 ggaren 2013-07-02 14:09:33 -0700 Created attachment 205943 Patch 905600 2 205943 darin 2013-07-02 15:30:14 -0700 Comment on attachment 205943 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205943&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:2742 > - m_boxes.clear(); > + m_boxes.shrink(0); Why comment? It’s unclear that clear must not call clear. 905618 3 205953 ggaren 2013-07-02 15:57:00 -0700 Created attachment 205953 Patch 905619 4 ggaren 2013-07-02 15:58:11 -0700 Added a why comment to the ChangeLog and the code. 905621 5 205955 ggaren 2013-07-02 15:58:25 -0700 Created attachment 205955 Patch 910232 6 205955 ggaren 2013-07-19 10:41:44 -0700 Comment on attachment 205955 Patch Clearing flags on attachment: 205955 Committed r152905: <http://trac.webkit.org/changeset/152905> 910233 7 ggaren 2013-07-19 10:41:46 -0700 All reviewed patches have been landed. Closing bug. 911824 8 rniwa 2013-07-25 17:34:30 -0700 *** Bug 118891 has been marked as a duplicate of this bug. *** 911825 9 rniwa 2013-07-25 17:35:03 -0700 <rdar://problem/14489987> 205943 2013-07-02 14:09:33 -0700 2013-07-02 15:56:58 -0700 Patch bug-118322-20130702140728.patch text/plain 1265 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjMxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA3LTAyICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgVHJhaWxpbmdPYmplY3RzIHNo b3VsZG4ndCBzaHJpbmsgdmVjdG9yIGNhcGFjaXR5IGluIGEgbG9vcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MzIyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzZWVtcyB0byB0YWtlIGFib3V0 IDMlIG9mZiB0aGUgcHJvZmlsZSBvZiBsb2FkaW5nIGEgbGFyZ2UgdGV4dCBmaWxlLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpUcmFpbGluZ09iamVjdHM6OmNsZWFyKToKKwogMjAxMy0wNy0wMiAgRXJpYyBDYXJsc29u ICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSAud2Via2l0Q2xvc2Vk Q2FwdGlvbnNWaXNpYmxlIGRvZXNuJ3Qgd29yayB3aXRoICJBdXRvbWF0aWMiIGNhcHRpb24gbW9k ZQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGlu ZUxheW91dC5jcHAJKHJldmlzaW9uIDE1MjMxNikKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNzM5LDcgKzI3 MzksNyBAQCBpbmxpbmUgdm9pZCBUcmFpbGluZ09iamVjdHM6OnNldFRyYWlsaW5nCiBpbmxpbmUg dm9pZCBUcmFpbGluZ09iamVjdHM6OmNsZWFyKCkKIHsKICAgICBtX3doaXRlc3BhY2UgPSAwOwot ICAgIG1fYm94ZXMuY2xlYXIoKTsKKyAgICBtX2JveGVzLnNocmluaygwKTsKIH0KIAogaW5saW5l IHZvaWQgVHJhaWxpbmdPYmplY3RzOjphcHBlbmRCb3hJZk5lZWRlZChSZW5kZXJCb3hNb2RlbE9i amVjdCogYm94KQo= 205953 2013-07-02 15:57:00 -0700 2013-07-02 15:58:23 -0700 Patch bug-118322-20130702155455.patch text/plain 1426 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjMxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTAyICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgVHJhaWxpbmdPYmplY3RzIHNo b3VsZG4ndCBzaHJpbmsgdmVjdG9yIGNhcGFjaXR5IGluIGEgbG9vcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MzIyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzZWVtcyB0byB0YWtlIGFib3V0 IDMlIG9mZiB0aGUgcHJvZmlsZSBvZiBsb2FkaW5nIGEgbGFyZ2UgdGV4dCBmaWxlLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpUcmFpbGluZ09iamVjdHM6OmNsZWFyKTogY2xlYXIoKSBoYXMgdGhlIGJ1aWx0LWluIHNp ZGUgZWZmZWN0CisgICAgICAgIG9mIHRocm93aW5nIGF3YXkgZXhpc3RpbmcgY2FwYWNpdHkuIFVz ZSBzaHJpbmsoMCkgdG8gaW5kaWNhdGUgdGhhdCB3ZQorICAgICAgICB3YW50IHRvIGtlZXAgb3Vy IGV4aXN0aW5nIGNhcGFjaXR5LgorCiAyMDEzLTA3LTAyICBFcmljIENhcmxzb24gIDxlcmljLmNh cmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIC53ZWJraXRDbG9zZWRDYXB0aW9uc1Zp c2libGUgZG9lc24ndCB3b3JrIHdpdGggIkF1dG9tYXRpYyIgY2FwdGlvbiBtb2RlCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNw cAkocmV2aXNpb24gMTUyMzE2KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrTGluZUxheW91dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3MzksNyArMjczOSw3IEBAIGlu bGluZSB2b2lkIFRyYWlsaW5nT2JqZWN0czo6c2V0VHJhaWxpbmcKIGlubGluZSB2b2lkIFRyYWls aW5nT2JqZWN0czo6Y2xlYXIoKQogewogICAgIG1fd2hpdGVzcGFjZSA9IDA7Ci0gICAgbV9ib3hl cy5jbGVhcigpOworICAgIG1fYm94ZXMuc2hyaW5rKDApOwogfQogCiBpbmxpbmUgdm9pZCBUcmFp bGluZ09iamVjdHM6OmFwcGVuZEJveElmTmVlZGVkKFJlbmRlckJveE1vZGVsT2JqZWN0KiBib3gp Cg== 205955 2013-07-02 15:58:25 -0700 2013-07-19 10:41:43 -0700 Patch bug-118322-20130702155620.patch text/plain 1486 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjMxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA3LTAyICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgVHJhaWxpbmdPYmplY3RzIHNo b3VsZG4ndCBzaHJpbmsgdmVjdG9yIGNhcGFjaXR5IGluIGEgbG9vcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MzIyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBzZWVtcyB0byB0YWtlIGFib3V0 IDMlIG9mZiB0aGUgcHJvZmlsZSBvZiBsb2FkaW5nIGEgbGFyZ2UgdGV4dCBmaWxlLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpUcmFpbGluZ09iamVjdHM6OmNsZWFyKTogY2xlYXIoKSBoYXMgdGhlIGJ1aWx0LWluIHNp ZGUgZWZmZWN0CisgICAgICAgIG9mIHRocm93aW5nIGF3YXkgZXhpc3RpbmcgY2FwYWNpdHkuIFVz ZSBzaHJpbmsoMCkgdG8gaW5kaWNhdGUgdGhhdCB3ZQorICAgICAgICB3YW50IHRvIGtlZXAgb3Vy IGV4aXN0aW5nIGNhcGFjaXR5LgorCiAyMDEzLTA3LTAyICBFcmljIENhcmxzb24gIDxlcmljLmNh cmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIC53ZWJraXRDbG9zZWRDYXB0aW9uc1Zp c2libGUgZG9lc24ndCB3b3JrIHdpdGggIkF1dG9tYXRpYyIgY2FwdGlvbiBtb2RlCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNw cAkocmV2aXNpb24gMTUyMzE2KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrTGluZUxheW91dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3MzksNyArMjczOSw3IEBAIGlu bGluZSB2b2lkIFRyYWlsaW5nT2JqZWN0czo6c2V0VHJhaWxpbmcKIGlubGluZSB2b2lkIFRyYWls aW5nT2JqZWN0czo6Y2xlYXIoKQogewogICAgIG1fd2hpdGVzcGFjZSA9IDA7Ci0gICAgbV9ib3hl cy5jbGVhcigpOworICAgIG1fYm94ZXMuc2hyaW5rKDApOyAvLyBVc2Ugc2hyaW5rKDApIGluc3Rl YWQgb2YgY2xlYXIoKSB0byByZXRhaW4gb3VyIGNhcGFjaXR5LgogfQogCiBpbmxpbmUgdm9pZCBU cmFpbGluZ09iamVjdHM6OmFwcGVuZEJveElmTmVlZGVkKFJlbmRlckJveE1vZGVsT2JqZWN0KiBi b3gpCg==