118316 2013-07-02 12:06:19 -0700 Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex 2013-07-02 12:48:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg oldest_to_newest 905523 0 mhahnenberg 2013-07-02 12:06:19 -0700 This is causing some crashiness in release builds. We should replace it with an ASSERT until we track down all the places that need fixing in bug 118315. 905526 1 mhahnenberg 2013-07-02 12:10:11 -0700 <rdar://problem/14165332> 905533 2 205935 mhahnenberg 2013-07-02 12:13:43 -0700 Created attachment 205935 Patch 905536 3 205935 ggaren 2013-07-02 12:15:44 -0700 Comment on attachment 205935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205935&action=review > Source/JavaScriptCore/bytecode/CodeBlock.h:228 > + ASSERT(index < m_rareData->m_callReturnIndexVector.size()); > + if (index < m_rareData->m_callReturnIndexVector.size()) I think you have this backwards? 905542 4 mhahnenberg 2013-07-02 12:21:40 -0700 (In reply to comment #3) > (From update of attachment 205935 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205935&action=review > > > Source/JavaScriptCore/bytecode/CodeBlock.h:228 > > + ASSERT(index < m_rareData->m_callReturnIndexVector.size()); > > + if (index < m_rareData->m_callReturnIndexVector.size()) > > I think you have this backwards? :-( 905543 5 205936 mhahnenberg 2013-07-02 12:23:23 -0700 Created attachment 205936 Patch 905545 6 205936 ggaren 2013-07-02 12:30:56 -0700 Comment on attachment 205936 Patch r=me! 905551 7 mhahnenberg 2013-07-02 12:48:43 -0700 Committed r152314: <http://trac.webkit.org/changeset/152314> 205935 2013-07-02 12:13:43 -0700 2013-07-02 12:23:22 -0700 Patch bug-118316-20130702121358.patch text/plain 1772 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyMzA1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA3LTAyICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgUmVwbGFjZSBSRUxFQVNFX0FTU0VSVCB3aXRoIEFTU0VSVCBpbiBDb2RlQmxvY2s6 OiBieXRlY29kZU9mZnNldEZvckNhbGxBdEluZGV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGNhdXNpbmcgc29tZSBjcmFzaGluZXNzIGlu IHJlbGVhc2UgYnVpbGRzLiBXZSBzaG91bGQgcmVwbGFjZSBpdCB3aXRoIGFuIEFTU0VSVCAKKyAg ICAgICAgdW50aWwgd2UgdHJhY2sgZG93biBhbGwgdGhlIHBsYWNlcyB0aGF0IG5lZWQgZml4aW5n IGluIGJ1ZyAxMTgzMTUuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suaDoKKyAgICAg ICAgKEpTQzo6Q29kZUJsb2NrOjpieXRlY29kZU9mZnNldEZvckNhbGxBdEluZGV4KToKKwogMjAx My0wNy0wMiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBb V2luZG93c10gVW5yZXZpZXdlZCBidWlsZCBjb3JyZWN0aW9uIGZvciAnRGVidWdTdWZmaXgnIHRh cmdldC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgJ KHJldmlzaW9uIDE1MjMwNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAtMjIzLDcgKzIyMywxMCBAQCBwdWJsaWM6CiAgICAg ICAgIFZlY3RvcjxDYWxsUmV0dXJuT2Zmc2V0VG9CeXRlY29kZU9mZnNldCwgMCwgVW5zYWZlVmVj dG9yT3ZlcmZsb3c+JiBjYWxsSW5kaWNlcyA9IG1fcmFyZURhdGEtPm1fY2FsbFJldHVybkluZGV4 VmVjdG9yOwogICAgICAgICBpZiAoIWNhbGxJbmRpY2VzLnNpemUoKSkKICAgICAgICAgICAgIHJl dHVybiAxOwotICAgICAgICBSRUxFQVNFX0FTU0VSVChpbmRleCA8IG1fcmFyZURhdGEtPm1fY2Fs bFJldHVybkluZGV4VmVjdG9yLnNpemUoKSk7CisgICAgICAgIC8vIEZJWE1FOiBGaXggcGxhY2Vz IGluIERGRyB0aGF0IGNhbGwgb3V0IHRvIEMgdGhhdCBkb24ndCBzZXQgdGhlIENvZGVPcmlnaW4u IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzMTUgCisgICAgICAg IEFTU0VSVChpbmRleCA8IG1fcmFyZURhdGEtPm1fY2FsbFJldHVybkluZGV4VmVjdG9yLnNpemUo KSk7CisgICAgICAgIGlmIChpbmRleCA8IG1fcmFyZURhdGEtPm1fY2FsbFJldHVybkluZGV4VmVj dG9yLnNpemUoKSkKKyAgICAgICAgICAgIHJldHVybiAxOwogICAgICAgICByZXR1cm4gbV9yYXJl RGF0YS0+bV9jYWxsUmV0dXJuSW5kZXhWZWN0b3JbaW5kZXhdLmJ5dGVjb2RlT2Zmc2V0OwogICAg IH0KIAo= 205936 2013-07-02 12:23:23 -0700 2013-07-02 12:30:56 -0700 Patch bug-118316-20130702122338.patch text/plain 1773 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyMzA1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA3LTAyICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgUmVwbGFjZSBSRUxFQVNFX0FTU0VSVCB3aXRoIEFTU0VSVCBpbiBDb2RlQmxvY2s6 OiBieXRlY29kZU9mZnNldEZvckNhbGxBdEluZGV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGNhdXNpbmcgc29tZSBjcmFzaGluZXNzIGlu IHJlbGVhc2UgYnVpbGRzLiBXZSBzaG91bGQgcmVwbGFjZSBpdCB3aXRoIGFuIEFTU0VSVCAKKyAg ICAgICAgdW50aWwgd2UgdHJhY2sgZG93biBhbGwgdGhlIHBsYWNlcyB0aGF0IG5lZWQgZml4aW5n IGluIGJ1ZyAxMTgzMTUuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suaDoKKyAgICAg ICAgKEpTQzo6Q29kZUJsb2NrOjpieXRlY29kZU9mZnNldEZvckNhbGxBdEluZGV4KToKKwogMjAx My0wNy0wMiAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBb V2luZG93c10gVW5yZXZpZXdlZCBidWlsZCBjb3JyZWN0aW9uIGZvciAnRGVidWdTdWZmaXgnIHRh cmdldC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgJ KHJldmlzaW9uIDE1MjMwNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAtMjIzLDcgKzIyMywxMCBAQCBwdWJsaWM6CiAgICAg ICAgIFZlY3RvcjxDYWxsUmV0dXJuT2Zmc2V0VG9CeXRlY29kZU9mZnNldCwgMCwgVW5zYWZlVmVj dG9yT3ZlcmZsb3c+JiBjYWxsSW5kaWNlcyA9IG1fcmFyZURhdGEtPm1fY2FsbFJldHVybkluZGV4 VmVjdG9yOwogICAgICAgICBpZiAoIWNhbGxJbmRpY2VzLnNpemUoKSkKICAgICAgICAgICAgIHJl dHVybiAxOwotICAgICAgICBSRUxFQVNFX0FTU0VSVChpbmRleCA8IG1fcmFyZURhdGEtPm1fY2Fs bFJldHVybkluZGV4VmVjdG9yLnNpemUoKSk7CisgICAgICAgIC8vIEZJWE1FOiBGaXggcGxhY2Vz IGluIERGRyB0aGF0IGNhbGwgb3V0IHRvIEMgdGhhdCBkb24ndCBzZXQgdGhlIENvZGVPcmlnaW4u IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgzMTUgCisgICAgICAg IEFTU0VSVChpbmRleCA8IG1fcmFyZURhdGEtPm1fY2FsbFJldHVybkluZGV4VmVjdG9yLnNpemUo KSk7CisgICAgICAgIGlmIChpbmRleCA+PSBtX3JhcmVEYXRhLT5tX2NhbGxSZXR1cm5JbmRleFZl Y3Rvci5zaXplKCkpCisgICAgICAgICAgICByZXR1cm4gMTsKICAgICAgICAgcmV0dXJuIG1fcmFy ZURhdGEtPm1fY2FsbFJldHVybkluZGV4VmVjdG9yW2luZGV4XS5ieXRlY29kZU9mZnNldDsKICAg ICB9CiAK