118312 2013-07-02 11:36:37 -0700 OpenGLShims doesn't have getProcAddress for Windows 2013-07-02 22:20:07 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P4 Minor --- 0 achristensen webkit-unassigned commit-queue rniwa oldest_to_newest 905510 0 achristensen 2013-07-02 11:36:37 -0700 OpenGLShims.cpp has a getProcAddress function used for filling a function table with function pointers to OpenGL functions. This function is implemented for Qt and it assumes everything else uses unix commands like dlsym. I added a Windows implementation that uses the WinAPI to do the same thing. I stepped through it in the debugger, and this succeeds in filling the function table with valid function pointers when linking with ANGLE libraries (of which libGLESv2 is one). 905511 1 205931 achristensen 2013-07-02 11:38:15 -0700 Created attachment 205931 Patch 905576 2 205931 bfulgham 2013-07-02 14:22:54 -0700 Comment on attachment 205931 Patch r=me 905595 3 205931 commit-queue 2013-07-02 15:19:21 -0700 Comment on attachment 205931 Patch Clearing flags on attachment: 205931 Committed r152325: <http://trac.webkit.org/changeset/152325> 905596 4 commit-queue 2013-07-02 15:19:23 -0700 All reviewed patches have been landed. Closing bug. 905691 5 rniwa 2013-07-02 22:20:07 -0700 It seems like this patch broke Windows builds: http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/49992 http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/68153 205931 2013-07-02 11:38:15 -0700 2013-07-02 15:19:20 -0700 Patch bug-118312-20130702113610.patch text/plain 1370 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjMwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA3LTAyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQGFwcGxlLmNvbT4KKworICAgICAgICBBZGRlZCBnZXRQ cm9jQWRkcmVzcyBpbXBsZW1lbnRhdGlvbiBmb3IgV2luZG93cyBpbiBPcGVuR0xTaGltcy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODMxMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvT3BlbkdMU2hpbXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0UHJvY0FkZHJl c3MpOiBBZGRlZCBmb3IgV2luZG93cy4KKwogMjAxMy0wNy0wMiAgVGltIEhvcnRvbiAgPHRpbW90 aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBjb25zdHJhaW5TY3JvbGxQb3NpdGlvbkZv ck92ZXJoYW5nIG5lZWRzIHRvIGhhbmRsZSBzY3JvbGxPcmlnaW4gY29ycmVjdGx5CkluZGV4OiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9PcGVuR0xTaGltcy5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMU2hpbXMuY3BwCShy ZXZpc2lvbiAxNTIwNjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9PcGVu R0xTaGltcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDExIEBAIHN0YXRpYyB2b2lk KiBnZXRQcm9jQWRkcmVzcyhjb25zdCBjaGFyKiAKIHsKICAgICByZXR1cm4gcmVpbnRlcnByZXRf Y2FzdDx2b2lkKj4oUU9wZW5HTENvbnRleHQ6OmN1cnJlbnRDb250ZXh0KCktPmdldFByb2NBZGRy ZXNzKHByb2NOYW1lKSk7CiB9CisjZWxpZiBQTEFURk9STShXSU4pCitzdGF0aWMgdm9pZCogZ2V0 UHJvY0FkZHJlc3MoY29uc3QgY2hhciogcHJvY05hbWUpCit7CisgICAgcmV0dXJuIEdldFByb2NB ZGRyZXNzKEdldE1vZHVsZUhhbmRsZUEoImxpYkdMRVN2MiIpLCBwcm9jTmFtZSk7Cit9CiAjZWxz ZQogdHlwZWRlZiB2b2lkKiAoKmdsR2V0UHJvY0FkZHJlc3NUeXBlKSAoY29uc3QgY2hhciogcHJv Y05hbWUpOwogc3RhdGljIHZvaWQqIGdldFByb2NBZGRyZXNzKGNvbnN0IGNoYXIqIHByb2NOYW1l KQo=