<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>118310</bug_id>
          
          <creation_ts>2013-07-02 10:36:41 -0700</creation_ts>
          <short_desc>Missing  allow-none introspection annotation for DomDocument.evaluate method</short_desc>
          <delta_ts>2013-09-14 12:20:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Niranjan Rao">nhrdls</reporter>
          <assigned_to name="Alberto Garcia">berto</assigned_to>
          <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>905485</commentid>
    <comment_count>0</comment_count>
    <who name="Niranjan Rao">nhrdls</who>
    <bug_when>2013-07-02 10:36:41 -0700</bug_when>
    <thetext>For the method webkit_dom_document_evaluate, parameter WebKitDOMXPathResult can be null. However this is not reflected in languages which use introspection and hence can not pass null value.

Tried on Ubuntu 12.04 and 13.04 Desktop.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>929246</commentid>
    <comment_count>1</comment_count>
      <attachid>211653</attachid>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2013-09-14 10:03:48 -0700</bug_when>
    <thetext>Created attachment 211653
Patch

This should be as simple as this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>929275</commentid>
    <comment_count>2</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2013-09-14 12:20:06 -0700</bug_when>
    <thetext>Committed r155778: &lt;http://trac.webkit.org/changeset/155778&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>211653</attachid>
            <date>2013-09-14 10:03:48 -0700</date>
            <delta_ts>2013-09-14 12:15:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>118310.diff</filename>
            <type>text/plain</type>
            <size>1618</size>
            <attacher name="Alberto Garcia">berto</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBlNDhjODA3Li4wOTNlMWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg
QEAKIDIwMTMtMDktMTQgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KIAorICAg
ICAgICBNaXNzaW5nICBhbGxvdy1ub25lIGludHJvc3BlY3Rpb24gYW5ub3RhdGlvbiBmb3IgRG9t
RG9jdW1lbnQuZXZhbHVhdGUgbWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMTgzMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBBZGQgKGFsbG93LW5vbmUpIGludHJvc3BlY3Rpb24gYW5ub3RhdGlv
biB0byBwYXJhbWV0ZXJzIHRoYXQgY2FuCisgICAgICAgIGJlIE5VTEwuCisKKyAgICAgICAgKiBi
aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtOgorICAgICAgICAoR2VuZXJh
dGVGdW5jdGlvbik6CisKKzIwMTMtMDktMTQgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlh
LmNvbT4KKwogICAgICAgICBbR1RLXSBXZWJLaXRHVEsrIGlzIGxpbmtpbmcgYWdhaW5zdCBsaWJ4
c2x0IGluIHRvbyBtYW55IHBsYWNlcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MTIxMzU2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp
bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5k
aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCmluZGV4IDIyOGYwZjMuLjQ3M2Vi
YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy
YXRvckdPYmplY3QucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl
R2VuZXJhdG9yR09iamVjdC5wbQpAQCAtOTM5LDcgKzkzOSwxMSBAQCBzdWIgR2VuZXJhdGVGdW5j
dGlvbiB7CiAgICAgICAgICMgJHBhcmFtVHlwZSBjYW4gaGF2ZSBhIHRyYWlsaW5nICogaW4gc29t
ZSBjYXNlcwogICAgICAgICAkcGFyYW1UeXBlID1+IHMvXCokLy87CiAgICAgICAgIG15ICRwYXJh
bU5hbWUgPSAkcGFyYW0tPm5hbWU7Ci0gICAgICAgIHB1c2goQGhCb2R5LCAiICogXEAke3BhcmFt
TmFtZX06IEEgIyR7cGFyYW1UeXBlfVxuIik7CisgICAgICAgIG15ICRwYXJhbUFubm90YXRpb25z
ID0gIiI7CisgICAgICAgIGlmIChQYXJhbUNhbkJlTnVsbCgkZnVuY3Rpb25OYW1lLCAkcGFyYW1O
YW1lKSkgeworICAgICAgICAgICAgJHBhcmFtQW5ub3RhdGlvbnMgPSAiIChhbGxvdy1ub25lKToi
OworICAgICAgICB9CisgICAgICAgIHB1c2goQGhCb2R5LCAiICogXEAke3BhcmFtTmFtZX06JHtw
YXJhbUFubm90YXRpb25zfSBBICMke3BhcmFtVHlwZX1cbiIpOwogICAgIH0KICAgICBwdXNoKEBo
Qm9keSwgIiAqIFxAZXJyb3I6ICNHRXJyb3JcbiIpIGlmICRyYWlzZXNFeGNlcHRpb247CiAgICAg
cHVzaChAaEJvZHksICIgKlxuIik7Cg==
</data>
<flag name="review"
          id="233772"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>