118299 2013-07-02 05:54:19 -0700 Modernize QualifiedName by wrapping gNameCache in a function and using more early exits 2013-07-14 18:30:26 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa benjamin commit-queue esprehn+autocc ggaren kangil.han kling koivisto oldest_to_newest 905373 0 rniwa 2013-07-02 05:54:19 -0700 It seems like QualifiedName.cpp hasn’t been updated in a while. Do some cleanups to match the modern coding style in WebKit. 905377 1 205898 rniwa 2013-07-02 05:58:12 -0700 Created attachment 205898 Cleanup 905690 2 rniwa 2013-07-02 22:08:52 -0700 Landed as https://trac.webkit.org/r152337. 905702 3 205898 benjamin 2013-07-02 23:20:32 -0700 Comment on attachment 205898 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=205898&action=review Man, you have a hard time vacationing :-D > Source/WebCore/dom/QualifiedName.cpp:124 > + result.append(prefix()); > + result.append(':'); > + result.append(localName()); > + return result.toString(); return prefix() + ':' + localName(); would be better here. 908275 4 rniwa 2013-07-14 17:45:08 -0700 Committed r152618: <http://trac.webkit.org/changeset/152618> 908279 5 rniwa 2013-07-14 18:30:26 -0700 Fixed Qt builds: http://trac.webkit.org/changeset/152621 http://trac.webkit.org/changeset/152622 205898 2013-07-02 05:58:12 -0700 2013-07-02 23:20:32 -0700 Cleanup bug-118299-20130702215607.patch text/plain 3509 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjI4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA3LTAyICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIE1vZGVybml6ZSBRdWFsaWZpZWRO YW1lIGJ5IHdyYXBwaW5nIGdOYW1lQ2FjaGUgaW4gYSBmdW5jdGlvbiBhbmQgdXNpbmcgbW9yZSBl YXJseSBleGl0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTE4Mjk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRGlkIGNsZWFudXBzLgorCisgICAgICAgICogZG9tL1F1YWxpZmllZE5hbWUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6cXVhbGlmaWVkTmFtZUNhY2hlKTogQWRkZWQgdG8gd3JhcCBnTmFtZUNh Y2hlLgorICAgICAgICAoV2ViQ29yZTo6UXVhbGlmaWVkTmFtZTo6UXVhbGlmaWVkTmFtZSk6Cisg ICAgICAgIChXZWJDb3JlOjpRdWFsaWZpZWROYW1lOjpRdWFsaWZpZWROYW1lSW1wbDo6flF1YWxp ZmllZE5hbWVJbXBsKToKKyAgICAgICAgKFdlYkNvcmU6OlF1YWxpZmllZE5hbWU6OnRvU3RyaW5n KTogVXNlIGVhcmx5IGV4aXQgYW5kIFN0cmluZ0J1aWxkZXIuCisgICAgICAgIChXZWJDb3JlOjpR dWFsaWZpZWROYW1lOjppbml0KTogVXNlIGVhcmx5IGV4aXQuCisKIDIwMTMtMDctMDIgIFJ5b3N1 a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5leHBvc2UgRWRpdGluZ1By b3BlcnRpZXNUb0luY2x1ZGUgaW4gRWRpdGluZ1N0eWxlLmggYWZ0ZXIgcjE1MTc3MgpJbmRleDog U291cmNlL1dlYkNvcmUvZG9tL1F1YWxpZmllZE5hbWUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2RvbS9RdWFsaWZpZWROYW1lLmNwcAkocmV2aXNpb24gMTUyMjc0KQorKysgU291 cmNlL1dlYkNvcmUvZG9tL1F1YWxpZmllZE5hbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMyw2 ICszMyw3IEBACiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvSGFz aFNldC5oPgogI2luY2x1ZGUgPHd0Zi9TdGF0aWNDb25zdHJ1Y3RvcnMuaD4KKyNpbmNsdWRlIDx3 dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+CiAKICNpZiBFTkFCTEUoTUFUSE1MKQogI2luY2x1ZGUg Ik1hdGhNTE5hbWVzLmgiCkBAIC03NiwxNCArNzcsMTYgQEAgc3RydWN0IFFOYW1lQ29tcG9uZW50 c1RyYW5zbGF0b3IgewogICAgIH0KIH07CiAKLXN0YXRpYyBRTmFtZVNldCogZ05hbWVDYWNoZTsK K3N0YXRpYyBpbmxpbmUgUU5hbWVTZXQmIHF1YWxpZmllZE5hbWVDYWNoZSgpCit7CisgICAgREVG SU5FX1NUQVRJQ19MT0NBTChRTmFtZVNldCwgbmFtZUNhY2hlLCAoKSk7CisgICAgcmV0dXJuIG5h bWVDYWNoZTsKK30KIAogUXVhbGlmaWVkTmFtZTo6UXVhbGlmaWVkTmFtZShjb25zdCBBdG9taWNT dHJpbmcmIHAsIGNvbnN0IEF0b21pY1N0cmluZyYgbCwgY29uc3QgQXRvbWljU3RyaW5nJiBuKQog ewotICAgIGlmICghZ05hbWVDYWNoZSkKLSAgICAgICAgZ05hbWVDYWNoZSA9IG5ldyBRTmFtZVNl dDsKICAgICBRdWFsaWZpZWROYW1lQ29tcG9uZW50cyBjb21wb25lbnRzID0geyBwLmltcGwoKSwg bC5pbXBsKCksIG4uaXNFbXB0eSgpID8gbnVsbEF0b20uaW1wbCgpIDogbi5pbXBsKCkgfTsKLSAg ICBRTmFtZVNldDo6QWRkUmVzdWx0IGFkZFJlc3VsdCA9IGdOYW1lQ2FjaGUtPmFkZDxRTmFtZUNv bXBvbmVudHNUcmFuc2xhdG9yPihjb21wb25lbnRzKTsKKyAgICBRTmFtZVNldDo6QWRkUmVzdWx0 IGFkZFJlc3VsdCA9IHF1YWxpZmllZE5hbWVDYWNoZSgpLmFkZDxRTmFtZUNvbXBvbmVudHNUcmFu c2xhdG9yPihjb21wb25lbnRzKTsKICAgICBtX2ltcGwgPSAqYWRkUmVzdWx0Lml0ZXJhdG9yOwog ICAgIGlmICghYWRkUmVzdWx0LmlzTmV3RW50cnkpCiAgICAgICAgIG1faW1wbC0+cmVmKCk7CkBA IC0xMDYsMTkgKzEwOSwxOSBAQCB2b2lkIFF1YWxpZmllZE5hbWU6OmRlcmVmKCkKIAogUXVhbGlm aWVkTmFtZTo6UXVhbGlmaWVkTmFtZUltcGw6On5RdWFsaWZpZWROYW1lSW1wbCgpCiB7Ci0gICAg Z05hbWVDYWNoZS0+cmVtb3ZlKHRoaXMpOworICAgIHF1YWxpZmllZE5hbWVDYWNoZSgpLnJlbW92 ZSh0aGlzKTsKIH0KIAogU3RyaW5nIFF1YWxpZmllZE5hbWU6OnRvU3RyaW5nKCkgY29uc3QKIHsK LSAgICBTdHJpbmcgbG9jYWwgPSBsb2NhbE5hbWUoKTsKLSAgICBpZiAoaGFzUHJlZml4KCkpIHsK LSAgICAgICAgU3RyaW5nIHJlc3VsdCA9IHByZWZpeCgpLnN0cmluZygpOwotICAgICAgICByZXN1 bHQuYXBwZW5kKCI6Iik7Ci0gICAgICAgIHJlc3VsdC5hcHBlbmQobG9jYWwpOwotICAgICAgICBy ZXR1cm4gcmVzdWx0OwotICAgIH0KLSAgICByZXR1cm4gbG9jYWw7CisgICAgaWYgKCFoYXNQcmVm aXgoKSkKKyAgICAgICAgcmV0dXJuIGxvY2FsTmFtZSgpOworCisgICAgU3RyaW5nQnVpbGRlciBy ZXN1bHQ7CisgICAgcmVzdWx0LmFwcGVuZChwcmVmaXgoKSk7CisgICAgcmVzdWx0LmFwcGVuZCgn OicpOworICAgIHJlc3VsdC5hcHBlbmQobG9jYWxOYW1lKCkpOworICAgIHJldHVybiByZXN1bHQu dG9TdHJpbmcoKTsKIH0KIAogLy8gR2xvYmFsIGluaXQgcm91dGluZXMKQEAgLTEyNiwxNCArMTI5 LDE0IEBAIERFRklORV9HTE9CQUwoUXVhbGlmaWVkTmFtZSwgYW55TmFtZSwgbnUKIAogdm9pZCBR dWFsaWZpZWROYW1lOjppbml0KCkKIHsKLSAgICBzdGF0aWMgYm9vbCBpbml0aWFsaXplZDsKLSAg ICBpZiAoIWluaXRpYWxpemVkKSB7Ci0gICAgICAgIC8vIFVzZSBwbGFjZW1lbnQgbmV3IHRvIGlu aXRpYWxpemUgdGhlIGdsb2JhbHMuCi0gICAgICAgIAotICAgICAgICBBdG9taWNTdHJpbmc6Omlu aXQoKTsKLSAgICAgICAgbmV3IChOb3ROdWxsLCAodm9pZCopJmFueU5hbWUpIFF1YWxpZmllZE5h bWUobnVsbEF0b20sIHN0YXJBdG9tLCBzdGFyQXRvbSk7Ci0gICAgICAgIGluaXRpYWxpemVkID0g dHJ1ZTsKLSAgICB9CisgICAgc3RhdGljIGJvb2wgaW5pdGlhbGl6ZWQgPSBmYWxzZTsKKyAgICBp ZiAoaW5pdGlhbGl6ZWQpCisgICAgICAgIHJldHVybjsKKworICAgIC8vIFVzZSBwbGFjZW1lbnQg bmV3IHRvIGluaXRpYWxpemUgdGhlIGdsb2JhbHMuCisgICAgQXRvbWljU3RyaW5nOjppbml0KCk7 CisgICAgbmV3IChOb3ROdWxsLCAodm9pZCopJmFueU5hbWUpIFF1YWxpZmllZE5hbWUobnVsbEF0 b20sIHN0YXJBdG9tLCBzdGFyQXRvbSk7CisgICAgaW5pdGlhbGl6ZWQgPSB0cnVlOwogfQogCiBj b25zdCBRdWFsaWZpZWROYW1lJiBudWxsUU5hbWUoKQo=