118293 2013-07-02 05:04:56 -0700 [webkitpy] Add run-tests-touched-by-attachment command 2014-12-03 03:53:21 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 118294 117831 1 ossy webkit-unassigned commit-queue dpranke glenn jbadics ossy oldest_to_newest 905346 0 ossy 2013-07-02 05:04:56 -0700 We need a new run-tests-touched-by-attachment command for webkit-patch. It should download the given attachment from bugzilla, apply the patch, build with the patch, determine which tests or expected files are touched by the attachment on any platform, run only these tests. It will be necessary for the rebaseline helper tools. See https://bugs.webkit.org/show_bug.cgi?id=117831 for details. 905402 1 205907 jbadics 2013-07-02 06:47:15 -0700 Created attachment 205907 WIP patch The tool can be run by 'Tools/Scripts/webkit-patch run-tests-touched-by-attachment [ATTACHMENT_ID]' At the current state, the tool gets the paths of modified expected txt/png files. Then it determines the filename without the '-expected' suffix and the file extension. _test_relative_dir() determines the relative generic directory path for the given test, e.g. LayoutTests/platform/qt-5.0-wk1/editing/deleting/delete-cell-contents-expected.txt -> editing/deleting/ Then _tests_in_dir gets the paths of all the tests found in this directory. As a last step, the loop in _first_generic_by_filename() gets the first match to the given file name. I know it's a bit ineffective, but we have to look up the extension for the given test file name, since a lot of extensions are supported for test files (htm, html, xhtml, etc.). Further modifications are also needed, especially the ones recommended by Ryosuke Niwa at https://bugs.webkit.org/show_bug.cgi?id=117831 1052117 2 ossy 2014-12-03 03:53:10 -0800 no interest in it anymore 205907 2013-07-02 06:47:15 -0700 2014-12-03 03:53:21 -0800 WIP patch ews_ossyjav.patch text/plain 6359 jbadics ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9h ZC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZC5weQpp bmRleCA4NWY1NzY5Li45MTdkZGM4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL2Rvd25sb2FkLnB5CkBAIC0yNjgsNiArMjY4LDI1IEBAIGNsYXNzIEJ1aWxk QXR0YWNobWVudChBYnN0cmFjdFBhdGNoU2VxdWVuY2luZ0NvbW1hbmQsIFByb2Nlc3NBdHRhY2ht ZW50c01peGluKToKICAgICBdCiAKIAorY2xhc3MgUnVuVGVzdHNUb3VjaGVkQnlBdHRhY2htZW50 KEFic3RyYWN0UGF0Y2hTZXF1ZW5jaW5nQ29tbWFuZCwgUHJvY2Vzc0F0dGFjaG1lbnRzTWl4aW4p OgorICAgIG5hbWUgPSAicnVuLXRlc3RzLXRvdWNoZWQtYnktYXR0YWNobWVudCIKKyAgICBoZWxw X3RleHQgPSAiUnVuIG9ubHkgdGVzdHMgdG91Y2hlZCBieSB0aGUgZ2l2ZW4gYXR0YWNobWVudCIK KyAgICBhcmd1bWVudF9uYW1lcyA9ICJBVFRBQ0hNRU5UX0lEIFtBVFRBQ0hNRU5UX0lEU10iCisg ICAgbWFpbl9zdGVwcyA9IFsKKyAgICAgICAgc3RlcHMuRGlzY2FyZExvY2FsQ2hhbmdlcywKKyAg ICAgICAgc3RlcHMuVXBkYXRlLAorICAgICAgICBzdGVwcy5CdWlsZCwKKyAgICAgICAgc3RlcHMu QXBwbHlQYXRjaCwKKyAgICAgICAgc3RlcHMuUmViYXNlZFRlc3RzLAorICAgICAgICBzdGVwcy5S dW5UZXN0cywKKyAgICBdCisKKyAgICBkZWYgX3ByZXBhcmVfc3RhdGUoc2VsZiwgb3B0aW9ucywg YXJncywgdG9vbCk6CisgICAgICAgIG9wdGlvbnMudGVzdCA9IFRydWUKKyAgICAgICAgb3B0aW9u cy5idWlsZCA9IFRydWUKKworCisKIGNsYXNzIEJ1aWxkQW5kVGVzdEF0dGFjaG1lbnQoQWJzdHJh Y3RQYXRjaFNlcXVlbmNpbmdDb21tYW5kLCBQcm9jZXNzQXR0YWNobWVudHNNaXhpbik6CiAgICAg bmFtZSA9ICJidWlsZC1hbmQtdGVzdC1hdHRhY2htZW50IgogICAgIGhlbHBfdGV4dCA9ICJBcHBs eSwgYnVpbGQsIGFuZCB0ZXN0IHBhdGNoZXMgZnJvbSBidWd6aWxsYSIKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9fX2luaXRfXy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9zdGVwcy9fX2luaXRfXy5weQppbmRleCA2NTVmN2Q1Li44YTgxZWY1 IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvX19pbml0X18u cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL19faW5pdF9fLnB5CkBA IC02MiwzICs2Miw0IEBAIGZyb20gd2Via2l0cHkudG9vbC5zdGVwcy51cGRhdGUgaW1wb3J0IFVw ZGF0ZQogZnJvbSB3ZWJraXRweS50b29sLnN0ZXBzLnVwZGF0ZWNoYW5nZWxvZ3N3aXRocmV2aWV3 ZXIgaW1wb3J0IFVwZGF0ZUNoYW5nZUxvZ3NXaXRoUmV2aWV3ZXIKIGZyb20gd2Via2l0cHkudG9v bC5zdGVwcy52YWxpZGF0ZWNoYW5nZWxvZ3MgaW1wb3J0IFZhbGlkYXRlQ2hhbmdlTG9ncwogZnJv bSB3ZWJraXRweS50b29sLnN0ZXBzLnZhbGlkYXRlcmV2aWV3ZXIgaW1wb3J0IFZhbGlkYXRlUmV2 aWV3ZXIKK2Zyb20gd2Via2l0cHkudG9vbC5zdGVwcy5yZWJhc2VkX3Rlc3RzIGltcG9ydCBSZWJh c2VkVGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9y ZWJhc2VkX3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3JlYmFz ZWRfdGVzdHMucHkKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYzI2YmNjNgot LS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9yZWJh c2VkX3Rlc3RzLnB5CkBAIC0wLDAgKzEsOTUgQEAKKyMgQ29weXJpZ2h0IChDKSAyMDEzIEphbm9z IEJhZGljcyAoamJhZGljc0BpbmYudS1zemVnZWQuaHUpLAorIyBVbml2ZXJzaXR5IG9mIFN6ZWdl ZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUK KyMgbWV0OgorIworIyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCBy ZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRp b25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisjICAgICAqIFJlZGlzdHJpYnV0aW9u cyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUKKyMgY29weXJpZ2h0IG5v dGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1l cgorIyBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVk IHdpdGggdGhlCisjIGRpc3RyaWJ1dGlvbi4KKyMgICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBH b29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cworIyBjb250cmlidXRvcnMgbWF5IGJlIHVz ZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorIyB0aGlzIHNv ZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorIworIyBU SElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09O VFJJQlVUT1JTCisjICJBUyBJUyIgQU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElF UywgSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJ RVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVS UE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorIyBP V05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwg SU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFH RVMgKElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJT VElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyMgREFUQSwgT1IgUFJPRklU UzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisj IFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJ VFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lO RyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYg QURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKK2ltcG9ydCBsb2dn aW5nCitpbXBvcnQgcmUKK2ltcG9ydCBvcworCitmcm9tIHdlYmtpdHB5LnRvb2wuc3RlcHMuYWJz dHJhY3RzdGVwIGltcG9ydCBBYnN0cmFjdFN0ZXAKK2Zyb20gd2Via2l0cHkudG9vbC5zdGVwcy5v cHRpb25zIGltcG9ydCBPcHRpb25zCisKK2Zyb20gd2Via2l0cHkucG9ydCBpbXBvcnQgUG9ydAor ZnJvbSB3ZWJraXRweS5jb21tb24uaG9zdCBpbXBvcnQgSG9zdAorZnJvbSB3ZWJraXRweS5sYXlv dXRfdGVzdHMuY29udHJvbGxlcnMubGF5b3V0X3Rlc3RfZmluZGVyIGltcG9ydCBMYXlvdXRUZXN0 RmluZGVyCitmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5jb250cm9sbGVycy5sYXlvdXRfdGVz dF9ydW5uZXIgaW1wb3J0IExheW91dFRlc3RSdW5uZXIKK2Zyb20gd2Via2l0cHkudG9vbC5tb2Nr dG9vbCBpbXBvcnQgTW9ja09wdGlvbnMKK2Zyb20gd2Via2l0cHkucG9ydC5mYWN0b3J5IGltcG9y dCBQb3J0RmFjdG9yeQorCisKK19sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykKKwor CitjbGFzcyBSZWJhc2VkVGVzdHMoQWJzdHJhY3RTdGVwKToKKyAgICBAY2xhc3NtZXRob2QKKyAg ICBkZWYgb3B0aW9ucyhjbHMpOgorICAgICAgICByZXR1cm4gQWJzdHJhY3RTdGVwLm9wdGlvbnMo KSArIFsKKyAgICAgICAgICAgIE9wdGlvbnMubm9uX2ludGVyYWN0aXZlLAorICAgICAgICBdCisK KyAgICBkZWYgX3Rlc3RfbmFtZV9zdHViKHNlbGYsIGV4cGVjdGVkKToKKyAgICAgICAgZXhwbmFt ZSA9IG9zLnBhdGguc3BsaXRleHQob3MucGF0aC5iYXNlbmFtZShleHBlY3RlZCkpWzBdCisgICAg ICAgIHJldHVybiBleHBuYW1lWzotbGVuKCctZXhwZWN0ZWQnKV0KKworICAgIGRlZiBfdGVzdF9y ZWxhdGl2ZV9kaXIoc2VsZiwgZGlyKToKKyAgICAgICAgYWJzZGlyID0gb3MucGF0aC5kaXJuYW1l KGRpcikKKyAgICAgICAgbWF0Y2ggPSByZS5tYXRjaChvcy5wYXRoLmpvaW4oJ0xheW91dFRlc3Rz JywgJ3BsYXRmb3JtJywgJyguKz8pJywgJyguKiknKSwgYWJzZGlyKQorICAgICAgICBpZiBtYXRj aDoKKyAgICAgICAgICAgIHJldHVybiBtYXRjaC5ncm91cHMoKVsxXQorICAgICAgICBlbHNlOgor ICAgICAgICAgICAgcmV0dXJuIGFic2RpcgorCisgICAgZGVmIF90ZXN0c19pbl9kaXIoc2VsZiwg cG9ydCwgcmVsZGlyKToKKyAgICAgICAgcmV0dXJuIHBvcnQudGVzdHMoW3NlbGYuX3Rlc3RfcmVs YXRpdmVfZGlyKHJlbGRpcildKQorCisgICAgZGVmIF9maXJzdF9nZW5lcmljX2J5X2ZpbGVuYW1l KHNlbGYsIHBvcnQsIGZpbGVuYW1lKToKKyAgICAgICAgcGF0aHMgPSBzZWxmLl90ZXN0c19pbl9k aXIocG9ydCwgZmlsZW5hbWUpCisgICAgICAgIGZpbGVzdHViID0gc2VsZi5fdGVzdF9uYW1lX3N0 dWIoZmlsZW5hbWUpCisgICAgICAgIHJldCA9IE5vbmUKKyAgICAgICAgZm9yIHBhdGggaW4gcGF0 aHM6CisgICAgICAgICAgICBoaXQgPSByZS5tYXRjaCgnLionICsgZmlsZXN0dWIgKyAnXC4uKics IHBhdGgpCisgICAgICAgICAgICBpZiBoaXQ6CisgICAgICAgICAgICAgICAgcmV0ID0gaGl0Lmdy b3VwKDApCisgICAgICAgICAgICAgICAgYnJlYWsKKyAgICAgICAgcmV0dXJuIHJldAorCisgICAg ZGVmIHJ1bihzZWxmLCBzdGF0ZSk6CisgICAgICAgIF9sb2cuaW5mbygiUHJvY2Vzc2luZyBwYXRj aCAlcyBmcm9tIGJ1ZyAlcy4iICUgKHN0YXRlWyJwYXRjaCJdLmlkKCksIHN0YXRlWyJwYXRjaCJd LmJ1Z19pZCgpKSkKKworICAgICAgICBob3N0ID0gSG9zdCgpCisgICAgICAgIGhvc3QuaW5pdGlh bGl6ZV9zY20oKQorICAgICAgICBmYWN0b3J5ID0gUG9ydEZhY3RvcnkoaG9zdCkKKyAgICAgICAg cG9ydCA9IGZhY3RvcnkuZ2V0KCkKKyAgICAgICAgZ2VuZXJpY19wYXRocyA9IFtdCisKKyAgICAg ICAgZm9yIGZpbGVuYW1lIGluIHNlbGYuX2NoYW5nZWRfZmlsZXMoc3RhdGUpOgorICAgICAgICAg ICAgaGl0cyA9IHJlLm1hdGNoKHInKCguKi1leHBlY3RlZFwuKSh0eHR8cG5nKSknLCBmaWxlbmFt ZSkKKyAgICAgICAgICAgIGlmIGhpdHM6CisgICAgICAgICAgICAgICAgZ2VuZXJpY19yZWxwYXRo ID0gc2VsZi5fZmlyc3RfZ2VuZXJpY19ieV9maWxlbmFtZShwb3J0LCBmaWxlbmFtZSkKKyAgICAg ICAgICAgICAgICBnZW5lcmljX3BhdGhzLmFwcGVuZChnZW5lcmljX3JlbHBhdGgpCisgICAgICAg IHN0YXRlWyJ0ZXN0bGlzdCJdID0gZ2VuZXJpY19wYXRocwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3J1bnRlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS90b29sL3N0ZXBzL3J1bnRlc3RzLnB5CmluZGV4IGE0NTYyOGIuLmQ5YjFiNGQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9ydW50ZXN0cy5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcnVudGVzdHMucHkKQEAgLTEwOSw2 ICsxMDksOCBAQCBjbGFzcyBSdW5UZXN0cyhBYnN0cmFjdFN0ZXApOgogCiAgICAgICAgIGlmIHNl bGYuX29wdGlvbnMucXVpZXQ6CiAgICAgICAgICAgICBhcmdzLmFwcGVuZCgiLS1xdWlldCIpCisg ICAgICAgIGlmICJ0ZXN0bGlzdCIgaW4gc3RhdGUgYW5kIHN0YXRlWyJ0ZXN0bGlzdCJdOgorICAg ICAgICAgICAgYXJncy5leHRlbmQoc3RhdGVbInRlc3RsaXN0Il0pCiAKICAgICAgICAgc2VsZi5f dG9vbC5leGVjdXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWlsKGFyZ3MsIGN3ZD1zZWxmLl90b29s LnNjbSgpLmNoZWNrb3V0X3Jvb3QpCiAgICAgICAgIAo=