118290 2013-07-02 04:12:52 -0700 Avoid code duplication inside String::append() 2013-07-02 06:36:51 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov andersca benjamin cmarcelo commit-queue kling oldest_to_newest 905320 0 mikhail.pozdnyakov 2013-07-02 04:12:52 -0700 SSIA. The implementation of 'append(UChar)' is repeated inside 'append(LChar)', this duplication can be obviated. 905321 1 205888 mikhail.pozdnyakov 2013-07-02 04:15:49 -0700 Created attachment 205888 patch 905325 2 205889 mikhail.pozdnyakov 2013-07-02 04:20:35 -0700 Created attachment 205889 patch Added change log. 905395 3 205889 commit-queue 2013-07-02 06:36:49 -0700 Comment on attachment 205889 patch Clearing flags on attachment: 205889 Committed r152289: <http://trac.webkit.org/changeset/152289> 905396 4 commit-queue 2013-07-02 06:36:51 -0700 All reviewed patches have been landed. Closing bug. 205888 2013-07-02 04:15:49 -0700 2013-07-02 04:20:35 -0700 patch bug118290 text/plain 2191 mikhail.pozdnyakov Y29tbWl0IDY2ZDAzZWYwMjQ2NTY0ZDZlNDM2YTYwMzk4NWYyNWM2MTExYzk0NzcKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VHVlIEp1bCAyIDE0OjEyOjAwIDIwMTMgKzAzMDAKCiAgICBidWcxMTgyOTAKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0 L1dURlN0cmluZy5jcHAKaW5kZXggN2M2ZTUzNS4uMjljMTNjMSAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvdGV4dC9XVEZTdHJpbmcuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RG U3RyaW5nLmNwcApAQCAtMTE5LDcgKzExOSw4IEBAIHZvaWQgU3RyaW5nOjphcHBlbmQoY29uc3Qg U3RyaW5nJiBzdHIpCiAgICAgfQogfQogCi12b2lkIFN0cmluZzo6YXBwZW5kKExDaGFyIGMpCit0 ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4KK2lubGluZSB2b2lkIFN0cmluZzo6YXBw ZW5kSW50ZXJuYWwoQ2hhcmFjdGVyVHlwZSBjKQogewogICAgIC8vIEZJWE1FOiBUaGlzIGlzIGV4 dHJlbWVseSBpbmVmZmljaWVudC4gU28gbXVjaCBzbyB0aGF0IHdlIG1pZ2h0IHdhbnQgdG8gdGFr ZSB0aGlzCiAgICAgLy8gb3V0IG9mIFN0cmluZydzIEFQSS4gV2UgY2FuIG1ha2UgaXQgYmV0dGVy IGJ5IG9wdGltaXppbmcgdGhlIGNhc2Ugd2hlcmUgZXhhY3RseQpAQCAtMTM3LDIyICsxMzgsMTQg QEAgdm9pZCBTdHJpbmc6OmFwcGVuZChMQ2hhciBjKQogICAgICAgICBtX2ltcGwgPSBTdHJpbmdJ bXBsOjpjcmVhdGUoJmMsIDEpOwogfQogCit2b2lkIFN0cmluZzo6YXBwZW5kKExDaGFyIGMpCit7 CisgICAgYXBwZW5kSW50ZXJuYWwoYyk7Cit9CisKIHZvaWQgU3RyaW5nOjphcHBlbmQoVUNoYXIg YykKIHsKLSAgICAvLyBGSVhNRTogVGhpcyBpcyBleHRyZW1lbHkgaW5lZmZpY2llbnQuIFNvIG11 Y2ggc28gdGhhdCB3ZSBtaWdodCB3YW50IHRvIHRha2UgdGhpcwotICAgIC8vIG91dCBvZiBTdHJp bmcncyBBUEkuIFdlIGNhbiBtYWtlIGl0IGJldHRlciBieSBvcHRpbWl6aW5nIHRoZSBjYXNlIHdo ZXJlIGV4YWN0bHkKLSAgICAvLyBvbmUgU3RyaW5nIGlzIHBvaW50aW5nIGF0IHRoaXMgU3RyaW5n SW1wbCwgYnV0IGV2ZW4gdGhlbiBpdCdzIGdvaW5nIHRvIHJlcXVpcmUgYQotICAgIC8vIGNhbGwg dG8gZmFzdE1hbGxvYyBldmVyeSBzaW5nbGUgdGltZS4KLSAgICBpZiAobV9pbXBsKSB7Ci0gICAg ICAgIFVDaGFyKiBkYXRhOwotICAgICAgICBpZiAobV9pbXBsLT5sZW5ndGgoKSA+PSBudW1lcmlj X2xpbWl0czx1bnNpZ25lZD46Om1heCgpKQotICAgICAgICAgICAgQ1JBU0goKTsKLSAgICAgICAg UmVmUHRyPFN0cmluZ0ltcGw+IG5ld0ltcGwgPSBTdHJpbmdJbXBsOjpjcmVhdGVVbmluaXRpYWxp emVkKG1faW1wbC0+bGVuZ3RoKCkgKyAxLCBkYXRhKTsKLSAgICAgICAgbWVtY3B5KGRhdGEsIG1f aW1wbC0+Y2hhcmFjdGVycygpLCBtX2ltcGwtPmxlbmd0aCgpICogc2l6ZW9mKFVDaGFyKSk7Ci0g ICAgICAgIGRhdGFbbV9pbXBsLT5sZW5ndGgoKV0gPSBjOwotICAgICAgICBtX2ltcGwgPSBuZXdJ bXBsLnJlbGVhc2UoKTsKLSAgICB9IGVsc2UKLSAgICAgICAgbV9pbXBsID0gU3RyaW5nSW1wbDo6 Y3JlYXRlKCZjLCAxKTsKKyAgICBhcHBlbmRJbnRlcm5hbChjKTsKIH0KIAogaW50IGNvZGVQb2lu dENvbXBhcmUoY29uc3QgU3RyaW5nJiBhLCBjb25zdCBTdHJpbmcmIGIpCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZT dHJpbmcuaAppbmRleCA0ODIwODhkLi4xYzhlOTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi90ZXh0L1dURlN0cmluZy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgK QEAgLTQ5NSw2ICs0OTUsOSBAQCBwcml2YXRlOgogICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBDaGFy YWN0ZXJUeXBlPgogICAgIHZvaWQgcmVtb3ZlSW50ZXJuYWwoY29uc3QgQ2hhcmFjdGVyVHlwZSos IHVuc2lnbmVkLCBpbnQpOwogCisgICAgdGVtcGxhdGUgPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+ CisgICAgdm9pZCBhcHBlbmRJbnRlcm5hbChDaGFyYWN0ZXJUeXBlKTsKKwogICAgIFJlZlB0cjxT dHJpbmdJbXBsPiBtX2ltcGw7CiB9OwogCg== 205889 2013-07-02 04:20:35 -0700 2013-07-02 06:36:49 -0700 patch bug118290 text/plain 2980 mikhail.pozdnyakov Y29tbWl0IDRhYmJjNWZhZmU1YTM1NTZkYTdlOTc5ZTI3MDU1Mzk4NDkzNzJjODAKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VHVlIEp1bCAyIDE0OjEyOjAwIDIwMTMgKzAzMDAKCiAgICBidWcxMTgyOTAKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRmNzAy YmMuLjI1NmRhM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDctMDIgIE1pa2hhaWwgUG96 ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgQXZvaWQg Y29kZSBkdXBsaWNhdGlvbiBpbnNpZGUgU3RyaW5nOjphcHBlbmQoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MjkwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGltcGxlbWVudGF0aW9uIG9mICdh cHBlbmQoVUNoYXIpJyBoYWQgYmVlbiByZXBlYXRlZCBpbnNpZGUgJ2FwcGVuZChMQ2hhciknLAor ICAgICAgICB0aGlzIGR1cGxpY2F0aW9uIGlzIG9idmlhdGVkIG5vdy4KKworICAgICAgICAqIHd0 Zi90ZXh0L1dURlN0cmluZy5jcHA6CisgICAgICAgIChXVEY6OlN0cmluZzo6YXBwZW5kSW50ZXJu YWwpOgorICAgICAgICAoV1RGOjpTdHJpbmc6OmFwcGVuZCk6CisgICAgICAgICogd3RmL3RleHQv V1RGU3RyaW5nLmg6CisKIDIwMTMtMDYtMjggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgU3RyaW5nOjpkZXByZWNhdGVkQ2hhcmFjdGVyc1dp dGhOdWxsVGVybWluYXRpb24oKSBhbmQgcmVsYXRlZCBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi90ZXh0L1dURlN0cmluZy5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmlu Zy5jcHAKaW5kZXggN2M2ZTUzNS4uMjljMTNjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv dGV4dC9XVEZTdHJpbmcuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmNw cApAQCAtMTE5LDcgKzExOSw4IEBAIHZvaWQgU3RyaW5nOjphcHBlbmQoY29uc3QgU3RyaW5nJiBz dHIpCiAgICAgfQogfQogCi12b2lkIFN0cmluZzo6YXBwZW5kKExDaGFyIGMpCit0ZW1wbGF0ZSA8 dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4KK2lubGluZSB2b2lkIFN0cmluZzo6YXBwZW5kSW50ZXJu YWwoQ2hhcmFjdGVyVHlwZSBjKQogewogICAgIC8vIEZJWE1FOiBUaGlzIGlzIGV4dHJlbWVseSBp bmVmZmljaWVudC4gU28gbXVjaCBzbyB0aGF0IHdlIG1pZ2h0IHdhbnQgdG8gdGFrZSB0aGlzCiAg ICAgLy8gb3V0IG9mIFN0cmluZydzIEFQSS4gV2UgY2FuIG1ha2UgaXQgYmV0dGVyIGJ5IG9wdGlt aXppbmcgdGhlIGNhc2Ugd2hlcmUgZXhhY3RseQpAQCAtMTM3LDIyICsxMzgsMTQgQEAgdm9pZCBT dHJpbmc6OmFwcGVuZChMQ2hhciBjKQogICAgICAgICBtX2ltcGwgPSBTdHJpbmdJbXBsOjpjcmVh dGUoJmMsIDEpOwogfQogCit2b2lkIFN0cmluZzo6YXBwZW5kKExDaGFyIGMpCit7CisgICAgYXBw ZW5kSW50ZXJuYWwoYyk7Cit9CisKIHZvaWQgU3RyaW5nOjphcHBlbmQoVUNoYXIgYykKIHsKLSAg ICAvLyBGSVhNRTogVGhpcyBpcyBleHRyZW1lbHkgaW5lZmZpY2llbnQuIFNvIG11Y2ggc28gdGhh dCB3ZSBtaWdodCB3YW50IHRvIHRha2UgdGhpcwotICAgIC8vIG91dCBvZiBTdHJpbmcncyBBUEku IFdlIGNhbiBtYWtlIGl0IGJldHRlciBieSBvcHRpbWl6aW5nIHRoZSBjYXNlIHdoZXJlIGV4YWN0 bHkKLSAgICAvLyBvbmUgU3RyaW5nIGlzIHBvaW50aW5nIGF0IHRoaXMgU3RyaW5nSW1wbCwgYnV0 IGV2ZW4gdGhlbiBpdCdzIGdvaW5nIHRvIHJlcXVpcmUgYQotICAgIC8vIGNhbGwgdG8gZmFzdE1h bGxvYyBldmVyeSBzaW5nbGUgdGltZS4KLSAgICBpZiAobV9pbXBsKSB7Ci0gICAgICAgIFVDaGFy KiBkYXRhOwotICAgICAgICBpZiAobV9pbXBsLT5sZW5ndGgoKSA+PSBudW1lcmljX2xpbWl0czx1 bnNpZ25lZD46Om1heCgpKQotICAgICAgICAgICAgQ1JBU0goKTsKLSAgICAgICAgUmVmUHRyPFN0 cmluZ0ltcGw+IG5ld0ltcGwgPSBTdHJpbmdJbXBsOjpjcmVhdGVVbmluaXRpYWxpemVkKG1faW1w bC0+bGVuZ3RoKCkgKyAxLCBkYXRhKTsKLSAgICAgICAgbWVtY3B5KGRhdGEsIG1faW1wbC0+Y2hh cmFjdGVycygpLCBtX2ltcGwtPmxlbmd0aCgpICogc2l6ZW9mKFVDaGFyKSk7Ci0gICAgICAgIGRh dGFbbV9pbXBsLT5sZW5ndGgoKV0gPSBjOwotICAgICAgICBtX2ltcGwgPSBuZXdJbXBsLnJlbGVh c2UoKTsKLSAgICB9IGVsc2UKLSAgICAgICAgbV9pbXBsID0gU3RyaW5nSW1wbDo6Y3JlYXRlKCZj LCAxKTsKKyAgICBhcHBlbmRJbnRlcm5hbChjKTsKIH0KIAogaW50IGNvZGVQb2ludENvbXBhcmUo Y29uc3QgU3RyaW5nJiBhLCBjb25zdCBTdHJpbmcmIGIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi90ZXh0L1dURlN0cmluZy5oIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaApp bmRleCA0ODIwODhkLi4xYzhlOTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dU RlN0cmluZy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgKQEAgLTQ5NSw2 ICs0OTUsOSBAQCBwcml2YXRlOgogICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBDaGFyYWN0ZXJUeXBl PgogICAgIHZvaWQgcmVtb3ZlSW50ZXJuYWwoY29uc3QgQ2hhcmFjdGVyVHlwZSosIHVuc2lnbmVk LCBpbnQpOwogCisgICAgdGVtcGxhdGUgPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+CisgICAgdm9p ZCBhcHBlbmRJbnRlcm5hbChDaGFyYWN0ZXJUeXBlKTsKKwogICAgIFJlZlB0cjxTdHJpbmdJbXBs PiBtX2ltcGw7CiB9OwogCg==