118284 2013-07-01 23:30:59 -0700 Simplify SVGTextContentElement::elementFromRenderer() 2013-07-02 13:16:25 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 cdumez cdumez commit-queue d-r fmalita krit laszlo.gombos pdr rwlbuis schenney thorton zimmermann oldest_to_newest 905265 0 cdumez 2013-07-01 23:30:59 -0700 Simplify SVGTextContentElement::elementFromRenderer() by leveraging SVGElement::isTextContent() methods instead of explicitly checking for tag names. Corresponding Blink revision: https://src.chromium.org/viewvc/blink?revision=153348&view=revision 905275 1 205874 cdumez 2013-07-02 00:11:49 -0700 Created attachment 205874 Patch 905338 2 205874 commit-queue 2013-07-02 04:51:06 -0700 Comment on attachment 205874 Patch Clearing flags on attachment: 205874 Committed r152284: <http://trac.webkit.org/changeset/152284> 905339 3 commit-queue 2013-07-02 04:51:09 -0700 All reviewed patches have been landed. Closing bug. 905544 4 205874 krit 2013-07-02 12:24:17 -0700 Comment on attachment 205874 Patch I assume we had these lines for <tref>. But am not entirely sure. Even if it landed, can you elaborate in the history so that we don't miss anything? 905563 5 cdumez 2013-07-02 13:16:25 -0700 (In reply to comment #4) > (From update of attachment 205874 [details]) > I assume we had these lines for <tref>. But am not entirely sure. Even if it landed, can you elaborate in the history so that we don't miss anything? For tref? Why does tref need special handling? SVGTRefElement inherits SVGTextContentElement so SVGTRefElement::isTextContent() will return true as expected. This function is supported to return a SVGTextContentElement from a Node so it seems logical to use isTextContent() / toSVGTextContentElement() instead of checking manually for all tags that correspond to SVGTextContentElement subclasses. AFAICT, there is no behavior change with this patch as the checks do the same in the end. Please let me know if I overlooked something. 205874 2013-07-02 00:11:49 -0700 2013-07-02 12:24:17 -0700 Patch 118284_elementFromRenderer.patch text/plain 1917 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNzY1YjBkLi44MTAzMGI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDctMDEgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFNpbXBsaWZ5IFNWR1RleHRDb250ZW50RWxlbWVudDo6ZWxlbWVudEZy b21SZW5kZXJlcigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTgyODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTaW1wbGlmeSBTVkdUZXh0Q29udGVudEVsZW1lbnQ6OmVsZW1lbnRGcm9tUmVuZGVyZXIo KSBieSBsZXZlcmFnaW5nCisgICAgICAgIFNWR0VsZW1lbnQ6OmlzVGV4dENvbnRlbnQoKSBtZXRo b2RzIGluc3RlYWQgb2YgZXhwbGljaXRseSBjaGVja2luZworICAgICAgICBmb3IgdGFnIG5hbWVz LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAg ICogc3ZnL1NWR1RleHRDb250ZW50RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdU ZXh0Q29udGVudEVsZW1lbnQ6OmVsZW1lbnRGcm9tUmVuZGVyZXIpOgorCiAyMDEzLTA3LTAxICBB bGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5k b3dzIHNob3VsZCBiZSBpbmNsdWRlZCBpbiB0aGUgbGlzdCBvZiBwbGF0Zm9ybXMgdGhhdCBjYW4g dXNlIE9wZW5HTCBFUyAyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RleHRD b250ZW50RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVGV4dENvbnRlbnRFbGVt ZW50LmNwcAppbmRleCAxMDNkOGJiLi40NmZkY2NkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9zdmcvU1ZHVGV4dENvbnRlbnRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcv U1ZHVGV4dENvbnRlbnRFbGVtZW50LmNwcApAQCAtMzAzLDIwICszMDMsMTMgQEAgU1ZHVGV4dENv bnRlbnRFbGVtZW50KiBTVkdUZXh0Q29udGVudEVsZW1lbnQ6OmVsZW1lbnRGcm9tUmVuZGVyZXIo UmVuZGVyT2JqZWN0KgogICAgIGlmICghcmVuZGVyZXItPmlzU1ZHVGV4dCgpICYmICFyZW5kZXJl ci0+aXNTVkdJbmxpbmUoKSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBOb2RlKiBub2RlID0g cmVuZGVyZXItPm5vZGUoKTsKLSAgICBBU1NFUlQobm9kZSk7Ci0gICAgQVNTRVJUKG5vZGUtPmlz U1ZHRWxlbWVudCgpKTsKLQotICAgIGlmICghbm9kZS0+aGFzVGFnTmFtZShTVkdOYW1lczo6dGV4 dFRhZykKLSAgICAgICAgJiYgIW5vZGUtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6OnRzcGFuVGFnKQot I2lmIEVOQUJMRShTVkdfRk9OVFMpCi0gICAgICAgICYmICFub2RlLT5oYXNUYWdOYW1lKFNWR05h bWVzOjphbHRHbHlwaFRhZykKLSNlbmRpZgotICAgICAgICAmJiAhbm9kZS0+aGFzVGFnTmFtZShT VkdOYW1lczo6dHJlZlRhZykKLSAgICAgICAgJiYgIW5vZGUtPmhhc1RhZ05hbWUoU1ZHTmFtZXM6 OnRleHRQYXRoVGFnKSkKKyAgICBTVkdFbGVtZW50KiBlbGVtZW50ID0gdG9TVkdFbGVtZW50KHJl bmRlcmVyLT5ub2RlKCkpOworICAgIEFTU0VSVChlbGVtZW50KTsKKworICAgIGlmICghZWxlbWVu dC0+aXNUZXh0Q29udGVudCgpKQogICAgICAgICByZXR1cm4gMDsKIAotICAgIHJldHVybiBzdGF0 aWNfY2FzdDxTVkdUZXh0Q29udGVudEVsZW1lbnQqPihub2RlKTsKKyAgICByZXR1cm4gdG9TVkdU ZXh0Q29udGVudEVsZW1lbnQoZWxlbWVudCk7CiB9CiAKIH0K