118280 2013-07-01 22:37:37 -0700 [WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure 2013-07-03 09:20:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan jberlin oldest_to_newest 905249 0 zan 2013-07-01 22:37:37 -0700 [WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure 905251 1 205866 zan 2013-07-01 22:42:35 -0700 Created attachment 205866 Patch 905528 2 205866 darin 2013-07-02 12:10:54 -0700 Comment on attachment 205866 Patch Debug-only code, so seems OK to me. 905697 3 205866 zan 2013-07-02 22:55:09 -0700 Comment on attachment 205866 Patch Clearing flags on attachment: 205866 Committed r152340: <http://trac.webkit.org/changeset/152340> 905698 4 zan 2013-07-02 22:55:14 -0700 All reviewed patches have been landed. Closing bug. 905872 5 jberlin 2013-07-03 08:21:43 -0700 This broke the build: http://build.webkit.org/builders/Apple%20Lion%20Debug%20%28Build%29/builds/17493/steps/compile-webkit/logs/stdio Ld /Volumes/Data/slave/lion-debug/build/WebKitBuild/Debug/WebKit2.framework/Versions/A/WebKit2 normal x86_64 cd /Volumes/Data/slave/lion-debug/build/Source/WebKit2 setenv MACOSX_DEPLOYMENT_TARGET 10.7 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -arch x86_64 -dynamiclib -L/Volumes/Data/slave/lion-debug/build/WebKitBuild/Debug -F/Volumes/Data/slave/lion-debug/build/WebKitBuild/Debug -F/Volumes/Data/slave/lion-debug/build/WebKitBuild/Debug -F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -F/System/Library/Frameworks/Carbon.framework/Frameworks -F/System/Library/Frameworks/Quartz.framework/Frameworks -F/System/Library/Frameworks/CoreServices.framework/Frameworks -filelist /Volumes/Data/slave/lion-debug/build/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Objects-normal/x86_64/WebKit2.LinkFileList -Xlinker --no-demangle -install_name /System/Library/PrivateFrameworks/WebKit2.framework/Versions/A/WebKit2 -mmacosx-version-min=10.7 -dead_strip -framework ApplicationServices -framework Carbon -framework Cocoa -framework CoreServices -framework IOKit -framework JavaScriptCore -licucore -framework QuartzCore -framework Security -framework WebCore -framework CoreAudio -framework WebInspectorUI -Wl,-unexported_symbol -Wl,__ZTISt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTISt9exception -Wl,-unexported_symbol -Wl,__ZTSSt9bad_alloc -Wl,-unexported_symbol -Wl,__ZTSSt9exception -Wl,-unexported_symbol -Wl,__ZdlPvS_ -Wl,-unexported_symbol -Wl,__ZnwmPv -Wl,-unexported_symbol -Wl,__Znwm -lWebKitSystemInterfaceLion -stdlib=libc++ -fobjc-link-runtime -single_module -compatibility_version 1 -current_version 538.1 -o /Volumes/Data/slave/lion-debug/build/WebKitBuild/Debug/WebKit2.framework/Versions/A/WebKit2 Undefined symbols for architecture x86_64: "__ZN7WebCore9FontCache10invalidateEv", referenced from: __ZN6WebKit10WebProcess9terminateEv in WebProcess.o __ZN6WebKit10WebProcess8didCloseEPN7CoreIPC10ConnectionE in WebProcess.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) I am going to try to fix it, but if that takes too long I will just roll out this patch. 905881 6 zan 2013-07-03 08:53:21 -0700 I apologize, I should have checked the builders after the patch landed. Thanks for fixing. 905884 7 jberlin 2013-07-03 09:20:31 -0700 Fix is in http://trac.webkit.org/changeset/152355 205866 2013-07-01 22:42:35 -0700 2013-07-02 22:55:09 -0700 Patch bug-118280-20130701224030.patch text/plain 1777 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTM5YTI5NjJjOGMzMjNl Y2JiM2M4ZmUxYWQzYTJhMzUxMzdkYTAzYS4uZGU3OWRkYzliZWQ5NTkzZmI1NGJjOWUxMWUwNTBh ZTY3NmNhM2U2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA3LTAxICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbV0syXSBJbnZhbGlk YXRlIEZvbnRDYWNoZSBiZWZvcmUgcHVyZ2luZyBNZW1vcnlDYWNoZSB1cG9uIFdlYlByb2Nlc3Mg dGVybWluYXRpb24vY2xvc3VyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE4MjgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW52YWxpZGF0ZSB0aGUgRm9udENhY2hlIGJlZm9yZSBkaXNhYmxpbmcgYW5k IHB1cmdpbmcgdGhlIE1lbW9yeUNhY2hlIGluIFdlYlByb2Nlc3M6OmRpZENsb3NlCisgICAgICAg IGFuZCBXZWJQcm9jZXNzOjp0ZXJtaW5hdGUuIFRoaXMgZnJlZXMgdXAgYWRkaXRpb25hbCByZWZl cmVuY2VzIHRvIG9iamVjdHMgdGhhdCB3ZXJlIGhlbGQKKyAgICAgICAgYnkgdGhlIEZvbnRDYWNo ZSwgcmVkdWNpbmcgdGhlIGFtb3VudCBvZiAnTEVBSzogKicgb3V0cHV0IHdoZW4gZXhpdGluZyBN aW5pQnJvd3NlciBvcgorICAgICAgICBXZWJLaXRUZXN0UnVubmVyIGluIGRlYnVnIGJ1aWxkcy4K KworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlByb2Nlc3M6OnRlcm1pbmF0ZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OmRp ZENsb3NlKToKKwogMjAxMy0wNy0wMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNv bT4KIAogICAgICAgICBDbGVhbiB1cCBwcml2YXRlIGJyb3dzaW5nIHNlc3Npb24gdHJhY2tpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCmluZGV4IGI1YjIxNGFhZWVj M2UwMDQxM2QxNTk4NmE0NWJhZTkwYWRiY2E4Y2IuLjMzZDMwY2YwNWFkM2E5MTA3N2FmNzVlNjAx MGNlNWVhMWM2NTdkNWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNw cApAQCAtNjE2LDYgKzYxNiw3IEBAIHZvaWQgV2ViUHJvY2Vzczo6dGVybWluYXRlKCkKIHsKICNp Zm5kZWYgTkRFQlVHCiAgICAgZ2NDb250cm9sbGVyKCkuZ2FyYmFnZUNvbGxlY3ROb3coKTsKKyAg ICBmb250Q2FjaGUoKS0+aW52YWxpZGF0ZSgpOwogICAgIG1lbW9yeUNhY2hlKCktPnNldERpc2Fi bGVkKHRydWUpOwogI2VuZGlmCiAKQEAgLTY2OCw2ICs2NjksNyBAQCB2b2lkIFdlYlByb2Nlc3M6 OmRpZENsb3NlKENvcmVJUEM6OkNvbm5lY3Rpb24qKQogICAgIHBhZ2VzLmNsZWFyKCk7CiAKICAg ICBnY0NvbnRyb2xsZXIoKS5nYXJiYWdlQ29sbGVjdFNvb24oKTsKKyAgICBmb250Q2FjaGUoKS0+ aW52YWxpZGF0ZSgpOwogICAgIG1lbW9yeUNhY2hlKCktPnNldERpc2FibGVkKHRydWUpOwogI2Vu ZGlmICAgIAogCg==