118244 2013-07-01 07:02:11 -0700 [Qt] Avoid creating a QWindow for offscreen GraphicsContext3D 2013-07-01 07:30:08 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen commit-queue dino jturcotte noam oldest_to_newest 905013 0 allan.jensen 2013-07-01 07:02:11 -0700 With Qt 5.0 we had to create a QWindow inorder to make a QOpenGLContext current. In Qt 5.1 we have the option of using a QOffscreenSurface instead. On platforms like X11 the results will be the same, but on OpenGL based platforms the QOffscreenSurface will use a pbuffer. 905017 1 205809 allan.jensen 2013-07-01 07:05:20 -0700 Created attachment 205809 Patch 905023 2 205809 noam 2013-07-01 07:17:06 -0700 Comment on attachment 205809 Patch Nice! 905025 3 205809 allan.jensen 2013-07-01 07:30:03 -0700 Comment on attachment 205809 Patch Clearing flags on attachment: 205809 Committed r152222: <http://trac.webkit.org/changeset/152222> 905026 4 allan.jensen 2013-07-01 07:30:08 -0700 All reviewed patches have been landed. Closing bug. 205809 2013-07-01 07:05:20 -0700 2013-07-01 07:30:03 -0700 Patch bug-118244-20130701160316.patch text/plain 2553 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjg3NTU0MWM2NGMzZWQ3 MzUwNjdmM2VjZjU3NThiZWE3MzY1NzBiMS4uNzNhYjcwMzk3Njg4ODEyMzhhOTI1NzA5MTYxNGRm YmM3NTdmM2MwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA3LTAxICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCisgICAgICAgIFtR dF0gQXZvaWQgY3JlYXRpbmcgYSBRV2luZG93IGZvciBvZmZzY3JlZW4gR3JhcGhpY3NDb250ZXh0 M0QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODI0 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIFF0 IDUuMCB3ZSBoYWQgdG8gY3JlYXRlIGludmlzaWJsZSB3aW5kb3dzLCBidXQgaW4gUXQgNS4xCisg ICAgICAgIHdlIGNhbiBub3cgY3JlYXRlIHNwZWNpZmljIG9mZnNjcmVlbiBzdXJmYWNlcy4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlOjpHcmFwaGljc0NvbnRl eHQzRFByaXZhdGUpOgorCisyMDEzLTA3LTAxICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxh bi5qZW5zZW5AZGlnaWEuY29tPgorCiAgICAgICAgIFtRdF0gQ3Jhc2ggb24gY2xvc2UgaWYgYnVp bGQgd2l0aCBnZW9sb2NhdGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE4MjQwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKaW5kZXggNzJjZGVlODRj MDFlMDZjZTMxMzgxYjE4ODdiYWJkYTNmZDQyNWJiMS4uZjJhNjU0MzE3ZDJlY2E0NWY0MTQwOGJk OWI5YzgyZmFmY2IxNzNjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAKQEAgLTM1LDEwICszNSwx NSBAQAogI2luY2x1ZGUgIlFXZWJQYWdlQ2xpZW50LmgiCiAjaW5jbHVkZSAiU2hhcmVkQnVmZmVy LmgiCiAjaW5jbHVkZSAiVGV4dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXIuaCIKLSNpbmNsdWRlIDxR V2luZG93PgogI2luY2x1ZGUgPHFwYS9xcGxhdGZvcm1waXhtYXAuaD4KICNpbmNsdWRlIDx3dGYv dGV4dC9DU3RyaW5nLmg+CiAKKyNpZiBRVF9WRVJTSU9OID49IDB4MDUwMTAwCisjaW5jbHVkZSA8 UU9mZnNjcmVlblN1cmZhY2U+CisjZWxzZQorI2luY2x1ZGUgPFFXaW5kb3c+CisjZW5kaWYKKwog I2lmIFVTRShURVhUVVJFX01BUFBFUl9HTCkKICNpbmNsdWRlIDx0ZXhtYXAvVGV4dHVyZU1hcHBl ckdMLmg+CiAjZW5kaWYKQEAgLTExNiwxNiArMTIxLDIxIEBAIEdyYXBoaWNzQ29udGV4dDNEUHJp dmF0ZTo6R3JhcGhpY3NDb250ZXh0M0RQcml2YXRlKEdyYXBoaWNzQ29udGV4dDNEKiBjb250ZXh0 LCBICiAgICAgfQogCiAjaWYgVVNFKEdSQVBISUNTX1NVUkZBQ0UpCi0gICAgLy8gRklYTUU6IEZp bmQgYSB3YXkgdG8gY3JlYXRlIGEgUU9wZW5HTENvbnRleHQgd2l0aG91dCBjcmVhdGluZyBhIFFX aW5kb3cgYXQgYWxsLgotICAgIC8vIFdlIG5lZWQgdG8gY3JlYXRlIGEgc3VyZmFjZSBpbiBvcmRl ciB0byBjcmVhdGUgYSBRT3BlbkdMQ29udGV4dCBhbmQgbWFrZSBpdCBjdXJyZW50LgorI2lmIFFU X1ZFUlNJT04gPj0gMHgwNTAxMDAKKyAgICBRT2Zmc2NyZWVuU3VyZmFjZSogc3VyZmFjZSA9IG5l dyBRT2Zmc2NyZWVuU3VyZmFjZTsKKyAgICBzdXJmYWNlLT5jcmVhdGUoKTsKKyAgICBtX3N1cmZh Y2UgPSBzdXJmYWNlOworICAgIG1fc3VyZmFjZU93bmVyID0gc3VyZmFjZTsKKyNlbHNlCiAgICAg UVdpbmRvdyogd2luZG93ID0gbmV3IFFXaW5kb3c7CiAgICAgd2luZG93LT5zZXRTdXJmYWNlVHlw ZShRU3VyZmFjZTo6T3BlbkdMU3VyZmFjZSk7CiAgICAgd2luZG93LT5zZXRHZW9tZXRyeSgtMTAs IC0xMCwgMSwgMSk7CiAgICAgd2luZG93LT5jcmVhdGUoKTsKICAgICBtX3N1cmZhY2UgPSB3aW5k b3c7CiAgICAgbV9zdXJmYWNlT3duZXIgPSB3aW5kb3c7CisjZW5kaWYKIAotICAgIG1fcGxhdGZv cm1Db250ZXh0ID0gbmV3IFFPcGVuR0xDb250ZXh0KHdpbmRvdyk7CisgICAgbV9wbGF0Zm9ybUNv bnRleHQgPSBuZXcgUU9wZW5HTENvbnRleHQobV9zdXJmYWNlT3duZXIpOwogICAgIGlmICghbV9w bGF0Zm9ybUNvbnRleHQtPmNyZWF0ZSgpKQogICAgICAgICByZXR1cm47CiAK