118242 2013-07-01 06:37:48 -0700 Fix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h 2013-07-01 08:39:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy ggaren mhahnenberg ossy oldest_to_newest 905006 0 ossy 2013-07-01 06:37:48 -0700 /home/oszi/Source/JavaScriptCore/heap/HandleBlockInlines.h:58:51: warning: cast from 'char*' to 'JSC::HandleNode*' increases required alignment of target type [-Wcast-align] This code introduced in http://trac.webkit.org/changeset/146734 : ... inline char* HandleBlock::payload() { return reinterpret_cast<char*>(this) + WTF::roundUpToMultipleOf<sizeof(double)>(sizeof(HandleBlock)); } inline HandleNode* HandleBlock::nodes() { return reinterpret_cast<HandleNode*>(payload()); <------ line 58 } ... This part of JSC isn't quite clear for me. As far as I understand a HandleBlock is 4K sized block on JSC heap, which contains HandleNode instances on int payload. And the payload is 64 bit aligned after the HandleBlock instance. Am I correct? If yes, I think this casting is safe and can be supressed by using reinterpret_cast_ptr instead of reinterpret_cast, because HandleNode has two following members: JSValue, HandleNode* and HandleNode* . 905007 1 205807 ossy 2013-07-01 06:39:28 -0700 Created attachment 205807 Patch 905031 2 205807 mhahnenberg 2013-07-01 08:10:01 -0700 Comment on attachment 205807 Patch r=me. We use char* to make the pointer arithmetic easier, so it's fine that the cast changes the alignment. Thanks for fixing this! 905038 3 205807 ossy 2013-07-01 08:39:41 -0700 Comment on attachment 205807 Patch Clearing flags on attachment: 205807 Committed r152225: <http://trac.webkit.org/changeset/152225> 905039 4 ossy 2013-07-01 08:39:47 -0700 All reviewed patches have been landed. Closing bug. 205807 2013-07-01 06:39:28 -0700 2013-07-01 08:39:41 -0700 Patch bug-118242-20130701063728.patch text/plain 1314 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NDIxNWMxNDk3M2NjOGEyNjZlYjU4YWVmYjMwOTkwNzNmYTI3MTIwLi4xM2UzZWFiZDBlNmJjZWE5 MjU3N2NlOGQ1ODAxMTQ5YTM5OWY1ZTBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0wNy0wMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEZpeCBjYXN0LWFsaWduIHdhcm5pbmdzIGluIEphdmFTY3JpcHRDb3Jl L2hlYXAvSGFuZGxlQmxvY2tJbmxpbmVzLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExODI0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogaGVhcC9IYW5kbGVCbG9ja0lubGluZXMuaDoKKyAgICAgICAg KEpTQzo6SGFuZGxlQmxvY2s6Om5vZGVzKToKKwogMjAxMy0wNi0yOSAgQW5kcmVhcyBLbGluZyAg PGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgRm9sbG93LXVwIHRvIHIxNTIyMDY6IGFsc28g dXBkYXRlIEhhc2hGbGFnczhCaXRCdWZmZXIgaW4gdGhlIExMSW50LgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGFuZGxlQmxvY2tJbmxpbmVzLmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaGVhcC9IYW5kbGVCbG9ja0lubGluZXMuaAppbmRleCBjM2ZjZDQ5MGUzN2M3 ZWU1YzJlNWU3ZWYzYWFkZWYyNGVhOWU2YTllLi43Yzc3MTkzNWUwZTJjM2RjYTZiMzA1YTZiNGYw MmM2OThlODkyZDVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IYW5k bGVCbG9ja0lubGluZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IYW5kbGVC bG9ja0lubGluZXMuaApAQCAtNTUsNyArNTUsNyBAQCBpbmxpbmUgY2hhciogSGFuZGxlQmxvY2s6 OnBheWxvYWQoKQogCiBpbmxpbmUgSGFuZGxlTm9kZSogSGFuZGxlQmxvY2s6Om5vZGVzKCkKIHsK LSAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDxIYW5kbGVOb2RlKj4ocGF5bG9hZCgpKTsKKyAg ICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdF9wdHI8SGFuZGxlTm9kZSo+KHBheWxvYWQoKSk7CiB9 CiAKIGlubGluZSBIYW5kbGVOb2RlKiBIYW5kbGVCbG9jazo6bm9kZUF0SW5kZXgodW5zaWduZWQg aSkK