118230 2013-06-30 23:54:25 -0700 [GTK] Use PassOwnPtr for the returned value of createBackingStore 2013-07-01 01:44:49 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kevin.cs.oh webkit-unassigned commit-queue gustavo mrobinson oldest_to_newest 904934 0 kevin.cs.oh 2013-06-30 23:54:25 -0700 I think it would be better that createBackingStore returns PassOwnPtr instread of OwnPtr to keep compatibility with c++0x. Otherwise we face following break with the c++0x compile option. [shivamidow@LenovoStation:Release]$ make -j 3 make all-am make[1]: Entering directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release' /bin/mkdir -p ./.deps/DerivedSources CXX Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-ChromeClientGtk.lo CXX Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-FrameLoaderClientGtk.lo CXX Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-FrameNetworkingContextGtk.lo CXX Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-GeolocationClientGtk.lo In file included from ../../Source/WTF/wtf/VectorTraits.h:25:0, from ../../Source/WTF/wtf/Vector.h:31, from ../../Source/WebCore/platform/graphics/FloatRect.h:31, from ../../Source/WebCore/platform/graphics/FloatQuad.h:33, from ../../Source/WebCore/accessibility/AccessibilityObject.h:33, from ../../Source/WebCore/accessibility/AXObjectCache.h:29, from ../../Source/WebCore/page/ChromeClient.h:25, from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:24, from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:26: ../../Source/WTF/wtf/OwnPtr.h: In member function 'virtual void WebKit::ChromeClient::attachRootGraphicsLayer(WebCore::Frame*, WebCore::GraphicsLayer*)': ../../Source/WTF/wtf/OwnPtr.h:97:17: error: 'WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::OwnPtr<T>&) [with T = WebCore::WidgetBackingStore; WTF::OwnPtr<T> = WTF::OwnPtr<WebCore::WidgetBackingStore>]' is private ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:1072:96: error: within this context In file included from ../../Source/WTF/wtf/VectorTraits.h:25:0, from ../../Source/WTF/wtf/Vector.h:31, from ../../Source/WebCore/platform/graphics/FloatRect.h:31, from ../../Source/WebCore/platform/graphics/FloatQuad.h:33, from ../../Source/WebCore/accessibility/AccessibilityObject.h:33, from ../../Source/WebCore/accessibility/AXObjectCache.h:29, from ../../Source/WebCore/page/ChromeClient.h:25, from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:24, from ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:26: ../../Source/WTF/wtf/OwnPtr.h:97:17: error: 'WTF::OwnPtr<T>& WTF::OwnPtr<T>::operator=(const WTF::OwnPtr<T>&) [with T = WebCore::WidgetBackingStore; WTF::OwnPtr<T> = WTF::OwnPtr<WebCore::WidgetBackingStore>]' is private ../../Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:1076:115: error: within this context make[1]: *** [Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-ChromeClientGtk.lo] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release' make: *** [all] Error 2 904935 1 205786 kevin.cs.oh 2013-06-30 23:59:35 -0700 Created attachment 205786 Patch 904945 2 205786 commit-queue 2013-07-01 01:44:47 -0700 Comment on attachment 205786 Patch Clearing flags on attachment: 205786 Committed r152216: <http://trac.webkit.org/changeset/152216> 904946 3 commit-queue 2013-07-01 01:44:49 -0700 All reviewed patches have been landed. Closing bug. 205786 2013-06-30 23:59:35 -0700 2013-07-01 01:44:47 -0700 Patch bug-118230-20130701155731.patch text/plain 1600 kevin.cs.oh U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOWI4Y2VkMDk3 MTY2ZmQ4ZDcwNWViMjdkZmE2ODE4N2VjYjY3Y2M2MS4uNzJmZjBlY2M4ODJhZjUxNDA1MmRjM2I2 OWM2ZjYzMWNlMTdlOThkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEz LTA2LTMwICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAg ICAgICBbR1RLXSBVc2UgUGFzc093blB0ciBmb3IgdGhlIHJldHVybmVkIHZhbHVlIG9mIGNyZWF0 ZUJhY2tpbmdTdG9yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE4MjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSXQgd291bGQgYmUgYmV0dGVyIHRoYXQgY3JlYXRlQmFja2luZ1N0b3JlIHJldHVybnMg UGFzc093blB0ciBpbnN0cmVhZCBvZiBPd25QdHIKKyAgICAgICAgdG8ga2VlcCBjb21wYXRpYmls aXR5IHdpdGggYysrMHguCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRH dGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpjcmVhdGVCYWNraW5nU3RvcmUpOgorCiAyMDEzLTA2 LTI4ICBJYWdvIFRvcmFsIFF1aXJvZ2EgIDxpdG9yYWxAaWdhbGlhLmNvbT4KIAogICAgICAgICBV c2UgZ3RrX3dpZGdldF9nZXRfcHJlZmVycmVkX3NpemUgaW5zdGVhZCBvZiBkZXByZWNhdGVkIGd0 a193aWRnZXRfZ2V0X3JlcXVpc2l0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9X ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRHdGsuY3BwIGIvU291cmNlL1dlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcAppbmRleCBhZTI5NTQzZDBlN2M5OWI5N2Ez ZTBlZjBhYzY0ZjE5ODk1YmQ2MzQ2Li44MzMyNjMzN2NlZWU0YTBmMzQxZmQ1MjdkYzYzNDcyMjkx YmY4NzI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJv bWVDbGllbnRHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0No cm9tZUNsaWVudEd0ay5jcHAKQEAgLTEwNCw3ICsxMDQsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2Vi Q29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLXN0YXRpYyBPd25QdHI8V2lkZ2V0QmFja2lu Z1N0b3JlPiBjcmVhdGVCYWNraW5nU3RvcmUoR3RrV2lkZ2V0KiB3aWRnZXQsIGNvbnN0IEludFNp emUmIHNpemUpCitzdGF0aWMgUGFzc093blB0cjxXaWRnZXRCYWNraW5nU3RvcmU+IGNyZWF0ZUJh Y2tpbmdTdG9yZShHdGtXaWRnZXQqIHdpZGdldCwgY29uc3QgSW50U2l6ZSYgc2l6ZSkKIHsKICNp ZmRlZiBHREtfV0lORE9XSU5HX1gxMQogICAgIEdka0Rpc3BsYXkqIGRpc3BsYXkgPSBnZGtfZGlz cGxheV9tYW5hZ2VyX2dldF9kZWZhdWx0X2Rpc3BsYXkoZ2RrX2Rpc3BsYXlfbWFuYWdlcl9nZXQo KSk7Cg==