118228 2013-06-30 23:43:32 -0700 Build fix: use of long long in CoreIPC::ArgumentEncoder and CoreIPC::ArgumentDecoder 2013-07-25 15:35:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108832 1 skyul skyul andersca ap cdumez sam oldest_to_newest 904929 0 skyul 2013-06-30 23:43:32 -0700 While porting NetworkProcess to Gtk port, I encountered the following compile errors: In file included from ../../Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:29:0, from ../../Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h:29, from ../../Source/WebKit2/Shared/FileAPI/BlobRegistrationData.cpp:31: ../../Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h: In instantiation of `static bool CoreIPC::ArgumentCoder<T>::decode(CoreIPC::ArgumentDecoder&, T&) [with T = long long int]': ../../Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h:91:49: required from `bool CoreIPC::ArgumentDecoder::decode(T&) [with T = long long int]' ../../Source/WebKit2/Shared/FileAPI/BlobRegistrationData.cpp:142:39: required from here ../../Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: `decode' is not a member of `long long int' ../../Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h: In instantiation of `static void CoreIPC::ArgumentCoder<T>::encode(CoreIPC::ArgumentEncoder&, const T&) [with T = long long int]': ../../Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h:57:9: required from `void CoreIPC::ArgumentEncoder::encode(const T&) [with T = long long int]' ../../Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h:62:9: required from `CoreIPC::ArgumentEncoder& CoreIPC::ArgumentEncoder::operator<<(const T&) [with T = long long int; CoreIPC::ArgumentEncoder = CoreIPC::ArgumentEncoder]' ../../Source/WebKit2/Shared/FileAPI/BlobRegistrationData.cpp:91:29: required from here ../../Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:39:9: error: request for member `encode' in `t', which is of non-class type `const long long int' ../../Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h: In static member function `static bool CoreIPC::ArgumentCoder<T>::decode(CoreIPC::ArgumentDecoder&, T&) [with T = long long int]': ../../Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:45:5: warning: control reaches end of non-void function [-Wreturn-type] ICECC[1565] 15:39:58: Compiled on 192.168.100.227 int64_t fixes build. 904932 1 205785 skyul 2013-06-30 23:47:26 -0700 Created attachment 205785 Patch 905028 2 205785 andersca 2013-07-01 07:36:41 -0700 Comment on attachment 205785 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205785&action=review > Source/WebCore/platform/network/BlobData.h:149 > - long long offset; > - long long length; > + int64_t offset; > + int64_t length; > double expectedModificationTime; I don't think we should change code in WebCore because of IPC requirements. 905056 3 skyul 2013-07-01 09:15:15 -0700 (In reply to comment #2) > I don't think we should change code in WebCore because of IPC requirements. Okay. Then do you want to add long long type to ArgumentEncoder::encode and ArgumentDecoder::decode? The problem with this approach is that int64_t and long long are the same type on some platforms. For example, the current Mac port does not have this problem because they are the same type. So adding ArgumentEncoder::encode(long long) might conflict with ArgumentEncoder::encode(int64_t) on these platforms. (can't be overloaded) So unless if you have a strong requirement for using long long over int64_t, I suggest to use int64. I understand long long is preferred in some cases because long long is at least 64 bit wide while int64_t is exactly 64 bit wide. But I think 64 bit is wide enough for offset and length here. Or do you have any other suggestion? 905059 4 ap 2013-07-01 09:19:33 -0700 > Okay. Then do you want to add long long type to ArgumentEncoder::encode and ArgumentDecoder::decode? Definitely not, IPC types should be all fixed size. Personally, I'd be OK with the current patch, but the way to address the comment Anders made is to add explicit casts (with value checks) in BlobRegistrationData encode and decode functions. 905077 5 andersca 2013-07-01 09:54:53 -0700 (In reply to comment #4) > Personally, I'd be OK with the current patch, but the way to address the comment Anders made is to add explicit casts (with value checks) in BlobRegistrationData encode and decode functions. Explicit casts sounds good. 905088 6 205820 skyul 2013-07-01 10:27:58 -0700 Created attachment 205820 Patch 905089 7 skyul 2013-07-01 10:28:43 -0700 (In reply to comment #5) > Explicit casts sounds good. Done. Thanks for the suggestion! 911470 8 skyul 2013-07-24 17:08:52 -0700 The patch is ready for review. Alexey and Anders, would you review the patch again? 911784 9 skyul 2013-07-25 15:35:25 -0700 Committed r153352: <http://trac.webkit.org/changeset/153352> 205785 2013-06-30 23:47:26 -0700 2013-07-01 10:27:54 -0700 Patch bug-118228-20130701154504.patch text/plain 3361 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzYxYWNhMjc5ZWY4ZDM3 Y2UwYzI3NWRjNDExMTg4OGMwNmE1OWFmNC4uOWIxZTUxMjM5MDY4MTE2YTZmMDU1ZjMwMDcyNGQ2 NzhiNzM4ZjI3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTA2LTMwICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKKyAgICAgICAgQnVpbGQgZml4OiB1 c2Ugb2YgbG9uZyBsb25nIGluIENvcmVJUEM6OkFyZ3VtZW50RW5jb2RlciBhbmQgQ29yZUlQQzo6 QXJndW1lbnREZWNvZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTgyMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBpbnQ2NF90IGZpeGVzIGJ1aWxkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8g YmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9CbG9iRGF0YS5o OgorCisyMDEzLTA2LTMwICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisK ICAgICAgICAgQWRkIG1pc3Npbmcgc3RyaW5nIGhlYWRlcnMgdGhhdCBhcmUgdXNlZCB3aGVuIExP R19ESVNBQkxFRCBpcyAwLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTE4MjI3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA4YTZhYjc2ZTZjODhmNDE0YjNlMWQ3NDYy YzMwYzI0MTJhNjkzNmU2Li5mYzE1NGY3NTFmZDU4MWE0ZGU0NWE2YzcyNTZmYmUxYjdiY2ZlZjNk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDYtMzAgIEt3YW5nIFl1bCBTZW8g IDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBCdWlsZCBmaXg6IHVzZSBvZiBsb25n IGxvbmcgaW4gQ29yZUlQQzo6QXJndW1lbnRFbmNvZGVyIGFuZCBDb3JlSVBDOjpBcmd1bWVudERl Y29kZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx ODIyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGlu dDY0X3QgZml4ZXMgYnVpbGQuCisKKyAgICAgICAgKiBTaGFyZWQvRmlsZUFQSS9CbG9iUmVnaXN0 cmF0aW9uRGF0YS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkJsb2JSZWdpc3RyYXRpb25EYXRhOjpk ZWNvZGUpOgorCiAyMDEzLTA2LTI4ICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9y Zz4KIAogICAgICAgICBbV0syXSBNYWtlIEVmbCBidWlsZCBhbmQgcnVuIHdpdGggRU5BQkxFX05F VFdPUktfUFJPQ0VTUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9CbG9iRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9CbG9iRGF0YS5o CmluZGV4IGZkOTRmNTk5MWUyNjhhZTdmMjMxOWQ4ZTNiMDQyM2MwYjllNjY3NzQuLjRiNzI1Y2Jh NDcyMmFmZGVkZmJkYjU2MmNjY2QyN2JiN2EyNjgzZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvQmxvYkRhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL0Jsb2JEYXRhLmgKQEAgLTE0NCw4ICsxNDQsOCBAQCBzdHJ1Y3QgQmxvYkRh dGFJdGVtIHsKICAgICAvLyBGb3IgQmxvYiBvciBVUkwgdHlwZS4KICAgICBLVVJMIHVybDsKIAot ICAgIGxvbmcgbG9uZyBvZmZzZXQ7Ci0gICAgbG9uZyBsb25nIGxlbmd0aDsKKyAgICBpbnQ2NF90 IG9mZnNldDsKKyAgICBpbnQ2NF90IGxlbmd0aDsKICAgICBkb3VibGUgZXhwZWN0ZWRNb2RpZmlj YXRpb25UaW1lOwogCiBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVk L0ZpbGVBUEkvQmxvYlJlZ2lzdHJhdGlvbkRhdGEuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVk L0ZpbGVBUEkvQmxvYlJlZ2lzdHJhdGlvbkRhdGEuY3BwCmluZGV4IDQxYTcxYTZkMWMzYWYzMjBk NWQxOTVjM2RmZGI4MTllMmYyMGU1N2YuLjk5ODU1OTU1NzNmMzdlN2JhMDVhMGUxODA5ODZkOWJl YTAxNjU2MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9GaWxlQVBJL0Jsb2JS ZWdpc3RyYXRpb25EYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRmlsZUFQSS9C bG9iUmVnaXN0cmF0aW9uRGF0YS5jcHAKQEAgLTEzOCwxMCArMTM4LDEwIEBAIGJvb2wgQmxvYlJl Z2lzdHJhdGlvbkRhdGE6OmRlY29kZShDb3JlSVBDOjpBcmd1bWVudERlY29kZXImIGRlY29kZXIs IEJsb2JSZWdpc3RyCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICBjYXNl IEJsb2JEYXRhSXRlbTo6RmlsZTogewotICAgICAgICAgICAgbG9uZyBsb25nIG9mZnNldDsKKyAg ICAgICAgICAgIGludDY0X3Qgb2Zmc2V0OwogICAgICAgICAgICAgaWYgKCFkZWNvZGVyLmRlY29k ZShvZmZzZXQpKQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgICAgIGxv bmcgbG9uZyBsZW5ndGg7CisgICAgICAgICAgICBpbnQ2NF90IGxlbmd0aDsKICAgICAgICAgICAg IGlmICghZGVjb2Rlci5kZWNvZGUobGVuZ3RoKSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgICAgICAgICBkb3VibGUgZXhwZWN0ZWRNb2RpZmljYXRpb25UaW1lOwpAQCAtMTU0 LDEwICsxNTQsMTAgQEAgYm9vbCBCbG9iUmVnaXN0cmF0aW9uRGF0YTo6ZGVjb2RlKENvcmVJUEM6 OkFyZ3VtZW50RGVjb2RlciYgZGVjb2RlciwgQmxvYlJlZ2lzdHIKICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICB9CiAgICAgICAgIGNhc2UgQmxvYkRhdGFJdGVtOjpCbG9iOiB7Ci0gICAgICAg ICAgICBsb25nIGxvbmcgb2Zmc2V0OworICAgICAgICAgICAgaW50NjRfdCBvZmZzZXQ7CiAgICAg ICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKG9mZnNldCkpCiAgICAgICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwotICAgICAgICAgICAgbG9uZyBsb25nIGxlbmd0aDsKKyAgICAgICAgICAgIGlu dDY0X3QgbGVuZ3RoOwogICAgICAgICAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShsZW5ndGgpKQog ICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgIFN0cmluZyB1cmw7Cg== 205820 2013-07-01 10:27:58 -0700 2013-07-25 09:24:35 -0700 Patch bug-118228-20130702022535.patch text/plain 3177 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWQ5NWY5ODc0ZDE4ZmZm NDBmMzY4MTdmNTdjZjAzMTIxNjMyZWU2Yi4uYmMzNzJjNjM5MzRjMDM0YTcwMDFlYjUzOWU5Yzc1 YzQ2NTFlZWM0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEzLTA3LTAxICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKKyAgICAgICAgQnVpbGQgZml4OiB1 c2Ugb2YgbG9uZyBsb25nIGluIENvcmVJUEM6OkFyZ3VtZW50RW5jb2RlciBhbmQgQ29yZUlQQzo6 QXJndW1lbnREZWNvZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTgyMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBCdWlsZCBmYWlscyBvbiBzb21lIHBsYXRmb3JtcyB3aGVyZSBpbnQ2NF90IGFuZCBs b25nIGxvbmcgYXJlIGRpZmZlcmVudCB0eXBlcy4KKworICAgICAgICAqIFNoYXJlZC9GaWxlQVBJ L0Jsb2JSZWdpc3RyYXRpb25EYXRhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6QmxvYlJlZ2lzdHJh dGlvbkRhdGE6OmVuY29kZSk6CisgICAgICAgIEFkZCBleHBsaWNpdCBjYXN0cyB0byBpbnQ2NF90 LgorICAgICAgICAoV2ViS2l0OjpCbG9iUmVnaXN0cmF0aW9uRGF0YTo6ZGVjb2RlKToKKyAgICAg ICAgVXNlIGludDY0X3QgaW5zdGVhZCBvZiBsb25nIGxvbmcuCisKKzIwMTMtMDctMDEgIEt3YW5n IFl1bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKwogICAgICAgICBbV0syXVtHdGtdIEFk ZCBzdXBwb3J0IGZvciBFTkFCTEVfTkVUV09SS19QUk9DRVNTIHRvIHRoZSBidWlsZCBzeXN0ZW0K ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODIzMQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRmlsZUFQSS9CbG9iUmVnaXN0cmF0 aW9uRGF0YS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvRmlsZUFQSS9CbG9iUmVnaXN0cmF0 aW9uRGF0YS5jcHAKaW5kZXggNDFhNzFhNmQxYzNhZjMyMGQ1ZDE5NWMzZGZkYjgxOWUyZjIwZTU3 Zi4uYTBkZDRkYzlhYzk2NmM5YzhjMDgwZmFhNzE3Yzk4NmQyZTFiOWZjZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvU2hhcmVkL0ZpbGVBUEkvQmxvYlJlZ2lzdHJhdGlvbkRhdGEuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9GaWxlQVBJL0Jsb2JSZWdpc3RyYXRpb25EYXRhLmNw cApAQCAtODgsMTQgKzg4LDE0IEBAIHZvaWQgQmxvYlJlZ2lzdHJhdGlvbkRhdGE6OmVuY29kZShD b3JlSVBDOjpBcmd1bWVudEVuY29kZXImIGVuY29kZXIpIGNvbnN0CiAgICAgICAgICAgICBlbmNv ZGVyIDw8IENvcmVJUEM6OkRhdGFSZWZlcmVuY2UocmVpbnRlcnByZXRfY2FzdDxjb25zdCB1aW50 OF90Kj4oaXRlbS5kYXRhLT5kYXRhKCkpLCBpdGVtLmRhdGEtPmxlbmd0aCgpKTsKICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICBjYXNlIEJsb2JEYXRhSXRlbTo6RmlsZToKLSAgICAgICAgICAg IGVuY29kZXIgPDwgaXRlbS5vZmZzZXQ7Ci0gICAgICAgICAgICBlbmNvZGVyIDw8IGl0ZW0ubGVu Z3RoOworICAgICAgICAgICAgZW5jb2RlciA8PCBzdGF0aWNfY2FzdDxpbnQ2NF90PihpdGVtLm9m ZnNldCk7CisgICAgICAgICAgICBlbmNvZGVyIDw8IHN0YXRpY19jYXN0PGludDY0X3Q+KGl0ZW0u bGVuZ3RoKTsKICAgICAgICAgICAgIGVuY29kZXIgPDwgaXRlbS5leHBlY3RlZE1vZGlmaWNhdGlv blRpbWU7CiAgICAgICAgICAgICBlbmNvZGVyIDw8IGl0ZW0ucGF0aDsKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBjYXNlIEJsb2JEYXRhSXRlbTo6QmxvYjoKLSAgICAgICAgICAgIGVuY29k ZXIgPDwgaXRlbS5vZmZzZXQ7Ci0gICAgICAgICAgICBlbmNvZGVyIDw8IGl0ZW0ubGVuZ3RoOwor ICAgICAgICAgICAgZW5jb2RlciA8PCBzdGF0aWNfY2FzdDxpbnQ2NF90PihpdGVtLm9mZnNldCk7 CisgICAgICAgICAgICBlbmNvZGVyIDw8IHN0YXRpY19jYXN0PGludDY0X3Q+KGl0ZW0ubGVuZ3Ro KTsKICAgICAgICAgICAgIGVuY29kZXIgPDwgaXRlbS51cmw7CiAgICAgICAgICAgICBicmVhazsK ICAgICAgICAgfQpAQCAtMTM4LDEwICsxMzgsMTAgQEAgYm9vbCBCbG9iUmVnaXN0cmF0aW9uRGF0 YTo6ZGVjb2RlKENvcmVJUEM6OkFyZ3VtZW50RGVjb2RlciYgZGVjb2RlciwgQmxvYlJlZ2lzdHIK ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGNhc2UgQmxvYkRhdGFJdGVt OjpGaWxlOiB7Ci0gICAgICAgICAgICBsb25nIGxvbmcgb2Zmc2V0OworICAgICAgICAgICAgaW50 NjRfdCBvZmZzZXQ7CiAgICAgICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKG9mZnNldCkpCiAg ICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICAgICAgbG9uZyBsb25nIGxlbmd0 aDsKKyAgICAgICAgICAgIGludDY0X3QgbGVuZ3RoOwogICAgICAgICAgICAgaWYgKCFkZWNvZGVy LmRlY29kZShsZW5ndGgpKQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAg ICAgIGRvdWJsZSBleHBlY3RlZE1vZGlmaWNhdGlvblRpbWU7CkBAIC0xNTQsMTAgKzE1NCwxMCBA QCBib29sIEJsb2JSZWdpc3RyYXRpb25EYXRhOjpkZWNvZGUoQ29yZUlQQzo6QXJndW1lbnREZWNv ZGVyJiBkZWNvZGVyLCBCbG9iUmVnaXN0cgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K ICAgICAgICAgY2FzZSBCbG9iRGF0YUl0ZW06OkJsb2I6IHsKLSAgICAgICAgICAgIGxvbmcgbG9u ZyBvZmZzZXQ7CisgICAgICAgICAgICBpbnQ2NF90IG9mZnNldDsKICAgICAgICAgICAgIGlmICgh ZGVjb2Rlci5kZWNvZGUob2Zmc2V0KSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgICAgICAgICBsb25nIGxvbmcgbGVuZ3RoOworICAgICAgICAgICAgaW50NjRfdCBsZW5ndGg7 CiAgICAgICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKGxlbmd0aCkpCiAgICAgICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgU3RyaW5nIHVybDsK