118219 2013-06-30 08:53:41 -0700 Calling WKBundlePageSetFooterBanner() API to set a banner to null does not actually hide the banner 2013-07-01 14:58:59 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan bdakin eflews.bot gyuyoung.kim jeffm rego+ews sam webkit-ews xan.lopez oldest_to_newest 904886 0 adachan 2013-06-30 08:53:41 -0700 Calling WKBundlePageSetFooterBanner() API to set a banner to null does not actually hide the banner. Looks like we need to call Page::addFooterWithHeight(0) in that case to properly remove the parent layer that hosts the banner. Ditto for the header banner. Patch coming soon. This is needed for <rdar://problem/13917901>. 904888 1 205775 adachan 2013-06-30 09:12:01 -0700 Created attachment 205775 Patch 904889 2 205775 eflews.bot 2013-06-30 09:16:55 -0700 Comment on attachment 205775 Patch Attachment 205775 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/995956 904890 3 205775 webkit-ews 2013-06-30 09:17:27 -0700 Comment on attachment 205775 Patch Attachment 205775 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/927397 904891 4 205776 adachan 2013-06-30 09:29:15 -0700 Created attachment 205776 Patch Replaced m_page with corePage(). 904892 5 205776 webkit-ews 2013-06-30 09:37:15 -0700 Comment on attachment 205776 Patch Attachment 205776 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/919584 904893 6 205776 eflews.bot 2013-06-30 09:38:06 -0700 Comment on attachment 205776 Patch Attachment 205776 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/943800 904896 7 205777 adachan 2013-06-30 10:16:15 -0700 Created attachment 205777 Patch Wrap the calls with #if ENABLE(RUBBER_BANDING). 904902 8 sam 2013-06-30 14:28:01 -0700 Ideally this would all be in the PageBanner class. Any reason we can't do this in PageBanner::detachFromPage()? 904923 9 adachan 2013-06-30 22:28:06 -0700 (In reply to comment #8) > Ideally this would all be in the PageBanner class. Any reason we can't do this in PageBanner::detachFromPage()? PageBanner::detachFromPage() is also called on the header and footer banners in WebPage's destructor. I don't know if it's necessary to hide the banners also for that case, and if there would be issues trying to hide the banners at that point. Another thing I can do is this: void WebPage::setHeaderPageBanner(PassRefPtr<PageBanner> pageBanner) { if (m_headerBanner) { m_headerBanner->hide(); m_headerBanner->detachFromPage(); } m_headerBanner = pageBanner; if (m_headerBanner) m_headerBanner->addToPage(PageBanner::Header, this); } In the common case where we are setting the page banner to another instance, the above code would remove the parent layer that hosts the banner and then recreate it again when we add in the new banner. What I had earlier in my patch would avoid that. I'm not sure if that optimization is worth the trouble though. If it's really worth not removing the parent layer that hosts the banner unless it's necessary, I could do this: void WebPage::setHeaderPageBanner(PassRefPtr<PageBanner> pageBanner) { if (m_headerBanner) { if (!pageBanner) m_headerBanner->hide(); m_headerBanner->detachFromPage(); } m_headerBanner = pageBanner; if (m_headerBanner) m_headerBanner->addToPage(PageBanner::Header, this); } Please let me know what you think. By the way, should we add a check in the beginning of the method to see if pageBanner is the same as m_headerBanner and bail early if it is? 905138 10 205831 adachan 2013-07-01 13:09:21 -0700 Created attachment 205831 Patch Fix this in PageBanner::detachFromPage() as suggested by Sam. 905156 11 adachan 2013-07-01 14:58:59 -0700 Committed: https://trac.webkit.org/changeset/152249 205775 2013-06-30 09:12:01 -0700 2013-06-30 09:29:15 -0700 Patch 0001-Properly-hide-the-header-and-footer-banners-if-they-.patch text/plain 2577 adachan RnJvbSA0NmEwNzM4NTAxOGI1NjUwNmYxYzk2NGZhODAzOTc3ZTYzOTFlNDIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IFN1 biwgMzAgSnVuIDIwMTMgMDk6MDg6MDAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBQcm9wZXJseSBo aWRlIHRoZSBoZWFkZXIgYW5kIGZvb3RlciBiYW5uZXJzIGlmIHRoZXkgYXJlIHNldAogdG8gbnVs bC4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODIxOQoKUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJZiB0aGUgZm9vdGVyIGJhbm5lciBpcyBzZXQgdG8gbnVs bCwgd2Ugc2hvdWxkIGNhbGwgUGFnZTo6YWRkRm9vdGVyV2l0aEhlaWdodCgwKQp0byByZW1vdmUg dGhlIHBhcmVudCBsYXllciB0aGF0IGhvc3RzIHRoZSBiYW5uZXIuIFNpbWlsYXJseSBmb3IgdGhl IGhlYWRlciBiYW5uZXIuCgoqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKFdlYktp dDo6V2ViUGFnZTo6c2V0SGVhZGVyUGFnZUJhbm5lcik6IENhbGwgUGFnZTo6YWRkSGVhZGVyV2l0 aEhlaWdodCgwKS4KKFdlYktpdDo6V2ViUGFnZTo6c2V0Rm9vdGVyUGFnZUJhbm5lcik6IENhbGwg UGFnZTo6YWRkRm9vdGVyV2l0aEhlaWdodCgwKS4KLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgfCAxNCArKysrKysrKysrKysrKwogU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIHwgIDQgKysrKwogMiBmaWxlcyBjaGFu Z2VkLCAxOCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDk2ZjRjYmMuLmFhMjEzM2MgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNi0zMCAgQWRhIENoYW4gIDxhZGFjaGFu QGFwcGxlLmNvbT4KKworICAgICAgICBQcm9wZXJseSBoaWRlIHRoZSBoZWFkZXIgYW5kIGZvb3Rl ciBiYW5uZXJzIGlmIHRoZXkgYXJlIHNldCB0byBudWxsLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJZiB0aGUgZm9vdGVyIGJhbm5lciBp cyBzZXQgdG8gbnVsbCwgd2Ugc2hvdWxkIGNhbGwgUGFnZTo6YWRkRm9vdGVyV2l0aEhlaWdodCgw KQorICAgICAgICB0byByZW1vdmUgdGhlIHBhcmVudCBsYXllciB0aGF0IGhvc3RzIHRoZSBiYW5u ZXIuIFNpbWlsYXJseSBmb3IgdGhlIGhlYWRlciBiYW5uZXIuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNldEhl YWRlclBhZ2VCYW5uZXIpOiBDYWxsIFBhZ2U6OmFkZEhlYWRlcldpdGhIZWlnaHQoMCkuCisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNldEZvb3RlclBhZ2VCYW5uZXIpOiBDYWxsIFBhZ2U6OmFk ZEZvb3RlcldpdGhIZWlnaHQoMCkuCisKIDIwMTMtMDYtMjggIEFuZHJlYXMgS2xpbmcgIDxha2xp bmdAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBXaW5kb3dzIGJ1aWxkcyBhZnRlciBkZXByZWNh dGVkQ2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKSByZW1vdmFsLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDBlZGE3YjAuLmM1MmQx ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAK QEAgLTE0NjMsNiArMTQ2Myw4IEBAIHZvaWQgV2ViUGFnZTo6c2V0SGVhZGVyUGFnZUJhbm5lcihQ YXNzUmVmUHRyPFBhZ2VCYW5uZXI+IHBhZ2VCYW5uZXIpCiAKICAgICBpZiAobV9oZWFkZXJCYW5u ZXIpCiAgICAgICAgIG1faGVhZGVyQmFubmVyLT5hZGRUb1BhZ2UoUGFnZUJhbm5lcjo6SGVhZGVy LCB0aGlzKTsKKyAgICBlbHNlCisgICAgICAgIG1fcGFnZS0+YWRkSGVhZGVyV2l0aEhlaWdodCgw KTsKIH0KIAogUGFnZUJhbm5lciogV2ViUGFnZTo6aGVhZGVyUGFnZUJhbm5lcigpCkBAIC0xNDc5 LDYgKzE0ODEsOCBAQCB2b2lkIFdlYlBhZ2U6OnNldEZvb3RlclBhZ2VCYW5uZXIoUGFzc1JlZlB0 cjxQYWdlQmFubmVyPiBwYWdlQmFubmVyKQogCiAgICAgaWYgKG1fZm9vdGVyQmFubmVyKQogICAg ICAgICBtX2Zvb3RlckJhbm5lci0+YWRkVG9QYWdlKFBhZ2VCYW5uZXI6OkZvb3RlciwgdGhpcyk7 CisgICAgZWxzZQorICAgICAgICBtX3BhZ2UtPmFkZEZvb3RlcldpdGhIZWlnaHQoMCk7CiB9CiAK IFBhZ2VCYW5uZXIqIFdlYlBhZ2U6OmZvb3RlclBhZ2VCYW5uZXIoKQotLSAKMS44LjIuMSAoQXBw bGUgR2l0LTQ1KQoK 205776 2013-06-30 09:29:15 -0700 2013-06-30 10:16:15 -0700 Patch 0001-Properly-hide-the-header-and-footer-banners-if-they-.patch text/plain 2585 adachan RnJvbSBlOGYyNTlmY2UzMjZmM2MzNmNkM2RjYmJhMDkwNWZhMTU5YzIxMzdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IFN1 biwgMzAgSnVuIDIwMTMgMDk6MDg6MDAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBQcm9wZXJseSBo aWRlIHRoZSBoZWFkZXIgYW5kIGZvb3RlciBiYW5uZXJzIGlmIHRoZXkgYXJlIHNldAogdG8gbnVs bC4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODIxOQoKUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJZiB0aGUgZm9vdGVyIGJhbm5lciBpcyBzZXQgdG8gbnVs bCwgd2Ugc2hvdWxkIGNhbGwgUGFnZTo6YWRkRm9vdGVyV2l0aEhlaWdodCgwKQp0byByZW1vdmUg dGhlIHBhcmVudCBsYXllciB0aGF0IGhvc3RzIHRoZSBiYW5uZXIuIFNpbWlsYXJseSBmb3IgdGhl IGhlYWRlciBiYW5uZXIuCgoqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKFdlYktp dDo6V2ViUGFnZTo6c2V0SGVhZGVyUGFnZUJhbm5lcik6IENhbGwgUGFnZTo6YWRkSGVhZGVyV2l0 aEhlaWdodCgwKS4KKFdlYktpdDo6V2ViUGFnZTo6c2V0Rm9vdGVyUGFnZUJhbm5lcik6IENhbGwg UGFnZTo6YWRkRm9vdGVyV2l0aEhlaWdodCgwKS4KLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgfCAxNCArKysrKysrKysrKysrKwogU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIHwgIDQgKysrKwogMiBmaWxlcyBjaGFu Z2VkLCAxOCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDk2ZjRjYmMuLmFhMjEzM2MgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMy0wNi0zMCAgQWRhIENoYW4gIDxhZGFjaGFu QGFwcGxlLmNvbT4KKworICAgICAgICBQcm9wZXJseSBoaWRlIHRoZSBoZWFkZXIgYW5kIGZvb3Rl ciBiYW5uZXJzIGlmIHRoZXkgYXJlIHNldCB0byBudWxsLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJZiB0aGUgZm9vdGVyIGJhbm5lciBp cyBzZXQgdG8gbnVsbCwgd2Ugc2hvdWxkIGNhbGwgUGFnZTo6YWRkRm9vdGVyV2l0aEhlaWdodCgw KQorICAgICAgICB0byByZW1vdmUgdGhlIHBhcmVudCBsYXllciB0aGF0IGhvc3RzIHRoZSBiYW5u ZXIuIFNpbWlsYXJseSBmb3IgdGhlIGhlYWRlciBiYW5uZXIuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNldEhl YWRlclBhZ2VCYW5uZXIpOiBDYWxsIFBhZ2U6OmFkZEhlYWRlcldpdGhIZWlnaHQoMCkuCisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2U6OnNldEZvb3RlclBhZ2VCYW5uZXIpOiBDYWxsIFBhZ2U6OmFk ZEZvb3RlcldpdGhIZWlnaHQoMCkuCisKIDIwMTMtMDYtMjggIEFuZHJlYXMgS2xpbmcgIDxha2xp bmdAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBXaW5kb3dzIGJ1aWxkcyBhZnRlciBkZXByZWNh dGVkQ2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKSByZW1vdmFsLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDBlZGE3YjAuLjUzNjQ4 Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAK QEAgLTE0NjMsNiArMTQ2Myw4IEBAIHZvaWQgV2ViUGFnZTo6c2V0SGVhZGVyUGFnZUJhbm5lcihQ YXNzUmVmUHRyPFBhZ2VCYW5uZXI+IHBhZ2VCYW5uZXIpCiAKICAgICBpZiAobV9oZWFkZXJCYW5u ZXIpCiAgICAgICAgIG1faGVhZGVyQmFubmVyLT5hZGRUb1BhZ2UoUGFnZUJhbm5lcjo6SGVhZGVy LCB0aGlzKTsKKyAgICBlbHNlCisgICAgICAgIGNvcmVQYWdlKCktPmFkZEhlYWRlcldpdGhIZWln aHQoMCk7CiB9CiAKIFBhZ2VCYW5uZXIqIFdlYlBhZ2U6OmhlYWRlclBhZ2VCYW5uZXIoKQpAQCAt MTQ3OSw2ICsxNDgxLDggQEAgdm9pZCBXZWJQYWdlOjpzZXRGb290ZXJQYWdlQmFubmVyKFBhc3NS ZWZQdHI8UGFnZUJhbm5lcj4gcGFnZUJhbm5lcikKIAogICAgIGlmIChtX2Zvb3RlckJhbm5lcikK ICAgICAgICAgbV9mb290ZXJCYW5uZXItPmFkZFRvUGFnZShQYWdlQmFubmVyOjpGb290ZXIsIHRo aXMpOworICAgIGVsc2UKKyAgICAgICAgY29yZVBhZ2UoKS0+YWRkRm9vdGVyV2l0aEhlaWdodCgw KTsKIH0KIAogUGFnZUJhbm5lciogV2ViUGFnZTo6Zm9vdGVyUGFnZUJhbm5lcigpCi0tIAoxLjgu Mi4xIChBcHBsZSBHaXQtNDUpCgo= 205777 2013-06-30 10:16:15 -0700 2013-07-01 13:09:21 -0700 Patch 0001-Properly-hide-the-header-and-footer-banners-if-they-.patch text/plain 2663 adachan RnJvbSAxNDZjOGJkYTM2OWQ5MjdjMDI0YTFlNzRmZDBkNmNiMjY3NjJlZmYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IFN1 biwgMzAgSnVuIDIwMTMgMDk6MDg6MDAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBQcm9wZXJseSBo aWRlIHRoZSBoZWFkZXIgYW5kIGZvb3RlciBiYW5uZXJzIGlmIHRoZXkgYXJlIHNldAogdG8gbnVs bC4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODIxOQoKUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpJZiB0aGUgZm9vdGVyIGJhbm5lciBpcyBzZXQgdG8gbnVs bCwgd2Ugc2hvdWxkIGNhbGwgUGFnZTo6YWRkRm9vdGVyV2l0aEhlaWdodCgwKQp0byByZW1vdmUg dGhlIHBhcmVudCBsYXllciB0aGF0IGhvc3RzIHRoZSBiYW5uZXIuIFNpbWlsYXJseSBmb3IgdGhl IGhlYWRlciBiYW5uZXIuCgoqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKFdlYktp dDo6V2ViUGFnZTo6c2V0SGVhZGVyUGFnZUJhbm5lcik6IENhbGwgUGFnZTo6YWRkSGVhZGVyV2l0 aEhlaWdodCgwKS4KKFdlYktpdDo6V2ViUGFnZTo6c2V0Rm9vdGVyUGFnZUJhbm5lcik6IENhbGwg UGFnZTo6YWRkRm9vdGVyV2l0aEhlaWdodCgwKS4KLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgfCAxNCArKysrKysrKysrKysrKwogU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIHwgIDggKysrKysrKysKIDIgZmlsZXMg Y2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA5NmY0Y2JjLi5hYTIxMzNj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMDYtMzAgIEFkYSBDaGFuICA8YWRh Y2hhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUHJvcGVybHkgaGlkZSB0aGUgaGVhZGVyIGFuZCBm b290ZXIgYmFubmVycyBpZiB0aGV5IGFyZSBzZXQgdG8gbnVsbC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODIxOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSWYgdGhlIGZvb3RlciBiYW5u ZXIgaXMgc2V0IHRvIG51bGwsIHdlIHNob3VsZCBjYWxsIFBhZ2U6OmFkZEZvb3RlcldpdGhIZWln aHQoMCkKKyAgICAgICAgdG8gcmVtb3ZlIHRoZSBwYXJlbnQgbGF5ZXIgdGhhdCBob3N0cyB0aGUg YmFubmVyLiBTaW1pbGFybHkgZm9yIHRoZSBoZWFkZXIgYmFubmVyLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpz ZXRIZWFkZXJQYWdlQmFubmVyKTogQ2FsbCBQYWdlOjphZGRIZWFkZXJXaXRoSGVpZ2h0KDApLgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzZXRGb290ZXJQYWdlQmFubmVyKTogQ2FsbCBQYWdl OjphZGRGb290ZXJXaXRoSGVpZ2h0KDApLgorCiAyMDEzLTA2LTI4ICBBbmRyZWFzIEtsaW5nICA8 YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggV2luZG93cyBidWlsZHMgYWZ0ZXIgZGVw cmVjYXRlZENoYXJhY3RlcnNXaXRoTnVsbFRlcm1pbmF0aW9uKCkgcmVtb3ZhbC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCAwZWRhN2IwLi5j NTEyYmJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu Y3BwCkBAIC0xNDYzLDYgKzE0NjMsMTAgQEAgdm9pZCBXZWJQYWdlOjpzZXRIZWFkZXJQYWdlQmFu bmVyKFBhc3NSZWZQdHI8UGFnZUJhbm5lcj4gcGFnZUJhbm5lcikKIAogICAgIGlmIChtX2hlYWRl ckJhbm5lcikKICAgICAgICAgbV9oZWFkZXJCYW5uZXItPmFkZFRvUGFnZShQYWdlQmFubmVyOjpI ZWFkZXIsIHRoaXMpOworI2lmIEVOQUJMRShSVUJCRVJfQkFORElORykKKyAgICBlbHNlCisgICAg ICAgIGNvcmVQYWdlKCktPmFkZEhlYWRlcldpdGhIZWlnaHQoMCk7CisjZW5kaWYKIH0KIAogUGFn ZUJhbm5lciogV2ViUGFnZTo6aGVhZGVyUGFnZUJhbm5lcigpCkBAIC0xNDc5LDYgKzE0ODMsMTAg QEAgdm9pZCBXZWJQYWdlOjpzZXRGb290ZXJQYWdlQmFubmVyKFBhc3NSZWZQdHI8UGFnZUJhbm5l cj4gcGFnZUJhbm5lcikKIAogICAgIGlmIChtX2Zvb3RlckJhbm5lcikKICAgICAgICAgbV9mb290 ZXJCYW5uZXItPmFkZFRvUGFnZShQYWdlQmFubmVyOjpGb290ZXIsIHRoaXMpOworI2lmIEVOQUJM RShSVUJCRVJfQkFORElORykKKyAgICBlbHNlCisgICAgICAgIGNvcmVQYWdlKCktPmFkZEZvb3Rl cldpdGhIZWlnaHQoMCk7CisjZW5kaWYKIH0KIAogUGFnZUJhbm5lciogV2ViUGFnZTo6Zm9vdGVy UGFnZUJhbm5lcigpCi0tIAoxLjguMi4xIChBcHBsZSBHaXQtNDUpCgo= 205831 2013-07-01 13:09:21 -0700 2013-07-01 13:09:52 -0700 Patch 0001-Properly-hide-the-header-and-footer-banners-if-they-.patch text/plain 2251 adachan RnJvbSA0NzRjNDRmNmQxMDhjMzYxZDcwMTFiMDJkYjI3MDA3YTljMmI2ZGMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IE1v biwgMSBKdWwgMjAxMyAxMzowNTo1MyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIFByb3Blcmx5IGhp ZGUgdGhlIGhlYWRlciBhbmQgZm9vdGVyIGJhbm5lcnMgaWYgdGhleSBhcmUgc2V0CiB0byBudWxs LiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MjE5CgpSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KCkNhbGwgUGFnZTo6YWRkRm9vdGVyV2l0aEhlaWdodCgwKSB0 byByZW1vdmUgdGhlIHBhcmVudCBsYXllciB0aGF0IGhvc3RzIHRoZSBiYW5uZXIgd2hlbgp0aGUg Zm9vdGVyIGJhbm5lciBpcyBkZXRhY2hlZC4gU2ltaWxhcmx5IGZvciB0aGUgaGVhZGVyIGJhbm5l ci4KCiogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QYWdlQmFubmVyTWFjLm1tOgooV2ViS2l0OjpQ YWdlQmFubmVyOjpkZXRhY2hGcm9tUGFnZSk6Ci0tLQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIC4uLi9XZWJQ cm9jZXNzL1dlYlBhZ2UvbWFjL1BhZ2VCYW5uZXJNYWMubW0gICAgICAgIHwgICAgNiArKysrKysK IDIgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA5NmY0Y2Jj Li41ODNhNzcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDctMDEgIEFkYSBD aGFuICA8YWRhY2hhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUHJvcGVybHkgaGlkZSB0aGUgaGVh ZGVyIGFuZCBmb290ZXIgYmFubmVycyBpZiB0aGV5IGFyZSBzZXQgdG8gbnVsbC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODIxOQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQ2FsbCBQYWdl OjphZGRGb290ZXJXaXRoSGVpZ2h0KDApIHRvIHJlbW92ZSB0aGUgcGFyZW50IGxheWVyIHRoYXQg aG9zdHMgdGhlIGJhbm5lciB3aGVuCisgICAgICAgIHRoZSBmb290ZXIgYmFubmVyIGlzIGRldGFj aGVkLiBTaW1pbGFybHkgZm9yIHRoZSBoZWFkZXIgYmFubmVyLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL21hYy9QYWdlQmFubmVyTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpQYWdl QmFubmVyOjpkZXRhY2hGcm9tUGFnZSk6CisKIDIwMTMtMDYtMjggIEFuZHJlYXMgS2xpbmcgIDxh a2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBXaW5kb3dzIGJ1aWxkcyBhZnRlciBkZXBy ZWNhdGVkQ2hhcmFjdGVyc1dpdGhOdWxsVGVybWluYXRpb24oKSByZW1vdmFsLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QYWdlQmFubmVyTWFjLm1t IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9QYWdlQmFubmVyTWFjLm1t CmluZGV4IGM4NGJkNmQuLjFlNDJiMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvUGFnZUJhbm5lck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1BhZ2VCYW5uZXJNYWMubW0KQEAgLTgxLDYgKzgxLDEyIEBA IHZvaWQgUGFnZUJhbm5lcjo6ZGlkQWRkUGFyZW50TGF5ZXIoR3JhcGhpY3NMYXllciogcGFyZW50 TGF5ZXIpCiAKIHZvaWQgUGFnZUJhbm5lcjo6ZGV0YWNoRnJvbVBhZ2UoKQogeworICAgIC8vIFdl IGNhbiBoaWRlIHRoZSBiYW5uZXIgYnkgcmVtb3ZpbmcgdGhlIHBhcmVudCBsYXllciB0aGF0IGhv c3RzIGl0LgorICAgIGlmIChtX3R5cGUgPT0gSGVhZGVyKQorICAgICAgICBtX3dlYlBhZ2UtPmNv cmVQYWdlKCktPmFkZEhlYWRlcldpdGhIZWlnaHQoMCk7CisgICAgZWxzZSBpZiAobV90eXBlID09 IEZvb3RlcikKKyAgICAgICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5hZGRGb290ZXJXaXRoSGVp Z2h0KDApOworCiAgICAgbV90eXBlID0gTm90U2V0OwogICAgIG1fd2ViUGFnZSA9IDA7CiB9Ci0t IAoxLjcuOS42IChBcHBsZSBHaXQtMzEuMSkKCg==