118218 2013-06-29 12:47:48 -0700 Avoid calling isSimpleContainerCompositingLayer() an extra time 2013-06-29 13:23:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin commit-queue esprehn+autocc glenn noam simon.fraser thorton oldest_to_newest 904872 0 simon.fraser 2013-06-29 12:47:48 -0700 Avoid calling isSimpleContainerCompositingLayer() an extra time 904873 1 205772 simon.fraser 2013-06-29 12:48:59 -0700 Created attachment 205772 Patch 904874 2 205772 thorton 2013-06-29 12:56:14 -0700 Comment on attachment 205772 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205772&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:982 > + bool hasPaintedContent = containsPaintedContent(isSimpleContainer); Wait, do you even need to pass it in? In the previous case, you were not calling in ever if it was false, so you can assume it's true? And, before, you were avoiding the function call at all... 904876 3 simon.fraser 2013-06-29 13:23:22 -0700 https://trac.webkit.org/r152213 205772 2013-06-29 12:48:59 -0700 2013-06-29 12:56:14 -0700 Patch bug-118218-20130629124658.patch text/plain 3355 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDE2ZTE5ZjA0NTg2ZTEy YjY2ZGRmYjQxZjliZTE4ODdiMTVhNTdhMy4uOTUzN2FlNjM3ODhjOGNmMzcyYTIyNjNmYjIyYjQw ODliOGE5NjE3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTA2LTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIEF2b2lkIGNhbGxp bmcgaXNTaW1wbGVDb250YWluZXJDb21wb3NpdGluZ0xheWVyKCkgYW4gZXh0cmEgdGltZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MjE4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY29udGFpbnNQYWlu dGVkQ29udGVudCgpIGNhbGxlZCBpc1NpbXBsZUNvbnRhaW5lckNvbXBvc2l0aW5nTGF5ZXIoKSwg d2hpY2gKKyAgICAgICAgaXMgbm90IHBhcnRpY3VsYXJseSBjaGVhcC4gQnV0IHRoZSBjYWxsZXIg YWxyZWFkeSBoYXMgdGhpcyBpbmZvcm1hdGlvbiwKKyAgICAgICAgc28gcGFzcyBpdCBpbi4KKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVEcmF3c0NvbnRlbnQpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjpjb250YWluc1BhaW50ZWRDb250ZW50KToKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmg6CisKKzIwMTMtMDYtMjkgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAgQXZvaWQgY2Fs bGluZyBpbnRvIE9iamVjdGl2ZS1DIGV2ZXJ5IHRpbWUgd2UgZ2V0IHRoZSBzY3JvbGxiYXIgd2lk dGgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODIx NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNr aW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3Bw CmluZGV4IDE3Y2RlNzgwOTk2ZGRhOGEwYjYzNzhlOTVhYmQyMDdmNTIyN2NjZDYuLmQwYjc4ZDgz MWM2ZGM5ZTI3YmZjOGE3OWQ3ZWViN2Y3YTA5Y2NkMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC05NzksNyArOTc5LDcgQEAgdm9p ZCBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZURyYXdzQ29udGVudChib29sIGlzU2ltcGxlQ29u dGFpbmVyKQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgYm9vbCBoYXNQYWludGVkQ29u dGVudCA9ICFpc1NpbXBsZUNvbnRhaW5lciAmJiBjb250YWluc1BhaW50ZWRDb250ZW50KCk7Cisg ICAgYm9vbCBoYXNQYWludGVkQ29udGVudCA9IGNvbnRhaW5zUGFpbnRlZENvbnRlbnQoaXNTaW1w bGVDb250YWluZXIpOwogCiAgICAgLy8gRklYTUU6IHdlIGNvdWxkIHJlZmluZSB0aGlzIHRvIG9u bHkgYWxsb2NhdGUgYmFja2luZyBmb3Igb25lIG9mIHRoZXNlIGxheWVycyBpZiBwb3NzaWJsZS4K ICAgICBtX2dyYXBoaWNzTGF5ZXItPnNldERyYXdzQ29udGVudChoYXNQYWludGVkQ29udGVudCk7 CkBAIC0xNjUyLDkgKzE2NTIsOSBAQCBib29sIFJlbmRlckxheWVyQmFja2luZzo6aGFzVmlzaWJs ZU5vbkNvbXBvc2l0aW5nRGVzY2VuZGFudExheWVycygpIGNvbnN0CiAgICAgcmV0dXJuIGhhc1Zp c2libGVOb25Db21wb3NpdGluZ0Rlc2NlbmRhbnQobV9vd25pbmdMYXllcik7CiB9CiAKLWJvb2wg UmVuZGVyTGF5ZXJCYWNraW5nOjpjb250YWluc1BhaW50ZWRDb250ZW50KCkgY29uc3QKK2Jvb2wg UmVuZGVyTGF5ZXJCYWNraW5nOjpjb250YWluc1BhaW50ZWRDb250ZW50KGJvb2wgaXNTaW1wbGVD b250YWluZXIpIGNvbnN0CiB7Ci0gICAgaWYgKGlzU2ltcGxlQ29udGFpbmVyQ29tcG9zaXRpbmdM YXllcigpIHx8IHBhaW50c0ludG9XaW5kb3coKSB8fCBwYWludHNJbnRvQ29tcG9zaXRlZEFuY2Vz dG9yKCkgfHwgbV9hcnRpZmljaWFsbHlJbmZsYXRlZEJvdW5kcyB8fCBtX293bmluZ0xheWVyLT5p c1JlZmxlY3Rpb24oKSkKKyAgICBpZiAoaXNTaW1wbGVDb250YWluZXIgfHwgcGFpbnRzSW50b1dp bmRvdygpIHx8IHBhaW50c0ludG9Db21wb3NpdGVkQW5jZXN0b3IoKSB8fCBtX2FydGlmaWNpYWxs eUluZmxhdGVkQm91bmRzIHx8IG1fb3duaW5nTGF5ZXItPmlzUmVmbGVjdGlvbigpKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAoaXNEaXJlY3RseUNvbXBvc2l0ZWRJbWFnZSgpKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5o IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5oCmluZGV4IDZj NGM4N2FkMTg3MzZjZWE3NzJmZWUxNTFjNDkxMjc3M2VjMjFhZTYuLjRkYjYxODc0Nzg1ZjYzZGZm NzM2NzEwZjMwYjkzMDliNDg0OTA2NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJCYWNraW5nLmgKQEAgLTI1NCw3ICsyNTQsNyBAQCBwcml2YXRlOgogICAgIC8v IFJldHVybnMgdHJ1ZSBpZiB0aGlzIGNvbXBvc2l0aW5nIGxheWVyIGhhcyBubyB2aXNpYmxlIGNv bnRlbnQuCiAgICAgYm9vbCBpc1NpbXBsZUNvbnRhaW5lckNvbXBvc2l0aW5nTGF5ZXIoKSBjb25z dDsKICAgICAvLyBSZXR1cm5zIHRydWUgaWYgdGhpcyBsYXllciBoYXMgY29udGVudCB0aGF0IG5l ZWRzIHRvIGJlIHJlbmRlcmVkIGJ5IHBhaW50aW5nIGludG8gdGhlIGJhY2tpbmcgc3RvcmUuCi0g ICAgYm9vbCBjb250YWluc1BhaW50ZWRDb250ZW50KCkgY29uc3Q7CisgICAgYm9vbCBjb250YWlu c1BhaW50ZWRDb250ZW50KGJvb2wgaXNTaW1wbGVDb250YWluZXIpIGNvbnN0OwogICAgIC8vIFJl dHVybnMgdHJ1ZSBpZiB0aGUgUmVuZGVyTGF5ZXIganVzdCBjb250YWlucyBhbiBpbWFnZSB0aGF0 IHdlIGNhbiBjb21wb3NpdGUgZGlyZWN0bHkuCiAgICAgYm9vbCBpc0RpcmVjdGx5Q29tcG9zaXRl ZEltYWdlKCkgY29uc3Q7CiAgICAgdm9pZCB1cGRhdGVJbWFnZUNvbnRlbnRzKCk7Cg==