118217 2013-06-29 12:35:49 -0700 Avoid calling RenderLayerBacking::resetContentsRect() if possible 2013-07-22 12:33:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser cmarcelo commit-queue esprehn+autocc glenn luiz noam oldest_to_newest 904871 0 simon.fraser 2013-06-29 12:35:49 -0700 Calling RenderLayerBacking::resetContentsRect() every time from updateGraphicsLayerGeometry() shows up on profiles, because calling enderer())->contentBoxRect() involves a bunch of virtual function calls. And we only need to call resetContentsRect() when the image tiling stuff has changed it, so calling this every time is overkill. 904878 1 noam 2013-06-29 14:19:23 -0700 (In reply to comment #0) > Calling RenderLayerBacking::resetContentsRect() every time from updateGraphicsLayerGeometry() shows up on profiles, because calling enderer())->contentBoxRect() involves a bunch of virtual function calls. And we only need to call resetContentsRect() when the image tiling stuff has changed it, so calling this every time is overkill. We also need to call resetContentsRect when the contentsRect of the RenderObject has changed; Previously we were calling setContentsRect(renderer()->contentsBox()) in updateGraphicsLayerGeometry() so this behavior has not changed (though now it appears in profile since it's in its own function...). 904998 2 205804 noam 2013-07-01 06:13:29 -0700 Created attachment 205804 Patch 905067 3 205804 commit-queue 2013-07-01 09:32:48 -0700 Comment on attachment 205804 Patch Clearing flags on attachment: 205804 Committed r152227: <http://trac.webkit.org/changeset/152227> 905068 4 commit-queue 2013-07-01 09:32:50 -0700 All reviewed patches have been landed. Closing bug. 910765 5 ap 2013-07-22 12:33:55 -0700 This caused bug 118951. 205804 2013-07-01 06:13:29 -0700 2013-07-01 09:32:48 -0700 Patch bug-118217-20130701151121.patch text/plain 3618 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTE3YTFjMDNlYTMzYjc2 OTliMWQxZDk0NWRiZjNjY2NhYzJhZTFmYy4uNjMyYjdiZGYzMjE5NTQwNzczYzRiMzRlOWI5N2Ji ZTVkZmI5ODdiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEzLTA3LTAxICBOb2Ft IFJvc2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBBdm9pZCBjYWxsaW5nIFJl bmRlckxheWVyQmFja2luZzo6cmVzZXRDb250ZW50c1JlY3QoKSBpZiBwb3NzaWJsZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MjE3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsbCByZXNldENvbnRl bnRzUmVjdCgpIG9ubHkgaWYgdGhlIGxheWVyIGhhcyBhIGNvbnRlbnRzTGF5ZXIuCisgICAgICAg IE90aGVyd2lzZSB0aGUgY29udGVudHNSZWN0IGlzIHJlZHVuZGFudCBmb3IgdGhlIEdyYXBoaWNz TGF5ZXIuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0gb3B0aW1pemF0aW9uIG9ubHkuIFRoaXMg aXMgY292ZXJlZCBieSBwbGVudHkgb2YgZXhpc3RpbmcKKyAgICAgICAgdGVzdHMgaW4gd2ViZ2wv IGFuZCBjb21wb3NpdGluZy8uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv R3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz TGF5ZXJUZXh0dXJlTWFwcGVyOjpoYXNDb250ZW50c0xheWVyKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmg6 CisgICAgICAgICAgICBBZGRlZCBoYXNDb250ZW50c0xheWVyIGNhbGxzIGZvciBUZXh0dXJlTWFw cGVyL0Nvb3JkaW5hdGVkR3JhcGhpY3MKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRh dGVHcmFwaGljc0xheWVyR2VvbWV0cnkpOgorCiAyMDEzLTA3LTAxICBLYW5naWwgSGFuICA8a2Fu Z2lsLmhhbkBzYW1zdW5nLmNvbT4KIAogICAgICAgICBBZG9wdCB0b0hUTUxUZXh0QXJlYUVsZW1l bnQgZm9yIGNvZGUgY2xlYW51cApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIu aAppbmRleCBmMTZkYmUxNTFkZTg0YjQ3ZWVlODY4MDY1NWE4Yjc2NDZkMzVkMTRhLi42MWRkZmI5 MmFkNmViNTczODhmYzk2NzAxNGZkYWMxYWMwNTdlZWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NM YXllclRleHR1cmVNYXBwZXIuaApAQCAtNzYsNiArNzYsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVh bCB2b2lkIGZsdXNoQ29tcG9zaXRpbmdTdGF0ZShjb25zdCBGbG9hdFJlY3QmKTsKICAgICB2aXJ0 dWFsIHZvaWQgZmx1c2hDb21wb3NpdGluZ1N0YXRlRm9yVGhpc0xheWVyT25seSgpOwogICAgIHZp cnR1YWwgdm9pZCBzZXROYW1lKGNvbnN0IFN0cmluZyYgbmFtZSk7CisgICAgdmlydHVhbCBib29s IGhhc0NvbnRlbnRzTGF5ZXIoKSBjb25zdCB7IHJldHVybiBtX2NvbnRlbnRzTGF5ZXI7IH0KICAg ICB2aXJ0dWFsIFBsYXRmb3JtTGF5ZXIqIHBsYXRmb3JtTGF5ZXIoKSBjb25zdCB7IHJldHVybiBt X2NvbnRlbnRzTGF5ZXI7IH0KIAogICAgIGlubGluZSBpbnQgY2hhbmdlTWFzaygpIGNvbnN0IHsg cmV0dXJuIG1fY2hhbmdlTWFzazsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nv b3JkaW5hdGVkR3JhcGhpY3NMYXllci5oCmluZGV4IDBlYTY5NzAyMWUzZGI1OTYxZjQ2OGJjMjdk MTc5MzhiZTBhMWE3MGEuLmNmYmMyMTM1ZDg0NDBlMzI4MDQzMDMxNTYxNzc1NWI3NDM0MzQ1NzAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29y ZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xh eWVyLmgKQEAgLTExMCw2ICsxMTAsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHJlbW92 ZUFuaW1hdGlvbihjb25zdCBTdHJpbmcmKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgc3Vz cGVuZEFuaW1hdGlvbnMoZG91YmxlIHRpbWUpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBy ZXN1bWVBbmltYXRpb25zKCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCBib29sIGhhc0NvbnRlbnRz TGF5ZXIoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiBtX2NhbnZhc1BsYXRmb3JtTGF5ZXIgfHwg bV9jb21wb3NpdGVkSW1hZ2U7IH0KIAogICAgIHZvaWQgc3luY1BlbmRpbmdTdGF0ZUNoYW5nZXNJ bmNsdWRpbmdTdWJMYXllcnMoKTsKICAgICB2b2lkIHVwZGF0ZUNvbnRlbnRCdWZmZXJzSW5jbHVk aW5nU3ViTGF5ZXJzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuY3BwCmluZGV4IGQwYjc4ZDgzMWM2ZGM5ZTI3YmZjOGE3OWQ3ZWViN2Y3YTA5Y2Nk MzcuLjUzYjBmYzFjNmY0YTdjMTQ4YTQwMWU2MDFlMTA2YWFhM2RjMjYxMWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC04NjEsNyAr ODYxLDcgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUdyYXBoaWNzTGF5ZXJHZW9t ZXRyeSgpCiAKICAgICBib29sIGRpZFVwZGF0ZUNvbnRlbnRzUmVjdCA9IGZhbHNlOwogICAgIHVw ZGF0ZURpcmVjdGx5Q29tcG9zaXRlZENvbnRlbnRzKGlzU2ltcGxlQ29udGFpbmVyLCBkaWRVcGRh dGVDb250ZW50c1JlY3QpOwotICAgIGlmICghZGlkVXBkYXRlQ29udGVudHNSZWN0KQorICAgIGlm ICghZGlkVXBkYXRlQ29udGVudHNSZWN0ICYmIG1fZ3JhcGhpY3NMYXllci0+aGFzQ29udGVudHNM YXllcigpKQogICAgICAgICByZXNldENvbnRlbnRzUmVjdCgpOwogCiAgICAgdXBkYXRlRHJhd3ND b250ZW50KGlzU2ltcGxlQ29udGFpbmVyKTsK