118216 2013-06-29 11:51:24 -0700 Avoid calling into Objective-C every time we get the scrollbar width 2013-07-01 11:57:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser andersca bdakin sam simon.fraser oldest_to_newest 904868 0 simon.fraser 2013-06-29 11:51:24 -0700 Avoid calling into Objective-C every time we get the scrollbar width 904869 1 205771 simon.fraser 2013-06-29 11:54:20 -0700 Created attachment 205771 Patch 904870 2 205771 ggaren 2013-06-29 12:18:53 -0700 Comment on attachment 205771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205771&action=review r=me > Source/WebCore/ChangeLog:12 > + is one that gets called when the user changes the setting in System Preferences. "is the function" maybe? > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:136 > +static bool gUseOverlayScrollbars = false; Can we call this gUsesOverlayScrollbars, to match the function name? (I added an 's'.) 904877 3 simon.fraser 2013-06-29 13:28:06 -0700 https://trac.webkit.org/r152214 905119 4 205771 darin 2013-07-01 11:57:31 -0700 Comment on attachment 205771 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205771&action=review > Source/WebCore/platform/ScrollbarTheme.h:60 > + virtual void usesOverlayScrollbarsChanged() { } This should not have been added. Nobody needs to call this as a virtual function. > Source/WebCore/platform/mac/ScrollbarThemeMac.h:50 > + virtual void usesOverlayScrollbarsChanged() OVERRIDE; This should be a non-virtual function. 205771 2013-06-29 11:54:20 -0700 2013-07-01 11:57:31 -0700 Patch bug-118216-20130629115219.patch text/plain 5051 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmZhOTMyY2M1NjM0YWJk ZjJhYzBiZjIxOGRiZjRkZTFiZjBiMGEzNS4uZTc3NzJiNGJiZjVmMzU0YjA3ZDhiMGY2ZGY0ODJm ZGM5MjNlYTA3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTA2LTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGNhbGxp bmcgaW50byBPYmplY3RpdmUtQyBldmVyeSB0aW1lIHdlIGdldCB0aGUgc2Nyb2xsYmFyIHdpZHRo CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgyMTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9maWxp bmcgc2hvd3MgdGhhdCBjYWxsaW5nIFNjcm9sbGJhcjo6aXNPdmVybGF5U2Nyb2xsYmFyKCkgaXMg c29tZXdoYXQKKyAgICAgICAgZXhwZW5zaXZlLCBiZWNhdXNlIGl0IGNhbGxzIGRvd24gaW50byBP YmplY3RpdmUtQy4gRml4IGJ5IGNhY2hpbmcgaW4KKyAgICAgICAgU2Nyb2xsYmFyVGhlbWVNYWMg d2hldGhlciB3ZSdyZSB1c2luZyBvdmVybGF5IHNjcm9sbGJhcnMuIFdlIHVwZGF0ZSB0aGlzCisg ICAgICAgIGNhY2hlIG9uIGNyZWF0aW9uLCBhbmQgd2hlbiBwcmVmZXJlbmNlcyBjaGFuZ2U7IFNj cm9sbEFuaW1hdG9yTWFjOjp1cGRhdGVTY3JvbGxlclN0eWxlKCkKKyAgICAgICAgaXMgb25lIHRo YXQgZ2V0cyBjYWxsZWQgd2hlbiB0aGUgdXNlciBjaGFuZ2VzIHRoZSBzZXR0aW5nIGluIFN5c3Rl bSBQcmVmZXJlbmNlcy4KKworICAgICAgICAqIHBsYXRmb3JtL1Njcm9sbGJhclRoZW1lLmg6Cisg ICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZTo6dXNlc092ZXJsYXlTY3JvbGxiYXJzQ2hh bmdlZCk6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tOgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0b3JNYWM6OnVwZGF0ZVNjcm9sbGVyU3R5bGUpOgor ICAgICAgICAqIHBsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5oOgorICAgICAgICAqIHBs YXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9s bGJhclRoZW1lTWFjOjpwcmVmZXJlbmNlc0NoYW5nZWQpOgorICAgICAgICAoV2ViQ29yZTo6U2Ny b2xsYmFyVGhlbWVNYWM6OnVzZXNPdmVybGF5U2Nyb2xsYmFycyk6CisgICAgICAgIChXZWJDb3Jl OjpTY3JvbGxiYXJUaGVtZU1hYzo6dXNlc092ZXJsYXlTY3JvbGxiYXJzQ2hhbmdlZCk6CisKIDIw MTMtMDYtMjkgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgogCiAgICAgICAg IEFkb3B0IGlzL3RvSFRNTE9wdEdyb3VwRWxlbWVudCBmb3IgY29kZSBjbGVhbnVwCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxiYXJUaGVtZS5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vU2Nyb2xsYmFyVGhlbWUuaAppbmRleCA5ZjhjNTY3ZjRlM2VhNGI2NjM4 MDQ5NTEyZGU2NjMzNWUzNTM4ZjRhLi5kNjhlMDYyODgzODAzYjRlZmE1OTZmMzU4NGRiOGJmZTgz ZmJhZmM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxiYXJUaGVt ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbGJhclRoZW1lLmgKQEAgLTU3 LDYgKzU3LDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzQ29udHJvbFRp bnRzKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgdXNlc092ZXJs YXlTY3JvbGxiYXJzKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KKyAgICB2aXJ0dWFsIHZvaWQg dXNlc092ZXJsYXlTY3JvbGxiYXJzQ2hhbmdlZCgpIHsgfQogICAgIHZpcnR1YWwgdm9pZCB1cGRh dGVTY3JvbGxiYXJPdmVybGF5U3R5bGUoU2Nyb2xsYmFyVGhlbWVDbGllbnQqKSB7IH0KIAogICAg IHZpcnR1YWwgdm9pZCB0aGVtZUNoYW5nZWQoKSB7fQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1tCmluZGV4IDk3YWUzOTQ2MmQ5ZDJkOTk2MWE2 MzllY2E4ZjhjNGE3OTIyNzBhOTAuLjgxZWJjYTkxYzIyNmRlNGIxZmNmNDcwOWUxNTBhMjNkOTI1 NDllZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmlt YXRvck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0 b3JNYWMubW0KQEAgLTEyMTIsNiArMTIxMiw4IEBAIHZvaWQgU2Nyb2xsQW5pbWF0b3JNYWM6OnVw ZGF0ZVNjcm9sbGVyU3R5bGUoKQogICAgICAgICBtX25lZWRzU2Nyb2xsZXJTdHlsZVVwZGF0ZSA9 IGZhbHNlOwogICAgICAgICByZXR1cm47CiAgICAgfQorICAgIAorICAgIG1hY1RoZW1lLT51c2Vz T3ZlcmxheVNjcm9sbGJhcnNDaGFuZ2VkKCk7CiAKICAgICBOU1Njcm9sbGVyU3R5bGUgbmV3U3R5 bGUgPSBbbV9zY3JvbGxiYXJQYWludGVyQ29udHJvbGxlci5nZXQoKSBzY3JvbGxlclN0eWxlXTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1l TWFjLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMuaApp bmRleCA2OTdiNGE4ODZlMGEyMDI5MDg1Y2RjNmIzNmFmODhjN2NhMmJkMzE1Li5kYTU3M2FmZjRi ZDFjMTg4OTAyOGRlNTkzYzhmYWNhNmQxNjcxMzMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMuaApAQCAtNDcsNiArNDcsNyBAQCBwdWJsaWM6 CiAgICAgCiAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzQ29udHJvbFRpbnRzKCkgY29uc3QgeyBy ZXR1cm4gdHJ1ZTsgfQogICAgIHZpcnR1YWwgYm9vbCB1c2VzT3ZlcmxheVNjcm9sbGJhcnMoKSBj b25zdDsKKyAgICB2aXJ0dWFsIHZvaWQgdXNlc092ZXJsYXlTY3JvbGxiYXJzQ2hhbmdlZCgpIE9W RVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVTY3JvbGxiYXJPdmVybGF5U3R5bGUoU2Ny b2xsYmFyVGhlbWVDbGllbnQqKTsKIAogICAgIHZpcnR1YWwgZG91YmxlIGluaXRpYWxBdXRvc2Ny b2xsVGltZXJEZWxheSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1Njcm9sbGJhclRoZW1lTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9s bGJhclRoZW1lTWFjLm1tCmluZGV4IGM1MTEwODU1Yjg5NzM1NzIxMmJhZTVhMzA0YjAxZDlmNjYx MmRjZTEuLjIyOTllNTA0MGRkNmE2ZTE2ZDg4ZDk1ZGE5YTdjMzU1YTUyYTRjNGMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0KQEAgLTEz Myw2ICsxMzMsNyBAQCBzdGF0aWMgaW50IGNPdXRlckJ1dHRvbk92ZXJsYXAgPSAyOwogc3RhdGlj IGZsb2F0IGdJbml0aWFsQnV0dG9uRGVsYXkgPSAwLjVmOwogc3RhdGljIGZsb2F0IGdBdXRvc2Ny b2xsQnV0dG9uRGVsYXkgPSAwLjA1ZjsKIHN0YXRpYyBib29sIGdKdW1wT25UcmFja0NsaWNrID0g ZmFsc2U7CitzdGF0aWMgYm9vbCBnVXNlT3ZlcmxheVNjcm9sbGJhcnMgPSBmYWxzZTsKIAogc3Rh dGljIFNjcm9sbGJhckJ1dHRvbnNQbGFjZW1lbnQgZ0J1dHRvblBsYWNlbWVudCA9IFNjcm9sbGJh ckJ1dHRvbnNEb3VibGVFbmQ7CiAKQEAgLTIyNiw2ICsyMjcsNyBAQCB2b2lkIFNjcm9sbGJhclRo ZW1lTWFjOjpwcmVmZXJlbmNlc0NoYW5nZWQoKQogICAgIGdJbml0aWFsQnV0dG9uRGVsYXkgPSBb ZGVmYXVsdHMgZmxvYXRGb3JLZXk6QCJOU1Njcm9sbGVyQnV0dG9uRGVsYXkiXTsKICAgICBnQXV0 b3Njcm9sbEJ1dHRvbkRlbGF5ID0gW2RlZmF1bHRzIGZsb2F0Rm9yS2V5OkAiTlNTY3JvbGxlckJ1 dHRvblBlcmlvZCJdOwogICAgIGdKdW1wT25UcmFja0NsaWNrID0gW2RlZmF1bHRzIGJvb2xGb3JL ZXk6QCJBcHBsZVNjcm9sbGVyUGFnaW5nQmVoYXZpb3IiXTsKKyAgICB1c2VzT3ZlcmxheVNjcm9s bGJhcnNDaGFuZ2VkKCk7CiB9CiAKIGludCBTY3JvbGxiYXJUaGVtZU1hYzo6c2Nyb2xsYmFyVGhp Y2tuZXNzKFNjcm9sbGJhckNvbnRyb2xTaXplIGNvbnRyb2xTaXplKQpAQCAtMjQxLDEwICsyNDMs MTUgQEAgaW50IFNjcm9sbGJhclRoZW1lTWFjOjpzY3JvbGxiYXJUaGlja25lc3MoU2Nyb2xsYmFy Q29udHJvbFNpemUgY29udHJvbFNpemUpCiAKIGJvb2wgU2Nyb2xsYmFyVGhlbWVNYWM6OnVzZXNP dmVybGF5U2Nyb2xsYmFycygpIGNvbnN0CiB7CisgICAgcmV0dXJuIGdVc2VPdmVybGF5U2Nyb2xs YmFyczsKK30KKwordm9pZCBTY3JvbGxiYXJUaGVtZU1hYzo6dXNlc092ZXJsYXlTY3JvbGxiYXJz Q2hhbmdlZCgpCit7CiAgICAgaWYgKGlzU2Nyb2xsYmFyT3ZlcmxheUFQSUF2YWlsYWJsZSgpKQot ICAgICAgICByZXR1cm4gcmVjb21tZW5kZWRTY3JvbGxlclN0eWxlKCkgPT0gTlNTY3JvbGxlclN0 eWxlT3ZlcmxheTsKKyAgICAgICAgZ1VzZU92ZXJsYXlTY3JvbGxiYXJzID0gcmVjb21tZW5kZWRT Y3JvbGxlclN0eWxlKCkgPT0gTlNTY3JvbGxlclN0eWxlT3ZlcmxheTsKICAgICBlbHNlCi0gICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgZ1VzZU92ZXJsYXlTY3JvbGxiYXJzID0gZmFsc2U7 CiB9CiAKIHZvaWQgU2Nyb2xsYmFyVGhlbWVNYWM6OnVwZGF0ZVNjcm9sbGJhck92ZXJsYXlTdHls ZShTY3JvbGxiYXJUaGVtZUNsaWVudCogc2Nyb2xsYmFyKQo=