118214 2013-06-29 07:16:10 -0700 Build fix for unguarded SVGGraphicsElement 2013-06-29 08:15:50 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kevin.cs.oh webkit-unassigned cdumez commit-queue d-r esprehn+autocc fmalita pdr schenney zimmermann oldest_to_newest 904853 0 kevin.cs.oh 2013-06-29 07:16:10 -0700 I faced following break when disabling svg features. [shivamidow@LenovoStation:Release]$ make -j 4 make[1]: Entering directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release' /bin/mkdir -p ./.deps/DerivedSources CXXLD libwebkit2gtkinjectedbundle.la CXXLD libjavascriptcoregtk-3.0.la CXXLD libPlatform.la CXXLD libPlatformGtk.la CXX DerivedSources/WebCore/libWebCore_la-JSDOMWindow.lo CXX DerivedSources/WebCore/libWebCore_la-JSEventTarget.lo CXX DerivedSources/WebCore/libWebCore_la-JSFile.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileCallback.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileEntry.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileEntrySync.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileError.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileException.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileList.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileReader.lo In file included from DerivedSources/WebCore/JSDOMWindow.cpp:216:0: DerivedSources/WebCore/JSSVGGraphicsElement.h:32:56: error: expected class-name before '{' token DerivedSources/WebCore/JSSVGGraphicsElement.h:34:13: error: 'JSSVGStyledElement' does not name a type DerivedSources/WebCore/JSSVGGraphicsElement.h:35:112: error: 'SVGGraphicsElement' was not declared in this scope In file included from DerivedSources/WebCore/JSDOMWindow.cpp:216:0: DerivedSources/WebCore/JSSVGGraphicsElement.h:35:130: error: template argument 1 is invalid DerivedSources/WebCore/JSSVGGraphicsElement.h:54:74: error: 'SVGGraphicsElement' was not declared in this scope DerivedSources/WebCore/JSSVGGraphicsElement.h:54:92: error: template argument 1 is invalid DerivedSources/WebCore/JSSVGGraphicsElement.h:56:145: error: 'Base' has not been declared CXX DerivedSources/WebCore/libWebCore_la-JSFileReaderSync.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileSystemCallback.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileWriter.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileWriterCallback.lo CXX DerivedSources/WebCore/libWebCore_la-JSFileWriterSync.lo In file included from ../../Source/JavaScriptCore/runtime/JSCJSValueInlines.h:31:0, from ../../Source/JavaScriptCore/runtime/Operations.h:27, from ../../Source/WebCore/bindings/js/BindingState.h:35, from ../../Source/WebCore/bindings/js/JSDOMBinding.h:27, from DerivedSources/WebCore/JSDOMWindow.h:25, from DerivedSources/WebCore/JSDOMWindow.cpp:22: ../../Source/JavaScriptCore/runtime/JSCellInlines.h: In instantiation of 'void* JSC::allocateCell(JSC::Heap&, size_t) [with T = WebCore::JSSVGGraphicsElement; JSC::Heap = JSC::Heap; size_t = long unsigned int]': ../../Source/JavaScriptCore/runtime/JSCellInlines.h:104:43: required from 'void* JSC::allocateCell(JSC::Heap&) [with T = WebCore::JSSVGGraphicsElement; JSC::Heap = JSC::Heap]' DerivedSources/WebCore/JSSVGGraphicsElement.h:37:114: required from here ../../Source/JavaScriptCore/runtime/JSCellInlines.h:91:5: error: 'hasImmortalStructure' is not a member of 'WebCore::JSSVGGraphicsElement' ../../Source/JavaScriptCore/runtime/JSCellInlines.h:91:5: error: 'needsDestruction' is not a member of 'WebCore::JSSVGGraphicsElement' ../../Source/JavaScriptCore/runtime/JSCellInlines.h:93:10: error: 'needsDestruction' is not a member of 'WebCore::JSSVGGraphicsElement' CXX DerivedSources/WebCore/libWebCore_la-JSFloat32Array.lo CXX DerivedSources/WebCore/libWebCore_la-JSFloat64Array.lo make[1]: *** [DerivedSources/WebCore/libWebCore_la-JSDOMWindow.lo] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/home/shivamidow/Projects/WebKit/WebKitBuild/Release' make: *** [all] Error 2 904854 1 205767 kevin.cs.oh 2013-06-29 07:21:29 -0700 Created attachment 205767 Patch 904856 2 205767 cdumez 2013-06-29 07:27:43 -0700 Comment on attachment 205767 Patch Looks good, thanks. r=me. 904859 3 205767 commit-queue 2013-06-29 08:15:48 -0700 Comment on attachment 205767 Patch Clearing flags on attachment: 205767 Committed r152210: <http://trac.webkit.org/changeset/152210> 904860 4 commit-queue 2013-06-29 08:15:50 -0700 All reviewed patches have been landed. Closing bug. 205767 2013-06-29 07:21:29 -0700 2013-06-29 08:15:48 -0700 Patch bug-118214-20130629231928.patch text/plain 1385 kevin.cs.oh U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThiOTUwN2MzYjZmNmI1 NDI3ZmMwNjQzZGFiZGYwYmZmMzhhNzc4OC4uZTc5N2FmMDVjOTkxYjJjNzEwMmU2YTRjNmFmMzlj ZjJjNDIzMzY2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA2LTI5ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBCdWlsZCBm aXggZm9yIHVuZ3VhcmRlZCBTVkdHcmFwaGljc0VsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODIxNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0aGUgU1ZHIGNvbmRpdGlvbiB0byBTVkdH cmFwaGljc0VsZW1lbnQuaWRsCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHJlcXVpcmVkIHNpbmNl IG5vIGZ1bmN0aW9uYWxpdHkgY2hhbmdlZC4KKworICAgICAgICAqIHN2Zy9TVkdHcmFwaGljc0Vs ZW1lbnQuaWRsOgorCiAyMDEzLTA2LTI5ICBLYW5naWwgSGFuICA8a2FuZ2lsLmhhbkBzYW1zdW5n LmNvbT4KIAogICAgICAgICBBZG9wdCBpcy90b0hUTUxPcHRpb25FbGVtZW50IGZvciBjb2RlIGNs ZWFudXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdHcmFwaGljc0VsZW1lbnQu aWRsIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0dyYXBoaWNzRWxlbWVudC5pZGwKaW5kZXggZDI3 NzJiMjUzNDgwYmQ4YzAzNWQ3ZjJlMGM0NjNjNWRlMDcxMzk0Ni4uZjk2ZTIzMTlmMzA1MTdiMzEw MjJmNmMyMjllNjQ0MWVkYTQ1ZTEwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NW R0dyYXBoaWNzRWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0dyYXBoaWNz RWxlbWVudC5pZGwKQEAgLTIzLDcgKzIzLDkgQEAKICAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4g SUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8KIAotaW50 ZXJmYWNlIFNWR0dyYXBoaWNzRWxlbWVudCA6IFNWR1N0eWxlZEVsZW1lbnQgeworWworICAgIENv bmRpdGlvbmFsPVNWRworXSBpbnRlcmZhY2UgU1ZHR3JhcGhpY3NFbGVtZW50IDogU1ZHU3R5bGVk RWxlbWVudCB7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFNWR0FuaW1hdGVkVHJhbnNmb3JtTGlz dCB0cmFuc2Zvcm07CiAKICAgICByZWFkb25seSBhdHRyaWJ1dGUgU1ZHRWxlbWVudCBuZWFyZXN0 Vmlld3BvcnRFbGVtZW50Owo=