118206 2013-06-28 15:07:52 -0700 Cached pages don't update their backing scale factor when it changes 2013-06-28 16:13:02 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin dino sam simon.fraser thorton oldest_to_newest 904768 0 bdakin 2013-06-28 15:07:52 -0700 Steps to reproduce: 1. Go to daringfireball.net on non-HiDPI display. 2. Click on any link on the page e.g. "Projects". 3. Move the window to HiDPI display. 4. Click the back button. <rdar://problem/14261627> 904782 1 205750 bdakin 2013-06-28 15:44:24 -0700 Created attachment 205750 Patch 904787 2 205750 thorton 2013-06-28 15:57:46 -0700 Comment on attachment 205750 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205750&action=review > Source/WebCore/history/CachedPage.h:74 > + bool m_needsDeviceScaleChanged; I don't really like the "needs XYZ changed" naming (it's really 'needs to *call* XYZChanged', or maybe needsDeviceScaleUpdate or something), but there's already one like that here :| 904790 3 bdakin 2013-06-28 16:13:02 -0700 Thanks, Tim! I gave it some thought but was unable to think of a better name. I do agree it's not great. I will keep thinking on it. 205750 2013-06-28 15:44:24 -0700 2013-06-28 15:57:45 -0700 Patch for-review.txt text/plain 5128 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjE5MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBACisyMDEzLTA2LTI4ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBDYWNoZWQgcGFnZXMgZG9uJ3QgdXBk YXRlIHRoZWlyIGJhY2tpbmcgc2NhbGUgZmFjdG9yIHdoZW4gaXQgY2hhbmdlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MjA2CisgICAgICAgIC1h bmQtCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNDI2MTYyNz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpcyBub3Qgc3VmZmljaWVudCB0byBt YXJrIHBhZ2VzIGluIHRoZSBQYWdlQ2FjaGUgYXMgbmVlZGluZyBhIGZ1bGwgc3R5bGUgCisgICAg ICAgIHJlY2FsYy4gV2UgYWxzbyBuZWVkIHRvIGVuc3VyZSB0aGF0IHRoZSBSZW5kZXJMYXllckNv bXBvc2l0b3JzIGZvciB0aGUgQ2FjaGVzUGFnZXMgCisgICAgICAgIGdldCB1cGRhdGVkLgorCisg ICAgICAgIEtlZXAgdHJhY2sgb2Ygd2hldGhlciBkZXZpY2Ugc2NhbGUgaGFzIGJlZW4gdXBkYXRl ZCB3aXRoIAorICAgICAgICBtX25lZWRzRGV2aWNlU2NhbGVDaGFuZ2VkLiBJZiB0aGF0IGhhcyBi ZWVuIG1hcmtlZCB0cnVlLCB0aGVuIHJlc3RvcmUoKSB3aWxsIGNhbGwgCisgICAgICAgIEZyYW1l OjpkZXZpY2VPclBhZ2VTY2FsZUZhY3RvckNoYW5nZWQoKS4KKyAgICAgICAgKiBoaXN0b3J5L0Nh Y2hlZFBhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkUGFnZTo6Q2FjaGVkUGFnZSk6 CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRQYWdlOjpyZXN0b3JlKToKKyAgICAgICAgKiBoaXN0 b3J5L0NhY2hlZFBhZ2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFBhZ2U6Om1hcmtGb3JE ZXZpY2VTY2FsZUNoYW5nZWQpOgorCisgICAgICAgIFByb3BhZ2F0ZSBtYXJrRm9yRGV2aWNlU2Nh bGVDaGFuZ2VkKCkgdG8gYWxsIG9mIHRoZSBDYWNoZWRQYWdlcy4KKyAgICAgICAgKiBoaXN0b3J5 L1BhZ2VDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlQ2FjaGU6Om1hcmtQYWdlc0Zv ckRldmljZVNjYWxlQ2hhbmdlZCk6CisgICAgICAgICogaGlzdG9yeS9QYWdlQ2FjaGUuaDoKKwor ICAgICAgICBDYWxsIFBhZ2VDYWNoZTo6bWFya1BhZ2VzRm9yRGV2aWNlU2NhbGVDaGFuZ2VkKCkK KyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6c2V0RGV2 aWNlU2NhbGVGYWN0b3IpOgorCiAyMDEzLTA2LTI4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIC13ZWJraXQtbGluZS1icmVhazogYWZ0ZXItd2hpdGUtc3BhY2Ug c29tZXRpbWVzIHRydW5jYXRlcyBET00gb24gY29weSAmIHBhc3RlCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9oaXN0b3J5L0NhY2hlZFBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2hpc3RvcnkvQ2FjaGVkUGFnZS5jcHAJKHJldmlzaW9uIDE1MjE4MCkKKysrIFNvdXJjZS9XZWJD b3JlL2hpc3RvcnkvQ2FjaGVkUGFnZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU3LDYgKzU3LDcg QEAgQ2FjaGVkUGFnZTo6Q2FjaGVkUGFnZShQYWdlKiBwYWdlKQogICAgICwgbV9uZWVkU3R5bGVS ZWNhbGNGb3JWaXNpdGVkTGlua3MoZmFsc2UpCiAgICAgLCBtX25lZWRzRnVsbFN0eWxlUmVjYWxj KGZhbHNlKQogICAgICwgbV9uZWVkc0NhcHRpb25QcmVmZXJlbmNlc0NoYW5nZWQoZmFsc2UpCisg ICAgLCBtX25lZWRzRGV2aWNlU2NhbGVDaGFuZ2VkKGZhbHNlKQogewogI2lmbmRlZiBOREVCVUcK ICAgICBjYWNoZWRQYWdlQ291bnRlci5pbmNyZW1lbnQoKTsKQEAgLTkyLDYgKzkzLDEzIEBAIHZv aWQgQ2FjaGVkUGFnZTo6cmVzdG9yZShQYWdlKiBwYWdlKQogICAgICAgICAgICAgZnJhbWUtPmRv Y3VtZW50KCktPnZpc2l0ZWRMaW5rU3RhdGUoKS0+aW52YWxpZGF0ZVN0eWxlRm9yQWxsTGlua3Mo KTsKICAgICB9CiAKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCisgICAgaWYgKG1f bmVlZHNEZXZpY2VTY2FsZUNoYW5nZWQpIHsKKyAgICAgICAgaWYgKEZyYW1lKiBmcmFtZSA9IHBh Z2UtPm1haW5GcmFtZSgpKQorICAgICAgICAgICAgZnJhbWUtPmRldmljZU9yUGFnZVNjYWxlRmFj dG9yQ2hhbmdlZCgpOworICAgIH0KKyNlbmRpZgorCiAgICAgaWYgKG1fbmVlZHNGdWxsU3R5bGVS ZWNhbGMpCiAgICAgICAgIHBhZ2UtPnNldE5lZWRzUmVjYWxjU3R5bGVJbkFsbEZyYW1lcygpOwog CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0NhY2hlZFBhZ2UuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L0NhY2hlZFBhZ2UuaAkocmV2aXNpb24gMTUyMTgwKQor KysgU291cmNlL1dlYkNvcmUvaGlzdG9yeS9DYWNoZWRQYWdlLmgJKHdvcmtpbmcgY29weSkKQEAg LTU4LDYgKzU4LDEwIEBAIHB1YmxpYzoKICAgICB2b2lkIG1hcmtGb3JDYXB0aW9uUHJlZmVyZW5j ZXNDaGFuZ2VkKCkgeyBtX25lZWRzQ2FwdGlvblByZWZlcmVuY2VzQ2hhbmdlZCA9IHRydWU7IH0K ICNlbmRpZgogCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgIHZvaWQgbWFy a0ZvckRldmljZVNjYWxlQ2hhbmdlZCgpIHsgbV9uZWVkc0RldmljZVNjYWxlQ2hhbmdlZCA9IHRy dWU7IH0KKyNlbmRpZgorCiBwcml2YXRlOgogICAgIENhY2hlZFBhZ2UoUGFnZSopOwogCkBAIC02 Nyw2ICs3MSw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX25lZWRTdHlsZVJlY2FsY0ZvclZpc2l0 ZWRMaW5rczsKICAgICBib29sIG1fbmVlZHNGdWxsU3R5bGVSZWNhbGM7CiAgICAgYm9vbCBtX25l ZWRzQ2FwdGlvblByZWZlcmVuY2VzQ2hhbmdlZDsKKyAgICBib29sIG1fbmVlZHNEZXZpY2VTY2Fs ZUNoYW5nZWQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv aGlzdG9yeS9QYWdlQ2FjaGUuY3BwCShyZXZpc2lvbiAxNTIxODApCisrKyBTb3VyY2UvV2ViQ29y ZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwNiw2ICs0MDYsMjAg QEAgdm9pZCBQYWdlQ2FjaGU6Om1hcmtQYWdlc0ZvckZ1bGxTdHlsZVJlYwogICAgIH0KIH0KIAor CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQordm9pZCBQYWdlQ2FjaGU6Om1hcmtQ YWdlc0ZvckRldmljZVNjYWxlQ2hhbmdlZChQYWdlKiBwYWdlKQoreworICAgIEZyYW1lKiBtYWlu RnJhbWUgPSBwYWdlLT5tYWluRnJhbWUoKTsKKworICAgIGZvciAoSGlzdG9yeUl0ZW0qIGN1cnJl bnQgPSBtX2hlYWQ7IGN1cnJlbnQ7IGN1cnJlbnQgPSBjdXJyZW50LT5tX25leHQpIHsKKyAgICAg ICAgQ2FjaGVkUGFnZSogY2FjaGVkUGFnZSA9IGN1cnJlbnQtPm1fY2FjaGVkUGFnZS5nZXQoKTsK KyAgICAgICAgaWYgKGNhY2hlZFBhZ2UtPmNhY2hlZE1haW5GcmFtZSgpLT52aWV3KCktPmZyYW1l KCkgPT0gbWFpbkZyYW1lKQorICAgICAgICAgICAgY2FjaGVkUGFnZS0+bWFya0ZvckRldmljZVNj YWxlQ2hhbmdlZCgpOworICAgIH0KK30KKyNlbmRpZgorCiAjaWYgRU5BQkxFKFZJREVPX1RSQUNL KQogdm9pZCBQYWdlQ2FjaGU6Om1hcmtQYWdlc0ZvckNhcHRpb25QcmVmZXJlbmNlc0NoYW5nZWQo KQogewpJbmRleDogU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5oCShyZXZpc2lvbiAxNTIxODAp CisrKyBTb3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5oCSh3b3JraW5nIGNvcHkpCkBA IC02Nyw2ICs2Nyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICNpZiBVU0UoQUNDRUxFUkFURURf Q09NUE9TSVRJTkcpCiAgICAgICAgIGJvb2wgc2hvdWxkQ2xlYXJCYWNraW5nU3RvcmVzKCkgY29u c3QgeyByZXR1cm4gbV9zaG91bGRDbGVhckJhY2tpbmdTdG9yZXM7IH0KICAgICAgICAgdm9pZCBz ZXRTaG91bGRDbGVhckJhY2tpbmdTdG9yZXMoYm9vbCBmbGFnKSB7IG1fc2hvdWxkQ2xlYXJCYWNr aW5nU3RvcmVzID0gZmxhZzsgfQorICAgICAgICB2b2lkIG1hcmtQYWdlc0ZvckRldmljZVNjYWxl Q2hhbmdlZChQYWdlKik7CiAjZW5kaWYKIAogICAgIHByaXZhdGU6CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wYWdlL1BhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvUGFn ZS5jcHAJKHJldmlzaW9uIDE1MjE4MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTgwNCw2ICs4MDQsOCBAQCB2b2lkIFBhZ2U6OnNldERldmljZVNj YWxlRmFjdG9yKGZsb2F0IHNjCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAg IGlmIChtYWluRnJhbWUoKSkKICAgICAgICAgbWFpbkZyYW1lKCktPmRldmljZU9yUGFnZVNjYWxl RmFjdG9yQ2hhbmdlZCgpOworCisgICAgcGFnZUNhY2hlKCktPm1hcmtQYWdlc0ZvckRldmljZVNj YWxlQ2hhbmdlZCh0aGlzKTsKICNlbmRpZgogCiAgICAgZm9yIChGcmFtZSogZnJhbWUgPSBtYWlu RnJhbWUoKTsgZnJhbWU7IGZyYW1lID0gZnJhbWUtPnRyZWUoKS0+dHJhdmVyc2VOZXh0KCkpCg==