118204 2013-06-28 14:49:41 -0700 std::min needs template parameters 2013-06-28 15:48:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 achristensen webkit-unassigned commit-queue oldest_to_newest 904762 0 achristensen 2013-06-28 14:49:41 -0700 https://bugs.webkit.org/show_bug.cgi?id=94124 committed in r135763 fixed a compile error with template parameters std::min, but there are two more places where this needs to be done. Visual Studio can't decide whether to use the 32-bit or 64-bit integer comparison, so I'm going to tell it to cast both to the desired return type first. 904769 1 205747 achristensen 2013-06-28 15:09:52 -0700 Created attachment 205747 Patch 904772 2 205747 ggaren 2013-06-28 15:13:36 -0700 Comment on attachment 205747 Patch r=me 904783 3 205747 commit-queue 2013-06-28 15:48:50 -0700 Comment on attachment 205747 Patch Clearing flags on attachment: 205747 Committed r152193: <http://trac.webkit.org/changeset/152193> 904784 4 commit-queue 2013-06-28 15:48:52 -0700 All reviewed patches have been landed. Closing bug. 205747 2013-06-28 15:09:52 -0700 2013-06-28 15:48:50 -0700 Patch bug-118204-20130628150752.patch text/plain 1915 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjE4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA2LTI4ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQGFwcGxlLmNvbT4KKworICAgICAgICBBZGRlZCB0ZW1w bGF0ZSBwYXJhbWV0ZXJzIHRvIHN0ZDo6bWluIHRvIGZpeCBjb21waWxlIGVycm9ycyBpbiBWaXN1 YWwgU3R1ZGlvIHg2NC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExODIwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UGFzdGVib2FyZDo6d3JpdGVVUkxUb0RhdGFPYmplY3QpOiBBZGRlZCA8dW5zaWduZWQ+IHRv IHN0ZDo6bWluLgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlR2xvYmFsSW1hZ2VGaWxlRGVzY3Jp cHRvcik6IEFkZGVkIDxpbnQ+IHRvIHN0ZDo6bWluLgorCiAyMDEzLTA2LTI4ICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIC13ZWJraXQtbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2Ugc29tZXRpbWVzIHRydW5jYXRlcyBET00gb24gY29weSAmIHBhc3RlCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGFzdGVib2FyZFdpbi5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL1Bhc3RlYm9hcmRXaW4uY3BwCShy ZXZpc2lvbiAxNTIwNjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUGFzdGVib2Fy ZFdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3Nyw3ICs2NzcsNyBAQCB2b2lkIFBhc3RlYm9h cmQ6OndyaXRlVVJMVG9EYXRhT2JqZWN0KGNvCiAgICAgZmdkLT5mZ2RbMF0uZHdGbGFncyA9IEZE X0ZJTEVTSVpFOwogICAgIGZnZC0+ZmdkWzBdLm5GaWxlU2l6ZUxvdyA9IGNvbnRlbnQubGVuZ3Ro KCk7CiAKLSAgICB1bnNpZ25lZCBtYXhTaXplID0gc3RkOjptaW4oZnNQYXRoLmxlbmd0aCgpLCBX VEZfQVJSQVlfTEVOR1RIKGZnZC0+ZmdkWzBdLmNGaWxlTmFtZSkpOworICAgIHVuc2lnbmVkIG1h eFNpemUgPSBzdGQ6Om1pbjx1bnNpZ25lZD4oZnNQYXRoLmxlbmd0aCgpLCBXVEZfQVJSQVlfTEVO R1RIKGZnZC0+ZmdkWzBdLmNGaWxlTmFtZSkpOwogICAgIENvcHlNZW1vcnkoZmdkLT5mZ2RbMF0u Y0ZpbGVOYW1lLCBmc1BhdGguY2hhcmFjdGVycygpLCBtYXhTaXplICogc2l6ZW9mKFVDaGFyKSk7 CiAgICAgR2xvYmFsVW5sb2NrKHVybEZpbGVEZXNjcmlwdG9yKTsKIApAQCAtOTI5LDcgKzkyOSw3 IEBAIHN0YXRpYyBIR0xPQkFMIGNyZWF0ZUdsb2JhbEltYWdlRmlsZURlc2MKICAgICAgICAgcmV0 dXJuIDA7CiAgICAgfQogCi0gICAgaW50IG1heFNpemUgPSBzdGQ6Om1pbihmc1BhdGgubGVuZ3Ro KCksIFdURl9BUlJBWV9MRU5HVEgoZmdkLT5mZ2RbMF0uY0ZpbGVOYW1lKSk7CisgICAgaW50IG1h eFNpemUgPSBzdGQ6Om1pbjxpbnQ+KGZzUGF0aC5sZW5ndGgoKSwgV1RGX0FSUkFZX0xFTkdUSChm Z2QtPmZnZFswXS5jRmlsZU5hbWUpKTsKICAgICBDb3B5TWVtb3J5KGZnZC0+ZmdkWzBdLmNGaWxl TmFtZSwgKExQQ1dTVFIpZnNQYXRoLmNoYXJhY3RlcnMoKSwgbWF4U2l6ZSAqIHNpemVvZihVQ2hh cikpOwogICAgIEdsb2JhbFVubG9jayhtZW1PYmopOwogCg==