118198 2013-06-28 11:34:57 -0700 media/video-currentTime.html flakey 2013-07-02 09:37:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson glenn jberlin webkit-bug-importer oldest_to_newest 904713 0 jer.noble 2013-06-28 11:34:57 -0700 media/video-currentTime.html flakey 904714 1 205729 jer.noble 2013-06-28 11:37:01 -0700 Created attachment 205729 Patch 904726 2 205729 eric.carlson 2013-06-28 12:20:14 -0700 Comment on attachment 205729 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205729&action=review > LayoutTests/media/video-currentTime-expected.txt:5 > +video.currentTime > 0 OK Nit: is there any reason the test results need to change (eg. call testExpected("video.currentTime", 0, '>') rather than logResult(true, 'video.currentTime > 0') ? 904729 3 205729 jer.noble 2013-06-28 12:29:25 -0700 Comment on attachment 205729 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205729&action=review >> LayoutTests/media/video-currentTime-expected.txt:5 >> +video.currentTime > 0 OK > > Nit: is there any reason the test results need to change (eg. call testExpected("video.currentTime", 0, '>') rather than logResult(true, 'video.currentTime > 0') ? Yes, because the first timeupdate event will likely always be at currentTime == 0. 904735 4 205729 commit-queue 2013-06-28 12:55:51 -0700 Comment on attachment 205729 Patch Clearing flags on attachment: 205729 Committed r152184: <http://trac.webkit.org/changeset/152184> 904736 5 commit-queue 2013-06-28 12:55:53 -0700 All reviewed patches have been landed. Closing bug. 905469 6 webkit-bug-importer 2013-07-02 09:37:40 -0700 <rdar://problem/14333042> 205729 2013-06-28 11:37:01 -0700 2013-06-28 12:55:51 -0700 Patch bug-118198-20130628113502.patch text/plain 2460 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMDM3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODVhZGMyMDEzNWUxNGViZjcwYTli MThiYWY1YjhiYTBkYjBlOWE1Yi4uOTYyZjk1MGVkMWVjZjI4MTg1ZDdlNThiZjBhNTIwMzc5NjNl ZTlhYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA2LTI4ICBKZXIgTm9ibGUgIDxqZXIu bm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIG1lZGlhL3ZpZGVvLWN1cnJlbnRUaW1lLmh0bWwg Zmxha2V5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MTgxOTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBV cGRhdGUgdmlkZW8tY3VycmVudFRpbWUuaHRtbCBzbyB0aGF0IGl0IGxpc3RlbnMgZm9yIHRpbWV1 cGRhdGUgZXZlbnRzLCBhbmQgZW5kcyB0aGUgdGVzdAorICAgICAgICBhZnRlciB0aGUgZmlyc3Qg b25lIHdpdGggYSA+MCBjdXJyZW50VGltZS4gQWRkIGEgM3Mgd2F0Y2hkb2cgZm9yIHRoZSBmYWls dXJlIGNhc2UuCisKKyAgICAgICAgKiBtZWRpYS92aWRlby1jdXJyZW50VGltZS1leHBlY3RlZC50 eHQ6CisgICAgICAgICogbWVkaWEvdmlkZW8tY3VycmVudFRpbWUuaHRtbDoKKwogMjAxMy0wNi0y NiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBQb3RlbnRpYWwg dXNlLWFmdGVyLWZyZWUgYWZ0ZXIgbmV1dGVyaW5nIEF1ZGlvQnVmZmVyJ3MgdW5kZXJseWluZyBB cnJheUJ1ZmZlci4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWN1cnJlbnRU aW1lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWN1cnJlbnRUaW1lLWV4 cGVjdGVkLnR4dAppbmRleCAyYjE4ZDQ3MGNlMTU1NzZlODEzNGI3NGUyMDQ0NGIzNDg2MzVlNWU3 Li40NDM2OGViOWQ0M2M1NTAyZDM1MmE5ZmFlYzkyNjhhOGZlMjQ1MWNkIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9tZWRpYS92aWRlby1jdXJyZW50VGltZS1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvbWVkaWEvdmlkZW8tY3VycmVudFRpbWUtZXhwZWN0ZWQudHh0CkBAIC0yLDYgKzIs NiBAQCBFWFBFQ1RFRCAodmlkZW8uY3VycmVudFRpbWUgPT0gJzAnKSBPSwogRVZFTlQoY2FucGxh eXRocm91Z2gpCiBFWFBFQ1RFRCAodmlkZW8uY3VycmVudFRpbWUgPT0gJzAnKSBPSwogRVZFTlQo cGxheSkKLUVYUEVDVEVEICh2aWRlby5jdXJyZW50VGltZSA+ICcwJykgT0sKK3ZpZGVvLmN1cnJl bnRUaW1lID4gMCBPSwogRU5EIE9GIFRFU1QKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvdmlkZW8tY3VycmVudFRpbWUuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWN1cnJl bnRUaW1lLmh0bWwKaW5kZXggZjBmMmE0NTM3YWNmMWQwNjcyNmQ1NmE2MGM4OWQ5OGE3NDQzODU1 Ny4uYTJlNzhkOTA5YmJiYTZkNzJiZGVhYjM2Njg3YWJmNTc1MWNiNmFlMiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY3VycmVudFRpbWUuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9tZWRpYS92aWRlby1jdXJyZW50VGltZS5odG1sCkBAIC00LDEyICs0LDE0IEBACiA8c2NyaXB0 PgogICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uY3VycmVudFRpbWUiLCAwKQogICAgIHdhaXRGb3JF dmVudCgnY2FucGxheXRocm91Z2gnLCBmdW5jdGlvbigpIHsgdGVzdEV4cGVjdGVkKCJ2aWRlby5j dXJyZW50VGltZSIsIDApOyB9ICk7Ci0gICAgdmlkZW8uYWRkRXZlbnRMaXN0ZW5lcignY2FucGxh eXRocm91Z2gnLCBmdW5jdGlvbigpIHsgdmlkZW8ucGxheSgpOyBzZXRUaW1lb3V0KHRlc3RDdXJy ZW50VGltZSwgNTAwKSB9KTsKKyAgICB2aWRlby5hZGRFdmVudExpc3RlbmVyKCdjYW5wbGF5dGhy b3VnaCcsIGZ1bmN0aW9uKCkgeyB2aWRlby5wbGF5KCk7IH0pOwogICAgIHdhaXRGb3JFdmVudCgn cGxheScpOwotICAgIGZ1bmN0aW9uIHRlc3RDdXJyZW50VGltZSgpCi0gICAgewotICAgICAgICB0 ZXN0RXhwZWN0ZWQoInZpZGVvLmN1cnJlbnRUaW1lIiwgMCwgJz4nKQotICAgICAgICBlbmRUZXN0 KCk7Ci0gICAgfQorICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVuZXIoJ3RpbWV1cGRhdGUnLCBmdW5j dGlvbigpIHsKKyAgICAgICAgaWYgKHZpZGVvLmN1cnJlbnRUaW1lID4gMCkgeworICAgICAgICAg ICAgbG9nUmVzdWx0KHRydWUsICd2aWRlby5jdXJyZW50VGltZSA+IDAnKTsKKyAgICAgICAgICAg IGVuZFRlc3QoKTsKKyAgICAgICAgfQorICAgIH0pOwogICAgIHZpZGVvLnNyYyA9IGZpbmRNZWRp YUZpbGUoInZpZGVvIiwgImNvbnRlbnQvdGVzdCIpOworICAgIGZhaWxUZXN0SW4oMzAwMCk7CiA8 L3NjcmlwdD4K