118193 2013-06-28 09:54:02 -0700 [EFL] back/forward keyboard shortcuts are non-intuitive 2013-06-28 11:08:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs cdumez commit-queue gyuyoung.kim gyuyoung.kim rakuco ryuan.choi oldest_to_newest 904676 0 kbalazs 2013-06-28 09:54:02 -0700 In my opinion it would be better to just mimic Chrome, function keys (F1&F2) are a bit odd :) 904677 1 205722 kbalazs 2013-06-28 09:56:22 -0700 Created attachment 205722 Patch 904680 2 205722 cdumez 2013-06-28 10:00:42 -0700 Comment on attachment 205722 Patch great! r=me. 904706 3 205722 commit-queue 2013-06-28 11:08:18 -0700 Comment on attachment 205722 Patch Clearing flags on attachment: 205722 Committed r152179: <http://trac.webkit.org/changeset/152179> 904707 4 commit-queue 2013-06-28 11:08:23 -0700 All reviewed patches have been landed. Closing bug. 205722 2013-06-28 09:56:22 -0700 2013-06-28 11:08:18 -0700 Patch bug-118193-20130628185422.patch text/plain 3719 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxODg3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTZkZmIxOTk5MTkzZjFmZGQzNTJhMGM0ZWY2NmQ2NDlm MzdmYzYxZC4uYmI5NzA0YzFkMjNjN2QzMjU3NTBlNzZmMWJlNmIwM2UzOWNhOTRhOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTA2LTI4ICBCYWxhenMgS2VsZW1lbiAgPGIua2VsZW1lbkBzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBiYWNrL2ZvcndhcmQga2V5Ym9hcmQgc2hvcnRjdXRzIGFyZSBub24t aW50dWl0aXZlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTgxOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDaGFuZ2VkIHNob3J0Y3V0cyBmb3IgZ28tYmFjay9nby1mb3J3YXJkIHRvIGFsdCtsZWZ0IGFu ZCBhbHQrcmlnaHQuCisKKyAgICAgICAgKiBFV2ViTGF1bmNoZXIvbWFpbi5jOgorICAgICAgICAo b25fa2V5X2Rvd24pOgorICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6CisgICAgICAg IChvbl9rZXlfZG93bik6CisKIDIwMTMtMDYtMjIgIFNhbnRvc2ggTWFodG8gIDxzYW50b3NoLm1h QHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEFkZCBzdXBwb3J0IGZvciBNSFRNTCBzYXZl L2xvYWQgZmVhdHVyZSB0byBNaW5pQnJvd3NlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvRVdlYkxhdW5j aGVyL21haW4uYyBiL1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMKaW5kZXggZjQxYTRmZGNhZmY5 ZGU5MmZhNmMzNDk4MmZlOTI5MWQ1NDkwNTlkZS4uNWM4MzNlOTBlYTQxOTQzMTc5ZDU2ZWUzMTU3 YTI2YTc3N2FkODFkMCAxMDA2NDQKLS0tIGEvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYworKysg Yi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCkBAIC00OTQsMTIgKzQ5NCwxNCBAQCBvbl9rZXlf ZG93bih2b2lkICpkYXRhLCBFdmFzICplLCBFdmFzX09iamVjdCAqb2JqLCB2b2lkICpldmVudF9p bmZvKQogICAgICAgICBOVUxMCiAgICAgfTsKICAgICBzdGF0aWMgaW50IGN1cnJlbnRFbmNvZGlu ZyA9IC0xOwotICAgIEVpbmFfQm9vbCBjdHJsUHJlc3NlZCA9IGV2YXNfa2V5X21vZGlmaWVyX2lz X3NldChldmFzX2tleV9tb2RpZmllcl9nZXQoZSksICJDb250cm9sIik7CisgICAgY29uc3QgRXZh c19Nb2RpZmllciAqbW9kID0gZXZhc19rZXlfbW9kaWZpZXJfZ2V0KGUpOworICAgIEVpbmFfQm9v bCBjdHJsUHJlc3NlZCA9IGV2YXNfa2V5X21vZGlmaWVyX2lzX3NldChtb2QsICJDb250cm9sIik7 CisgICAgRWluYV9Cb29sIGFsdFByZXNzZWQgPSBldmFzX2tleV9tb2RpZmllcl9pc19zZXQobW9k LCAiQWx0Iik7CiAKICAgICBpZiAoIXN0cmNtcChldi0+a2V5LCAiRXNjYXBlIikpIHsKICAgICAg ICAgY2xvc2VXaW5kb3coYXBwLT5lZSk7Ci0gICAgfSBlbHNlIGlmICghc3RyY21wKGV2LT5rZXks ICJGMSIpKSB7Ci0gICAgICAgIGluZm8oIkJhY2sgKEYxKSB3YXMgcHJlc3NlZCIpOworICAgIH0g ZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5LCAiTGVmdCIpICYmIGFsdFByZXNzZWQpIHsKKyAgICAg ICAgaW5mbygiQmFjayAoQWx0K0xlZnQpIHdhcyBwcmVzc2VkIik7CiAgICAgICAgIGlmIChld2tf dmlld19iYWNrX3Bvc3NpYmxlKG9iaikpIHsKICAgICAgICAgICAgIEV3a19IaXN0b3J5ICpoaXN0 b3J5ID0gZXdrX3ZpZXdfaGlzdG9yeV9nZXQob2JqKTsKICAgICAgICAgICAgIEVpbmFfTGlzdCAq bGlzdCA9IGV3a19oaXN0b3J5X2JhY2tfbGlzdF9nZXQoaGlzdG9yeSk7CkBAIC01MDgsOCArNTEw LDggQEAgb25fa2V5X2Rvd24odm9pZCAqZGF0YSwgRXZhcyAqZSwgRXZhc19PYmplY3QgKm9iaiwg dm9pZCAqZXZlbnRfaW5mbykKICAgICAgICAgICAgIGV3a192aWV3X2JhY2sob2JqKTsKICAgICAg ICAgfSBlbHNlCiAgICAgICAgICAgICBpbmZvKCJCYWNrIGlnbm9yZWQ6IE5vIGJhY2sgaGlzdG9y eSIpOwotICAgIH0gZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5LCAiRjIiKSkgewotICAgICAgICBp bmZvKCJGb3J3YXJkIChGMikgd2FzIHByZXNzZWQiKTsKKyAgICB9IGVsc2UgaWYgKCFzdHJjbXAo ZXYtPmtleSwgIlJpZ2h0IikgJiYgYWx0UHJlc3NlZCkgeworICAgICAgICBpbmZvKCJGb3J3YXJk IChBbHQrUmlnaHQpIHdhcyBwcmVzc2VkIik7CiAgICAgICAgIGlmIChld2tfdmlld19mb3J3YXJk X3Bvc3NpYmxlKG9iaikpIHsKICAgICAgICAgICAgIEV3a19IaXN0b3J5ICpoaXN0b3J5ID0gZXdr X3ZpZXdfaGlzdG9yeV9nZXQob2JqKTsKICAgICAgICAgICAgIEVpbmFfTGlzdCAqbGlzdCA9IGV3 a19oaXN0b3J5X2ZvcndhcmRfbGlzdF9nZXQoaGlzdG9yeSk7CmRpZmYgLS1naXQgYS9Ub29scy9N aW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwppbmRl eCBlOWMwY2VhNGM0YWQyNjY3YWU4ZTMyNjRmNmNiZTk2MDU3YzcxZmUxLi4xY2E1MTU1YjI2MGQx OWZhMDlkMjgyMTUwMDE5M2Q3NTQ4NjU1MGM5IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nl ci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAgLTM5MSwx NCArMzkxLDE2IEBAIG9uX2tleV9kb3duKHZvaWQgKnVzZXJfZGF0YSwgRXZhcyAqZSwgRXZhc19P YmplY3QgKmV3a192aWV3LCB2b2lkICpldmVudF9pbmZvKQogICAgICAgICBOVUxMCiAgICAgfTsK ICAgICBzdGF0aWMgaW50IGN1cnJlbnRFbmNvZGluZyA9IC0xOwotICAgIEVpbmFfQm9vbCBjdHJs UHJlc3NlZCA9IGV2YXNfa2V5X21vZGlmaWVyX2lzX3NldChldmFzX2tleV9tb2RpZmllcl9nZXQo ZSksICJDb250cm9sIik7CisgICAgY29uc3QgRXZhc19Nb2RpZmllciAqbW9kID0gZXZhc19rZXlf bW9kaWZpZXJfZ2V0KGUpOworICAgIEVpbmFfQm9vbCBjdHJsUHJlc3NlZCA9IGV2YXNfa2V5X21v ZGlmaWVyX2lzX3NldChtb2QsICJDb250cm9sIik7CisgICAgRWluYV9Cb29sIGFsdFByZXNzZWQg PSBldmFzX2tleV9tb2RpZmllcl9pc19zZXQobW9kLCAiQWx0Iik7CiAKLSAgICBpZiAoIXN0cmNt cChldi0+a2V5LCAiRjEiKSkgewotICAgICAgICBpbmZvKCJCYWNrIChGMSkgd2FzIHByZXNzZWQi KTsKKyAgICBpZiAoIXN0cmNtcChldi0+a2V5LCAiTGVmdCIpICYmIGFsdFByZXNzZWQpIHsKKyAg ICAgICAgaW5mbygiQmFjayAoQWx0K0xlZnQpIHdhcyBwcmVzc2VkIik7CiAgICAgICAgIGlmICgh ZXdrX3ZpZXdfYmFjayhld2tfdmlldykpCiAgICAgICAgICAgICBpbmZvKCJCYWNrIGlnbm9yZWQ6 IE5vIGJhY2sgaGlzdG9yeSIpOwotICAgIH0gZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5LCAiRjIi KSkgewotICAgICAgICBpbmZvKCJGb3J3YXJkIChGMikgd2FzIHByZXNzZWQiKTsKKyAgICB9IGVs c2UgaWYgKCFzdHJjbXAoZXYtPmtleSwgIlJpZ2h0IikgJiYgYWx0UHJlc3NlZCkgeworICAgICAg ICBpbmZvKCJGb3J3YXJkIChBbHQrUmlnaHQpIHdhcyBwcmVzc2VkIik7CiAgICAgICAgIGlmICgh ZXdrX3ZpZXdfZm9yd2FyZChld2tfdmlldykpCiAgICAgICAgICAgICBpbmZvKCJGb3J3YXJkIGln bm9yZWQ6IE5vIGZvcndhcmQgaGlzdG9yeSIpOwogICAgIH0gZWxzZSBpZiAoIXN0cmNtcChldi0+ a2V5LCAiRjMiKSkgewo=