118192 2013-06-28 07:54:27 -0700 Update TestExpectations so new Shapes tests are skipped where the old ones were 2013-06-28 11:09:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe bjonesbe cdumez commit-queue gyuyoung.kim paroga rakuco roger_fong oldest_to_newest 904624 0 bjonesbe 2013-06-28 07:54:27 -0700 Update TestExpectations so new Shapes tests are skipped where the old ones were 904625 1 205714 bjonesbe 2013-06-28 07:55:09 -0700 Created attachment 205714 Patch Update expectations so that the new tests are skipped on platforms the old tests were skipped on. 904631 2 205714 cdumez 2013-06-28 08:08:36 -0700 Comment on attachment 205714 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205714&action=review > LayoutTests/platform/efl/TestExpectations:341 > +webkit.org/b/83898 csswg/submitted/shapes Those tests are passing on EFL port. SHAPES are probably enabled for us because it is enabled for all port in Tools/Scripts/webkitperl/FeatureList.pm. I ran a couple of these tests manually in MiniBrowser and they run fine. 904636 3 bjonesbe 2013-06-28 08:18:13 -0700 (In reply to comment #2) > (From update of attachment 205714 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205714&action=review > > > LayoutTests/platform/efl/TestExpectations:341 > > +webkit.org/b/83898 csswg/submitted/shapes > > Those tests are passing on EFL port. SHAPES are probably enabled for us because it is enabled for all port in Tools/Scripts/webkitperl/FeatureList.pm. I ran a couple of these tests manually in MiniBrowser and they run fine. That's great news. I'll remove the expectations for EFL completely and upload a new patch. 904637 4 205716 bjonesbe 2013-06-28 08:20:43 -0700 Created attachment 205716 Patch Remove shapes skipping for EFL since it is apparently enabled now. 904641 5 205716 cdumez 2013-06-28 08:40:13 -0700 Comment on attachment 205716 Patch I cannot speak for the windows part but the EFL changes look good to me. 904705 6 205716 bfulgham 2013-06-28 11:01:50 -0700 Comment on attachment 205716 Patch r=me. 904708 7 205716 commit-queue 2013-06-28 11:09:00 -0700 Comment on attachment 205716 Patch Clearing flags on attachment: 205716 Committed r152180: <http://trac.webkit.org/changeset/152180> 904709 8 commit-queue 2013-06-28 11:09:04 -0700 All reviewed patches have been landed. Closing bug. 205714 2013-06-28 07:55:09 -0700 2013-06-28 08:20:40 -0700 Patch bug-118192-20130628075309.patch text/plain 2577 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMTY0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjQxYmE1ZWVlOTc3OTllNWE1NGVj ODU4YjBiYzAxYjQyNjhlNTBlNi4uZjBiNGEzMmJlZWM4ODU0ZGQ0NDFjYjMxZWNlNjMwOTg3YTkz YmQxMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA2LTI4ICBCZW0gSm9uZXMtQmV5ICA8 YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFVwZGF0ZSBUZXN0RXhwZWN0YXRpb25zIHNv IG5ldyBTaGFwZXMgdGVzdHMgYXJlIHNraXBwZWQgd2hlcmUgdGhlIG9sZCBvbmVzIHdlcmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODE5MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNoYXBlcyBzdGls bCBhcmVuJ3QgZW5hYmxlZCBvbiBzb21lIHBvcnRzLCBzbyBza2lwIHRoZSB0ZXN0cyB0aGVyZS4K KworICAgICAgICAqIHBsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBs YXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL3dpbmNhaXJv L1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTMtMDYtMjggIEdhYm9yIEFicmFoYW0gIDxhYnJobUBp bmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgW1F0XSBVbnJldmlld2VkIGdhcmRlbmluZy4gU2tp cHBpbmcgZmFpbGluZyB0ZXN0cywgYW5kIG1hdGhtbCB0ZXN0cyBiZWNhdXNlIG5vdCB5ZXQgc3Vw cG9ydGVkLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3Rh dGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBk ZDZlMzdmMjc2YjJjYzVhYTAzNjJmMzM2ZTczNTYzM2ZhOTQ0MDQzLi40M2ZmM2QxODVkMjMxYTYw NDVmNDBkZmUxNmI2MjRmZjc4ZWQ5YTRlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVz dEV4cGVjdGF0aW9ucwpAQCAtMzM4LDYgKzMzOCw3IEBAIEJ1ZyhFRkwpIGZhc3QvZm9ybXMvaW5w dXQtdGV4dC1jbGljay1vdXRzaWRlLmh0bWwKIAogIyBFeGNsdXNpb25zIGltcGxlbWVudGF0aW9u IG5vdCBjb21wbGV0ZSB5ZXQuCiB3ZWJraXQub3JnL2IvODM4OTggZmFzdC9leGNsdXNpb25zCit3 ZWJraXQub3JnL2IvODM4OTggY3Nzd2cvc3VibWl0dGVkL3NoYXBlcwogCiAjIENTUyBGaWx0ZXJz IHN1cHBvcnQgbm90IHlldCBlbmFibGVkIChuZWVkcyBFTkFCTEVfQ1NTX0ZJTFRFUlMpLgogd2Vi a2l0Lm9yZy9iLzg1NDY1IGNzczMvZmlsdGVycyBbIFNraXAgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd2luL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS93aW4vVGVzdEV4cGVjdGF0aW9ucwppbmRleCAxZDJmNDc5MWI5NTgyNGM3MjQ4YTBlNTM2YzRl ZjNmZTQ3ZTQxZTA1Li40YjYwNWU2NzUyYWQ5MWI1MmM4N2RjN2UxOWVmMDg4ODg4ZWE0NWQzIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9ucworKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTU3NCw2ICsx NTc0LDcgQEAgZmFzdC9yZWdpb25zCiAKICMgQ1NTIEV4Y2x1c2lvbnMgc3VwcG9ydCBub3QgeWV0 IGVuYWJsZWQuIGh0dHA6Ly93ZWJraXQub3JnL2IvNTczMTEKIGZhc3QvZXhjbHVzaW9ucworY3Nz d2cvc3VibWl0dGVkL3NoYXBlcwogCiAjIENhdXNlcyBhIFN5bnRheEVycm9yIChodHRwOi8vd2Vi a2l0Lm9yZy9iLzYyNTk1KS4KIGZhc3Qvd29ya2Vycy93b3JrZXItY3Jhc2gtd2l0aC1pbnZhbGlk LWxvY2F0aW9uLmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbmNhaXJv L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW5jYWlyby9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IGZhNzgzYTdkYzllNWZmZTA0MzdhZWYwNzMwNTkxNWM3NDZhMmMwNmUu LjA4NWU5NzZmM2M5NDU3NzdmOTRkZGIwNjJlM2E3MDM1ZGZlNGNkODYgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL3dpbmNhaXJvL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd2luY2Fpcm8vVGVzdEV4cGVjdGF0aW9ucwpAQCAtMjA3OCw2ICsyMDc4 LDcgQEAgZmFzdC9yZWdpb25zCiAKICMgQ1NTIEV4Y2x1c2lvbnMgc3VwcG9ydCBub3QgeWV0IGVu YWJsZWQuIGh0dHA6Ly93ZWJraXQub3JnL2IvNTczMTEKIGZhc3QvZXhjbHVzaW9ucworY3Nzd2cv c3VibWl0dGVkL3NoYXBlcwogCiAjIENhdXNlcyBhIFN5bnRheEVycm9yIChodHRwOi8vd2Via2l0 Lm9yZy9iLzYyNTk1KS4KIGZhc3Qvd29ya2Vycy93b3JrZXItY3Jhc2gtd2l0aC1pbnZhbGlkLWxv Y2F0aW9uLmh0bWwK 205716 2013-06-28 08:20:43 -0700 2013-06-28 11:08:59 -0700 Patch bug-118192-20130628081843.patch text/plain 2897 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMTY0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjQxYmE1ZWVlOTc3OTllNWE1NGVj ODU4YjBiYzAxYjQyNjhlNTBlNi4uNWE3OGMwZDI0YzI3Yzk0MGZhMTNiYzAwMmIxYjQwZDk4Mjg3 M2YxZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA2LTI4ICBCZW0gSm9uZXMtQmV5ICA8 YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFVwZGF0ZSBUZXN0RXhwZWN0YXRpb25zIHNv IG5ldyBTaGFwZXMgdGVzdHMgYXJlIHNraXBwZWQgd2hlcmUgdGhlIG9sZCBvbmVzIHdlcmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODE5MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNoYXBlcyBzdGls bCBhcmVuJ3QgZW5hYmxlZCBvbiBzb21lIHBvcnRzLCBzbyBza2lwIHRoZSB0ZXN0cyB0aGVyZS4K KyAgICAgICAgQXMgcGFydCBvZiB0aGlzIHBhdGNoLCBpdCB3YXMgZGlzY292ZXJlZCB0aGF0IHRo ZXkgd29yayBvbiBFRkwsIHNvIHRoZQorICAgICAgICBza2lwcGluZyBoYXMgYmVlbiByZW1vdmVk IGZyb20gdGhlcmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9uczoK KyAgICAgICAgKiBwbGF0Zm9ybS93aW4vVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0 Zm9ybS93aW5jYWlyby9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEzLTA2LTI4ICBHYWJvciBBYnJh aGFtICA8YWJyaG1AaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBn YXJkZW5pbmcuIFNraXBwaW5nIGZhaWxpbmcgdGVzdHMsIGFuZCBtYXRobWwgdGVzdHMgYmVjYXVz ZSBub3QgeWV0IHN1cHBvcnRlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Vm bC9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3Rh dGlvbnMKaW5kZXggZGQ2ZTM3ZjI3NmIyY2M1YWEwMzYyZjMzNmU3MzU2MzNmYTk0NDA0My4uZTgz NmE5MzUzM2I5NzhjOGVmNzRiMTU1OTIwNmMyMjg4ZjYzYmJkZiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTMzNiw5ICszMzYsNiBAQCB3ZWJraXQub3Jn L2IvNjU3MDkgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2Uub3V0c2lkZXNvdXJjZS5o dG1sIFsgRmFpbHVyZQogIyBCdWcgaW4gdGhlIHRlc3QgaXRzZWxmLCBhcyB0aGUgaW5wdXQgYm94 IGNhbiBiZSBiaWcgZW5vdWdoIGZvciB0aGUgZ2l2ZW4gY29vcmRpbmF0ZXMgdG8gYmUgaW5zaWRl IGl0LgogQnVnKEVGTCkgZmFzdC9mb3Jtcy9pbnB1dC10ZXh0LWNsaWNrLW91dHNpZGUuaHRtbAog Ci0jIEV4Y2x1c2lvbnMgaW1wbGVtZW50YXRpb24gbm90IGNvbXBsZXRlIHlldC4KLXdlYmtpdC5v cmcvYi84Mzg5OCBmYXN0L2V4Y2x1c2lvbnMKLQogIyBDU1MgRmlsdGVycyBzdXBwb3J0IG5vdCB5 ZXQgZW5hYmxlZCAobmVlZHMgRU5BQkxFX0NTU19GSUxURVJTKS4KIHdlYmtpdC5vcmcvYi84NTQ2 NSBjc3MzL2ZpbHRlcnMgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi84NTQ2NSBjb21wb3NpdGluZy9m aWx0ZXJzIFsgU2tpcCBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vVGVz dEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25z CmluZGV4IDFkMmY0NzkxYjk1ODI0YzcyNDhhMGU1MzZjNGVmM2ZlNDdlNDFlMDUuLjRiNjA1ZTY3 NTJhZDkxYjUyYzg3ZGM3ZTE5ZWYwODg4ODhlYTQ1ZDMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL3dpbi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L3dpbi9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNTc0LDYgKzE1NzQsNyBAQCBmYXN0L3JlZ2lvbnMK IAogIyBDU1MgRXhjbHVzaW9ucyBzdXBwb3J0IG5vdCB5ZXQgZW5hYmxlZC4gaHR0cDovL3dlYmtp dC5vcmcvYi81NzMxMQogZmFzdC9leGNsdXNpb25zCitjc3N3Zy9zdWJtaXR0ZWQvc2hhcGVzCiAK ICMgQ2F1c2VzIGEgU3ludGF4RXJyb3IgKGh0dHA6Ly93ZWJraXQub3JnL2IvNjI1OTUpLgogZmFz dC93b3JrZXJzL3dvcmtlci1jcmFzaC13aXRoLWludmFsaWQtbG9jYXRpb24uaHRtbApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luY2Fpcm8vVGVzdEV4cGVjdGF0aW9ucyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL3dpbmNhaXJvL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZmE3ODNh N2RjOWU1ZmZlMDQzN2FlZjA3MzA1OTE1Yzc0NmEyYzA2ZS4uMDg1ZTk3NmYzYzk0NTc3N2Y5NGRk YjA2MmUzYTcwMzVkZmU0Y2Q4NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2lu Y2Fpcm8vVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW5jYWly by9UZXN0RXhwZWN0YXRpb25zCkBAIC0yMDc4LDYgKzIwNzgsNyBAQCBmYXN0L3JlZ2lvbnMKIAog IyBDU1MgRXhjbHVzaW9ucyBzdXBwb3J0IG5vdCB5ZXQgZW5hYmxlZC4gaHR0cDovL3dlYmtpdC5v cmcvYi81NzMxMQogZmFzdC9leGNsdXNpb25zCitjc3N3Zy9zdWJtaXR0ZWQvc2hhcGVzCiAKICMg Q2F1c2VzIGEgU3ludGF4RXJyb3IgKGh0dHA6Ly93ZWJraXQub3JnL2IvNjI1OTUpLgogZmFzdC93 b3JrZXJzL3dvcmtlci1jcmFzaC13aXRoLWludmFsaWQtbG9jYXRpb24uaHRtbAo=