118186 2013-06-28 05:12:48 -0700 [Autotools] Properly quote harfbuzz-icu pkg-config check 2013-06-28 06:32:26 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Minor --- 1 sean webkit-unassigned cgarcia commit-queue gustavo mrobinson zan oldest_to_newest 904572 0 sean 2013-06-28 05:12:48 -0700 A secondary test was added to check for harfbuzz-icu when it was split but the test wasn't properly quoted. If the test fails you get an error about missing version "./configure.9.8" instead of the expected "0.9.8". 904577 1 205701 sean 2013-06-28 05:23:09 -0700 Created attachment 205701 Patch 904580 2 zan 2013-06-28 05:29:26 -0700 The patch looks OK, but requires a ChangeLog entry. The contributing documentation has some guidelines on how to prepare the ChangeLog. http://www.webkit.org/coding/contributing.html 904583 3 205703 sean 2013-06-28 05:36:58 -0700 Created attachment 205703 Patch 904584 4 sean 2013-06-28 05:39:06 -0700 (In reply to comment #2) > The patch looks OK, but requires a ChangeLog entry. Yes I had some issues with webkit-patch, so I manually created a diff with a ChangeLog entry and uploaded directly. 904586 5 cgarcia 2013-06-28 05:41:11 -0700 Thanks for adding the changelog entry, but could you explain in the changelog what's the problem you are fixing? something similar to the first comment in this bug. 904589 6 205705 sean 2013-06-28 05:46:15 -0700 Created attachment 205705 Patch 904590 7 sean 2013-06-28 05:47:38 -0700 (In reply to comment #5) > but could you explain in the changelog what's the problem you are fixing? I've included more detail in the most recent attachment. 904592 8 205705 cgarcia 2013-06-28 05:52:51 -0700 Comment on attachment 205705 Patch Thanks! It seems there are more cases like this one in FindDependencies.m4 we should fix them also eventually. 904598 9 205705 commit-queue 2013-06-28 06:32:24 -0700 Comment on attachment 205705 Patch Clearing flags on attachment: 205705 Committed r152163: <http://trac.webkit.org/changeset/152163> 904599 10 commit-queue 2013-06-28 06:32:26 -0700 All reviewed patches have been landed. Closing bug. 205701 2013-06-28 05:23:09 -0700 2013-06-28 05:27:26 -0700 Patch bug-118186-20130628082105.patch text/plain 734 sean SW5kZXg6IFNvdXJjZS9hdXRvdG9vbHMvRmluZERlcGVuZGVuY2llcy5tNAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMubTQJKHJldmlzaW9uIDE1MjE2MSkK KysrIFNvdXJjZS9hdXRvdG9vbHMvRmluZERlcGVuZGVuY2llcy5tNAkod29ya2luZyBjb3B5KQpA QCAtMzc4LDcgKzM3OCw3IEBAIGZpCiAjIEhhcmZCdXp6IDAuOS4xOCBzcGxpdHMgaGFyYnV6ei1p Y3UgaW50byBhIHNlcGFyYXRlIGxpYnJhcnkuCiAjIFNpbmNlIHdlIHN1cHBvcnQgZWFybGllciBI YXJmQnV6eiB2ZXJzaW9ucyB3ZSBrZWVwIHRoaXMgY29uZGl0aW9uYWwgZm9yIG5vdy4KIGlmICRQ S0dfQ09ORklHIC0tYXRsZWFzdC12ZXJzaW9uIDAuOS4xOCBoYXJmYnV6ejsgdGhlbgotICAgIFBL R19DSEVDS19NT0RVTEVTKEhBUkZCVVpaX0lDVSwgaGFyZmJ1enotaWN1ID49ICRoYXJmYnV6el9y ZXF1aXJlZF92ZXJzaW9uKQorICAgIFBLR19DSEVDS19NT0RVTEVTKFtIQVJGQlVaWl9JQ1VdLCBb aGFyZmJ1enotaWN1ID49IGhhcmZidXp6X3JlcXVpcmVkX3ZlcnNpb25dKQogICAgIEZSRUVUWVBF X0NGTEFHUz0iJEZSRUVUWVBFX0NGTEFHUyAkSEFSRkJVWlpfSUNVX0NGTEFHUyIKICAgICBGUkVF VFlQRV9MSUJTPSIkRlJFRVRZUEVfTElCUyAkSEFSRkJVWlpfSUNVX0xJQlMiCiBmaQo= 205703 2013-06-28 05:36:58 -0700 2013-06-28 05:46:15 -0700 Patch harfbuzz-icu.diff text/plain 1277 sean SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjE2 MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA2 LTI4ICBTZWFuIEJyaWdodCAgPHNlYW5AbWFsbGVhYmxlLmNvbT4KKworICAgICAgICBbQXV0b3Rv b2xzXSBQcm9wZXJseSBxdW90ZSBoYXJmYnV6ei1pY3UgcGtnLWNvbmZpZyBjaGVjaworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MTg2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rv b2xzL0ZpbmREZXBlbmRlbmNpZXMubTQ6CisKIDIwMTMtMDYtMjcgIENocmlzdG9waGUgRHVtZXog IDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFJlbW92ZSBbTm9JbnRlcmZh Y2VPYmplY3RdIGZyb20gV29ya2VyR2xvYmFsU2NvcGUKSW5kZXg6IFNvdXJjZS9hdXRvdG9vbHMv RmluZERlcGVuZGVuY2llcy5tNAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmRE ZXBlbmRlbmNpZXMubTQJKHJldmlzaW9uIDE1MjE2MSkKKysrIFNvdXJjZS9hdXRvdG9vbHMvRmlu ZERlcGVuZGVuY2llcy5tNAkod29ya2luZyBjb3B5KQpAQCAtMzc4LDcgKzM3OCw3IEBACiAjIEhh cmZCdXp6IDAuOS4xOCBzcGxpdHMgaGFyYnV6ei1pY3UgaW50byBhIHNlcGFyYXRlIGxpYnJhcnku CiAjIFNpbmNlIHdlIHN1cHBvcnQgZWFybGllciBIYXJmQnV6eiB2ZXJzaW9ucyB3ZSBrZWVwIHRo aXMgY29uZGl0aW9uYWwgZm9yIG5vdy4KIGlmICRQS0dfQ09ORklHIC0tYXRsZWFzdC12ZXJzaW9u IDAuOS4xOCBoYXJmYnV6ejsgdGhlbgotICAgIFBLR19DSEVDS19NT0RVTEVTKEhBUkZCVVpaX0lD VSwgaGFyZmJ1enotaWN1ID49ICRoYXJmYnV6el9yZXF1aXJlZF92ZXJzaW9uKQorICAgIFBLR19D SEVDS19NT0RVTEVTKFtIQVJGQlVaWl9JQ1VdLCBbaGFyZmJ1enotaWN1ID49IGhhcmZidXp6X3Jl cXVpcmVkX3ZlcnNpb25dKQogICAgIEZSRUVUWVBFX0NGTEFHUz0iJEZSRUVUWVBFX0NGTEFHUyAk SEFSRkJVWlpfSUNVX0NGTEFHUyIKICAgICBGUkVFVFlQRV9MSUJTPSIkRlJFRVRZUEVfTElCUyAk SEFSRkJVWlpfSUNVX0xJQlMiCiBmaQo= 205705 2013-06-28 05:46:15 -0700 2013-06-28 06:32:24 -0700 Patch harfbuzz-icu.diff text/plain 1562 sean SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjE2 MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA2 LTI4ICBTZWFuIEJyaWdodCAgPHNlYW5AbWFsbGVhYmxlLmNvbT4KKworICAgICAgICBbQXV0b3Rv b2xzXSBQcm9wZXJseSBxdW90ZSBoYXJmYnV6ei1pY3UgcGtnLWNvbmZpZyBjaGVjaworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MTg2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBzZWNvbmRhcnkgdGVz dCB3YXMgYWRkZWQgaW4gcjE1MDk2MyB0byBjaGVjayBmb3IgaGFyZmJ1enotaWN1CisgICAgICAg IHdoZW4gaXQgd2FzIHNwbGl0IGludG8gdHdvIHBhY2thZ2VzLCBidXQgdGhlIHRlc3QgaXMgbm90 IHByb3Blcmx5CisgICAgICAgIHF1b3RlZC4gIElmIHRoZSB0ZXN0IGZhaWxzIHlvdSBnZXQgYW4g ZXJyb3IgYWJvdXQgbWlzc2luZworICAgICAgICB2ZXJzaW9uICIuL2NvbmZpZ3VyZS45LjgiIGlu c3RlYWQgb2YgdGhlIGV4cGVjdGVkICIwLjkuOC4iCisKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rv b2xzL0ZpbmREZXBlbmRlbmNpZXMubTQ6CisKIDIwMTMtMDYtMjcgIENocmlzdG9waGUgRHVtZXog IDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIFJlbW92ZSBbTm9JbnRlcmZh Y2VPYmplY3RdIGZyb20gV29ya2VyR2xvYmFsU2NvcGUKSW5kZXg6IFNvdXJjZS9hdXRvdG9vbHMv RmluZERlcGVuZGVuY2llcy5tNAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmRE ZXBlbmRlbmNpZXMubTQJKHJldmlzaW9uIDE1MjE2MSkKKysrIFNvdXJjZS9hdXRvdG9vbHMvRmlu ZERlcGVuZGVuY2llcy5tNAkod29ya2luZyBjb3B5KQpAQCAtMzc4LDcgKzM3OCw3IEBACiAjIEhh cmZCdXp6IDAuOS4xOCBzcGxpdHMgaGFyYnV6ei1pY3UgaW50byBhIHNlcGFyYXRlIGxpYnJhcnku CiAjIFNpbmNlIHdlIHN1cHBvcnQgZWFybGllciBIYXJmQnV6eiB2ZXJzaW9ucyB3ZSBrZWVwIHRo aXMgY29uZGl0aW9uYWwgZm9yIG5vdy4KIGlmICRQS0dfQ09ORklHIC0tYXRsZWFzdC12ZXJzaW9u IDAuOS4xOCBoYXJmYnV6ejsgdGhlbgotICAgIFBLR19DSEVDS19NT0RVTEVTKEhBUkZCVVpaX0lD VSwgaGFyZmJ1enotaWN1ID49ICRoYXJmYnV6el9yZXF1aXJlZF92ZXJzaW9uKQorICAgIFBLR19D SEVDS19NT0RVTEVTKFtIQVJGQlVaWl9JQ1VdLCBbaGFyZmJ1enotaWN1ID49IGhhcmZidXp6X3Jl cXVpcmVkX3ZlcnNpb25dKQogICAgIEZSRUVUWVBFX0NGTEFHUz0iJEZSRUVUWVBFX0NGTEFHUyAk SEFSRkJVWlpfSUNVX0NGTEFHUyIKICAgICBGUkVFVFlQRV9MSUJTPSIkRlJFRVRZUEVfTElCUyAk SEFSRkJVWlpfSUNVX0xJQlMiCiBmaQo=