118177 2013-06-28 02:38:11 -0700 Use gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requisition 2013-06-28 04:00:17 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 0 itoral webkit-unassigned commit-queue oldest_to_newest 904517 0 itoral 2013-06-28 02:38:11 -0700 Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp uses deprecated function gtk_widget_get_requisition, which produces compilation warnings. I'll attach a patch shortly to use gtk_widget_get_preferred_size instead, which is the function used to implement gtk_widget_get_requisition in GTK. 904520 1 205683 itoral 2013-06-28 02:41:51 -0700 Created attachment 205683 Proposed patch 904525 2 205683 cgarcia 2013-06-28 02:52:15 -0700 Comment on attachment 205683 Proposed patch Thanks! 904546 3 205683 commit-queue 2013-06-28 04:00:15 -0700 Comment on attachment 205683 Proposed patch Clearing flags on attachment: 205683 Committed r152159: <http://trac.webkit.org/changeset/152159> 904547 4 commit-queue 2013-06-28 04:00:17 -0700 All reviewed patches have been landed. Closing bug. 205683 2013-06-28 02:41:51 -0700 2013-06-28 04:00:15 -0700 Proposed patch webkit-bug-118177.patch text/plain 1367 itoral SW5kZXg6IFNvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21l Q2xpZW50R3RrLmNwcAkocmV2aXNpb24gMTUyMTUyKQorKysgU291cmNlL1dlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzQ2LDcg Kzc0Niw3IEBACiAgICAgLy8gb3RoZXJ3aXNlIHdlIGdldCBpbnRvIGFuIGluZmluaXRlIGxvb3Ah CiAgICAgR3RrV2lkZ2V0KiB3aWRnZXQgPSBHVEtfV0lER0VUKG1fd2ViVmlldyk7CiAgICAgR3Rr UmVxdWlzaXRpb24gcmVxdWlzaXRpb247Ci0gICAgZ3RrX3dpZGdldF9nZXRfcmVxdWlzaXRpb24o d2lkZ2V0LCAmcmVxdWlzaXRpb24pOworICAgIGd0a193aWRnZXRfZ2V0X3ByZWZlcnJlZF9zaXpl KHdpZGdldCwgJnJlcXVpc2l0aW9uLCAwKTsKICAgICBpZiAoZ3RrX3dpZGdldF9nZXRfcmVhbGl6 ZWQod2lkZ2V0KQogICAgICAgICAmJiAocmVxdWlzaXRpb24uaGVpZ2h0ICE9IHNpemUuaGVpZ2h0 KCkKICAgICAgICAgfHwgcmVxdWlzaXRpb24ud2lkdGggIT0gc2l6ZS53aWR0aCgpKSkKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MjE1NykKKysrIFNvdXJjZS9XZWJLaXQvZ3RrL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA2LTI4ICBJYWdv IFRvcmFsIFF1aXJvZ2EgIDxpdG9yYWxAaWdhbGlhLmNvbT4KKworICAgICAgICBVc2UgZ3RrX3dp ZGdldF9nZXRfcHJlZmVycmVkX3NpemUgaW5zdGVhZCBvZiBkZXByZWNhdGVkIGd0a193aWRnZXRf Z2V0X3JlcXVpc2l0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTgxNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHA6CisgICAgICAgIChX ZWJLaXQ6OkNocm9tZUNsaWVudDo6Y29udGVudHNTaXplQ2hhbmdlZCk6CisKIDIwMTMtMDYtMjcg IElhZ28gVG9yYWwgUXVpcm9nYSAgPGl0b3JhbEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVzZSBj b25zaXN0ZW50IGZpbGUgbmFtZXMgZm9yIFdpZGdldEJhY2tpbmdTdG9yZUd0a1gxMSBjbGFzcwo=