118169 2013-06-27 22:11:42 -0700 REGRESSION(151586): multipart/x-mixed-replace images are broken 2013-06-29 00:26:26 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://158.250.33.102/view/view.htm InRadar P2 Normal --- 115804 1 ap webkit-unassigned cdumez cgarcia commit-queue japhet thorton oldest_to_newest 904447 0 ap 2013-06-27 22:11:42 -0700 <http://trac.webkit.org/changeset/151586> broke a lot of webcam sites, such as <http://158.250.33.102/view/view.htm>. <rdar://problem/14242032> 904480 1 cgarcia 2013-06-28 01:04:36 -0700 It works for me, what's exactly broken? 904496 2 thorton 2013-06-28 01:45:48 -0700 I get corrupt and/or partial images in Safari. 904526 3 cgarcia 2013-06-28 02:53:35 -0700 Actually it crashes for me in another laptop I've tried, I'm looking at it. 904527 4 thorton 2013-06-28 02:54:09 -0700 (In reply to comment #3) > Actually it crashes for me in another laptop I've tried, I'm looking at it. Yeah, I think we see that in some places too. 904533 5 205689 cgarcia 2013-06-28 03:17:38 -0700 Created attachment 205689 Patch In case of multipart content we always have to copy the data, I removed that by mistake in r151586. 904544 6 cdumez 2013-06-28 03:56:10 -0700 Visiting http://158.250.33.102/view/view.htm also makes EFL wk1 and wk2 crash. Backtrace: http://pastebin.com/xLcPkHHg 904555 7 cgarcia 2013-06-28 04:21:24 -0700 (In reply to comment #6) > Visiting http://158.250.33.102/view/view.htm also makes EFL wk1 and wk2 crash. > Backtrace: http://pastebin.com/xLcPkHHg Thanks for testing it, yes, same crash I got, the attached patch fixes the crash. 904669 8 205689 ap 2013-06-28 09:44:35 -0700 Comment on attachment 205689 Patch r=me to land just the fix to adddress the regression ASAP, however please consider making a regression test as a follow-up bug. 904842 9 cgarcia 2013-06-29 00:24:36 -0700 (In reply to comment #8) > (From update of attachment 205689 [details]) > r=me to land just the fix to adddress the regression ASAP, however please consider making a regression test as a follow-up bug. Yes, I thought about it, but I didn't have time to understand how multipart layout tests work and how to write a new one (not that this was not easy to reproduce and had different effects to different people), so I submitted the patch without a test because it fixes a crash. I'll try to make a test next week. 904843 10 cgarcia 2013-06-29 00:26:26 -0700 Committed r152207: <http://trac.webkit.org/changeset/152207> 205689 2013-06-28 03:17:38 -0700 2013-06-28 09:44:35 -0700 Patch wcore-multipart-crash.diff text/plain 1850 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNTEyMzc3Li5lNDk4NTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDYtMjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04oMTUxNTg2KTogbXVsdGlwYXJ0L3gtbWl4ZWQtcmVwbGFj ZSBpbWFnZXMgYXJlIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE4MTY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2hlbiBsb2FkaW5nIG11bHRpcGFydCBjb250ZW50IHRoZSByZXNvdXJjZSBk YXRhIHdpbGwgY2hhbmdlIGFzCisgICAgICAgIHRoZSBuZXh0IHBhcnQgaXMgbG9hZGVkLCBzbyB3 ZSBuZWVkIHRvIG1ha2UgYSBjb3B5IG9mIHRoZSBkYXRhCisgICAgICAgIGJlZm9yZSBzZW5kaW5n IGl0IHRvIHRoZSByZXNvdXJjZS4KKworICAgICAgICAqIGxvYWRlci9TdWJyZXNvdXJjZUxvYWRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdWJyZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJl c3BvbnNlKToKKwogMjAxMy0wNi0yNyAgS2FuZ2lsIEhhbiAgPGthbmdpbC5oYW5Ac2Ftc3VuZy5j b20+CiAKICAgICAgICAgSFRNTEF1ZGlvRWxlbWVudCBkb2Vzbid0IGhhdmUgdG8ga25vdyBhYm91 dCBpc1ZpZGVvIGZ1bmN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3Vi cmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9h ZGVyLmNwcAppbmRleCBhZjI2ZTMwLi43MjE3ZTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9TdWJyZXNvdXJjZUxvYWRlci5jcHAKQEAgLTIwNSw3ICsyMDUsOSBAQCB2b2lkIFN1YnJlc291 cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVz cG9uc2UpCiAKICAgICBSZWZQdHI8UmVzb3VyY2VCdWZmZXI+IGJ1ZmZlciA9IHJlc291cmNlRGF0 YSgpOwogICAgIGlmIChtX2xvYWRpbmdNdWx0aXBhcnRDb250ZW50ICYmIGJ1ZmZlciAmJiBidWZm ZXItPnNpemUoKSkgewotICAgICAgICBtX3Jlc291cmNlLT5maW5pc2hMb2FkaW5nKGJ1ZmZlci5n ZXQoKSk7CisgICAgICAgIC8vIFRoZSByZXNvdXJjZSBkYXRhIHdpbGwgY2hhbmdlIGFzIHRoZSBu ZXh0IHBhcnQgaXMgbG9hZGVkLCBzbyB3ZSBuZWVkIHRvIG1ha2UgYSBjb3B5LgorICAgICAgICBS ZWZQdHI8UmVzb3VyY2VCdWZmZXI+IGNvcGllZERhdGEgPSBSZXNvdXJjZUJ1ZmZlcjo6Y3JlYXRl KGJ1ZmZlci0+ZGF0YSgpLCBidWZmZXItPnNpemUoKSk7CisgICAgICAgIG1fcmVzb3VyY2UtPmZp bmlzaExvYWRpbmcoY29waWVkRGF0YS5nZXQoKSk7CiAgICAgICAgIGNsZWFyUmVzb3VyY2VEYXRh KCk7CiAgICAgICAgIC8vIFNpbmNlIGEgc3VicmVzb3VyY2UgbG9hZGVyIGRvZXMgbm90IGxvYWQg bXVsdGlwYXJ0IHNlY3Rpb25zIHByb2dyZXNzaXZlbHksIGRhdGEgd2FzIGRlbGl2ZXJlZCB0byB0 aGUgbG9hZGVyIGFsbCBhdCBvbmNlLiAgICAgICAgCiAgICAgICAgIC8vIEFmdGVyIHRoZSBmaXJz dCBtdWx0aXBhcnQgc2VjdGlvbiBpcyBjb21wbGV0ZSwgc2lnbmFsIHRvIGRlbGVnYXRlcyB0aGF0 IHRoaXMgbG9hZCBpcyAiZmluaXNoZWQiIAo=