118147 2013-06-27 14:16:58 -0700 [BlackBerry] Unnecessary root layer commits occur during html5 video playback 2013-06-27 15:41:10 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo commit-queue oldest_to_newest 904348 0 anlo 2013-06-27 14:16:58 -0700 Playing html5 video fullscreen with no controls should not cause root layer commits. Currently it does since the progress event timer for the video element calls GraphicsLayerBlackBerry::setContentsToMedia continuously. 904351 1 205636 anlo 2013-06-27 14:27:00 -0700 Created attachment 205636 Patch 904352 2 205636 rwlbuis 2013-06-27 14:28:59 -0700 Comment on attachment 205636 Patch LGTM. 904363 3 205636 commit-queue 2013-06-27 15:41:08 -0700 Comment on attachment 205636 Patch Clearing flags on attachment: 205636 Committed r152132: <http://trac.webkit.org/changeset/152132> 904364 4 commit-queue 2013-06-27 15:41:10 -0700 All reviewed patches have been landed. Closing bug. 205636 2013-06-27 14:27:00 -0700 2013-06-27 15:41:08 -0700 Patch bug-118147-20130627172740.patch text/plain 2585 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxOTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFhZWU3YTg4ZjRhMThj NDY1YmQwYTU4YzI0ZjRmNTFmZTYwYTA2OS4uOTVjMzQzNjk1M2RkNWVjZWY0YjU0NzU3ZmY4Mzc2 NzQyYmQyYzg4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA2LTI3ICBBbmRy ZXcgTG8gIDxhbmxvQGJsYWNrYmVycnkuY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBVbm5l Y2Vzc2FyeSByb290IGxheWVyIGNvbW1pdHMgb2NjdXIgZHVyaW5nIGh0bWw1IHZpZGVvIHBsYXli YWNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgx NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgSW50ZXJu YWxseSByZXZpZXdlZCBieSBBcnZpZCBOaWxzc29uLCBKb2huIEdyaWdncy4KKworICAgICAgICBP bmx5IHJlcXVlc3QgbGF5ZXIgY29tbWl0cyB3aGVuIGxheWVyIHByb3BlcnRpZXMgY2hhbmdlIGlu CisgICAgICAgIEdyYXBoaWNzTGF5ZXJCbGFja0JlcnJ5Ojp1cGRhdGVDb250ZW50c1JlY3QgYW5k CisgICAgICAgIEdyYXBoaWNzTGF5ZXJCbGFja0JlcnJ5OjpzZXRDb250ZW50c1RvTWVkaWEuCisg ICAgICAgIEpJUkExMTI3NDkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2Jl cnJ5L0dyYXBoaWNzTGF5ZXJCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBo aWNzTGF5ZXJCbGFja0JlcnJ5OjpzZXRDb250ZW50c1RvTWVkaWEpOgorICAgICAgICAoV2ViQ29y ZTo6R3JhcGhpY3NMYXllckJsYWNrQmVycnk6OnVwZGF0ZUNvbnRlbnRzUmVjdCk6CisKIDIwMTMt MDYtMDcgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JF U1NJT04gKHIxNTEwODgpOiBDcmFzaCBuYXZpZ2F0aW5nIGF3YXkgZnJvbSBub24tbG9hZGVkIG1h aW4gcmVzb3VyY2VzIHdpdGggbm9uLWxvYWRlZCBzY3JpcHRzLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0xheWVyQmxhY2tC ZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dy YXBoaWNzTGF5ZXJCbGFja0JlcnJ5LmNwcAppbmRleCBhNGVmOTQ4NDA0Yjc0ZjcxZWQwZDM2M2Q4 NGY1ZTBjYmQ2Njc1MzE0Li4yYzQ5OTRhMzQ1NzViM2RhYTljMTdhNTk5ZmFmMDM0N2U0MmIzZWI3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5 L0dyYXBoaWNzTGF5ZXJCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzTGF5ZXJCbGFja0JlcnJ5LmNwcApAQCAtNTY5 LDggKzU2OSwxMSBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJCbGFja0JlcnJ5OjpzZXRDb250ZW50c1Rv TWVkaWEoUGxhdGZvcm1MYXllciogbGF5ZXIpCiAgICAgICAgICAgICBtX2NvbnRlbnRzTGF5ZXJQ dXJwb3NlID0gQ29udGVudHNMYXllckZvclZpZGVvOwogICAgICAgICAgICAgY2hpbGRyZW5DaGFu Z2VkID0gdHJ1ZTsKICAgICAgICAgfQotICAgICAgICBsYXllci0+c2V0T3duZXIodGhpcyk7Ci0g ICAgICAgIGxheWVyLT5zZXROZWVkc0Rpc3BsYXkoKTsKKworICAgICAgICBpZiAobGF5ZXItPm93 bmVyKCkgIT0gdGhpcykgeworICAgICAgICAgICAgbGF5ZXItPnNldE93bmVyKHRoaXMpOworICAg ICAgICAgICAgbGF5ZXItPnNldE5lZWRzRGlzcGxheSgpOworICAgICAgICB9CiAgICAgICAgIHVw ZGF0ZUNvbnRlbnRzUmVjdCgpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIGlmIChtX2NvbnRlbnRz TGF5ZXIpIHsKQEAgLTg1NCw4ICs4NTcsMTEgQEAgdm9pZCBHcmFwaGljc0xheWVyQmxhY2tCZXJy eTo6dXBkYXRlQ29udGVudHNSZWN0KCkKICAgICBpZiAoIW1fY29udGVudHNMYXllcikKICAgICAg ICAgcmV0dXJuOwogCi0gICAgbV9jb250ZW50c0xheWVyLT5zZXRQb3NpdGlvbihtX2NvbnRlbnRz UmVjdC5sb2NhdGlvbigpKTsKLSAgICBtX2NvbnRlbnRzTGF5ZXItPnNldEJvdW5kcyhtX2NvbnRl bnRzUmVjdC5zaXplKCkpOworICAgIGlmIChtX2NvbnRlbnRzTGF5ZXItPnBvc2l0aW9uKCkgIT0g bV9jb250ZW50c1JlY3QubG9jYXRpb24oKSkKKyAgICAgICAgbV9jb250ZW50c0xheWVyLT5zZXRQ b3NpdGlvbihtX2NvbnRlbnRzUmVjdC5sb2NhdGlvbigpKTsKKworICAgIGlmIChtX2NvbnRlbnRz TGF5ZXItPmJvdW5kcygpICE9IG1fY29udGVudHNSZWN0LnNpemUoKSkKKyAgICAgICAgbV9jb250 ZW50c0xheWVyLT5zZXRCb3VuZHMobV9jb250ZW50c1JlY3Quc2l6ZSgpKTsKIH0KIAogdm9pZCBH cmFwaGljc0xheWVyQmxhY2tCZXJyeTo6c2V0dXBDb250ZW50c0xheWVyKExheWVyV2ViS2l0VGhy ZWFkKiBjb250ZW50c0xheWVyKQo=