118144 2013-06-27 12:25:40 -0700 Fix the CLoop LLINT build on the FTL branch 2013-07-11 17:01:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mark.lam mhahnenberg oldest_to_newest 904319 0 mhahnenberg 2013-06-27 12:25:40 -0700 We should probably fix this. 907778 1 206496 mark.lam 2013-07-11 16:52:49 -0700 Created attachment 206496 the patch 907781 2 206496 mhahnenberg 2013-07-11 16:57:29 -0700 Comment on attachment 206496 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=206496&action=review r=me with comment. > Source/JavaScriptCore/runtime/Structure.cpp:36 > +#include <wtf/CommaPrinter.h> Do we need this? 907782 3 mark.lam 2013-07-11 16:58:28 -0700 (In reply to comment #2) > (From update of attachment 206496 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206496&action=review > > r=me with comment. > > > Source/JavaScriptCore/runtime/Structure.cpp:36 > > +#include <wtf/CommaPrinter.h> > > Do we need this? I added it because the compiler was complaining without it. So, yes, it's needed. 907783 4 mhahnenberg 2013-07-11 16:58:57 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 206496 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=206496&action=review > > > > r=me with comment. > > > > > Source/JavaScriptCore/runtime/Structure.cpp:36 > > > +#include <wtf/CommaPrinter.h> > > > > Do we need this? > > I added it because the compiler was complaining without it. So, yes, it's needed. Fair enough, sounds good! 907785 5 mark.lam 2013-07-11 17:01:41 -0700 Landed in r152581: <http://trac.webkit.org/changeset/152581>. 206496 2013-07-11 16:52:49 -0700 2013-07-11 16:57:29 -0700 the patch bug-118144.patch text/plain 6827 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTUyNTc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDEzLTA3LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXN1cnJlY3QgdGhlIENMb29wIExMSU5UIG9uIHRoZSBGVEwgYnJhbmNoLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MTQ0LgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2Nr Lmg6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6aml0VHlwZSk6CisgICAgICAgICAgLSBGaXgg dGhlIENvZGVCbG9jayBqaXRUeXBlIHRvIGJlIEludGVycHJldGVyVGh1bmsgd2hlbiAhRU5BQkxF X0pJVC4KKyAgICAgICAgKiBieXRlY29kZS9KdW1wVGFibGUuaDoKKyAgICAgICAgKEpTQzo6U2lt cGxlSnVtcFRhYmxlOjpjbGVhcik6CisgICAgICAgICogaW50ZXJwcmV0ZXIvU3RhY2tJdGVyYXRv ci5jcHA6CisgICAgICAgIChKU0M6OlN0YWNrSXRlcmF0b3I6OkZyYW1lOjpieXRlY29kZU9mZnNl dCk6CisgICAgICAgIChKU0M6OlN0YWNrSXRlcmF0b3I6OkZyYW1lOjpwcmludCk6CisgICAgICAg ICogaml0L0pJVENvZGUuY3BwOgorICAgICAgICAoSlNDKToKKyAgICAgICAgKiBqaXQvSklURXhj ZXB0aW9ucy5jcHA6CisgICAgICAgIChKU0M6OmdldEV4Y2VwdGlvbkxvY2F0aW9uKToKKyAgICAg ICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmNwcDoKKyAgICAgICAgKiBvZmZsaW5lYXNt L2Nsb29wLnJiOgorICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlLmNwcDoKKwogMjAxMy0wNy0x MCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgTWVyZ2VkIGZyb20g aHR0cDovL3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0L3RydW5rCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCShyZXZpc2lvbiAxNTI1Nzkp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgJKHdvcmtpbmcg Y29weSkKQEAgLTMwNyw3ICszMDcsNyBAQCBwdWJsaWM6CiAKICAgICBib29sIGhhc09wdGltaXpl ZFJlcGxhY2VtZW50KCk7CiAjZWxzZQotICAgIEpJVENvZGU6OkpJVFR5cGUgaml0VHlwZSgpIGNv bnN0IHsgcmV0dXJuIEpJVENvZGU6OkJhc2VsaW5lSklUOyB9CisgICAgSklUQ29kZTo6SklUVHlw ZSBqaXRUeXBlKCkgY29uc3QgeyByZXR1cm4gSklUQ29kZTo6SW50ZXJwcmV0ZXJUaHVuazsgfQog I2VuZGlmCiAKICAgICBTY3JpcHRFeGVjdXRhYmxlKiBvd25lckV4ZWN1dGFibGUoKSBjb25zdCB7 IHJldHVybiBtX293bmVyRXhlY3V0YWJsZS5nZXQoKTsgfQpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL0p1bXBUYWJsZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9KdW1wVGFibGUuaAkocmV2aXNpb24gMTUyNTc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0p1bXBUYWJsZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0x MDUsNyArMTA1LDkgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHZvaWQgY2xlYXIoKQogICAg ICAgICB7CiAgICAgICAgICAgICBicmFuY2hPZmZzZXRzLmNsZWFyKCk7CisjaWYgRU5BQkxFKEpJ VCkKICAgICAgICAgICAgIGN0aU9mZnNldHMuY2xlYXIoKTsKKyNlbmRpZgogICAgICAgICB9CiAg ICAgfTsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL1N0YWNrSXRl cmF0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRl ci9TdGFja0l0ZXJhdG9yLmNwcAkocmV2aXNpb24gMTUyNTc5KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2ludGVycHJldGVyL1N0YWNrSXRlcmF0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NDcsOCArMTQ3LDEwIEBAIHVuc2lnbmVkIFN0YWNrSXRlcmF0b3I6OkZyYW1lOjpieXRlY29kZU8K IHsKICAgICBpZiAoIWlzSlNGcmFtZSgpKQogICAgICAgICByZXR1cm4gMDsKKyNpZiBFTkFCTEUo REZHX0pJVCkKICAgICBpZiAoaGFzTG9jYXRpb25Bc0NvZGVPcmlnaW5JbmRleCgpKQogICAgICAg ICByZXR1cm4gYnl0ZWNvZGVPZmZzZXRGcm9tQ29kZU9yaWdpbkluZGV4KCk7CisjZW5kaWYKICAg ICByZXR1cm4gbG9jYXRpb25Bc0J5dGVjb2RlT2Zmc2V0KCk7CiB9CiAKQEAgLTM2NCwxOCArMzY2 LDIyIEBAIHZvaWQgU3RhY2tJdGVyYXRvcjo6RnJhbWU6OnByaW50KGludCBpbmQKICAgICAgICAg aWYgKGhhc0xvY2F0aW9uQXNCeXRlY29kZU9mZnNldCgpKSB7CiAgICAgICAgICAgICB1bnNpZ25l ZCBieXRlY29kZU9mZnNldCA9IGxvY2F0aW9uQXNCeXRlY29kZU9mZnNldCgpOwogICAgICAgICAg ICAgcHJpbnRpZihpLCAiICAgICAgYnl0ZWNvZGVPZmZzZXQgJXUgJXAgLyAlenVcbiIsIGJ5dGVj b2RlT2Zmc2V0LCByZWludGVycHJldF9jYXN0PHZvaWQqPihieXRlY29kZU9mZnNldCksIGNvZGVC bG9jay0+aW5zdHJ1Y3Rpb25zKCkuc2l6ZSgpKTsKKyNpZiBFTkFCTEUoREZHX0pJVCkKICAgICAg ICAgfSBlbHNlIHsKICAgICAgICAgICAgIHVuc2lnbmVkIGNvZGVPcmlnaW5JbmRleCA9IGxvY2F0 aW9uQXNDb2RlT3JpZ2luSW5kZXgoKTsKICAgICAgICAgICAgIHByaW50aWYoaSwgIiAgICAgIGNv ZGVPcmlnaW5JZGV4ICV1ICVwIC8gJXp1XG4iLCBjb2RlT3JpZ2luSW5kZXgsIHJlaW50ZXJwcmV0 X2Nhc3Q8dm9pZCo+KGNvZGVPcmlnaW5JbmRleCksIGNvZGVCbG9jay0+Y29kZU9yaWdpbnMoKS5z aXplKCkpOworI2VuZGlmCiAgICAgICAgIH0KICAgICAgICAgcHJpbnRpZihpLCAiICAgICAgbGlu ZSAlZFxuIiwgbGluZSgpKTsKICAgICAgICAgcHJpbnRpZihpLCAiICAgICAgY29sdW1uICVkXG4i LCBjb2x1bW4oKSk7CiAgICAgICAgIHByaW50aWYoaSwgIiAgICAgIGppdFR5cGUgJWQgPCVzPiBp c09wdGltaXppbmdKSVQgJWRcbiIsIGppdFR5cGUsIGppdFR5cGVOYW1lKGppdFR5cGUpLCBKSVRD b2RlOjppc09wdGltaXppbmdKSVQoaml0VHlwZSkpOworI2lmIEVOQUJMRShERkdfSklUKQogICAg ICAgICBwcmludGlmKGksICIgICAgICBoYXNDb2RlT3JpZ2lucyAlZFxuIiwgY29kZUJsb2NrLT5o YXNDb2RlT3JpZ2lucygpKTsKICAgICAgICAgaWYgKGNvZGVCbG9jay0+aGFzQ29kZU9yaWdpbnMo KSkgewogICAgICAgICAgICAgSklUQ29kZSogaml0Q29kZSA9IGNvZGVCbG9jay0+aml0Q29kZSgp LmdldCgpOwogICAgICAgICAgICAgcHJpbnRpZihpLCAiICAgICAgICAgaml0Q29kZSAlcCBzdGFy dCAlcCBlbmQgJXBcbiIsIGppdENvZGUsIGppdENvZGUtPnN0YXJ0KCksIGppdENvZGUtPmVuZCgp KTsKICAgICAgICAgfQorI2VuZGlmCiAgICAgfQogICAgIHByaW50aWYoaSwgIn1cbiIpOwogfQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRDb2RlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVENvZGUuY3BwCShyZXZpc2lvbiAxNTI1Nzkp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVENvZGUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00MCwxMSArNDAsMTMgQEAgSklUQ29kZTo6fkpJVENvZGUoKQogewogfQogCisjaWYgRU5B QkxFKEpJVCkKIEpTVmFsdWUgSklUQ29kZTo6ZXhlY3V0ZShKU1N0YWNrKiBzdGFjaywgQ2FsbEZy YW1lKiBjYWxsRnJhbWUsIFZNKiB2bSkKIHsKICAgICBKU1ZhbHVlIHJlc3VsdCA9IEpTVmFsdWU6 OmRlY29kZShjdGlUcmFtcG9saW5lKGV4ZWN1dGFibGVBZGRyZXNzKCksIHN0YWNrLCBjYWxsRnJh bWUsIDAsIDAsIHZtKSk7CiAgICAgcmV0dXJuIHZtLT5leGNlcHRpb24gPyBqc051bGwoKSA6IHJl c3VsdDsKIH0KKyNlbmRpZgogCiBERkc6OkNvbW1vbkRhdGEqIEpJVENvZGU6OmRmZ0NvbW1vbigp CiB7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVEV4Y2VwdGlvbnMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklURXhjZXB0aW9ucy5jcHAJ KHJldmlzaW9uIDE1MjU3OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklURXhjZXB0 aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDggKzQzLDEwIEBAIHN0YXRpYyB1bnNpZ25l ZCBnZXRFeGNlcHRpb25Mb2NhdGlvbihWTSoKICAgICBVTlVTRURfUEFSQU0odm0pOwogICAgIEFT U0VSVCghY2FsbEZyYW1lLT5oYXNIb3N0Q2FsbEZyYW1lRmxhZygpKTsKIAorI2lmIEVOQUJMRShE RkdfSklUKQogICAgIGlmIChjYWxsRnJhbWUtPmhhc0xvY2F0aW9uQXNDb2RlT3JpZ2luSW5kZXgo KSkKICAgICAgICAgcmV0dXJuIGNhbGxGcmFtZS0+Ynl0ZWNvZGVPZmZzZXRGcm9tQ29kZU9yaWdp bkluZGV4KCk7CisjZW5kaWYKIAogICAgIHJldHVybiBjYWxsRnJhbWUtPmxvY2F0aW9uQXNCeXRl Y29kZU9mZnNldCgpOwogfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9s bGludC9Mb3dMZXZlbEludGVycHJldGVyLmNwcAkocmV2aXNpb24gMTUyNTc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zMywxMCArMzMsMTAgQEAKIAogI2lmIEVOQUJMRShMTElOVF9DX0xPT1ApCiAjaW5j bHVkZSAiQ29kZUJsb2NrLmgiCisjaW5jbHVkZSAiQ29tbW9uU2xvd1BhdGhzLmgiCiAjaW5jbHVk ZSAiTExJbnRDTG9vcC5oIgogI2luY2x1ZGUgIkxMSW50U2xvd1BhdGhzLmgiCiAjaW5jbHVkZSAi T3BlcmF0aW9ucy5oIgotI2luY2x1ZGUgIlNsb3dQYXRocy5oIgogI2luY2x1ZGUgIlZNSW5zcGVj dG9yLmgiCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvTWF0aEV4 dHJhcy5oPgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIJ KHJldmlzaW9uIDE1MjU3OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Ns b29wLnJiCSh3b3JraW5nIGNvcHkpCkBAIC01NDYsNyArNTQ2LDcgQEAgZGVmIGNsb29wRW1pdENh bGxTbG93UGF0aChvcGVyYW5kcykKICAgICAkYXNtLnB1dGMgIiAgICBFeGVjU3RhdGUqIGV4ZWMg PSBDQVNUPEV4ZWNTdGF0ZSo+KCN7b3BlcmFuZHNbMV0uY2xWYWx1ZSg6dm9pZFB0cil9KTsiCiAg ICAgJGFzbS5wdXRjICIgICAgSW5zdHJ1Y3Rpb24qIHBjID0gQ0FTVDxJbnN0cnVjdGlvbio+KCN7 b3BlcmFuZHNbMl0uY2xWYWx1ZSg6dm9pZFB0cil9KTsiCiAgICAgJGFzbS5wdXRjICIgICAgU2xv d1BhdGhSZXR1cm5UeXBlIHJlc3VsdCA9ICN7b3BlcmFuZHNbMF0uY0xhYmVsfShleGVjLCBwYyk7 IgotICAgICRhc20ucHV0YyAiICAgIExMSW50OjpkZWNvZGVSZXN1bHQocmVzdWx0LCB0MC5pbnN0 cnVjdGlvbiwgdDEuZXhlY1N0YXRlKTsiCisgICAgJGFzbS5wdXRjICIgICAgZGVjb2RlUmVzdWx0 KHJlc3VsdCwgdDAuaW5zdHJ1Y3Rpb24sIHQxLmV4ZWNTdGF0ZSk7IgogICAgICRhc20ucHV0YyAi fSIKIGVuZAogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVy ZS5jcHAJKHJldmlzaW9uIDE1MjU3OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N0cnVjdHVyZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzLDYgKzMzLDcgQEAKICNpbmNsdWRl ICJQcm9wZXJ0eU5hbWVBcnJheS5oIgogI2luY2x1ZGUgIlN0cnVjdHVyZUNoYWluLmgiCiAjaW5j bHVkZSAiU3RydWN0dXJlUmFyZURhdGFJbmxpbmVzLmgiCisjaW5jbHVkZSA8d3RmL0NvbW1hUHJp bnRlci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZDb3VudGVkTGVha0NvdW50ZXIuaD4KICNpbmNsdWRl IDx3dGYvUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1RocmVhZGluZy5oPgo=