118136 2013-06-27 07:57:40 -0700 [BlackBerry] We should clear all markers when input changes a word 2013-06-27 09:33:26 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nghanavatian nghanavatian commit-queue oldest_to_newest 904242 0 nghanavatian 2013-06-27 07:57:40 -0700 For the case where a letter is added to the middle of a misspelled word, we were sending incorrect offsets to clear spelling markers. However, since this expanded the current word, it overlaps entirely the previous spelling marker so no issue is found. However, if the keypress is backspace, the incorrect range is smaller, causing an overlap which recreates the marker over the last character. Setting shouldEraseMarkersAfterChangeSelection to follow continuous spell checking, which will clear all markers regardless of overlap. This patch also sustains spelling markers after the user taps to move the caret onto the word, which is a nice gain as it was asked for previously. 904243 1 205609 nghanavatian 2013-06-27 08:02:00 -0700 Created attachment 205609 Patch 904251 2 205609 rwlbuis 2013-06-27 08:20:12 -0700 Comment on attachment 205609 Patch Looks good. 904270 3 205609 commit-queue 2013-06-27 09:33:24 -0700 Comment on attachment 205609 Patch Clearing flags on attachment: 205609 Committed r152102: <http://trac.webkit.org/changeset/152102> 904271 4 commit-queue 2013-06-27 09:33:26 -0700 All reviewed patches have been landed. Closing bug. 205609 2013-06-27 08:02:00 -0700 2013-06-27 09:33:24 -0700 Patch bug-118136-20130627105900.patch text/plain 2537 nghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxNzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4MWY1MTIyMGNkYThkNTRlMTExMDc0MDk4YjY2NDA5NWY1M2NiNDRlLi4xY2E3ODViOTk3 YjI2YjI1MmFjN2RjNmViMjc2OGRmMmQ0MTExYWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMy0wNi0yNyAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkBibGFja2JlcnJ5LmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gV2Ugc2hv dWxkIGNsZWFyIGFsbCBtYXJrZXJzIHdoZW4gaW5wdXQgY2hhbmdlcyBhIHdvcmQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODEzNgorICAgICAgICBK SVJBMTE1MzEzLgorCisgICAgICAgIEZvciB0aGUgY2FzZSB3aGVyZSBhIGxldHRlciBpcyBhZGRl ZCB0byB0aGUgbWlkZGxlIG9mIGEgbWlzc3BlbGxlZCB3b3JkLCB3ZSB3ZXJlCisgICAgICAgIHNl bmRpbmcgaW5jb3JyZWN0IG9mZnNldHMgdG8gY2xlYXIgc3BlbGxpbmcgbWFya2Vycy4gSG93ZXZl ciwgc2luY2UgdGhpcworICAgICAgICBleHBhbmRlZCB0aGUgY3VycmVudCB3b3JkLCBpdCBvdmVy bGFwcyBlbnRpcmVseSB0aGUgcHJldmlvdXMgc3BlbGxpbmcgbWFya2VyIHNvCisgICAgICAgIG5v IGlzc3VlIGlzIGZvdW5kLiBIb3dldmVyLCBpZiB0aGUga2V5cHJlc3MgaXMgYmFja3NwYWNlLCB0 aGUgaW5jb3JyZWN0IHJhbmdlCisgICAgICAgIGlzIHNtYWxsZXIsIGNhdXNpbmcgYW4gb3Zlcmxh cCB3aGljaCByZWNyZWF0ZXMgdGhlIG1hcmtlciBvdmVyIHRoZSBsYXN0IGNoYXJhY3Rlci4KKyAg ICAgICAgU2V0dGluZyBzaG91bGRFcmFzZU1hcmtlcnNBZnRlckNoYW5nZVNlbGVjdGlvbiB0byBm b2xsb3cgY29udGludW91cyBzcGVsbCBjaGVja2luZywKKyAgICAgICAgd2hpY2ggd2lsbCBjbGVh ciBhbGwgbWFya2VycyByZWdhcmRsZXNzIG9mIG92ZXJsYXAuCisgICAgICAgIFRoaXMgcGF0Y2gg YWxzbyBzdXN0YWlucyBzcGVsbGluZyBtYXJrZXJzIGFmdGVyIHRoZSB1c2VyIHRhcHMgdG8gbW92 ZSB0aGUgY2FyZXQgb250bworICAgICAgICB0aGUgd29yZCwgd2hpY2ggaXMgYSBuaWNlIGdhaW4g YXMgaXQgd2FzIGFza2VkIGZvciBwcmV2aW91c2x5LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEludGVybmFsbHkgUmV2aWV3ZWQgYnkgTWlrZSBGZW50 b24KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEJsYWNrQmVycnkuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yQ2xpZW50QmxhY2tCZXJyeTo6c2hvdWxkRXJhc2VN YXJrZXJzQWZ0ZXJDaGFuZ2VTZWxlY3Rpb24pOgorCiAyMDEzLTA2LTI0ICBKYWtvYiBQZXRzb3Zp dHMgIDxqcGV0c292aXRzQGJsYWNrYmVycnkuY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBP bmx5IHJlc3VtZSByb290IGxheWVyIGNvbW1pdHMgZm9yIHZpc2libGUgV2ViUGFnZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGll bnRCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9y dC9FZGl0b3JDbGllbnRCbGFja0JlcnJ5LmNwcAppbmRleCBiZWVkMjA3YmU2NDdkYjhmZmRlMjgz MzZiZGIzMDUyMTI1OWZjZWMyLi5kNTI2YjE2MmIyZTIxNTljMzgzOTNjMzJjNjZmMGVmYmI2Y2Fk YjU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQv RWRpdG9yQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYkNvcmVTdXBwb3J0L0VkaXRvckNsaWVudEJsYWNrQmVycnkuY3BwCkBAIC01NTAsNyArNTUw LDggQEAgdm9pZCBFZGl0b3JDbGllbnRCbGFja0JlcnJ5Ojp0ZXh0RGlkQ2hhbmdlSW5UZXh0QXJl YShFbGVtZW50KikKIAogYm9vbCBFZGl0b3JDbGllbnRCbGFja0JlcnJ5OjpzaG91bGRFcmFzZU1h cmtlcnNBZnRlckNoYW5nZVNlbGVjdGlvbihUZXh0Q2hlY2tpbmdUeXBlKSBjb25zdAogewotICAg IHJldHVybiB0cnVlOworICAgIGNvbnN0IEZyYW1lKiBmcmFtZSA9IG1fd2ViUGFnZVByaXZhdGUt PmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgIHJldHVybiAhZnJhbWUgfHwgIWZyYW1lLT5zZXR0 aW5ncygpIHx8ICghZnJhbWUtPnNldHRpbmdzKCktPmFzeW5jaHJvbm91c1NwZWxsQ2hlY2tpbmdF bmFibGVkKCkgJiYgIWZyYW1lLT5zZXR0aW5ncygpLT51bmlmaWVkVGV4dENoZWNrZXJFbmFibGVk KCkpOwogfQogCiB2b2lkIEVkaXRvckNsaWVudEJsYWNrQmVycnk6Omlnbm9yZVdvcmRJblNwZWxs RG9jdW1lbnQoY29uc3QgV1RGOjpTdHJpbmcmKQo=