118128 2013-06-27 05:36:00 -0700 [webkitpy] AbstractPatchSequencingCommand should have _prepare_state 2013-06-27 10:52:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117831 1 ossy ossy commit-queue dpranke galpeter glenn jbadics ossy rniwa oldest_to_newest 904186 0 ossy 2013-06-27 05:36:00 -0700 AbstractSequencedCommand already has _prepare_state method to let its subclasses to prepare an initial state, set options, etc. for example: queries.py/SuggestReviewers, download.py/Clean,Build,Land Unfortunately AbstractPatchSequencingCommand doesn't have _prepare_state method to do similar things, we can only use prepare_steps. But it's overkiller to implement new steps for trivial things, like setting an option. It is a dependency for the new run-tests-touched-by-attachment command, see https://bugs.webkit.org/show_bug.cgi?id=117831#c3 for details. 904189 1 205595 ossy 2013-06-27 05:42:34 -0700 Created attachment 205595 Patch 904207 2 galpeter 2013-06-27 06:36:51 -0700 View in context: https://bugs.webkit.org/attachment.cgi?id=205595&action=review > Tools/ChangeLog:10 > + (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps. you mean prepare_sequence instead of the prepare_steps? 904265 3 205595 rniwa 2013-06-27 09:15:57 -0700 Comment on attachment 205595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205595&action=review > Tools/ChangeLog:7 > + You should probably mention that this is a preparation to fix some other bug. 904295 4 ossy 2013-06-27 10:50:40 -0700 Committed r152113: <http://trac.webkit.org/changeset/152113> 205595 2013-06-27 05:42:34 -0700 2013-06-27 10:52:01 -0700 Patch bug-118128-20130627054049.patch text/plain 2275 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMDkyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzk4ZmM1MGFkZjRlMTdhMjkzZjFkZTU0OGVmZGY2NGU4 NzdjYmVmMi4uMzUzNDQzOGM1MWE0YmMyOTAwMWMyM2MyZWUzZTMwZGRjMDc4YzkwYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTA2LTI3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW3dlYmtpdHB5XSBBYnN0cmFjdFBhdGNoU2VxdWVuY2luZ0NvbW1hbmQgc2hvdWxk IGhhdmUgX3ByZXBhcmVfc3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExODEyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkLnB5 OgorICAgICAgICAoQWJzdHJhY3RQYXRjaFNlcXVlbmNpbmdDb21tYW5kKToKKyAgICAgICAgKEFi c3RyYWN0UGF0Y2hTZXF1ZW5jaW5nQ29tbWFuZC5fcHJlcGFyZV90b19wcm9jZXNzKTogQ2FsbCBf cHJlcGFyZV9zdGF0ZSBiZWZvcmUgcHJlcGFyZV9zdGVwcy4KKyAgICAgICAgKEFic3RyYWN0UGF0 Y2hTZXF1ZW5jaW5nQ29tbWFuZC5fcHJvY2Vzc19wYXRjaCk6IFVzZSB0aGUgc2FtZSBpbml0aWFs IHN0YXRlIGZvciBlYWNoIHBhdGNoLgorICAgICAgICAoQWJzdHJhY3RQYXRjaFNlcXVlbmNpbmdD b21tYW5kLl9wcmVwYXJlX3N0YXRlKTogQWRkZWQuCisKIDIwMTMtMDYtMjcgIENocmlzdG9waGUg RHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIEZpeCBiaW5kaW5n cyB0ZXN0cyBhZnRlciByMTUyMDgwCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvZG93bmxvYWQucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv Y29tbWFuZHMvZG93bmxvYWQucHkKaW5kZXggZDMxNjUzOGQ5NmM1ZTUzNjNhNjY4YjBhM2ZhMDBk MzViYjgzMjMxZS4uODVmNTc2OTI4OTU2MjJlOWNiNTkwOTcyODJkYmQzN2Q2ZjNjN2MwNSAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9kb3dubG9hZC5weQpA QCAtMTg5LDEyICsxODksMjIgQEAgY2xhc3MgQWJzdHJhY3RQYXRjaFNlcXVlbmNpbmdDb21tYW5k KEFic3RyYWN0UGF0Y2hQcm9jZXNzaW5nQ29tbWFuZCk6CiAgICAgICAgIEFic3RyYWN0UGF0Y2hQ cm9jZXNzaW5nQ29tbWFuZC5fX2luaXRfXyhzZWxmLCBvcHRpb25zKQogCiAgICAgZGVmIF9wcmVw YXJlX3RvX3Byb2Nlc3Moc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6Ci0gICAgICAgIHNlbGYu X3ByZXBhcmVfc2VxdWVuY2UucnVuX2FuZF9oYW5kbGVfZXJyb3JzKHRvb2wsIG9wdGlvbnMpCisg ICAgICAgIHRyeToKKyAgICAgICAgICAgIHNlbGYuc3RhdGUgPSBzZWxmLl9wcmVwYXJlX3N0YXRl KG9wdGlvbnMsIGFyZ3MsIHRvb2wpCisgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKKyAg ICAgICAgICAgIF9sb2cuZXJyb3IoZS5tZXNzYWdlX3dpdGhfb3V0cHV0KCkpCisgICAgICAgICAg ICBzZWxmLl9leGl0KGUuZXhpdF9jb2RlIG9yIDIpCisgICAgICAgIHNlbGYuX3ByZXBhcmVfc2Vx dWVuY2UucnVuX2FuZF9oYW5kbGVfZXJyb3JzKHRvb2wsIG9wdGlvbnMsIHNlbGYuc3RhdGUpCiAK ICAgICBkZWYgX3Byb2Nlc3NfcGF0Y2goc2VsZiwgcGF0Y2gsIG9wdGlvbnMsIGFyZ3MsIHRvb2wp OgotICAgICAgICBzdGF0ZSA9IHsgInBhdGNoIiA6IHBhdGNoIH0KKyAgICAgICAgc3RhdGUgPSB7 fQorICAgICAgICBzdGF0ZS51cGRhdGUoc2VsZi5zdGF0ZSBvciB7fSkKKyAgICAgICAgc3RhdGVb InBhdGNoIl0gPSBwYXRjaAogICAgICAgICBzZWxmLl9tYWluX3NlcXVlbmNlLnJ1bl9hbmRfaGFu ZGxlX2Vycm9ycyh0b29sLCBvcHRpb25zLCBzdGF0ZSkKIAorICAgIGRlZiBfcHJlcGFyZV9zdGF0 ZShzZWxmLCBvcHRpb25zLCBhcmdzLCB0b29sKToKKyAgICAgICAgcmV0dXJuIE5vbmUKKwogCiBj bGFzcyBQcm9jZXNzQXR0YWNobWVudHNNaXhpbihvYmplY3QpOgogICAgIGRlZiBfZmV0Y2hfbGlz dF9vZl9wYXRjaGVzX3RvX3Byb2Nlc3Moc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6Cg==