118122 2013-06-27 01:50:55 -0700 Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required' 2013-06-28 18:26:22 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 118162 1 jcraig jcraig commit-queue graouts jcraig joepeck timothy webkit-bug-importer oldest_to_newest 904106 0 jcraig 2013-06-27 01:50:55 -0700 I believe this is just an oversight. These fields aren't actually required for anything and there appears to be no validation checking that relies on this property, so we could comment or remove "*.required = true;" in all occurrences to make this work better for VoiceOver. Searching 400 files for ".required" (case sensitive) /Users/jc/svnroot/WebKit/Source/WebInspectorUI/UserInterface/FilterBar.js: 32 this._inputField = document.createElement("input"); 33 this._inputField.type = "search"; 34: this._inputField.required = true; 35 this._inputField.spellcheck = false; 36 this._inputField.incremental = true; /Users/jc/svnroot/WebKit/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js: 33 this._inputElement = document.createElement("input"); 34 this._inputElement.type = "search"; 35: this._inputElement.required = true; 36 this._inputElement.spellcheck = false; 37 this._inputElement.addEventListener("search", this._searchFieldChanged.bind(this)); /Users/jc/svnroot/WebKit/Source/WebInspectorUI/UserInterface/SearchBar.js: 36 this._searchInput = this._element.appendChild(document.createElement("input")); 37 this._searchInput.type = "search"; 38: this._searchInput.required = true; 39 this._searchInput.spellcheck = false; 40 this._searchInput.incremental = true; 3 matches across 3 files 904107 1 webkit-bug-importer 2013-06-27 01:51:10 -0700 <rdar://problem/14287209> 904135 2 timothy 2013-06-27 03:05:03 -0700 They are marked required to allow us to style them with a white background when there is content typed into them. Otherwise they have a semi transparent background. Can we hide that from VoiceOver since this is a purely visual reason? 904404 3 jcraig 2013-06-27 17:45:32 -0700 (In reply to comment #2) > They are marked required to allow us to style them with a white background when there is content typed into them. Otherwise they have a semi transparent background. Oh, I see the :valid pseudo-class selectors now. I think we can manage the same thing with a :not([value=""]) selector, right? I'll try it out. > Can we hide that from VoiceOver since this is a purely visual reason? No, for attrs with identical semantics like @required and @aria-required, the host language attribute wins if there is a conflict, so <input required aria-required="false"> is still required. 904412 4 jcraig 2013-06-27 18:05:59 -0700 The :not([value=""]) selector doesn't work as I had hoped. Even if I set an initial empty value via el.value=""; or el.setAttribute("value","");, the attribute does not stay in sync. I thought value was a reflected attribute, but it appears the DOM attribute is just to set the default value of the WebIDL attribute. http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#attr-input-value 904415 5 jcraig 2013-06-27 18:20:44 -0700 The CSS4 selector :not(:placeholder-shown) is the right one to use, but WebKit does not recognize it yet (I filed bug 118162). I think it looks okay with the change (currently only white when focused), and it should should match the previous style (white when focused or non-empty) once WebKit supports the new selector. I'll upload a diff for review. 904417 6 205654 jcraig 2013-06-27 18:33:35 -0700 Created attachment 205654 patch 904815 7 205654 commit-queue 2013-06-28 18:26:20 -0700 Comment on attachment 205654 patch Clearing flags on attachment: 205654 Committed r152199: <http://trac.webkit.org/changeset/152199> 904816 8 commit-queue 2013-06-28 18:26:22 -0700 All reviewed patches have been landed. Closing bug. 205654 2013-06-27 18:33:35 -0700 2013-06-28 18:26:20 -0700 patch 118122.patch text/plain 4858 jcraig SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1NlYXJjaEJhci5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9TZWFyY2hC YXIuanMJKHJldmlzaW9uIDE1MjE0MykKKysrIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1NlYXJjaEJhci5qcwkod29ya2luZyBjb3B5KQpAQCAtMzUsNyArMzUsNiBAQAogCiAg ICAgdGhpcy5fc2VhcmNoSW5wdXQgPSB0aGlzLl9lbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoImlucHV0IikpOwogICAgIHRoaXMuX3NlYXJjaElucHV0LnR5cGUgPSAi c2VhcmNoIjsKLSAgICB0aGlzLl9zZWFyY2hJbnB1dC5yZXF1aXJlZCA9IHRydWU7CiAgICAgdGhp cy5fc2VhcmNoSW5wdXQuc3BlbGxjaGVjayA9IGZhbHNlOwogICAgIHRoaXMuX3NlYXJjaElucHV0 LmluY3JlbWVudGFsID0gdHJ1ZTsKICAgICB0aGlzLl9zZWFyY2hJbnB1dC5zZXRBdHRyaWJ1dGUo InJlc3VsdHMiLCA1KTsKSW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzCShyZXZpc2lvbiAxNTIx NDMpCisrKyBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9SZXNvdXJjZVNpZGVi YXJQYW5lbC5qcwkod29ya2luZyBjb3B5KQpAQCAtMzIsNyArMzIsNiBAQAogCiAgICAgdGhpcy5f aW5wdXRFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaW5wdXQiKTsKICAgICB0aGlz Ll9pbnB1dEVsZW1lbnQudHlwZSA9ICJzZWFyY2giOwotICAgIHRoaXMuX2lucHV0RWxlbWVudC5y ZXF1aXJlZCA9IHRydWU7CiAgICAgdGhpcy5faW5wdXRFbGVtZW50LnNwZWxsY2hlY2sgPSBmYWxz ZTsKICAgICB0aGlzLl9pbnB1dEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigic2VhcmNoIiwgdGhp cy5fc2VhcmNoRmllbGRDaGFuZ2VkLmJpbmQodGhpcykpOwogICAgIHRoaXMuX2lucHV0RWxlbWVu dC5hZGRFdmVudExpc3RlbmVyKCJpbnB1dCIsIHRoaXMuX3NlYXJjaEZpZWxkSW5wdXQuYmluZCh0 aGlzKSk7CkluZGV4OiBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9TZWFyY2hC YXIuY3NzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1NlYXJjaEJhci5jc3MJKHJldmlzaW9uIDE1MjE0MykKKysrIFNvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1NlYXJjaEJhci5jc3MJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDcgKzQ1 LDUgQEAKICAgICBjb2xvcjogcmdiYSgwLCAwLCAwLCAwLjM1KTsKIH0KIAotLnNlYXJjaC1iYXIg PiBpbnB1dFt0eXBlPSJzZWFyY2giXTpmb2N1cywKLS5zZWFyY2gtYmFyID4gaW5wdXRbdHlwZT0i c2VhcmNoIl06dmFsaWQgewotICAgIGJhY2tncm91bmQtY29sb3I6IHdoaXRlOwotfQorLnNlYXJj aC1iYXIgPiBpbnB1dFt0eXBlPSJzZWFyY2giXTpmb2N1cyB7IGJhY2tncm91bmQtY29sb3I6IHdo aXRlOyB9Cisuc2VhcmNoLWJhciA+IGlucHV0W3R5cGU9InNlYXJjaCJdOm5vdCg6cGxhY2Vob2xk ZXItc2hvd24pIHsgYmFja2dyb3VuZC1jb2xvcjogd2hpdGU7IH0gLyogTmVlZHMgdG8gYmUgYSBz ZXBhcmF0ZSBydWxlLiBTZWUgaHR0cDovL3dlYmtpdC5vcmcvYi8xMTgxNjIgKi8KSW5kZXg6IFNv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0ZpbHRlckJhci5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9GaWx0ZXJCYXIuanMJKHJl dmlzaW9uIDE1MjE0MykKKysrIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Zp bHRlckJhci5qcwkod29ya2luZyBjb3B5KQpAQCAtMzEsNyArMzEsNiBAQAogCiAgICAgdGhpcy5f aW5wdXRGaWVsZCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlucHV0Iik7CiAgICAgdGhpcy5f aW5wdXRGaWVsZC50eXBlID0gInNlYXJjaCI7Ci0gICAgdGhpcy5faW5wdXRGaWVsZC5yZXF1aXJl ZCA9IHRydWU7CiAgICAgdGhpcy5faW5wdXRGaWVsZC5zcGVsbGNoZWNrID0gZmFsc2U7CiAgICAg dGhpcy5faW5wdXRGaWVsZC5pbmNyZW1lbnRhbCA9IHRydWU7CiAgICAgdGhpcy5faW5wdXRGaWVs ZC5hZGRFdmVudExpc3RlbmVyKCJzZWFyY2giLCB0aGlzLl9pbnB1dEZpZWxkQ2hhbmdlZC5iaW5k KHRoaXMpLCBmYWxzZSk7CkluZGV4OiBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9GaWx0ZXJCYXIuY3NzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0ZpbHRlckJhci5jc3MJKHJldmlzaW9uIDE1MjE0MykKKysrIFNvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0ZpbHRlckJhci5jc3MJKHdvcmtpbmcgY29weSkKQEAg LTU3LDEwICs1Nyw4IEBACiAgICAgY29sb3I6IHJnYmEoMCwgMCwgMCwgMC4zNSk7CiB9CiAKLS5m aWx0ZXItYmFyID4gaW5wdXRbdHlwZT0ic2VhcmNoIl06Zm9jdXMsCi0uZmlsdGVyLWJhciA+IGlu cHV0W3R5cGU9InNlYXJjaCJdOnZhbGlkIHsKLSAgICBiYWNrZ3JvdW5kLWNvbG9yOiB3aGl0ZTsK LX0KKy5maWx0ZXItYmFyID4gaW5wdXRbdHlwZT0ic2VhcmNoIl06Zm9jdXMgeyBiYWNrZ3JvdW5k LWNvbG9yOiB3aGl0ZTsgfQorLmZpbHRlci1iYXIgPiBpbnB1dFt0eXBlPSJzZWFyY2giXTpub3Qo OnBsYWNlaG9sZGVyLXNob3duKSB7IGJhY2tncm91bmQtY29sb3I6IHdoaXRlOyB9IC8qIE5lZWRz IHRvIGJlIGEgc2VwYXJhdGUgcnVsZS4gU2VlIGh0dHA6Ly93ZWJraXQub3JnL2IvMTE4MTYyICov CiAKIC5maWx0ZXItYmFyID4gaW5wdXRbdHlwZT0ic2VhcmNoIl06Oi13ZWJraXQtc2VhcmNoLWRl Y29yYXRpb24gewogICAgIHdpZHRoOiAxM3B4OwpJbmRleDogU291cmNlL1dlYkluc3BlY3RvclVJ L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNTIxNDYpCisrKyBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsMjkgQEAKIDIwMTMtMDYtMjcgIEphbWVzIENyYWlnICA8 amFtZXNAY29va2llY3Jvb2suY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFYOiBWb2lj ZU92ZXIgc3BlYWtzIGFsbCBpbnNwZWN0b3Igc2VhcmNoIGZpZWxkcyBhcyAncmVxdWlyZWQnCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgxMjIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIGJv Z3VzICJyZXF1aXJlZCIgc3RhdGUsIGFuZCBzd2l0Y2hlZCA6dmFsaWQgc2VsZWN0b3IgdG8gdXNl IDpub3QoOnBsYWNlaG9sZGVyLXNob3duKQorICAgICAgICBzbyB0aGF0IHNjcmVlbiByZWFkZXJz IHdpbGwgbm90IGluZGljYXRlIGEgYm9ndXMgOnJlcXVpcmVkLzppbnZhbGlkIHN0YXRlIHRvIHRo ZSB1c2VyLgorICAgICAgICBNaW5vciBjb3NtZXRpYyBkaWZmZXJlbmNlIGJsb2NrZWQgYnkgaHR0 cDovL3dlYmtpdC5vcmcvYi8xMTgxNjIKKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvRmlsdGVy QmFyLmNzczoKKyAgICAgICAgKC5maWx0ZXItYmFyID4gaW5wdXRbdHlwZT0ic2VhcmNoIl06Zm9j dXMpOgorICAgICAgICAoLmZpbHRlci1iYXIgPiBpbnB1dFt0eXBlPSJzZWFyY2giXTpub3QoOnBs YWNlaG9sZGVyLXNob3duKSk6CisgICAgICAgICogVXNlckludGVyZmFjZS9GaWx0ZXJCYXIuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRmlsdGVyQmFyKToKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1Jlc291cmNlU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291 cmNlU2lkZWJhclBhbmVsKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1NlYXJjaEJhci5jc3M6 CisgICAgICAgICguc2VhcmNoLWJhciA+IGlucHV0W3R5cGU9InNlYXJjaCJdOmZvY3VzKToKKyAg ICAgICAgKC5zZWFyY2gtYmFyID4gaW5wdXRbdHlwZT0ic2VhcmNoIl06bm90KDpwbGFjZWhvbGRl ci1zaG93bikpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvU2VhcmNoQmFyLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlNlYXJjaEJhcik6CisKKzIwMTMtMDYtMjcgIEphbWVzIENyYWlnICA8 amFtZXNAY29va2llY3Jvb2suY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFYOiBBZGQg Y29udGFpbmVyIEFSSUEgcm9sZXMgKHRvb2xiYXIsIG1haW4sIGxhYmVsZWQgcmVnaW9ucywgZXRj LikgCiAgICAgICAgIHNvIHRoZSBsYXlvdXQgaXMgbW9yZSBkaXNjb3ZlcmFibGUgdG8gc2NyZWVu IHJlYWRlciB1c2VycwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTE4MTA0Cg==