118120 2013-06-27 01:32:33 -0700 [CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project 2013-07-04 01:55:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga commit-queue gyuyoung.kim rakuco oldest_to_newest 904101 0 paroga 2013-06-27 01:32:33 -0700 [CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project 904102 1 205574 paroga 2013-06-27 01:40:45 -0700 Created attachment 205574 Patch 904894 2 205574 rakuco 2013-06-30 09:41:10 -0700 Comment on attachment 205574 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205574&action=review LGTM. > Source/JavaScriptCore/CMakeLists.txt:540 > add_definitions(-DBUILDING_JavaScriptCore) > +add_definitions(-DSTATICALLY_LINKED_WITH_WTF) You could merge these into a single call. 904912 3 205574 gyuyoung.kim 2013-06-30 19:07:49 -0700 Comment on attachment 205574 Patch Looks fine too. 906096 4 paroga 2013-07-04 01:55:10 -0700 Committed r152393: <http://trac.webkit.org/changeset/152393> 205574 2013-06-27 01:40:45 -0700 2013-07-04 01:49:01 -0700 Patch bug-118120.patch text/plain 1550 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCAwZDcyOTllLi5iMjU5OWZlIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC01MzcsNiArNTM3LDcgQEAgYWRk X3N1YmRpcmVjdG9yeShzaGVsbCkKIFdFQktJVF9XUkFQX1NPVVJDRUxJU1QoJHtKYXZhU2NyaXB0 Q29yZV9TT1VSQ0VTfSkKIGluY2x1ZGVfZGlyZWN0b3JpZXMoJHtKYXZhU2NyaXB0Q29yZV9JTkNM VURFX0RJUkVDVE9SSUVTfSkKIGFkZF9kZWZpbml0aW9ucygtREJVSUxESU5HX0phdmFTY3JpcHRD b3JlKQorYWRkX2RlZmluaXRpb25zKC1EU1RBVElDQUxMWV9MSU5LRURfV0lUSF9XVEYpCiBhZGRf bGlicmFyeShKYXZhU2NyaXB0Q29yZSAke0phdmFTY3JpcHRDb3JlX0xJQlJBUllfVFlQRX0gJHtK YXZhU2NyaXB0Q29yZV9IRUFERVJTfSAke0phdmFTY3JpcHRDb3JlX1NPVVJDRVN9KQogdGFyZ2V0 X2xpbmtfbGlicmFyaWVzKEphdmFTY3JpcHRDb3JlICR7SmF2YVNjcmlwdENvcmVfTElCUkFSSUVT fSkKIHNldF90YXJnZXRfcHJvcGVydGllcyhKYXZhU2NyaXB0Q29yZSBQUk9QRVJUSUVTIEZPTERF UiAiSmF2YVNjcmlwdENvcmUiKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggODI2Yzc3MS4u YTgwODBkYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMt MDYtMjcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAg W0NNYWtlXSBBZGQgU1RBVElDQUxMWV9MSU5LRURfV0lUSF9XVEYgdG8gSmF2YVNjcmlwdENvcmUg cHJvamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTE4MTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U2luY2UgV1RGIGlzIGEgc3RhdGljIGxpYnJhcnkgbGlua2VkIHRvIEphdmFTY3JpcHRDb3JlIG9u IGFsbCBDTWFrZSBwb3J0cworICAgICAgICB3ZSBuZWVkIHRvIGRlZmluZSBTVEFUSUNBTExZX0xJ TktFRF9XSVRIX1dURiBmb3IgYWxsIG9mIHRoZW0uCisgICAgICAgIFRoaXMgbWFrZXMgb25seSBh IGRpZmZlcmVuY2UgZm9yIFdpbmRvd3MsIHNpbmNlIFdURl9FWFBPUlQgYW5kIFdURl9JTVBPUlQK KyAgICAgICAgYXJlIHRoZSBzYW1lIG9uIGFsbCBvdGhlciBwbGF0Zm9ybXMuCisKKyAgICAgICAg KiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxMy0wNi0yNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJz Tm9Db3B5IFNQSQo=