118114 2013-06-26 21:13:19 -0700 Avoid redundant checks for Compositing reasons in RenderLayerCompositor 2013-06-27 00:12:41 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 118117 0 sanjoy.pal webkit-unassigned commit-queue esprehn+autocc glenn simon.fraser oldest_to_newest 904048 0 sanjoy.pal 2013-06-26 21:13:19 -0700 A RendereObject can be any one of the Video, Canvas, Plugin or Iframe. Patch follows. 904049 1 205558 sanjoy.pal 2013-06-26 21:15:22 -0700 Created attachment 205558 Patch 904054 2 205558 andersca 2013-06-26 21:53:21 -0700 Comment on attachment 205558 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205558&action=review > Source/WebCore/ChangeLog:8 > + A RendereObject can be any one of the Video, Canvas, Plugin or Iframe. Typo, RenderObject. 904056 3 205560 sanjoy.pal 2013-06-26 22:07:10 -0700 Created attachment 205560 Patch 904065 4 205560 commit-queue 2013-06-26 23:03:26 -0700 Comment on attachment 205560 Patch Clearing flags on attachment: 205560 Committed r152078: <http://trac.webkit.org/changeset/152078> 904066 5 commit-queue 2013-06-26 23:03:28 -0700 All reviewed patches have been landed. Closing bug. 205558 2013-06-26 21:15:22 -0700 2013-06-26 22:07:01 -0700 Patch bug-118114-20130627094500.patch text/plain 2061 sanjoy.pal U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQ0ZmI1ODY4MmM4YTRh MTkyOTVhNzgwMWM1OWJiNDY5M2EyN2UzOS4uOGNmYTJhNjU3NTNlODE5MGIwYmE2ZWVlNWJiYjZk NzUxZmQ1MThmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA2LTI2ICBTYW5q b3kgUGFsICA8c2Fuam95LnBhbEBzYW1zdW5nLmNvbT4KKworICAgICAgICBBdm9pZCByZWR1bmRh bnQgY2hlY2tzIGZvciBDb21wb3NpdGluZyByZWFzb25zIGluIFJlbmRlckxheWVyQ29tcG9zaXRv cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MTE0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBSZW5k ZXJlT2JqZWN0IGNhbiBiZSBhbnkgb25lIG9mIHRoZSBWaWRlbywgQ2FudmFzLCBQbHVnaW4gb3Ig SWZyYW1lLgorICAgICAgICBIZW5jZSByZW1vdmluZyB0aGUgcmVkdW5kYW50IGNoZWNrcy4KKwor ICAgICAgICBObyBuZXcgdGVzdHMgYXMgbm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2UuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVhc29uc0ZvckNvbXBvc2l0aW5nKToKKwogMjAx My0wNi0yNiAgR3dhbmcgWW9vbiBId2FuZyAgPHJ5dW1pZWxAY29tcGFueTEwMC5uZXQ+CiAKICAg ICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3M6IFNlcGFyYXRlIENvb3JkaW5hdGVkTGF5ZXJUcmVl SG9zdCBpbnRvIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdCBhbmQgQ29tcG9zaXRpbmdDb29yZGlu YXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcAppbmRleCA0NjA2ZGM3NTg0ZGIwYjU2NjVkMTY3Yjc0MWQ1MmRlMGNjNzI5OGMwLi5i MjEwYWRiYzRiZDgxYTgyZWM4ZjhkOWU5MzU5Yjc0MTIzNzVjZTY5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMTg0MSwx NCArMTg0MSwxMSBAQCBDb21wb3NpdGluZ1JlYXNvbnMgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpy ZWFzb25zRm9yQ29tcG9zaXRpbmcoY29uc3QgUmVuZGVyTGF5ZQogCiAgICAgaWYgKHJlcXVpcmVz Q29tcG9zaXRpbmdGb3JWaWRlbyhyZW5kZXJlcikpCiAgICAgICAgIHJlYXNvbnMgfD0gQ29tcG9z aXRpbmdSZWFzb25WaWRlbzsKLQotICAgIGlmIChyZXF1aXJlc0NvbXBvc2l0aW5nRm9yQ2FudmFz KHJlbmRlcmVyKSkKKyAgICBlbHNlIGlmIChyZXF1aXJlc0NvbXBvc2l0aW5nRm9yQ2FudmFzKHJl bmRlcmVyKSkKICAgICAgICAgcmVhc29ucyB8PSBDb21wb3NpdGluZ1JlYXNvbkNhbnZhczsKLQot ICAgIGlmIChyZXF1aXJlc0NvbXBvc2l0aW5nRm9yUGx1Z2luKHJlbmRlcmVyKSkKKyAgICBlbHNl IGlmIChyZXF1aXJlc0NvbXBvc2l0aW5nRm9yUGx1Z2luKHJlbmRlcmVyKSkKICAgICAgICAgcmVh c29ucyB8PSBDb21wb3NpdGluZ1JlYXNvblBsdWdpbjsKLQotICAgIGlmIChyZXF1aXJlc0NvbXBv c2l0aW5nRm9yRnJhbWUocmVuZGVyZXIpKQorICAgIGVsc2UgaWYgKHJlcXVpcmVzQ29tcG9zaXRp bmdGb3JGcmFtZShyZW5kZXJlcikpCiAgICAgICAgIHJlYXNvbnMgfD0gQ29tcG9zaXRpbmdSZWFz b25JRnJhbWU7CiAgICAgCiAgICAgaWYgKChjYW5SZW5kZXIzRFRyYW5zZm9ybXMoKSAmJiByZW5k ZXJlci0+c3R5bGUoKS0+YmFja2ZhY2VWaXNpYmlsaXR5KCkgPT0gQmFja2ZhY2VWaXNpYmlsaXR5 SGlkZGVuKSkK 205560 2013-06-26 22:07:10 -0700 2013-06-26 23:03:26 -0700 Patch bug-118114-20130627103647.patch text/plain 2061 sanjoy.pal U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyMDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQ0ZmI1ODY4MmM4YTRh MTkyOTVhNzgwMWM1OWJiNDY5M2EyN2UzOS4uZDM1YjYwODU2ODJjYzk3NDZkNWVlODViMDM1NzJl Nzc2M2UxOWU4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTA2LTI2ICBTYW5q b3kgUGFsICA8c2Fuam95LnBhbEBzYW1zdW5nLmNvbT4KKworICAgICAgICBBdm9pZCByZWR1bmRh bnQgY2hlY2tzIGZvciBDb21wb3NpdGluZyByZWFzb25zIGluIFJlbmRlckxheWVyQ29tcG9zaXRv cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MTE0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgorCisgICAgICAgIEEgUmVu ZGVyT2JqZWN0IGNhbiBiZSBhbnkgb25lIG9mIHRoZSBWaWRlbywgQ2FudmFzLCBQbHVnaW4gb3Ig SWZyYW1lLgorICAgICAgICBIZW5jZSByZW1vdmluZyB0aGUgcmVkdW5kYW50IGNoZWNrcy4KKwor ICAgICAgICBObyBuZXcgdGVzdHMgYXMgbm8gZnVuY3Rpb25hbGl0eSBjaGFuZ2UuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVhc29uc0ZvckNvbXBvc2l0aW5nKToKKwogMjAx My0wNi0yNiAgR3dhbmcgWW9vbiBId2FuZyAgPHJ5dW1pZWxAY29tcGFueTEwMC5uZXQ+CiAKICAg ICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3M6IFNlcGFyYXRlIENvb3JkaW5hdGVkTGF5ZXJUcmVl SG9zdCBpbnRvIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdCBhbmQgQ29tcG9zaXRpbmdDb29yZGlu YXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcAppbmRleCA0NjA2ZGM3NTg0ZGIwYjU2NjVkMTY3Yjc0MWQ1MmRlMGNjNzI5OGMwLi5i MjEwYWRiYzRiZDgxYTgyZWM4ZjhkOWU5MzU5Yjc0MTIzNzVjZTY5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMTg0MSwx NCArMTg0MSwxMSBAQCBDb21wb3NpdGluZ1JlYXNvbnMgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpy ZWFzb25zRm9yQ29tcG9zaXRpbmcoY29uc3QgUmVuZGVyTGF5ZQogCiAgICAgaWYgKHJlcXVpcmVz Q29tcG9zaXRpbmdGb3JWaWRlbyhyZW5kZXJlcikpCiAgICAgICAgIHJlYXNvbnMgfD0gQ29tcG9z aXRpbmdSZWFzb25WaWRlbzsKLQotICAgIGlmIChyZXF1aXJlc0NvbXBvc2l0aW5nRm9yQ2FudmFz KHJlbmRlcmVyKSkKKyAgICBlbHNlIGlmIChyZXF1aXJlc0NvbXBvc2l0aW5nRm9yQ2FudmFzKHJl bmRlcmVyKSkKICAgICAgICAgcmVhc29ucyB8PSBDb21wb3NpdGluZ1JlYXNvbkNhbnZhczsKLQot ICAgIGlmIChyZXF1aXJlc0NvbXBvc2l0aW5nRm9yUGx1Z2luKHJlbmRlcmVyKSkKKyAgICBlbHNl IGlmIChyZXF1aXJlc0NvbXBvc2l0aW5nRm9yUGx1Z2luKHJlbmRlcmVyKSkKICAgICAgICAgcmVh c29ucyB8PSBDb21wb3NpdGluZ1JlYXNvblBsdWdpbjsKLQotICAgIGlmIChyZXF1aXJlc0NvbXBv c2l0aW5nRm9yRnJhbWUocmVuZGVyZXIpKQorICAgIGVsc2UgaWYgKHJlcXVpcmVzQ29tcG9zaXRp bmdGb3JGcmFtZShyZW5kZXJlcikpCiAgICAgICAgIHJlYXNvbnMgfD0gQ29tcG9zaXRpbmdSZWFz b25JRnJhbWU7CiAgICAgCiAgICAgaWYgKChjYW5SZW5kZXIzRFRyYW5zZm9ybXMoKSAmJiByZW5k ZXJlci0+c3R5bGUoKS0+YmFja2ZhY2VWaXNpYmlsaXR5KCkgPT0gQmFja2ZhY2VWaXNpYmlsaXR5 SGlkZGVuKSkK