118093 2013-06-26 15:29:32 -0700 Kill updateStyleForAllDocuments() 2013-08-08 17:46:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser ap darin hyatt psolanki simon.fraser oldest_to_newest 903942 0 simon.fraser 2013-06-26 15:29:32 -0700 There is no reason we should ever have to call Document::updateStyleForAllDocuments(), yet JSCallbackData::invokeCallback() and JSCustomXPathNSResolver::lookupNamespaceURI() both do so. 912667 1 simon.fraser 2013-07-29 22:11:23 -0700 I tried this. The only new test failure is editing/selection/leak-document-with-selection-inside.html which makes bogus assumptions about how long documents live. 912670 2 simon.fraser 2013-07-29 22:14:51 -0700 (In reply to comment #1) > I tried this. The only new test failure is editing/selection/leak-document-with-selection-inside.html which makes bogus assumptions about how long documents live. Actually it's just flakey. It fails without any change. 912671 3 207687 simon.fraser 2013-07-29 22:23:39 -0700 Created attachment 207687 Patch 912673 4 simon.fraser 2013-07-29 22:31:17 -0700 This patch removes the callers. If it passes EWS I'll remove the function too. 912676 5 207687 ggaren 2013-07-29 23:32:15 -0700 Comment on attachment 207687 Patch r=me 912923 6 ap 2013-07-30 10:27:47 -0700 See also: bug 46761. Good to hear that tests are no longer failing, although EWS is in such shape that it probably won’t provide a trustworthy answer. Looks like we still have a caller in Element::setActive()? 912925 7 ap 2013-07-30 10:29:27 -0700 See also discussion in bug 32580. 912937 8 simon.fraser 2013-07-30 10:42:58 -0700 http://trac.webkit.org/changeset/42384 is related. 915661 9 simon.fraser 2013-08-08 17:46:51 -0700 https://trac.webkit.org/r153872 207687 2013-07-29 22:23:39 -0700 2013-07-29 23:32:15 -0700 Patch bug-118093-20130729222338.patch text/plain 2827 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTUzNDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTg5MDhmOGY5NjU3YTYx NThiM2RmNjkyOThmMTUwM2E1MWNkYjA5Ni4uOGIzMGZkOTU3NjM4YzA4MjkyM2U4YTk3ZGVkZDk1 MWUyYTgzZWRmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEzLTA3LTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIEtpbGwgdXBkYXRl U3R5bGVGb3JBbGxEb2N1bWVudHMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTE4MDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIG5ldmVyIGhhdmUgdG8gZWFnZXJseSB1cGRhdGUgc3R5 bGUsIGVzcGVjaWFsbHkgZm9yIGFsbCBkb2N1bWVudHMKKyAgICAgICAgdGhhdCB0aGUgcHJvY2Vz cyBrbm93cyBhYm91dC4gVGhlIFdlYktpdCBtb2RlbCBpcyB0byB1cGRhdGUgc3R5bGUgd2hlbgor ICAgICAgICByZXF1aXJlZCBmb3IgbGF5b3V0IGV0Yywgbm90IHRvIHVwZGF0ZSBpdCBlYWdlcmx5 LgorICAgICAgICAKKyAgICAgICAgVGhpcyBpcyBoaXN0b3JpY2FsIGNvZGUgd2hvc2Ugb3JpZ2lu cyBhcmUgbG9zdCBpbiB0aGUgbWlzdHMgb2YgS0hUTUwuCisKKyAgICAgICAgKiBiaW5kaW5ncy9q cy9KU0NhbGxiYWNrRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0NhbGxiYWNrRGF0YTo6 aW52b2tlQ2FsbGJhY2spOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ3VzdG9tWFBhdGhOU1Jl c29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTQ3VzdG9tWFBhdGhOU1Jlc29sdmVyOjps b29rdXBOYW1lc3BhY2VVUkkpOgorCisyMDEzLTA3LTI5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIFBhZ2UgY291bnQgY2FuIGJlIGluY29ycmVjdCBp ZiB0aGVyZSBpcyBhIHBlbmRpbmcgc3R5bGUgcmVjYWxjCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTkyMzIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNDYWxsYmFja0RhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNDYWxsYmFja0RhdGEuY3BwCmluZGV4IGE5MGZhODc0M2EyMDE0NWJmZWY4MjFl MzVkM2QyYzI1ODM4OGUzM2MuLmI1OTViNDRiZDkyMTFjYWQ2ZGYwOTMwMzFhZjJlZmQwMzg4YWZh ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ2FsbGJhY2tEYXRh LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NhbGxiYWNrRGF0YS5jcHAK QEAgLTcyLDE2ICs3MiwxMiBAQCBKU1ZhbHVlIEpTQ2FsbGJhY2tEYXRhOjppbnZva2VDYWxsYmFj ayhKU1ZhbHVlIHRoaXNWYWx1ZSwgTWFya2VkQXJndW1lbnRCdWZmZXImCiAKICAgICBJbnNwZWN0 b3JJbnN0cnVtZW50YXRpb25Db29raWUgY29va2llID0gSlNNYWluVGhyZWFkRXhlY1N0YXRlOjpp bnN0cnVtZW50RnVuY3Rpb25DYWxsKGNvbnRleHQsIGNhbGxUeXBlLCBjYWxsRGF0YSk7CiAKLSAg ICBib29sIGNvbnRleHRJc0RvY3VtZW50ID0gY29udGV4dC0+aXNEb2N1bWVudCgpOwotICAgIEpT VmFsdWUgcmVzdWx0ID0gY29udGV4dElzRG9jdW1lbnQKKyAgICBKU1ZhbHVlIHJlc3VsdCA9IGNv bnRleHQtPmlzRG9jdW1lbnQoKQogICAgICAgICA/IEpTTWFpblRocmVhZEV4ZWNTdGF0ZTo6Y2Fs bChleGVjLCBmdW5jdGlvbiwgY2FsbFR5cGUsIGNhbGxEYXRhLCB0aGlzVmFsdWUsIGFyZ3MpCiAg ICAgICAgIDogSlNDOjpjYWxsKGV4ZWMsIGZ1bmN0aW9uLCBjYWxsVHlwZSwgY2FsbERhdGEsIHRo aXNWYWx1ZSwgYXJncyk7CiAKICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZENhbGxG dW5jdGlvbihjb29raWUpOwogCi0gICAgaWYgKGNvbnRleHRJc0RvY3VtZW50KQotICAgICAgICBE b2N1bWVudDo6dXBkYXRlU3R5bGVGb3JBbGxEb2N1bWVudHMoKTsKLQogICAgIGlmIChleGVjLT5o YWRFeGNlcHRpb24oKSkgewogICAgICAgICByZXBvcnRDdXJyZW50RXhjZXB0aW9uKGV4ZWMpOwog ICAgICAgICBpZiAocmFpc2VkRXhjZXB0aW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNDdXN0b21YUGF0aE5TUmVzb2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNDdXN0b21YUGF0aE5TUmVzb2x2ZXIuY3BwCmluZGV4IDEyZTE1NjMyNjc5 MTUwOGI4YTc0Y2ExYjFmMjQ5NmIyYzM5ZDgxNzguLjEyNWI5MWU3NzIyMjkzMzllYThiZDFkOTYz NWQ4NzkwZjEzZjczNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT Q3VzdG9tWFBhdGhOU1Jlc29sdmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0N1c3RvbVhQYXRoTlNSZXNvbHZlci5jcHAKQEAgLTEwMSw4ICsxMDEsNiBAQCBTdHJpbmcg SlNDdXN0b21YUGF0aE5TUmVzb2x2ZXI6Omxvb2t1cE5hbWVzcGFjZVVSSShjb25zdCBTdHJpbmcm IHByZWZpeCkKICAgICAgICAgICAgIHJlc3VsdCA9IHJldHZhbC50b1N0cmluZyhleGVjKS0+dmFs dWUoZXhlYyk7CiAgICAgfQogCi0gICAgRG9jdW1lbnQ6OnVwZGF0ZVN0eWxlRm9yQWxsRG9jdW1l bnRzKCk7Ci0KICAgICByZXR1cm4gcmVzdWx0OwogfQogCg==