118064 2013-06-26 08:57:01 -0700 Match CanvasGradient::addColorStop to the spec. 2017-09-18 01:52:14 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 160297 BlinkMergeCandidate, WebExposed P2 Normal --- 1 dongseong.hwang dongseong.hwang ap benjamin cdumez commit-queue darin dino esprehn+autocc Ms2ger rniwa oldest_to_newest 903743 0 dongseong.hwang 2013-06-26 08:57:01 -0700 The canvas spec [1] defines addColorStop without optional arguments. This patch removes optional attribute from addColorStop interface. [1] http://www.w3.org/TR/2dcontext2/ 903750 1 205501 dongseong.hwang 2013-06-26 09:00:42 -0700 Created attachment 205501 Patch 903754 2 dongseong.hwang 2013-06-26 09:01:22 -0700 This patch is backported from Blink : https://chromiumcodereview.appspot.com/14798006 903782 3 cdumez 2013-06-26 10:09:16 -0700 (In reply to comment #2) > This patch is backported from Blink : https://chromiumcodereview.appspot.com/14798006 "cherry-pick" or "ported" would be more accurate than "backport" here :) 903789 4 205501 cdumez 2013-06-26 10:25:10 -0700 Comment on attachment 205501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205501&action=review LGTM but someone else should confirm as this is a web exposed change. > Source/WebCore/ChangeLog:9 > + removes optional attribute from addColorStop interface. nit: "removes the optional keyword from addColorStop operation arguments." 904198 5 dongseong.hwang 2013-06-27 06:05:01 -0700 (In reply to comment #4) > (From update of attachment 205501 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205501&action=review > > LGTM but someone else should confirm as this is a web exposed change. > > > Source/WebCore/ChangeLog:9 > > + removes optional attribute from addColorStop interface. > > nit: "removes the optional keyword from addColorStop operation arguments." Thank you for review! I'll fix nit :) 997087 6 krit 2014-04-03 01:43:55 -0700 *** Bug 118011 has been marked as a duplicate of this bug. *** 997088 7 205501 krit 2014-04-03 01:44:50 -0700 Comment on attachment 205501 Patch r=me. I hope you can still land this bug. But please fix the change log. 1349861 8 Ms2ger 2017-09-18 01:52:14 -0700 This was eventually fixed in bug 160297. *** This bug has been marked as a duplicate of bug 160297 *** 205501 2013-06-26 09:00:42 -0700 2014-04-03 01:44:50 -0700 Patch bug-118064-20130626185835.patch text/plain 3187 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTUxOTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmRmNGI2ZmQzODNkYWVk NDE3MmEyZDAyMDFlNDU5MTg4ODIxMDVmNy4uNjA4NTYyOWQ5NjljMjRjMzcwMTJiNWFjNDViNGU3 YmUzMDM0YjVhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA2LTI2ICBEb25n c2VvbmcgSHdhbmcgIDxkb25nc2VvbmcuaHdhbmdAaW50ZWwuY29tPgorCisgICAgICAgIE1hdGNo IENhbnZhc0dyYWRpZW50OjphZGRDb2xvclN0b3AgdG8gdGhlIHNwZWMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTgwNjQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY2FudmFzIHNwZWMgWzFdIGRl ZmluZXMgYWRkQ29sb3JTdG9wIHdpdGhvdXQgb3B0aW9uYWwgYXJndW1lbnRzLiBUaGlzIHBhdGNo CisgICAgICAgIHJlbW92ZXMgb3B0aW9uYWwgYXR0cmlidXRlIGZyb20gYWRkQ29sb3JTdG9wIGlu dGVyZmFjZS4KKworICAgICAgICBbMV0gaHR0cDovL3d3dy53My5vcmcvVFIvMmRjb250ZXh0Mi8K KworICAgICAgICBDb3ZlcmVkIGJ5IExheW91dFRlc3RzL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQu bWlzc2luZ2FyZ3MuaHRtbAorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzR3JhZGllbnQu aWRsOgorCiAyMDEzLTA2LTI2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVzZS1hZnRlci1mcmVlIGluIFJhZGlvSW5wdXRUeXBlOjpoYW5kbGVLZXlkb3duRXZl bnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc0dyYWRpZW50 LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc0dyYWRpZW50LmlkbAppbmRl eCA2ZWNkNTFiYzczMThkNWE0OGU5YTdlZmU3YzYwYmU0OTZhYThiOWZmLi5hMmY5MWJlZjI1NGU3 MGU4NTAyNmY5YjA3ODFiMjA3NWIwMGZlZjAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9DYW52YXNHcmFkaWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9j YW52YXMvQ2FudmFzR3JhZGllbnQuaWRsCkBAIC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdo dCAoQykgMjAwNiBBcHBsZSBDb21wdXRlciwgSW5jLiAgQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAxMyBJbnRlbCBDb3Jwb3JhdGlvbi4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZv cm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92 aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjYsOCArMjcsNyBAQAogICAg IEltcGxlbWVudGF0aW9uTGFja3NWVGFibGUKIF0gaW50ZXJmYWNlIENhbnZhc0dyYWRpZW50IHsK IAotICAgIFtSYWlzZXNFeGNlcHRpb25dIHZvaWQgYWRkQ29sb3JTdG9wKFtEZWZhdWx0PVVuZGVm aW5lZF0gb3B0aW9uYWwgZmxvYXQgb2Zmc2V0LCAKLSAgICAgICAgICAgICAgICAgICAgICBbRGVm YXVsdD1VbmRlZmluZWRdIG9wdGlvbmFsIERPTVN0cmluZyBjb2xvcik7CisgICAgW1JhaXNlc0V4 Y2VwdGlvbl0gdm9pZCBhZGRDb2xvclN0b3AoZmxvYXQgb2Zmc2V0LCBET01TdHJpbmcgY29sb3Ip OwogCiB9OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggNTlkMTUyZDIxNjE2ZmE2MzhmZjE0NDIxZjcwY2M1YmMzOTM4ZmI3 Mi4uMjFlNWU5MjVjNTc1N2Q3MWRjMDQ3ZDQ4MWQxNmYzZGJhMGQ4YWQ1MSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTA2LTI2ICBEb25nc2VvbmcgSHdhbmcgIDxkb25nc2VvbmcuaHdhbmdA aW50ZWwuY29tPgorCisgICAgICAgIE1hdGNoIENhbnZhc0dyYWRpZW50OjphZGRDb2xvclN0b3Ag dG8gdGhlIHNwZWMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTgwNjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBSZW1vdmUgYSB3b3JrYXJvdW5kIHBsYXRmb3JtIGV4cGVjdGVkIGZpbGUgYmVjYXVzZSB0 aGlzIHBhdGNoIG1ha2VzCisgICAgICAgIGFkZENvbG9yU3RvcCB3b3JrIHdlbGwuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMvY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5taXNzaW5nYXJncy1leHBl Y3RlZC50eHQ6IFJlbW92ZWQuCisKIDIwMTMtMDYtMjYgIENocmlzdG9waGUgRHVtZXogIDxjaC5k dW1lekBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAgIEdldCByaWQgb2YgbXVsdGlwbGUgaW5o ZXJpdGVuY2UgZm9yIFNWR1ZpZXdFbGVtZW50IGludGVyZmFjZQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjL2NhbnZhcy9waGlsaXAvdGVzdHMvMmQubWlzc2luZ2FyZ3MtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2NhbnZhcy9waGlsaXAvdGVzdHMv MmQubWlzc2luZ2FyZ3MtZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCA1NjFiYzEwODQyNzNhMmIyYjkzMzQ5OWVkYmU2NzU3ODY4OWM1YjgzLi4wMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9jYW52YXMvcGhpbGlwL3Rlc3RzLzJkLm1pc3NpbmdhcmdzLWV4cGVjdGVkLnR4dAorKysgL2Rl di9udWxsCkBAIC0xLDIgKzAsMCBAQAotRmFpbGVkIGFzc2VydGlvbjogZXhwZWN0ZWQgZXhjZXB0 aW9uIG9mIHR5cGUgVHlwZUVycm9yLCBnb3Q6IEVycm9yOiBJbmRleFNpemVFcnJvcjogRE9NIEV4 Y2VwdGlvbiAxCi1GYWlsZWQgYXNzZXJ0aW9uOiBleHBlY3RlZCBleGNlcHRpb24gb2YgdHlwZSBU eXBlRXJyb3IsIGdvdDogRXJyb3I6IFN5bnRheEVycm9yOiBET00gRXhjZXB0aW9uIDEyCg==