118061 2013-06-26 08:19:02 -0700 [curl] Add "set-cookie" to appendable headers 2013-06-27 03:05:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 117300 1 davidsz webkit-unassigned bfulgham cdumez commit-queue galpeter ossy oldest_to_newest 903720 0 davidsz 2013-06-26 08:19:02 -0700 The curl implementation does not allows the concatenating of "Set-Cookie" headers. (RFC 2109) 903722 1 205496 davidsz 2013-06-26 08:22:17 -0700 Created attachment 205496 Patch 903744 2 galpeter 2013-06-26 08:57:02 -0700 (In reply to comment #1) > Created an attachment (id=205496) [details] > Patch Ah... yeah I missed that one in my patch. 903801 3 205496 cdumez 2013-06-26 10:44:46 -0700 Comment on attachment 205496 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). Please update this line and add a Changelog. 904108 4 galpeter 2013-06-27 01:54:12 -0700 (In reply to comment #3) > (From update of attachment 205496 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests (OOPS!). > > Please update this line and add a Changelog. The title of the bug already describes the change I don't know what more can be described here. 904110 5 205496 gyuyoung.kim 2013-06-27 02:07:33 -0700 Comment on attachment 205496 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review >>> Source/WebCore/ChangeLog:8 >>> + No new tests (OOPS!). >> >> Please update this line and add a Changelog. > > The title of the bug already describes the change I don't know what more can be described here. Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html 904114 6 205578 davidsz 2013-06-27 02:11:39 -0700 Created attachment 205578 Fixed changelog problem 904118 7 galpeter 2013-06-27 02:22:25 -0700 (In reply to comment #5) > (From update of attachment 205496 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205496&action=review > > >>> Source/WebCore/ChangeLog:8 > >>> + No new tests (OOPS!). > >> > >> Please update this line and add a Changelog. > > > > The title of the bug already describes the change I don't know what more can be described here. > > Please read "ChangeLog files" in https://www.webkit.org/coding/contributing.html I know that, but still... oh well... 904125 8 205578 cdumez 2013-06-27 02:43:52 -0700 Comment on attachment 205578 Fixed changelog problem Thank you for updating the Changelog. r=me. 904136 9 205578 commit-queue 2013-06-27 03:05:50 -0700 Comment on attachment 205578 Fixed changelog problem Clearing flags on attachment: 205578 Committed r152085: <http://trac.webkit.org/changeset/152085> 904137 10 commit-queue 2013-06-27 03:05:54 -0700 All reviewed patches have been landed. Closing bug. 205496 2013-06-26 08:22:17 -0700 2013-06-27 02:19:45 -0700 Patch appendcookieheader.diff text/plain 1165 davidsz ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMzRhMGU2Li4wZDVlNTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDYtMjYgIFN6YWJvbGNzIETDoXZpZCAgPGRhdmlkc3pAaW5mLnUtc3plZ2VkLmh1 PgorCisgICAgICAgIFtjdXJsXSBBZGQgInNldC1jb29raWUiIHRvIGFwcGVuZGFibGUgaGVhZGVy cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MDYx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzQXBwZW5kYWJsZUhlYWRl cik6CisKIDIwMTMtMDYtMTkgIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CiAK ICAgICAgICAgRml4IGEgZmV3IG1pc3NlZCByZW5hbWVzIGZyb20gRXhjbHVzaW9ucyAtPiBTaGFw ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNv dXJjZUhhbmRsZU1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j dXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKaW5kZXggZWEzMDBjYi4uNWIxZGFiMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFu ZGxlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs L1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKQEAgLTI1NSw2ICsyNTYsNyBAQCBzdGF0aWMgYm9v bCBpc0FwcGVuZGFibGVIZWFkZXIoY29uc3QgU3RyaW5nICZrZXkpCiAgICAgICAgICJwcm94eS1h dXRoZW50aWNhdGUiLAogICAgICAgICAicHVibGljIiwKICAgICAgICAgInNlcnZlciIsCisgICAg ICAgICJzZXQtY29va2llIiwKICAgICAgICAgInRlIiwKICAgICAgICAgInRyYWlsZXIiLAogICAg ICAgICAidHJhbnNmZXItZW5jb2RpbmciLA== 205578 2013-06-27 02:11:39 -0700 2013-06-27 03:05:49 -0700 Fixed changelog problem appendcookieheader.diff text/plain 1184 davidsz ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMzRhMGU2Li4wZDVlNTY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMDYtMjcgIFN6YWJvbGNzIETDoXZpZCAgPGRhdmlkc3pAaW5mLnUtc3plZ2VkLmh1 PgorCisgICAgICAgIFtjdXJsXSBBZGQgInNldC1jb29raWUiIHRvIGFwcGVuZGFibGUgaGVhZGVy cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE4MDYx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFyayBz ZXQtY29va2llIGFzIGFuIGFwcGVuZGFibGUgaGVhZGVyLgorCisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojppc0FwcGVuZGFibGVIZWFkZXIpOgorCiAyMDEzLTA2LTE5ICBCZW0gSm9uZXMtQmV5ICA8Ympv bmVzYmVAYWRvYmUuY29tPgogCiAgICAgICAgIEZpeCBhIGZldyBtaXNzZWQgcmVuYW1lcyBmcm9t IEV4Y2x1c2lvbnMgLT4gU2hhcGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCmluZGV4IGVh MzAwY2IuLjViMWRhYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCkBAIC0yNTUsNiAr MjU2LDcgQEAgc3RhdGljIGJvb2wgaXNBcHBlbmRhYmxlSGVhZGVyKGNvbnN0IFN0cmluZyAma2V5 KQogICAgICAgICAicHJveHktYXV0aGVudGljYXRlIiwKICAgICAgICAgInB1YmxpYyIsCiAgICAg ICAgICJzZXJ2ZXIiLAorICAgICAgICAic2V0LWNvb2tpZSIsCiAgICAgICAgICJ0ZSIsCiAgICAg ICAgICJ0cmFpbGVyIiwKICAgICAgICAgInRyYW5zZmVyLWVuY29kaW5nIiw=