118025 2013-06-25 21:10:05 -0700 [CSS Grid Layout] CSSParser should reject <track-list> without a <track-size> 2013-11-07 02:51:28 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 118255 1 rniwa svillar allan.jensen andersca bdakin commit-queue dino eric.carlson esprehn+autocc glenn gyuyoung.kim hyatt jchaffraix jer.noble kling koivisto macpherson menard simon.fraser svillar thorton oldest_to_newest 903520 0 rniwa 2013-06-25 21:10:05 -0700 Consider merging https://chromium.googlesource.com/chromium/blink/+/486ed9f6fb9e9d72509c94a173092ac6370c35da The case of <track-list> without a <track-size> was properly handled but that's because style resolution had to account for the parsing being not totally right. This refactoring will help with implementing parsing for <repeat-function> as the code matches the specification more closely. 947747 1 216186 svillar 2013-11-06 09:42:21 -0800 Created attachment 216186 Patch 948148 2 216186 kling 2013-11-07 01:42:30 -0800 Comment on attachment 216186 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216186&action=review r=me with a tiny improvement: > Source/WebCore/css/CSSParser.cpp:5029 > + values->append(name); values->append(name.release()); 948168 3 svillar 2013-11-07 02:51:28 -0800 Committed r158839: <http://trac.webkit.org/changeset/158839> 216186 2013-11-06 09:42:21 -0800 2013-11-07 01:42:30 -0800 Patch bug-118025-20131106184219.patch text/plain 6525 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4NzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2E5NmRlN2NkMzkzMTU4 MTY1YTFmZGQ4YjIzZDViZmM3MDE3ZmE5OS4uZDk4NDdkYWFmNTA0MTlhNDA5ZTAwOTFkOTdlYjNi YTc2YzY0OTgwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEzLTExLTA2ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCisgICAgICAgIFtDU1MgR3Jp ZCBMYXlvdXRdIENTU1BhcnNlciBzaG91bGQgcmVqZWN0IDx0cmFjay1saXN0PiB3aXRob3V0IGEg PHRyYWNrLXNpemU+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTgwMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGcm9tIEJsaW5rIHIxNTI5MTQgYnkgPGpjaGFmZnJhaXhAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIE1ha2Ugc3VyZSB0aGF0IHdlIHBhcnNlIGF0IGxlYXN0IDEgPHRyYWNrLXNpemU+IGlu c2lkZSBlYWNoCisgICAgICAgIDx0cmFjay1saXN0Pi4gVGhlIG9sZCBwYXJzZXIgY29kZSBhbGxv d2VkIHRyYWNrLWxpc3RzIGV4Y2x1c2l2ZWx5CisgICAgICAgIG1hZGUgb2YgPHRyYWNrLW5hbWU+ LiBUaGUgd2F5IGl0IHdhcyBpbXBsZW1lbnRlZCBlYXNlcyB0aGUgZnV0dXJlCisgICAgICAgIGFk ZGl0aW9uIG9mIHBhcnNpbmcgZm9yIHRoZSByZXBlYXQoKSBmdW5jdGlvbi4KKworICAgICAgICAq IGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUdy aWRUcmFja0xpc3QpOgorICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OmNyZWF0ZUdyaWRUcmFja0xpc3QpOiBBU1NFUlQgaWYgd2UgZG9uJ3QgZmluZCBh bnkKKyAgICAgICAgPHRyYWNrLXNpemU+IG5vdyB0aGF0IHdlIGRldGVjdCB0aGVpciBhYnNlbmNl IGluIHRoZSBwYXJzZXIuCisKKzIwMTMtMTEtMDYgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmls bGFyQGlnYWxpYS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXgsIHN0eWxlKCkg cmV0dXJuIHR5cGUgaXMgbm93IGEgcmVmZXJlbmNlLgogCiAgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckdyaWQuY3BwOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCA5ZGMyZWIxOGVjMzhj YTQwYjlkOWZiMTI2NWFiNDc4YTU2MTIxMTdmLi5mMTU4M2JkMzE4YTgxZmIwNDhiMmUwMDA0MjY4 MjlhYTVhNmJlYWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtNTAyMywyMyArNTAy MywzMiBAQCBib29sIENTU1BhcnNlcjo6cGFyc2VHcmlkVHJhY2tMaXN0KENTU1Byb3BlcnR5SUQg cHJvcElkLCBib29sIGltcG9ydGFudCkKICAgICB9CiAKICAgICBSZWZQdHI8Q1NTVmFsdWVMaXN0 PiB2YWx1ZXMgPSBDU1NWYWx1ZUxpc3Q6OmNyZWF0ZVNwYWNlU2VwYXJhdGVkKCk7CisgICAgLy8g SGFuZGxlIGxlYWRpbmcgdHJhY2sgbmFtZXMKKyAgICB3aGlsZSAobV92YWx1ZUxpc3QtPmN1cnJl bnQoKSAmJiBtX3ZhbHVlTGlzdC0+Y3VycmVudCgpLT51bml0ID09IENTU1ByaW1pdGl2ZVZhbHVl OjpDU1NfU1RSSU5HKSB7CisgICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gbmFtZSA9 IGNyZWF0ZVByaW1pdGl2ZVN0cmluZ1ZhbHVlKG1fdmFsdWVMaXN0LT5jdXJyZW50KCkpOworICAg ICAgICB2YWx1ZXMtPmFwcGVuZChuYW1lKTsKKyAgICAgICAgbV92YWx1ZUxpc3QtPm5leHQoKTsK KyAgICB9CisKKyAgICBib29sIHNlZW5UcmFja1NpemUgPSBmYWxzZTsKICAgICB3aGlsZSAobV92 YWx1ZUxpc3QtPmN1cnJlbnQoKSkgeworICAgICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+ IHByaW1pdGl2ZVZhbHVlID0gcGFyc2VHcmlkVHJhY2tTaXplKCk7CisgICAgICAgIGlmICghcHJp bWl0aXZlVmFsdWUpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgc2VlblRy YWNrU2l6ZSA9IHRydWU7CisgICAgICAgIHZhbHVlcy0+YXBwZW5kKHByaW1pdGl2ZVZhbHVlLnJl bGVhc2UoKSk7CisKICAgICAgICAgd2hpbGUgKG1fdmFsdWVMaXN0LT5jdXJyZW50KCkgJiYgbV92 YWx1ZUxpc3QtPmN1cnJlbnQoKS0+dW5pdCA9PSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1NUUklO RykgewogICAgICAgICAgICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBuYW1lID0gY3JlYXRl UHJpbWl0aXZlU3RyaW5nVmFsdWUobV92YWx1ZUxpc3QtPmN1cnJlbnQoKSk7CiAgICAgICAgICAg ICB2YWx1ZXMtPmFwcGVuZChuYW1lKTsKICAgICAgICAgICAgIG1fdmFsdWVMaXN0LT5uZXh0KCk7 CiAgICAgICAgIH0KKyAgICB9CiAKLSAgICAgICAgLy8gVGhpcyBhbGxvd3MgdHJhaWxpbmcgPHN0 cmluZz4qIHBlciB0aGUgc3BlY2lmaWNhdGlvbi4KLSAgICAgICAgaWYgKCFtX3ZhbHVlTGlzdC0+ Y3VycmVudCgpKQotICAgICAgICAgICAgYnJlYWs7Ci0KLSAgICAgICAgUmVmUHRyPENTU1ByaW1p dGl2ZVZhbHVlPiBwcmltaXRpdmVWYWx1ZSA9IHBhcnNlR3JpZFRyYWNrU2l6ZSgpOwotICAgICAg ICBpZiAoIXByaW1pdGl2ZVZhbHVlKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGlm ICghc2VlblRyYWNrU2l6ZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIHZhbHVl cy0+YXBwZW5kKHByaW1pdGl2ZVZhbHVlLnJlbGVhc2UoKSk7Ci0gICAgfQogICAgIGFkZFByb3Bl cnR5KHByb3BJZCwgdmFsdWVzLnJlbGVhc2UoKSwgaW1wb3J0YW50KTsKICAgICByZXR1cm4gdHJ1 ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAppbmRleCBiYTdlM2VjMzY1ODc2 NTg3MjJkMjlkMTc0NzM3MzliMjY2YTk1ODhmLi5jMjdhYTE4ODU1ZjExYjliMjU5ZDBkODJjYTc1 ZTk4ZWFkOWE0ZTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCkBAIC0xOTky LDkgKzE5OTIsOSBAQCBzdGF0aWMgYm9vbCBjcmVhdGVHcmlkVHJhY2tMaXN0KENTU1ZhbHVlKiB2 YWx1ZSwgVmVjdG9yPEdyaWRUcmFja1NpemU+JiB0cmFja1NpegogICAgICAgICB0cmFja1NpemVz LmFwcGVuZCh0cmFja1NpemUpOwogICAgIH0KIAotICAgIGlmICh0cmFja1NpemVzLmlzRW1wdHko KSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCisgICAgLy8gVGhlIHBhcnNlciBzaG91bGQgaGF2 ZSByZWplY3RlZCBhbnkgPHRyYWNrLWxpc3Q+IHdpdGhvdXQgYW55IDx0cmFjay1zaXplPiBhcwor ICAgIC8vIHRoaXMgaXMgbm90IGNvbmZvcm1hbnQgdG8gdGhlIHN5bnRheC4KKyAgICBBU1NFUlQo IXRyYWNrU2l6ZXMuaXNFbXB0eSgpKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGUz MWQzOTAxMjUyMTk4YTc1Y2U4YjAwYzM3MzU1NDY1YTI3NTk5MGMuLmRmMjBlNmYwMTQ4MmE2ZjM1 Y2E1MGM2YTRkMmE3YmMyZTVkNGFlMTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0xMS0w NiAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAgICBb Q1NTIEdyaWQgTGF5b3V0XSBDU1NQYXJzZXIgc2hvdWxkIHJlamVjdCA8dHJhY2stbGlzdD4gd2l0 aG91dCBhIDx0cmFjay1zaXplPgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTE4MDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgYSBuZXcgdGVzdCB0aGF0IHZlcmlmaWVzIHRoYXQgPHRyYWNrLWxp c3Q+IGV4Y2x1c2l2ZWx5IG1hZGUKKyAgICAgICAgb2YgPHRyYWNrLW5hbWU+IGFyZSBub3Qgc3Vw cG9ydGVkLgorCisgICAgICAgICogZmFzdC9jc3MtZ3JpZC1sYXlvdXQvbmFtZWQtZ3JpZC1saW5l LWdldC1zZXQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L25h bWVkLWdyaWQtbGluZS1nZXQtc2V0Lmh0bWw6CisKIDIwMTMtMTAtMjQgIFNlcmdpbyBWaWxsYXIg U2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NTUyBHcmlkIExheW91dF0g QWRkIHN1cHBvcnQgZm9yIG5hbWVkIGdyaWQgYXJlYXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvY3NzLWdyaWQtbGF5b3V0L25hbWVkLWdyaWQtbGluZS1nZXQtc2V0LWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L25hbWVkLWdyaWQtbGluZS1nZXQt c2V0LWV4cGVjdGVkLnR4dAppbmRleCBlNzZhNGFhNWI5NTkxZTNiOWVkYjJjNDlhOGNmNmJmZTE5 OGNjMGNiLi43ZjY3ZWZmZTg2NTZlZTM2NzA1YmQwMmU4Zjc3ZWIyOGM0ODkwNWRlIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9uYW1lZC1ncmlkLWxpbmUtZ2V0 LXNldC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQv bmFtZWQtZ3JpZC1saW5lLWdldC1zZXQtZXhwZWN0ZWQudHh0CkBAIC00Niw2ICs0Niw4IEBAIFBB U1MgZ2V0Q29tcHV0ZWRTdHlsZShncmlkRWxlbWVudCwgJycpLmdldFByb3BlcnR5VmFsdWUoJy13 ZWJraXQtZ3JpZC1kZWZpbml0aW9uCiBUZXN0IGdldHRpbmcgYW5kIHNldHRpbmcgaW52YWxpZCAt d2Via2l0LWdyaWQtZGVmaW5pdGlvbi1jb2x1bW5zIGFuZCAtd2Via2l0LWdyaWQtZGVmaW5pdGlv bi1yb3dzIHRocm91Z2ggSlMKIFBBU1MgZ2V0Q29tcHV0ZWRTdHlsZShncmlkRWxlbWVudCwgJycp LmdldFByb3BlcnR5VmFsdWUoJy13ZWJraXQtZ3JpZC1kZWZpbml0aW9uLWNvbHVtbnMnKSBpcyAi bm9uZSIKIFBBU1MgZ2V0Q29tcHV0ZWRTdHlsZShncmlkRWxlbWVudCwgJycpLmdldFByb3BlcnR5 VmFsdWUoJy13ZWJraXQtZ3JpZC1kZWZpbml0aW9uLXJvd3MnKSBpcyAibm9uZSIKK1BBU1MgZ2V0 Q29tcHV0ZWRTdHlsZShncmlkRWxlbWVudCwgJycpLmdldFByb3BlcnR5VmFsdWUoJy13ZWJraXQt Z3JpZC1kZWZpbml0aW9uLWNvbHVtbnMnKSBpcyAibm9uZSIKK1BBU1MgZ2V0Q29tcHV0ZWRTdHls ZShncmlkRWxlbWVudCwgJycpLmdldFByb3BlcnR5VmFsdWUoJy13ZWJraXQtZ3JpZC1kZWZpbml0 aW9uLXJvd3MnKSBpcyAibm9uZSIKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAog VEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlv dXQvbmFtZWQtZ3JpZC1saW5lLWdldC1zZXQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdy aWQtbGF5b3V0L25hbWVkLWdyaWQtbGluZS1nZXQtc2V0Lmh0bWwKb2xkIG1vZGUgMTAwNjQ0Cm5l dyBtb2RlIDEwMDc1NQppbmRleCAyYjVlNGVhM2NhZDQ2MDk0YzBiNTljODA2YzBlYTRmY2FjMzgy MjIzLi41Y2VkMjlmZjc2MGU2OGRhZDk1NmNkNTUzYjcxNTBlN2EwMTcyNWQ1Ci0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L25hbWVkLWdyaWQtbGluZS1nZXQtc2V0Lmh0bWwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvbmFtZWQtZ3JpZC1saW5lLWdl dC1zZXQuaHRtbApAQCAtMTQ3LDYgKzE0NywxMiBAQCBpZiAod2luZG93LnRlc3RSdW5uZXIpCiAg ICAgZWxlbWVudC5zdHlsZS53ZWJraXRHcmlkRGVmaW5pdGlvbkNvbHVtbnMgPSAiJ2ZvbyciOwog ICAgIGVsZW1lbnQuc3R5bGUud2Via2l0R3JpZERlZmluaXRpb25Sb3dzID0gIidiYXIiOwogICAg IHRlc3RWYWx1ZShlbGVtZW50LCAibm9uZSIsICJub25lIik7CisKKyAgICBlbGVtZW50ID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGls ZChlbGVtZW50KTsKKyAgICBlbGVtZW50LnN0eWxlLndlYmtpdEdyaWREZWZpbml0aW9uQ29sdW1u cyA9ICInZm9vJyAnYmFyJyI7CisgICAgZWxlbWVudC5zdHlsZS53ZWJraXRHcmlkRGVmaW5pdGlv blJvd3MgPSAiJ2JhcicgJ2ZvbyciOworICAgIHRlc3RWYWx1ZShlbGVtZW50LCAibm9uZSIsICJu b25lIik7CiA8L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1w b3N0LmpzIj48L3NjcmlwdD4KIDwvYm9keT4K