118021 2013-06-25 21:00:27 -0700 Remove many static_casts to Element types from AccessibilityNodeObject 2013-06-26 08:39:31 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa rniwa aboxhall apinheiro benjamin cfleizach commit-queue dmazzoni esprehn jdiggs kling koivisto mario oldest_to_newest 903512 0 rniwa 2013-06-25 21:00:27 -0700 Merge https://chromium.googlesource.com/chromium/blink/+/ecd837f94996a20fdb8798e24f26cf6edea2a423 Some of these casts were to overly specific types, like casting to HTMLFrameElementBase* just to call getAttribute. In other cases we can cast to a more generic type like HTMLTextFormControlElement to avoid the extra cases the code originally had. 903513 1 205444 rniwa 2013-06-25 21:01:11 -0700 Created attachment 205444 Cleanup 903590 2 205444 cfleizach 2013-06-26 00:34:30 -0700 Comment on attachment 205444 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=205444&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1647 > + return toHTMLTextFormControlElement(node)->value(); Isn't this a bad cast for input type=checkbox for instance? 903609 3 rniwa 2013-06-26 01:47:05 -0700 (In reply to comment #2) > (From update of attachment 205444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205444&action=review > > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1647 > > + return toHTMLTextFormControlElement(node)->value(); > > Isn't this a bad cast for input type=checkbox for instance? No. Both HTMLInputElement and HTMLTextAreaElement inherit from HTMLTextFormControlElement. 903734 4 205444 commit-queue 2013-06-26 08:39:28 -0700 Comment on attachment 205444 Cleanup Clearing flags on attachment: 205444 Committed r151990: <http://trac.webkit.org/changeset/151990> 903735 5 commit-queue 2013-06-26 08:39:31 -0700 All reviewed patches have been landed. Closing bug. 205444 2013-06-25 21:01:11 -0700 2013-06-26 08:39:28 -0700 Cleanup bug-118021-20130625205915.patch text/plain 2823 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1MTk3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA2LTI1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBtYW55IHN0YXRpY19j YXN0cyB0byBFbGVtZW50IHR5cGVzIGZyb20gQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExODAyMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1lcmdlIGh0dHBzOi8v Y2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9jaHJvbWl1bS9ibGluay8rL2VjZDgzN2Y5NDk5NmEy MGZkYjg3OThlMjRmMjZjZjZlZGVhMmE0MjMuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlOb2RlT2JqZWN0Ojppc1JlYWRPbmx5KToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlOb2RlT2JqZWN0OjphbHRlcm5hdGl2ZVRleHRGb3JXZWJBcmVhKToKKyAgICAgICAgKFdlYkNv cmU6OkFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0Ojp0ZXh0KToKKwogMjAxMy0wNi0yNSAgUnlvc3Vr ZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBKU1N0cmluZyBzaG91bGQgcmVt ZW1iZXIgQXRvbWljU3RyaW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcAkocmV2aXNpb24gMTUxOTc3 KQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVj dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5NSw3ICs2OTUsNyBAQCBib29sIEFjY2Vzc2liaWxp dHlOb2RlT2JqZWN0Ojppc1JlYWRPbmx5CiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgaWYg KG5vZGUtPmhhc1RhZ05hbWUodGV4dGFyZWFUYWcpKQotICAgICAgICByZXR1cm4gc3RhdGljX2Nh c3Q8SFRNTFRleHRBcmVhRWxlbWVudCo+KG5vZGUpLT5pc1JlYWRPbmx5KCk7CisgICAgICAgIHJl dHVybiB0b0hUTUxGb3JtQ29udHJvbEVsZW1lbnQobm9kZSktPmlzUmVhZE9ubHkoKTsKIAogICAg IGlmIChub2RlLT5oYXNUYWdOYW1lKGlucHV0VGFnKSkgewogICAgICAgICBIVE1MSW5wdXRFbGVt ZW50KiBpbnB1dCA9IHN0YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihub2RlKTsKQEAgLTEz NzQsMTAgKzEzNzQsMTAgQEAgU3RyaW5nIEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0OjphbHRlcm5h dAogICAgIE5vZGUqIG93bmVyID0gZG9jdW1lbnQtPm93bmVyRWxlbWVudCgpOwogICAgIGlmIChv d25lcikgewogICAgICAgICBpZiAob3duZXItPmhhc1RhZ05hbWUoZnJhbWVUYWcpIHx8IG93bmVy LT5oYXNUYWdOYW1lKGlmcmFtZVRhZykpIHsKLSAgICAgICAgICAgIGNvbnN0IEF0b21pY1N0cmlu ZyYgdGl0bGUgPSBzdGF0aWNfY2FzdDxIVE1MRnJhbWVFbGVtZW50QmFzZSo+KG93bmVyKS0+Z2V0 QXR0cmlidXRlKHRpdGxlQXR0cik7CisgICAgICAgICAgICBjb25zdCBBdG9taWNTdHJpbmcmIHRp dGxlID0gdG9FbGVtZW50KG93bmVyKS0+Z2V0QXR0cmlidXRlKHRpdGxlQXR0cik7CiAgICAgICAg ICAgICBpZiAoIXRpdGxlLmlzRW1wdHkoKSkKICAgICAgICAgICAgICAgICByZXR1cm4gdGl0bGU7 Ci0gICAgICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8SFRNTEZyYW1lRWxlbWVudEJhc2UqPihv d25lciktPmdldE5hbWVBdHRyaWJ1dGUoKTsKKyAgICAgICAgICAgIHJldHVybiB0b0VsZW1lbnQo b3duZXIpLT5nZXROYW1lQXR0cmlidXRlKCk7CiAgICAgICAgIH0KICAgICAgICAgaWYgKG93bmVy LT5pc0hUTUxFbGVtZW50KCkpCiAgICAgICAgICAgICByZXR1cm4gdG9IVE1MRWxlbWVudChvd25l ciktPmdldE5hbWVBdHRyaWJ1dGUoKTsKQEAgLTE2NDMsMTIgKzE2NDMsOCBAQCBTdHJpbmcgQWNj ZXNzaWJpbGl0eU5vZGVPYmplY3Q6OnRleHQoKSBjCiAgICAgaWYgKCFub2RlKQogICAgICAgICBy ZXR1cm4gU3RyaW5nKCk7CiAKLSAgICBpZiAoaXNOYXRpdmVUZXh0Q29udHJvbCgpKSB7Ci0gICAg ICAgIGlmIChub2RlLT5oYXNUYWdOYW1lKHRleHRhcmVhVGFnKSkKLSAgICAgICAgICAgIHJldHVy biBzdGF0aWNfY2FzdDxIVE1MVGV4dEFyZWFFbGVtZW50Kj4obm9kZSktPnZhbHVlKCk7Ci0gICAg ICAgIGlmIChub2RlLT5oYXNUYWdOYW1lKGlucHV0VGFnKSkKLSAgICAgICAgICAgIHJldHVybiBu b2RlLT50b0lucHV0RWxlbWVudCgpLT52YWx1ZSgpOwotICAgIH0KKyAgICBpZiAoaXNOYXRpdmVU ZXh0Q29udHJvbCgpICYmIChub2RlLT5oYXNUYWdOYW1lKHRleHRhcmVhVGFnKSB8fCBub2RlLT5o YXNUYWdOYW1lKGlucHV0VGFnKSkpCisgICAgICAgIHJldHVybiB0b0hUTUxUZXh0Rm9ybUNvbnRy b2xFbGVtZW50KG5vZGUpLT52YWx1ZSgpOwogCiAgICAgaWYgKCFub2RlLT5pc0VsZW1lbnROb2Rl KCkpCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsK